Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/1.1/patches/2225192/?format=api
{ "id": 2225192, "url": "http://patchwork.ozlabs.org/api/1.1/patches/2225192/?format=api", "web_url": "http://patchwork.ozlabs.org/project/linux-cifs-client/patch/20260420135058.469990-1-michael.bommarito@gmail.com/", "project": { "id": 12, "url": "http://patchwork.ozlabs.org/api/1.1/projects/12/?format=api", "name": "Linux CIFS Client", "link_name": "linux-cifs-client", "list_id": "linux-cifs.vger.kernel.org", "list_email": "linux-cifs@vger.kernel.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20260420135058.469990-1-michael.bommarito@gmail.com>", "date": "2026-04-20T13:50:58", "name": "smb: client: require a full NFS mode SID before reading mode bits", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "24e3bb6775a10500766ce80b86ddf0483c1682d7", "submitter": { "id": 93078, "url": "http://patchwork.ozlabs.org/api/1.1/people/93078/?format=api", "name": "Michael Bommarito", "email": "michael.bommarito@gmail.com" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/linux-cifs-client/patch/20260420135058.469990-1-michael.bommarito@gmail.com/mbox/", "series": [ { "id": 500620, "url": "http://patchwork.ozlabs.org/api/1.1/series/500620/?format=api", "web_url": "http://patchwork.ozlabs.org/project/linux-cifs-client/list/?series=500620", "date": "2026-04-20T13:50:58", "name": "smb: client: require a full NFS mode SID before reading mode bits", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/500620/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/2225192/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/2225192/checks/", "tags": {}, "headers": { "Return-Path": "\n <linux-cifs+bounces-10940-incoming=patchwork.ozlabs.org@vger.kernel.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "linux-cifs@vger.kernel.org" ], "Delivered-To": "patchwork-incoming@legolas.ozlabs.org", "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256\n header.s=20251104 header.b=eX1CBI0I;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org\n (client-ip=2600:3c0a:e001:db::12fc:5321; helo=sea.lore.kernel.org;\n envelope-from=linux-cifs+bounces-10940-incoming=patchwork.ozlabs.org@vger.kernel.org;\n receiver=patchwork.ozlabs.org)", "smtp.subspace.kernel.org;\n\tdkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com\n header.b=\"eX1CBI0I\"", "smtp.subspace.kernel.org;\n arc=none smtp.client-ip=209.85.222.175", "smtp.subspace.kernel.org;\n dmarc=pass (p=none dis=none) header.from=gmail.com", "smtp.subspace.kernel.org;\n spf=pass smtp.mailfrom=gmail.com" ], "Received": [ "from sea.lore.kernel.org (sea.lore.kernel.org\n [IPv6:2600:3c0a:e001:db::12fc:5321])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fzptQ21nFz1yCv\n\tfor <incoming@patchwork.ozlabs.org>; Tue, 21 Apr 2026 01:14:22 +1000 (AEST)", "from smtp.subspace.kernel.org (conduit.subspace.kernel.org\n [100.90.174.1])\n\tby sea.lore.kernel.org (Postfix) with ESMTP id E79A6361523E\n\tfor <incoming@patchwork.ozlabs.org>; Mon, 20 Apr 2026 14:46:37 +0000 (UTC)", "from localhost.localdomain (localhost.localdomain [127.0.0.1])\n\tby smtp.subspace.kernel.org (Postfix) with ESMTP id 7C6A12E7621;\n\tMon, 20 Apr 2026 13:51:08 +0000 (UTC)", "from mail-qk1-f175.google.com (mail-qk1-f175.google.com\n [209.85.222.175])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits))\n\t(No client certificate requested)\n\tby smtp.subspace.kernel.org (Postfix) with ESMTPS id 0A9582DCBE3\n\tfor <linux-cifs@vger.kernel.org>; Mon, 20 Apr 2026 13:51:03 +0000 (UTC)", "by mail-qk1-f175.google.com with SMTP id\n af79cd13be357-8dfb9139008so199174785a.1\n for <linux-cifs@vger.kernel.org>;\n Mon, 20 Apr 2026 06:51:02 -0700 (PDT)", "from server0 (c-68-48-65-54.hsd1.mi.comcast.net. [68.48.65.54])\n by smtp.gmail.com with ESMTPSA id\n af79cd13be357-8e7d69abee3sm790342385a.17.2026.04.20.06.51.00\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Mon, 20 Apr 2026 06:51:01 -0700 (PDT)" ], "ARC-Seal": "i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;\n\tt=1776693067; cv=none;\n b=hcND5Ct9zuJlRweHeWN/pKPfzn2JsRHEy67GgxeBI2dk2yaV2P0q5tsc5vdQLWWOAxyOG/spYZWk/Yis3s0ikvQHmLq+aFJvAvG5xSdhiNhFec1uTM7H4L3inE+1TqGmqvVoavHG/hHymLdrjBr/gv4rd0ROTVOMQy49ABPZm0Q=", "ARC-Message-Signature": "i=1; a=rsa-sha256; d=subspace.kernel.org;\n\ts=arc-20240116; t=1776693067; c=relaxed/simple;\n\tbh=vmZvs6UHY7QD3B9MWYRhLwssp9+U49BA9oDYPNJlnbQ=;\n\th=From:To:Cc:Subject:Date:Message-ID:MIME-Version;\n b=WQZqf/y/WfPqj7sZjLdzmBJirRiStFhivmg2xYAVXwIDklSgDTzhuBGSW5VUG2UHLwGr/zb9F8XTa061DadG1t1SKMgX1CvKwrBIHVJJ5WRRwplpdF9jaExeKZrPQckplMDSfw83nD/ZHltpWIK3rlQtwEIxDQKzOaCFKZL3I2w=", "ARC-Authentication-Results": "i=1; smtp.subspace.kernel.org;\n dmarc=pass (p=none dis=none) header.from=gmail.com;\n spf=pass smtp.mailfrom=gmail.com;\n dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com\n header.b=eX1CBI0I; arc=none smtp.client-ip=209.85.222.175", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=gmail.com; s=20251104; t=1776693062; x=1777297862;\n darn=vger.kernel.org;\n h=content-transfer-encoding:mime-version:message-id:date:subject:cc\n :to:from:from:to:cc:subject:date:message-id:reply-to;\n bh=2CQQpu+pTCuIRdY5y4O2DIzGNhbLx1QOGGuLTzhze6c=;\n b=eX1CBI0ISZbv2Dtqx9JEmkmhtO9WaeFmWzGJxfDY58gGclDPTjLddsg7dijrhcFXk3\n 8tikwhZAkUd9yivwOGS4nIrbrPlVeeTGyt/QJ96yEgr2rNgWwVmR6Eg/svqHb0XY8eee\n j/erY13lySWTYWbaCnMMrA/QnmOV9zEkqEYFVXgvl/uXL3B05RgaFYiKDv0MCuenp0ZR\n ig5Dr2pmSIRFGnff1TeBnfbk28J5SdUTENMRYPW3kQY+UlPA98EdVDdf4FauSpOxG2o6\n yy5ycx8LcPKoGDCGjfqCR1naZ9Iew6mwU7H9zVCG7VyQiOcXlo9D55lcHE73dtJQnGbZ\n LEbA==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1776693062; x=1777297862;\n h=content-transfer-encoding:mime-version:message-id:date:subject:cc\n :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date\n :message-id:reply-to;\n bh=2CQQpu+pTCuIRdY5y4O2DIzGNhbLx1QOGGuLTzhze6c=;\n b=N5okDjLkHeFh4NFFTDjxXBwvHBYyAx2qEtOgOum+0Td92uElfDTMP3678fpxjwATTd\n JDEwaHrnv81Wtmy2urLgMoYy14Akn2DKDEXRUFJGE06dfZEOUDsUe82HQkKg48xBjGdl\n PPksTPnGnJNvO28f44XX9ZTgJxe5LxV/8jEPlQ5Cl5oAM85NyngU8/ibyrwZrThs3Q8h\n PPNyS5epy3fVRW8cp9hBBiFUbGcGotc6JJoKGmpuirQoF684JVH/ZhXT+1c99KOdsi1w\n ZbGnTthJcGpzQg7mgpnBTIJSBV4YqGDrGvCuJt+6QMIPukgRR+DCpt8mbHHT47tyWGOb\n fNZQ==", "X-Forwarded-Encrypted": "i=1;\n AFNElJ+J/y4ttVzcodlBGMeJZsn7PpfXYXd1jN35iislKKKO4sAV9j5h3qMri7UDz1yp/9mXgT8b2lwc5rVz@vger.kernel.org", "X-Gm-Message-State": "AOJu0Yx2hWClKRVJBsaDpwvcfL1WV86phn+Jr+afrq/v6uwguhdSGvwU\n\t6/0ARWuMWfbrJt41h/b0Ntilnqa57y5oP1BujNUF7zGJqXfNQjct9JwvzG3HzT9v", "X-Gm-Gg": "AeBDieukPuhKuYRtLRsjiaZbL9GfUp+clF+4gw3bH5Md1H1Vwx9itPPFaSIux8ET7BG\n\tdaXVTbo9tDtsY3m+9Xpm/t5H11vaNNUtgTUxA19yaNzgL5EqH7RscMDr6h2mAwfRwStNXfLgtXX\n\tKtuE6JmgOisaXCsW7KFneEg+3z0bdzCQgiJm66tsRWqSx9ByLLfKS/aFiRPPTzyIk7XZfAxsHVE\n\thUlIm60W/G+OC5e5KoY2l3J4FyLj/FVytrRe3k3nR74sG+Q46SdEcBSKJgZ+mBQCtxj1H3/PmZe\n\tHD+iOkeeRxHfhcMnn34oLpK8ORRv4gcgrXO/8GRovcKEm2vAMUeRA/LxHQxgulGYnNtVmWzVwCT\n\tVB3JrusMWdXlIx9ft/Cj6UOinm1FwjIkN9Ee8X89fE3XogXddaTvetp3xFT5KnnyZz3w8uoKsbx\n\tenTT28LpfFUc83RcArqm3vbKwaTldG4fELScqE0I3LuaalTCZPBxCbLwu55rw4hzC+8R5zNbGE7\n\tgp0LNuRWZf8P4kOB1lTbNgJ3SCCABHieLK65XnN+w==", "X-Received": "by 2002:a05:620a:370e:b0:8cf:d953:b4f1 with SMTP id\n af79cd13be357-8e78f72ffd4mr1870500885a.1.1776693061842;\n Mon, 20 Apr 2026 06:51:01 -0700 (PDT)", "From": "Michael Bommarito <michael.bommarito@gmail.com>", "To": "Steve French <sfrench@samba.org>,\n\tNamjae Jeon <linkinjeon@kernel.org>,\n\tlinux-cifs@vger.kernel.org", "Cc": "Paulo Alcantara <pc@manguebit.org>,\n\tRonnie Sahlberg <ronniesahlberg@gmail.com>,\n\tShyam Prasad N <sprasad@microsoft.com>,\n\tTom Talpey <tom@talpey.com>,\n\tBharath SM <bharathsm@microsoft.com>,\n\tsamba-technical@lists.samba.org,\n\tlinux-kernel@vger.kernel.org,\n\tstable@vger.kernel.org", "Subject": "[PATCH] smb: client: require a full NFS mode SID before reading mode\n bits", "Date": "Mon, 20 Apr 2026 09:50:58 -0400", "Message-ID": "<20260420135058.469990-1-michael.bommarito@gmail.com>", "X-Mailer": "git-send-email 2.53.0", "Precedence": "bulk", "X-Mailing-List": "linux-cifs@vger.kernel.org", "List-Id": "<linux-cifs.vger.kernel.org>", "List-Subscribe": "<mailto:linux-cifs+subscribe@vger.kernel.org>", "List-Unsubscribe": "<mailto:linux-cifs+unsubscribe@vger.kernel.org>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit" }, "content": "parse_dacl() treats an ACE SID matching sid_unix_NFS_mode as an NFS\nmode SID and reads sid.sub_auth[2] to recover the mode bits.\n\nThat assumes the ACE carries three subauthorities, but compare_sids()\nonly compares min(a, b) subauthorities. A malicious server can return\nan ACE with num_subauth = 2 and sub_auth[] = {88, 3}, which still\nmatches sid_unix_NFS_mode and then drives the sub_auth[2] read four\nbytes past the end of the ACE.\n\nRequire num_subauth >= 3 before treating the ACE as an NFS mode SID.\nThis keeps the fix local to the special-SID mode path without changing\ncompare_sids() semantics for the rest of cifsacl.\n\nFixes: e2f8fbfb8d09 (\"cifs: get mode bits from special sid on stat\")\nCc: stable@vger.kernel.org\nAssisted-by: Claude:claude-opus-4-6\nSigned-off-by: Michael Bommarito <michael.bommarito@gmail.com>\n---\n fs/smb/client/cifsacl.c | 1 +\n 1 file changed, 1 insertion(+)", "diff": "diff --git a/fs/smb/client/cifsacl.c b/fs/smb/client/cifsacl.c\nindex c920039d733c..a62c8a733779 100644\n--- a/fs/smb/client/cifsacl.c\n+++ b/fs/smb/client/cifsacl.c\n@@ -831,6 +831,7 @@ static void parse_dacl(struct smb_acl *pdacl, char *end_of_acl,\n \t\t\tdump_ace(ppace[i], end_of_acl);\n #endif\n \t\t\tif (mode_from_special_sid &&\n+\t\t\t ppace[i]->sid.num_subauth >= 3 &&\n \t\t\t (compare_sids(&(ppace[i]->sid),\n \t\t\t\t\t &sid_unix_NFS_mode) == 0)) {\n \t\t\t\t/*\n", "prefixes": [] }