Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/1.1/patches/2225168/?format=api
{ "id": 2225168, "url": "http://patchwork.ozlabs.org/api/1.1/patches/2225168/?format=api", "web_url": "http://patchwork.ozlabs.org/project/linuxppc-dev/patch/20260420132429.128075-1-lgs201920130244@gmail.com/", "project": { "id": 2, "url": "http://patchwork.ozlabs.org/api/1.1/projects/2/?format=api", "name": "Linux PPC development", "link_name": "linuxppc-dev", "list_id": "linuxppc-dev.lists.ozlabs.org", "list_email": "linuxppc-dev@lists.ozlabs.org", "web_url": "https://github.com/linuxppc/wiki/wiki", "scm_url": "https://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux.git", "webscm_url": "https://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux.git/" }, "msgid": "<20260420132429.128075-1-lgs201920130244@gmail.com>", "date": "2026-04-20T13:24:29", "name": "[v2] powerpc/pseries/papr-hvpipe: fix NULL dereference in handle creation", "commit_ref": null, "pull_url": null, "state": "changes-requested", "archived": false, "hash": "59e99ac7f2632b262ba945e450c16f114637861f", "submitter": { "id": 91722, "url": "http://patchwork.ozlabs.org/api/1.1/people/91722/?format=api", "name": "Guangshuo Li", "email": "lgs201920130244@gmail.com" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/linuxppc-dev/patch/20260420132429.128075-1-lgs201920130244@gmail.com/mbox/", "series": [ { "id": 500609, "url": "http://patchwork.ozlabs.org/api/1.1/series/500609/?format=api", "web_url": "http://patchwork.ozlabs.org/project/linuxppc-dev/list/?series=500609", "date": "2026-04-20T13:24:29", "name": "[v2] powerpc/pseries/papr-hvpipe: fix NULL dereference in handle creation", "version": 2, "mbox": "http://patchwork.ozlabs.org/series/500609/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/2225168/comments/", "check": "fail", "checks": "http://patchwork.ozlabs.org/api/patches/2225168/checks/", "tags": {}, "headers": { "Return-Path": "\n <linuxppc-dev+bounces-19852-incoming=patchwork.ozlabs.org@lists.ozlabs.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "linuxppc-dev@lists.ozlabs.org" ], "Delivered-To": "patchwork-incoming@legolas.ozlabs.org", "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256\n header.s=20251104 header.b=tGTto8wG;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=lists.ozlabs.org\n (client-ip=2404:9400:21b9:f100::1; helo=lists.ozlabs.org;\n envelope-from=linuxppc-dev+bounces-19852-incoming=patchwork.ozlabs.org@lists.ozlabs.org;\n receiver=patchwork.ozlabs.org)", "lists.ozlabs.org;\n arc=none smtp.remote-ip=\"2607:f8b0:4864:20::52f\"", "lists.ozlabs.org;\n dmarc=pass (p=none dis=none) header.from=gmail.com", "lists.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256\n header.s=20251104 header.b=tGTto8wG;\n\tdkim-atps=neutral", "lists.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=gmail.com\n (client-ip=2607:f8b0:4864:20::52f; helo=mail-pg1-x52f.google.com;\n envelope-from=lgs201920130244@gmail.com; receiver=lists.ozlabs.org)" ], "Received": [ "from lists.ozlabs.org (lists.ozlabs.org\n [IPv6:2404:9400:21b9:f100::1])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fzmSL70R6z1yGs\n\tfor <incoming@patchwork.ozlabs.org>; Mon, 20 Apr 2026 23:25:06 +1000 (AEST)", "from boromir.ozlabs.org (localhost [127.0.0.1])\n\tby lists.ozlabs.org (Postfix) with ESMTP id 4fzmSL5xFpz2ypw;\n\tMon, 20 Apr 2026 23:25:06 +1000 (AEST)", "from mail-pg1-x52f.google.com (mail-pg1-x52f.google.com\n [IPv6:2607:f8b0:4864:20::52f])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature RSA-PSS (2048 bits) server-digest\n SHA256)\n\t(No client certificate requested)\n\tby lists.ozlabs.org (Postfix) with ESMTPS id 4fzmSK1V1bz2xll\n\tfor <linuxppc-dev@lists.ozlabs.org>; Mon, 20 Apr 2026 23:25:04 +1000 (AEST)", "by mail-pg1-x52f.google.com with SMTP id\n 41be03b00d2f7-c741692db4cso776106a12.1\n for <linuxppc-dev@lists.ozlabs.org>;\n Mon, 20 Apr 2026 06:25:04 -0700 (PDT)", "from lgs.. ([2408:8417:d50:4775:1153:f731:14e3:b103])\n by smtp.gmail.com with ESMTPSA id\n 41be03b00d2f7-c7976f8fcbdsm7907037a12.6.2026.04.20.06.24.55\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Mon, 20 Apr 2026 06:25:01 -0700 (PDT)" ], "ARC-Seal": "i=1; a=rsa-sha256; d=lists.ozlabs.org; s=201707; t=1776691506;\n\tcv=none;\n b=oPtEvaaUbJAwKEZAQm1+ZjsyNoYgk62v3iPVbTdFsiYIWzpR8ZlHjcdIh78raYlBipxtdUXhW5pxXhfRpWLesgOPc+0s6emhkGuNC/vN9FOLUQ0WmsjW1Vq4+swa9YsD/vYsFAau76VZ0CWw6U377uTMGaxeaIo8AtZaXAzi/zoWK1VPxFJudbEyWbnQPeeA/j9nbHOIQ459plaYdCQJuyQ6/Y8FYOkCV8u4ntFyYhWoA1qKTjJbpNHAPH5luvQYOiGxnRJfn3Nr1Z6mn3dNd8+SqW/iffI2Rb13BL/jLvqvTMbbBp+X/PmsbUXDlnKE0VKNCUB75joiwrRD+hncRA==", "ARC-Message-Signature": "i=1; a=rsa-sha256; d=lists.ozlabs.org; s=201707;\n\tt=1776691506; c=relaxed/relaxed;\n\tbh=gr0oztocKaKLkdTKEsH8odatBVVrOkD1g/pdHlqb6Es=;\n\th=From:To:Cc:Subject:Date:Message-ID:MIME-Version;\n b=WUARofQ/RzZv35ufBZkeBjoQ4eVoAwPiTziYNM9p28jvlWnJRQjaiMlqG6m5EmUypbFMI7jgZ2Q8X2Fd0xCkzKVQlsSkrHQaevozOtDtOGqN3/C7KTpfJw9TLhnjrojDJmr7ibLq9y2m6brlh88hEaPgfDfY+9fF5v6MU/D96J9CCDaqTCz8EBweKij2UK8WnC8cfn+0iHSJQY72MovtMfcacsera/LmeDnxJaBjD454Z6u4E/DkFHlnZRSvX+dyWu9GtV/etfbgbuiIN7ywsOhNT9X7vrW2DBdP9HMISfoRHZEQ+nQu0Jswae0vGVlfrUjgL2rfPyFXTiSR6W+Kkg==", "ARC-Authentication-Results": "i=1; lists.ozlabs.org;\n dmarc=pass (p=none dis=none) header.from=gmail.com; dkim=pass (2048-bit key;\n unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256\n header.s=20251104 header.b=tGTto8wG; dkim-atps=neutral;\n spf=pass (client-ip=2607:f8b0:4864:20::52f; helo=mail-pg1-x52f.google.com;\n envelope-from=lgs201920130244@gmail.com;\n receiver=lists.ozlabs.org) smtp.mailfrom=gmail.com", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=gmail.com; s=20251104; t=1776691502; x=1777296302;\n darn=lists.ozlabs.org;\n h=content-transfer-encoding:mime-version:message-id:date:subject:cc\n :to:from:from:to:cc:subject:date:message-id:reply-to;\n bh=gr0oztocKaKLkdTKEsH8odatBVVrOkD1g/pdHlqb6Es=;\n b=tGTto8wGBFT9sMURMr1apQKv6VnQNI6ddAYD+VAZY1TZ0DFI2dAC9K0oG7BDyXD5wK\n yvfRCtmbCWb2kqkdtIYmgKI5EOHy6y0WAKqsnrU1yRxPcy4IbC6kfM2SkdOtwujr3kCL\n vI+JYmG3nHNHFpuqwi2W3N7JW4j1i2ieLjpqcky4MclCSezCzksgCG5CKCQ8eNkj3PzA\n MQAlx5eAZ2lBgcYOikEMuNw+1gXbWWIJ0OVk6tXu0Tz575P3IwdwbggXDHHZUcAieCha\n YbD/HhykTQopDziUToxm06+5/3PiwE4UJzad+P/2eVK/nIbrHf7+lWuAQSOAITs1/KFH\n jSJQ==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1776691502; x=1777296302;\n h=content-transfer-encoding:mime-version:message-id:date:subject:cc\n :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date\n :message-id:reply-to;\n bh=gr0oztocKaKLkdTKEsH8odatBVVrOkD1g/pdHlqb6Es=;\n b=nsGXOmaz1EyujL/BfjYRSWGbYOVcII85FkW4rfWuKd3AV1MBIb2nipUnD7/m5DTrOi\n VZTvoG8HeFyberlQ/dOSGyDJIiHCd28KBOe25BIfzFie7Paukg8ywUK0AnxkdVtiRxMg\n QMj6wGP3tAuYxsadPNlM0QrPKyQM0+Dis4Cx1nK3DcqeS4DttivGETNpJxilOl+c6rZ1\n eC1hvMkesAClvY4PuV9yWEUD8VowOaZs0R0iualp7ATmPJSTv0Q4XsJ/U2c/7gfIMyIH\n X38DmqNyjLl6qMKEWhWLr7F36yM1YNEE4UQFbzeh3yDvxlbsgs1ZMOR7Z7JaBdu6zSF8\n WpCQ==", "X-Forwarded-Encrypted": "i=1;\n AFNElJ/bYeR/FHO0G0QY/CAQTPYvuhTSSGD1Do3hZYExRAdsonI/SAkpMwPS1+v0K52R4vFQHJRSJitEYczTM+Q=@lists.ozlabs.org", "X-Gm-Message-State": "AOJu0YxGRqzttiH7en+3dV3tqBwINQ06eIi4PwQBWP60KIetdRSv88En\n\tlYNLh+6Z/2yfpABKm8V2eeZxHndHAN4AsFum2xKuxtvWxnKVztgYNlnt", "X-Gm-Gg": "AeBDieuBsxXJWbH4VQafAh1PiDE0FLO+QfsREA3gDYQe7Xfboqp/igczsjh8d05JYiv\n\tALre8eie4mcGKao1YzdhCzuHrPE3wcqmBH1xr9z8HRTL0l1Lb83NDjEnC1FFK0s6TUJ8Nl5aIyz\n\tPuMSI3OeAq39RTIjzIbsc84inJ6kFpEtB3i+ncubZ0M3c1kVR7W/pshKOPPwupj794BLdgAMU58\n\tb2RRaW2cyf+GJbTuJ844E6ecl6A4bExvunrJEt4UUI8BYOMjY1kGDtPUaS1UKjJSn1C4LzomvYO\n\td2J8SpwtmM9gsu5511qO3HqfdTbnFNFvfjuU6M9tzbd6VzqdKyscCndLDoDNqA1P57OBGLu8tkX\n\tzXj8iV1M5LxjYzxA/Y9EkYI22CjvlxIX4bhsLNKwE7OYbhvlk66nviuQMPVPQDcD26mxfX46oHZ\n\tVka3wDSzBTdbQ9ErT/hgAPDJW1qpWKqgvPMxY=", "X-Received": "by 2002:a05:6a20:3d06:b0:3a2:d5b8:bfa7 with SMTP id\n adf61e73a8af0-3a2d5b8c92fmr2099312637.1.1776691502065;\n Mon, 20 Apr 2026 06:25:02 -0700 (PDT)", "From": "Guangshuo Li <lgs201920130244@gmail.com>", "To": "Madhavan Srinivasan <maddy@linux.ibm.com>,\n\tMichael Ellerman <mpe@ellerman.id.au>,\n\tNicholas Piggin <npiggin@gmail.com>,\n\t\"Christophe Leroy (CS GROUP)\" <chleroy@kernel.org>,\n\tMahesh Salgaonkar <mahesh@linux.ibm.com>,\n\tHaren Myneni <haren@linux.ibm.com>,\n\tTyrel Datwyler <tyreld@linux.ibm.com>,\n\tChristian Brauner <brauner@kernel.org>,\n\tKees Cook <kees@kernel.org>,\n\tGuangshuo Li <lgs201920130244@gmail.com>,\n\tlinuxppc-dev@lists.ozlabs.org,\n\tlinux-kernel@vger.kernel.org", "Cc": "stable@vger.kernel.org", "Subject": "[PATCH v2] powerpc/pseries/papr-hvpipe: fix NULL dereference in\n handle creation", "Date": "Mon, 20 Apr 2026 21:24:29 +0800", "Message-ID": "<20260420132429.128075-1-lgs201920130244@gmail.com>", "X-Mailer": "git-send-email 2.43.0", "X-Mailing-List": "linuxppc-dev@lists.ozlabs.org", "List-Id": "<linuxppc-dev.lists.ozlabs.org>", "List-Help": "<mailto:linuxppc-dev+help@lists.ozlabs.org>", "List-Owner": "<mailto:linuxppc-dev+owner@lists.ozlabs.org>", "List-Post": "<mailto:linuxppc-dev@lists.ozlabs.org>", "List-Archive": "<https://lore.kernel.org/linuxppc-dev/>,\n <https://lists.ozlabs.org/pipermail/linuxppc-dev/>", "List-Subscribe": "<mailto:linuxppc-dev+subscribe@lists.ozlabs.org>,\n <mailto:linuxppc-dev+subscribe-digest@lists.ozlabs.org>,\n <mailto:linuxppc-dev+subscribe-nomail@lists.ozlabs.org>", "List-Unsubscribe": "<mailto:linuxppc-dev+unsubscribe@lists.ozlabs.org>", "Precedence": "list", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-Spam-Status": "No, score=0.4 required=3.0 tests=DKIM_SIGNED,DKIM_VALID,\n\tDKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_ENVFROM_END_DIGIT,FREEMAIL_FROM,\n\tFROM_LOCAL_DIGITS,FROM_LOCAL_HEX,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,\n\tSPF_PASS autolearn=disabled version=4.0.1 OzLabs 8", "X-Spam-Checker-Version": "SpamAssassin 4.0.1 (2024-03-25) on lists.ozlabs.org" }, "content": "papr_hvpipe_dev_create_handle() transfers ownership of src_info with\nretain_and_null_ptr(src_info) after anon_inode_getfile() succeeds.\nHowever, retain_and_null_ptr() clears src_info immediately, and the\nfunction then still dereferences src_info in the subsequent list_add().\n\nStore the transferred pointer in a separate variable and use that for\nthe list insertion.\n\nManually identified during code review.\n\nFixes: 6d3789d347a7 (\"papr-hvpipe: convert papr_hvpipe_dev_create_handle() to FD_PREPARE()\")\nCc: stable@vger.kernel.org\nSigned-off-by: Guangshuo Li <lgs201920130244@gmail.com>\n---\nv2:\n - Fix the Fixes tag to use the documented 12-character SHA-1 format\n\n arch/powerpc/platforms/pseries/papr-hvpipe.c | 5 +++--\n 1 file changed, 3 insertions(+), 2 deletions(-)", "diff": "diff --git a/arch/powerpc/platforms/pseries/papr-hvpipe.c b/arch/powerpc/platforms/pseries/papr-hvpipe.c\nindex 14ae480d060a..497eb967611b 100644\n--- a/arch/powerpc/platforms/pseries/papr-hvpipe.c\n+++ b/arch/powerpc/platforms/pseries/papr-hvpipe.c\n@@ -480,6 +480,7 @@ static const struct file_operations papr_hvpipe_handle_ops = {\n static int papr_hvpipe_dev_create_handle(u32 srcID)\n {\n \tstruct hvpipe_source_info *src_info __free(kfree) = NULL;\n+\tstruct hvpipe_source_info *owned_src_info;\n \n \tspin_lock(&hvpipe_src_list_lock);\n \t/*\n@@ -509,7 +510,7 @@ static int papr_hvpipe_dev_create_handle(u32 srcID)\n \tif (fdf.err)\n \t\treturn fdf.err;\n \n-\tretain_and_null_ptr(src_info);\n+\towned_src_info = retain_and_null_ptr(src_info);\n \tspin_lock(&hvpipe_src_list_lock);\n \t/*\n \t * If two processes are executing ioctl() for the same\n@@ -520,7 +521,7 @@ static int papr_hvpipe_dev_create_handle(u32 srcID)\n \t\tspin_unlock(&hvpipe_src_list_lock);\n \t\treturn -EALREADY;\n \t}\n-\tlist_add(&src_info->list, &hvpipe_src_list);\n+\tlist_add(&owned_src_info->list, &hvpipe_src_list);\n \tspin_unlock(&hvpipe_src_list_lock);\n \treturn fd_publish(fdf);\n }\n", "prefixes": [ "v2" ] }