Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/1.1/patches/2225085/?format=api
{ "id": 2225085, "url": "http://patchwork.ozlabs.org/api/1.1/patches/2225085/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20260420104248.86702-12-mohamed@unpredictable.fr/", "project": { "id": 14, "url": "http://patchwork.ozlabs.org/api/1.1/projects/14/?format=api", "name": "QEMU Development", "link_name": "qemu-devel", "list_id": "qemu-devel.nongnu.org", "list_email": "qemu-devel@nongnu.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20260420104248.86702-12-mohamed@unpredictable.fr>", "date": "2026-04-20T10:42:21", "name": "[v2,11/38] whpx: i386: IO port fast path cleanup", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "31475a5ad9d98230a9d0aa6d0b833df4a17e1e62", "submitter": { "id": 91318, "url": "http://patchwork.ozlabs.org/api/1.1/people/91318/?format=api", "name": "Mohamed Mediouni", "email": "mohamed@unpredictable.fr" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20260420104248.86702-12-mohamed@unpredictable.fr/mbox/", "series": [ { "id": 500592, "url": "http://patchwork.ozlabs.org/api/1.1/series/500592/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/list/?series=500592", "date": "2026-04-20T10:42:10", "name": "WHPX x86 updates for QEMU 11.1", "version": 2, "mbox": "http://patchwork.ozlabs.org/series/500592/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/2225085/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/2225085/checks/", "tags": {}, "headers": { "Return-Path": "<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@legolas.ozlabs.org", "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=unpredictable.fr header.i=@unpredictable.fr\n header.a=rsa-sha256 header.s=sig1 header.b=IdWxXi1z;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists1p.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)" ], "Received": [ "from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fzhz75rdRz1yCv\n\tfor <incoming@patchwork.ozlabs.org>; Mon, 20 Apr 2026 20:48:03 +1000 (AEST)", "from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists1p.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from <qemu-devel-bounces@nongnu.org>)\n\tid 1wEm6L-00073H-A2; Mon, 20 Apr 2026 06:43:37 -0400", "from eggs.gnu.org ([2001:470:142:3::10])\n by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <mohamed@unpredictable.fr>)\n id 1wEm6B-0006wf-Pc\n for qemu-devel@nongnu.org; Mon, 20 Apr 2026 06:43:27 -0400", "from p-west3-cluster5-host1-snip4-10.eps.apple.com ([57.103.72.73]\n helo=outbound.ms.icloud.com)\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <mohamed@unpredictable.fr>)\n id 1wEm69-0000a2-Pr\n for qemu-devel@nongnu.org; Mon, 20 Apr 2026 06:43:27 -0400", "from outbound.ms.icloud.com (unknown [127.0.0.2])\n by p00-icloudmta-asmtp-us-west-3a-100-percent-1 (Postfix) with ESMTPS id\n C346618000A3; Mon, 20 Apr 2026 10:43:21 +0000 (UTC)", "from localhost.localdomain (unknown [17.57.154.37])\n by p00-icloudmta-asmtp-us-west-3a-100-percent-1 (Postfix) with ESMTPSA id\n E26C11800451; Mon, 20 Apr 2026 10:43:18 +0000 (UTC)" ], "Dkim-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=unpredictable.fr;\n s=sig1; t=1776681804; x=1779273804;\n bh=nQndBaUP3p2GZXyo2M9Kbvf88ZtsTTUcXFr9tOFWW7A=;\n h=From:To:Subject:Date:Message-ID:MIME-Version:x-icloud-hme;\n b=IdWxXi1zVZXv44s4zRRsjVx2FHvC9BYFG5DB70W98TBCe1Fn9J7IPKpacB8+jQfxwUwHtIYfG6BRZcLMAoosvl/hvxL+xRJ2sxOeDPtiUP90wh61FoWHggg4xbTJEDd1BIr/77+zuG7/XuqzhFkLPgxQ7z3p1XoFA5Ls/2JtrsYbGvntw3Ars5Wdqz0BWUjBZQw66gX1uS1LwFHVcZOdQk9wvRkpbu1ZF/dmlyc4/1H1Z4sOaHxszP1LrWlSam7h/bssTjwAZdwnsIwYxtojeuUI6MIylGFs69PDEFV8ZCxA6bz4MNnu0reD6l6LbPp0UcTiBe+NjYr50LbGhaf8ow==", "mail-alias-created-date": "1752046281608", "From": "Mohamed Mediouni <mohamed@unpredictable.fr>", "To": "qemu-devel@nongnu.org", "Cc": "qemu-arm@nongnu.org, Mohamed Mediouni <mohamed@unpredictable.fr>,\n Paolo Bonzini <pbonzini@redhat.com>,\n Phil Dennis-Jordan <phil@philjordan.eu>,\n Roman Bolshakov <rbolshakov@ddn.com>,\n Pierrick Bouvier <pierrick.bouvier@linaro.org>,\n Pedro Barbuda <pbarbuda@microsoft.com>, Wei Liu <wei.liu@kernel.org>,\n \"Michael S. Tsirkin\" <mst@redhat.com>,\n Peter Maydell <peter.maydell@linaro.org>, Zhao Liu <zhao1.liu@intel.com>", "Subject": "[PATCH v2 11/38] whpx: i386: IO port fast path cleanup", "Date": "Mon, 20 Apr 2026 12:42:21 +0200", "Message-ID": "<20260420104248.86702-12-mohamed@unpredictable.fr>", "X-Mailer": "git-send-email 2.50.1", "In-Reply-To": "<20260420104248.86702-1-mohamed@unpredictable.fr>", "References": "<20260420104248.86702-1-mohamed@unpredictable.fr>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-Proofpoint-GUID": "w0YYqtkw1NyWm0C125HfF_BDCgCCAIVx", "X-Proofpoint-Spam-Details-Enc": "AW1haW4tMjYwNDIwMDEwNCBTYWx0ZWRfX3xTYq0JAgDqw\n 3sywa5JekA6elTiW8T8gjzu2uTO/XbFZRkgCz0hhcvEjsRcMQuAoRMhikosba4Ci3io5cV+QZi3\n DfkdBrVakNnBUpDG3JXlc00uYmgi1qF1YP+QgaeDY5mj3mPYGlep2TS8jmKtci6qpVrAVlFMnks\n QqKK8lOG55nd8+QghhiAA3Ygb9zWhUDfkcXu30eVUxGDNTBMFP/VebttxwcRORCYQ2H/6tcZtq2\n FPjm/ub6TUjlDhOsaD/wverweDU/4Jh46/omxJvvXP9yv8FnGGewzMJ8Fxci38ly1oMDHPABF6D\n aILm6TwExQ/9Qu6+AvF0GJCSN+cNSG8zs3uOfxoErTcntE0h2ZUyuWMZok8o9Q=", "X-Proofpoint-ORIG-GUID": "w0YYqtkw1NyWm0C125HfF_BDCgCCAIVx", "X-Authority-Info-Out": "v=2.4 cv=TtzrRTXh c=1 sm=1 tr=0 ts=69e6034b\n cx=c_apl:c_pps:t_out a=qkKslKyYc0ctBTeLUVfTFg==:117 a=A5OVakUREuEA:10\n a=VkNPw1HP01LnGYTKEx00:22 a=Vrzv6M8N8vcM0KmfSJEA:9", "X-Proofpoint-Virus-Version": "vendor=baseguard\n engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49\n definitions=2026-04-20_02,2026-04-17_04,2025-10-01_01", "X-Proofpoint-Spam-Details": "rule=notspam policy=default score=0 suspectscore=0\n malwarescore=0 mlxscore=0 phishscore=0 spamscore=0\n bulkscore=0\n mlxlogscore=873 lowpriorityscore=0 adultscore=0 clxscore=1030 classifier=spam\n authscore=0 adjust=0 reason=mlx scancount=1 engine=8.22.0-2601150000\n definitions=main-2604200104", "Received-SPF": "pass client-ip=57.103.72.73;\n envelope-from=mohamed@unpredictable.fr; helo=outbound.ms.icloud.com", "X-Spam_score_int": "-27", "X-Spam_score": "-2.8", "X-Spam_bar": "--", "X-Spam_report": "(-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H2=0.001, SPF_HELO_PASS=-0.001,\n SPF_PASS=-0.001 autolearn=ham autolearn_force=no", "X-Spam_action": "no action", "X-BeenThere": "qemu-devel@nongnu.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "qemu development <qemu-devel.nongnu.org>", "List-Unsubscribe": "<https://lists.nongnu.org/mailman/options/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>", "List-Archive": "<https://lists.nongnu.org/archive/html/qemu-devel>", "List-Post": "<mailto:qemu-devel@nongnu.org>", "List-Help": "<mailto:qemu-devel-request@nongnu.org?subject=help>", "List-Subscribe": "<https://lists.nongnu.org/mailman/listinfo/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=subscribe>", "Errors-To": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org", "Sender": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org" }, "content": "vmport calls synchronise_state within an I/O port read.\nSupport that properly.\n\nWhat was there before worked because of a side effect of\nwhpx_get_reg synchronising context if cpu->vcpu_dirty.\n\nRemove that whpx_get_reg call in whpx_bump_rip too as it's no longer\nneeded now.\n\nSigned-off-by: Mohamed Mediouni <mohamed@unpredictable.fr>\n---\n target/i386/whpx/whpx-all.c | 17 +++++++++++++----\n 1 file changed, 13 insertions(+), 4 deletions(-)", "diff": "diff --git a/target/i386/whpx/whpx-all.c b/target/i386/whpx/whpx-all.c\nindex 4d1a151db5..4deeffbcfc 100644\n--- a/target/i386/whpx/whpx-all.c\n+++ b/target/i386/whpx/whpx-all.c\n@@ -862,7 +862,6 @@ static void handle_io(CPUState *env, uint16_t port, void *buffer,\n static void whpx_bump_rip(CPUState *cpu, WHV_RUN_VP_EXIT_CONTEXT *exit_ctx)\n {\n WHV_REGISTER_VALUE reg;\n- whpx_get_reg(cpu, WHvX64RegisterRip, ®);\n reg.Reg64 = exit_ctx->VpContext.Rip + exit_ctx->VpContext.InstructionLength;\n whpx_set_reg(cpu, WHvX64RegisterRip, reg);\n }\n@@ -890,13 +889,23 @@ static int whpx_handle_portio(CPUState *cpu,\n } else {\n reg.Reg64 = (uint64_t)val;\n }\n- whpx_bump_rip(cpu, exit_ctx);\n- whpx_set_reg(cpu, WHvX64RegisterRax, reg);\n+ /* vmport calls cpu_synchronize_state on an I/O port read */\n+ if (!cpu->vcpu_dirty) {\n+ whpx_bump_rip(cpu, exit_ctx);\n+ whpx_set_reg(cpu, WHvX64RegisterRax, reg);\n+ } else {\n+ env->eip = exit_ctx->VpContext.Rip + exit_ctx->VpContext.InstructionLength;\n+ env->regs[R_EAX] = reg.Reg64;\n+ }\n return 0;\n } else if (!ctx->AccessInfo.StringOp && ctx->AccessInfo.IsWrite) {\n RAX(env) = ctx->Rax;\n handle_io(cpu, ctx->PortNumber, &RAX(env), 1, ctx->AccessInfo.AccessSize, 1);\n- whpx_bump_rip(cpu, exit_ctx);\n+ if (!cpu->vcpu_dirty) {\n+ whpx_bump_rip(cpu, exit_ctx);\n+ } else {\n+ env->eip = exit_ctx->VpContext.Rip + exit_ctx->VpContext.InstructionLength;\n+ }\n return 0;\n }\n \n", "prefixes": [ "v2", "11/38" ] }