Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/1.1/patches/2223738/?format=api
{ "id": 2223738, "url": "http://patchwork.ozlabs.org/api/1.1/patches/2223738/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20260416-virtio-fixups-v1-1-ec14e2de0852@linaro.org/", "project": { "id": 14, "url": "http://patchwork.ozlabs.org/api/1.1/projects/14/?format=api", "name": "QEMU Development", "link_name": "qemu-devel", "list_id": "qemu-devel.nongnu.org", "list_email": "qemu-devel@nongnu.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20260416-virtio-fixups-v1-1-ec14e2de0852@linaro.org>", "date": "2026-04-16T05:48:09", "name": "[1/2] virtio-snd: check rx buffer descriptor size", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "dc63a3d6ab28d6a379568b65afaceefc6a2ce4c7", "submitter": { "id": 86526, "url": "http://patchwork.ozlabs.org/api/1.1/people/86526/?format=api", "name": "Manos Pitsidianakis", "email": "manos.pitsidianakis@linaro.org" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20260416-virtio-fixups-v1-1-ec14e2de0852@linaro.org/mbox/", "series": [ { "id": 500076, "url": "http://patchwork.ozlabs.org/api/1.1/series/500076/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/list/?series=500076", "date": "2026-04-16T05:48:10", "name": "More virtio-snd fortifications/coverity fixes", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/500076/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/2223738/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/2223738/checks/", "tags": {}, "headers": { "Return-Path": "<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@legolas.ozlabs.org", "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256\n header.s=google header.b=IArrUbgu;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists1p.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)" ], "Received": [ "from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fx6Wv4xq7z1yG9\n\tfor <incoming@patchwork.ozlabs.org>; Thu, 16 Apr 2026 15:48:59 +1000 (AEST)", "from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists1p.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from <qemu-devel-bounces@nongnu.org>)\n\tid 1wDFaT-0003Sb-99; Thu, 16 Apr 2026 01:48:25 -0400", "from eggs.gnu.org ([2001:470:142:3::10])\n by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <manos.pitsidianakis@linaro.org>)\n id 1wDFaS-0003Rl-4A\n for qemu-devel@nongnu.org; Thu, 16 Apr 2026 01:48:24 -0400", "from mail-wm1-x32f.google.com ([2a00:1450:4864:20::32f])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)\n (Exim 4.90_1) (envelope-from <manos.pitsidianakis@linaro.org>)\n id 1wDFaQ-00016e-M4\n for qemu-devel@nongnu.org; Thu, 16 Apr 2026 01:48:23 -0400", "by mail-wm1-x32f.google.com with SMTP id\n 5b1f17b1804b1-488af96f6b2so99666585e9.0\n for <qemu-devel@nongnu.org>; Wed, 15 Apr 2026 22:48:22 -0700 (PDT)", "from [127.0.1.1] (athedsl-4440559.home.otenet.gr. [79.129.177.223])\n by smtp.gmail.com with ESMTPSA id\n 5b1f17b1804b1-488f5818e51sm39201895e9.5.2026.04.15.22.48.19\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Wed, 15 Apr 2026 22:48:20 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=linaro.org; s=google; t=1776318501; x=1776923301; darn=nongnu.org;\n h=cc:to:in-reply-to:references:message-id:content-transfer-encoding\n :mime-version:subject:date:from:from:to:cc:subject:date:message-id\n :reply-to; bh=30dDtFtVzrZ0rFH7FQtblfDTpXIqR78+UUjDSh4LLvs=;\n b=IArrUbguahQQbnJNRh+q41IDDyB29BNakMvh06/MpLLCTIPDd77HKlx1IBY03vyQyf\n dssSiYDF3R33GHda6Z1iCY+JNs2/DKPHBkAC7kaK342Yl61rxRlftNpmW2rnabWqVATJ\n LMdYi4zVdf79h/2O6qWQ6Siq23qjO09P+AOzuMhYPrF7MogXn4ICB5hkA/HJzdufayqo\n tLn4P1jdcIGgqiiV2PllH2fprZDJD3VwOYYNOnJLw/gYjgyA1aKEqOeL95cPAQcXtTik\n DurB5dHsIG33AKwBNOHQRrhu48xhrXhPumNaV6KAZudZnUk4h8akhymt7VglCgfw5ACL\n dpEw==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1776318501; x=1776923301;\n h=cc:to:in-reply-to:references:message-id:content-transfer-encoding\n :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to\n :cc:subject:date:message-id:reply-to;\n bh=30dDtFtVzrZ0rFH7FQtblfDTpXIqR78+UUjDSh4LLvs=;\n b=hD2TIkBlBpujty/fEsGUe/LTrHCPNpt+9gu17VcazEtYpsHCv50s8FLjmTENY6CNcv\n lblK4NvM0xnBQyg6dklymh+Fs0fhOnFku/b3dxaC68+721zB4KFSrxDA5JKAYe75tJ4I\n b/j/AtIUkUY++bdxNrvU9U9lyznlpwsgAxvKhfYj/3HAIo0RhHBIpLC6TqHmS84t4v76\n UWYK/s+hExjBVOA4MKJsZPCgruv1pW+KrJSNXgdxedaRqeUpQNs+OuQhH2Q+1AV8CTJ8\n 3alab3O4tcn1/tw5JpLSt329cgN/CMmNlPIx2HO1F4KBhluoKCqGtOGGFd/mNYlT0Ry7\n I/Vg==", "X-Gm-Message-State": "AOJu0YzE+iY2B7vt4buszG96eKB54XKP/mJSFH414msHrLPVsSdnvvAk\n s4h+VLxg84a3LiEqxZkUyodmjQlwP5aXt/fMuosTe5yr67yQAkAMkIhQxNxg1EhTHMY=", "X-Gm-Gg": "AeBDievtK/thUvLRg5VbbVP4SP4BP+X4fDlcy4R8hSWAdzEw12a+AunuuEIExLCRgoE\n +ARN+rdq2e3QUGy5eEMlB68cgHEs/yhThtKgd4K4Am8whVLEmSigemFZBttGuG3ka6OWNcSs2qY\n WipDZWDV84LCFqbFAdUwU1ar78oRYzUR6Sun7ubwwVMvN84PWW1N9GqOdcSicp4ebQmEgXv3+DN\n VYhvDN0hgw0fDxp53I0taVPYZ+k+47u9SN0KMkDhjeziZHeEuiApDfZxnOSjm4IU+T2nV2SLcyo\n IS8NcMqW8amiqFpipXIcVHTt5yUP9vx//PVyMINXibtTxlQhgGOEQAaiXU4OUKEzISKowIzB8BN\n dJcroIDiEz+N3PpFUwOc+TqIzGBwBxLaKSRRql9kvtFJcqyWg9gFizlHpswebiUwyuN4yx1HwS8\n eGm7wYYntPNExTaF/IQ5al+d40fPF14RKvY9AD0qPLUKIfjI7Kb3QJAKIZJARdJTwuH3UEK9GC2\n i7BtCapaOQXk/22tq5YmqLF23bCKQai980hhsJQ", "X-Received": "by 2002:a05:600c:871a:b0:488:a2ac:a34a with SMTP id\n 5b1f17b1804b1-488d67f4299mr357889185e9.10.1776318500875;\n Wed, 15 Apr 2026 22:48:20 -0700 (PDT)", "From": "Manos Pitsidianakis <manos.pitsidianakis@linaro.org>", "Date": "Thu, 16 Apr 2026 08:48:09 +0300", "Subject": "[PATCH 1/2] virtio-snd: check rx buffer descriptor size", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"utf-8\"", "Content-Transfer-Encoding": "7bit", "Message-Id": "<20260416-virtio-fixups-v1-1-ec14e2de0852@linaro.org>", "References": "<20260416-virtio-fixups-v1-0-ec14e2de0852@linaro.org>", "In-Reply-To": "<20260416-virtio-fixups-v1-0-ec14e2de0852@linaro.org>", "To": "qemu-devel@nongnu.org", "Cc": "Gerd Hoffmann <kraxel@redhat.com>, \"Michael S. Tsirkin\" <mst@redhat.com>,\n\t=?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= <philmd@linaro.org>, =?utf-8?q?Alex?=\n\t=?utf-8?q?_Benn=C3=A9e?= <alex.bennee@linaro.org>, qemu-stable@nongnu.org,\n Manos Pitsidianakis <manos.pitsidianakis@linaro.org>", "X-Mailer": "b4 0.14.2", "X-Developer-Signature": "v=1; a=openpgp-sha256; l=1381;\n i=manos.pitsidianakis@linaro.org; h=from:subject:message-id;\n bh=e7CNu6bOPefkB4cYwLokIAQo8SEItIOzfhxsnDPZRv4=;\n b=LS0tLS1CRUdJTiBQR1AgTUVTU0FHRS0tLS0tCgpvd0VCYlFLUy9aQU5Bd0FLQVhjcHgzQi9mZ\n 25RQWNzbVlnQnA0SGdpNGliQnNkQTBjaGRjb2QxcDNaRm1IYi94CmI4NEt4MDBmVzVyYmJOTm50\n OFdKQWpNRUFBRUtBQjBXSVFUTVhCdE9SS0JXODRkd0hSQjNLY2R3ZjM0SjBBVUMKYWVCNElnQUt\n DUkIzS2Nkd2YzNEowQmdXRC9zR1Q3NG1hbHRFOFBrN29rKy9FWHlGVUVwWnpFYnVjSUxvK1JqOQ\n o4eGFveEd1V1VJVDVtbm9LeEtaa2plQnhlSVZvMkdCVDdSVXRtQUdGZVZCVGNqbVZ4MWkxTU1Yc\n 2JUSTVWYTJ3CjBIcTJ4TjJOV3p4WDkxbzRCaE9QbEhPRDdCakllM21ZMytMTTFKc0F6TUZmc0Jx\n UW1LSXAwaEMrZzJqZjF3VjIKdlVydDhMb28vQmVIK2YzOUhES2ZPbGpnaE1aZUVDakdhNHJSd0t\n sSmJLdUpZUmxTa2R1QmRKT3dpdXhTYkVKWgpjck1WcUJLdld5SDFsLzFjRncvTnYyMGV1N2pvcV\n FKdm8zMWZOQWJMZjJpRzdNS2s0MTh2SUgyckJWZ0NCMEh0CldVZVpRMXpTbS9JLytnbG1RT3NRb\n GpSd0ExNEQ4Y1RSUVduNGlVajBuUTdVN1ZYMjgrMGk2K01SbVB2T0dsNTYKb1dGL0lxYmpDcTFn\n VTFrb1EwaVRxM1JFQmdYcTZvRXFieUtpZVZVWlh2R0tvdXFVcE82TkEwYlpiS2FKNTFySwptZWY\n xSW5wcnFPcEJ4ZlFCMkNBWXlXVW92OUVWcmxuMnJnZnV1T0lkOS9LMUgraEllTEtsS2FGTE9ON0\n szZXN5CmY2NWxSbkoxTk9GckdrZjNvTE9pS1MzMjFUbW9vWDM5WFN1YUFoWlN6QjdPd0VlT0ZUc\n nFGOXNnZ3R0UE9ZaFUKZ0s1MGMwV3FVeWd6Tm1VS0tjSWIvaEtGcjFzVGJFZHloUlFJL3ZsY1lv\n TTQwWlhPYjVXOGlKY21KYUJoMEJLOAp5VXM4dkRITGp3bHRhNmxJNkFRT3lTdENuUmxpRTM3L25\n uaHQ5ZHo1eDlsZzJZd1Y3UHQ1dHFBYUxTWVdOTndRCnl0MWh3QT09Cj03Qkp6Ci0tLS0tRU5EIF\n BHUCBNRVNTQUdFLS0tLS0K", "X-Developer-Key": "i=manos.pitsidianakis@linaro.org; a=openpgp;\n fpr=7C721DF9DB3CC7182311C0BF68BC211D47B421E1", "Received-SPF": "pass client-ip=2a00:1450:4864:20::32f;\n envelope-from=manos.pitsidianakis@linaro.org; helo=mail-wm1-x32f.google.com", "X-Spam_score_int": "-20", "X-Spam_score": "-2.1", "X-Spam_bar": "--", "X-Spam_report": "(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001,\n SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no", "X-Spam_action": "no action", "X-BeenThere": "qemu-devel@nongnu.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "qemu development <qemu-devel.nongnu.org>", "List-Unsubscribe": "<https://lists.nongnu.org/mailman/options/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>", "List-Archive": "<https://lists.nongnu.org/archive/html/qemu-devel>", "List-Post": "<mailto:qemu-devel@nongnu.org>", "List-Help": "<mailto:qemu-devel-request@nongnu.org?subject=help>", "List-Subscribe": "<https://lists.nongnu.org/mailman/listinfo/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=subscribe>", "Errors-To": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org", "Sender": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org" }, "content": "It must be at least sizeof(virtio_snd_pcm_status).\n\nI haven't verified if it's possible to get an underflow, but coverity\npoints it out so add a check.\n\nSigned-off-by: Manos Pitsidianakis <manos.pitsidianakis@linaro.org>\n---\n hw/audio/virtio-snd.c | 8 +++++---\n 1 file changed, 5 insertions(+), 3 deletions(-)", "diff": "diff --git a/hw/audio/virtio-snd.c b/hw/audio/virtio-snd.c\nindex fb5cff386606d03e5cfce88f79e404e510bbcde7..93fbcfb43f7fdcfd5c164b496015da743822f5eb 100644\n--- a/hw/audio/virtio-snd.c\n+++ b/hw/audio/virtio-snd.c\n@@ -970,12 +970,14 @@ static void virtio_snd_handle_rx_xfer(VirtIODevice *vdev, VirtQueue *vq)\n }\n \n stream = vsnd->pcm.streams[stream_id];\n- if (stream == NULL || stream->info.direction != VIRTIO_SND_D_INPUT) {\n+ size = iov_size(elem->in_sg, elem->in_num);\n+ if (stream == NULL\n+ || stream->info.direction != VIRTIO_SND_D_INPUT\n+ || size < sizeof(virtio_snd_pcm_status)) {\n goto rx_err;\n }\n+ size -= sizeof(virtio_snd_pcm_status);\n WITH_QEMU_LOCK_GUARD(&stream->queue_mutex) {\n- size = iov_size(elem->in_sg, elem->in_num) -\n- sizeof(virtio_snd_pcm_status);\n buffer = g_malloc0(sizeof(VirtIOSoundPCMBuffer) + size);\n buffer->elem = elem;\n buffer->vq = vq;\n", "prefixes": [ "1/2" ] }