Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/1.1/patches/2223736/?format=api
{ "id": 2223736, "url": "http://patchwork.ozlabs.org/api/1.1/patches/2223736/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20260416-virtio-fixups-v1-2-ec14e2de0852@linaro.org/", "project": { "id": 14, "url": "http://patchwork.ozlabs.org/api/1.1/projects/14/?format=api", "name": "QEMU Development", "link_name": "qemu-devel", "list_id": "qemu-devel.nongnu.org", "list_email": "qemu-devel@nongnu.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20260416-virtio-fixups-v1-2-ec14e2de0852@linaro.org>", "date": "2026-04-16T05:48:10", "name": "[2/2] virtio-snd: check for overflow before g_malloc0", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "3bd3b2bc85261319725a1cadce91a562d35ec626", "submitter": { "id": 86526, "url": "http://patchwork.ozlabs.org/api/1.1/people/86526/?format=api", "name": "Manos Pitsidianakis", "email": "manos.pitsidianakis@linaro.org" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20260416-virtio-fixups-v1-2-ec14e2de0852@linaro.org/mbox/", "series": [ { "id": 500076, "url": "http://patchwork.ozlabs.org/api/1.1/series/500076/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/list/?series=500076", "date": "2026-04-16T05:48:10", "name": "More virtio-snd fortifications/coverity fixes", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/500076/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/2223736/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/2223736/checks/", "tags": {}, "headers": { "Return-Path": "<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@legolas.ozlabs.org", "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256\n header.s=google header.b=picWPq9Y;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists1p.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)" ], "Received": [ "from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fx6Wq4Bjwz1yG9\n\tfor <incoming@patchwork.ozlabs.org>; Thu, 16 Apr 2026 15:48:55 +1000 (AEST)", "from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists1p.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from <qemu-devel-bounces@nongnu.org>)\n\tid 1wDFaX-0003U9-F1; Thu, 16 Apr 2026 01:48:30 -0400", "from eggs.gnu.org ([2001:470:142:3::10])\n by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <manos.pitsidianakis@linaro.org>)\n id 1wDFaT-0003Sw-G1\n for qemu-devel@nongnu.org; Thu, 16 Apr 2026 01:48:25 -0400", "from mail-wm1-x330.google.com ([2a00:1450:4864:20::330])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)\n (Exim 4.90_1) (envelope-from <manos.pitsidianakis@linaro.org>)\n id 1wDFaR-000177-MB\n for qemu-devel@nongnu.org; Thu, 16 Apr 2026 01:48:25 -0400", "by mail-wm1-x330.google.com with SMTP id\n 5b1f17b1804b1-488ab2db91aso116479845e9.3\n for <qemu-devel@nongnu.org>; Wed, 15 Apr 2026 22:48:23 -0700 (PDT)", "from [127.0.1.1] (athedsl-4440559.home.otenet.gr. [79.129.177.223])\n by smtp.gmail.com with ESMTPSA id\n 5b1f17b1804b1-488f5818e51sm39201895e9.5.2026.04.15.22.48.21\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Wed, 15 Apr 2026 22:48:21 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=linaro.org; s=google; t=1776318502; x=1776923302; darn=nongnu.org;\n h=cc:to:in-reply-to:references:message-id:content-transfer-encoding\n :mime-version:subject:date:from:from:to:cc:subject:date:message-id\n :reply-to; bh=F2jYUyzKmM1Ih+knLVuBivXQ4AWzwy4G2sMPSe8xIm8=;\n b=picWPq9Y6W7sXr/WbLnPVy6Qt3fV1w8v3mUWuWO+hQU4syM3atR8OBS/j6hYKcMPwP\n NV4asLu99uZyrHUHLV2FX0p4cRCeKXhe17vpDfuXN+a03PK0TVOCyeqBHuHXqYfar9Tb\n XjOLMKda2MPjvauGvL3jUnT2Aq2aT7Cble54PZONKOAykUtROixt00+TuSyhx4LXo+rQ\n au36c0nxxHt9SSpOaI4pXECuCHA7pamw3MrlYthSUT03xUd67oDhexiI+BSl3NVXEvRZ\n kAiyYHrN1bMI5V+h7Z11k4BN4tWxK2sl8UxbFVl2c+CoI1/mIGY659TRqUATVMQ4M6A5\n r3fA==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1776318502; x=1776923302;\n h=cc:to:in-reply-to:references:message-id:content-transfer-encoding\n :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to\n :cc:subject:date:message-id:reply-to;\n bh=F2jYUyzKmM1Ih+knLVuBivXQ4AWzwy4G2sMPSe8xIm8=;\n b=flmLaMqW3CfS8OvBniOnAUrz7fNRhrYoxRYPhfhSUVHM/F4+r/7hSOHsBIwOLEJjtQ\n Kv8Stl0uLJaLxHBM2n8kPrvI+CHOlpID4r0E0wjk0HO0Kg6g8/25aywrq9WEW4FSusiB\n KdVwdn7ccYu4shEtRjcicq8VcjyCGDZYcqFn4N/vFm9QeuFm6cV5n8aiHFFXUwH7gvWK\n 73uO/WbyzMY2TIoftZ9UWtvhwCWmBKI4EJfU5zP9hdQUB7w96cfVzA+UoRG+Jc5+mQbE\n 0byLUz8hX3muZQc2pIHeS/FEmrF3ev059XKsbl7jy5ek23khT1V0IniWd5cu8SUpA96X\n Jugw==", "X-Gm-Message-State": "AOJu0Yx3ybFiayMPPfTffgwkLKHCa0Tp4wtlspbUeeOeR1jrNbQcQ1fh\n Vb29xjNsxdJVE2BrJew5F56lgfQY3MimRa7TtUQHxww4eYHDbX+bls5e8Fdexn7O2YA=", "X-Gm-Gg": "AeBDies/OW7oI3Vv8XI8glo1Q1aR5nmpy9XAJ2E5E8sGMkJAIQKPjVj4aU+IRacEIXl\n eZc23GDfHNMkhKX44hDDyXiVNQfRIekY8LoUbXbHC4+HbR1U7EEiQu4wy626Ib90oy5Hkwic1Dg\n yEI+cTY+0PYj84E5vKy2xm6OyRb69QQ8sV5nEdoOsILaLHEujMb1id9m/vwi6OODi/wqO0FjlgE\n RgYu0Q63DVrREbGxBI5pIEhu5JV5NFcRu7IL8XyX+nE0zbsLgLjO+7GQ361CVnHd0zSgjD0swzu\n K/J0TCnY3CSy8lf02HiKu4XfagFRJYWRiMdNs2PuCJmAUlso20q2Ei71m9LntCjBv5+hc8pgWJj\n 5NGFFAIFXttDTvBgsEiTBiNXQHFc0gy0ZsimUaQVLL1jkH/k31+vY4AsPNab88+r1xNfQmLhiNl\n MUrE8ZsI2oeQTsbZbQWhqjWVw1gbKVUOlYxklrcgv6gOwAroCqdza4zSiZPc6cCRq3k5epgZXrD\n D/yNaEqH8n4tYjQWk3DXe6drexu4xxzRnzcplD9", "X-Received": "by 2002:a05:600c:c16d:b0:488:be21:54ae with SMTP id\n 5b1f17b1804b1-488d66504bfmr364443315e9.0.1776318501986;\n Wed, 15 Apr 2026 22:48:21 -0700 (PDT)", "From": "Manos Pitsidianakis <manos.pitsidianakis@linaro.org>", "Date": "Thu, 16 Apr 2026 08:48:10 +0300", "Subject": "[PATCH 2/2] virtio-snd: check for overflow before g_malloc0", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"utf-8\"", "Content-Transfer-Encoding": "7bit", "Message-Id": "<20260416-virtio-fixups-v1-2-ec14e2de0852@linaro.org>", "References": "<20260416-virtio-fixups-v1-0-ec14e2de0852@linaro.org>", "In-Reply-To": "<20260416-virtio-fixups-v1-0-ec14e2de0852@linaro.org>", "To": "qemu-devel@nongnu.org", "Cc": "Gerd Hoffmann <kraxel@redhat.com>, \"Michael S. Tsirkin\" <mst@redhat.com>,\n\t=?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= <philmd@linaro.org>, =?utf-8?q?Alex?=\n\t=?utf-8?q?_Benn=C3=A9e?= <alex.bennee@linaro.org>, qemu-stable@nongnu.org,\n Manos Pitsidianakis <manos.pitsidianakis@linaro.org>", "X-Mailer": "b4 0.14.2", "X-Developer-Signature": "v=1; a=openpgp-sha256; l=2754;\n i=manos.pitsidianakis@linaro.org; h=from:subject:message-id;\n bh=xDZS3tY6bYSiiCPsg7erlUolIXhnU1SspuDcZfqcF18=;\n b=LS0tLS1CRUdJTiBQR1AgTUVTU0FHRS0tLS0tCgpvd0VCYlFLUy9aQU5Bd0FLQVhjcHgzQi9mZ\n 25RQWNzbVlnQnA0SGdpbnlVMURieUVaUC96MUJNL0xsamhLZ25ECjUyNHdIc0NESkFhL2ppNWVn\n d3VKQWpNRUFBRUtBQjBXSVFUTVhCdE9SS0JXODRkd0hSQjNLY2R3ZjM0SjBBVUMKYWVCNElnQUt\n DUkIzS2Nkd2YzNEowTVZ4RC85dEd5YlUxVUVSaE5BNWJ2UGJaVEJxYS9tcWM5L3BxVGJDY1REKw\n prQ2xaTFc4VzRvbmU5Nm51K1JzY1Zlc3lTUXFqZTcvVk0xeFkrN2lrUFBwcHhyOHkzeFg0S0JaY\n 0I5c3ZhRzJYCnAzZ0l6SWwvU1NtazRFeDRZYjdCSlFHOUpLOGhvVmN3MDk2cWtmL2xqQ3J5VHBn\n Smh2Q1plSWtnMWxmRjdKUnEKWmVYT3V6SUlLNCtHRFl6Q0FvenoyYXhSeEsvcFg1L2JMMk9KYnM\n 0VWtQajBXb0xHeFNySnRuYjM1WEJTS3U2ZgpLWGUvNFZ5YzAzZGhWOUxuRFJBeElIOFpQREwwek\n FIbHdZYzc2WkxRUk4relNMTFJaYVR0UDFGOWMvZlFiQVcrCnhLRjhOcVZ2bXF5azh0elIrckxJd\n WRISTNoa0dXWi96S2Z6d2lMRVFOUkdlcDJWeUtXS2tBdld2Ymc0YWhsNGwKa1J5dFdvRzVUUkQx\n a1IxUk5KUVpIcm9HSDZZaVdiaVhpRExzMzg1d29HVGJnZk5SSUx1V29lcWNLNmczYURxbApnMG5\n TcXg1UzUzZjVwdTZLMWJKUkJHa1hqNW9FVldNd1Y5Q3pBT2lRUGxZWXRrRTFDSWY3Wng5VUlMam\n kwOHV3Cm00SkY2ZUUrMXpxckN1bzV5SFJsb0hHMm5KWDJSc3ZDT281Q05iZWEyQ1dkM3VnN2xyd\n 0c4dkdBajhYY21rVVEKa3hrNHI2S2t0azVGK3NKRkpYcElSTnQwV3ZKaEJicC8rdWJ2Y2FheGFi\n S3FldVhoU3llYi9jK3kzVkc3b3czNAovdVdqb2JqamVycTlrNlZ0M1FHdm5iV0VYbjkwV3psOFJ\n aUXppRzdGTGtuaU1EaTRlbzhsOWNTelB0endieCtJCmV0UjFZdz09Cj05cDcxCi0tLS0tRU5EIF\n BHUCBNRVNTQUdFLS0tLS0K", "X-Developer-Key": "i=manos.pitsidianakis@linaro.org; a=openpgp;\n fpr=7C721DF9DB3CC7182311C0BF68BC211D47B421E1", "Received-SPF": "pass client-ip=2a00:1450:4864:20::330;\n envelope-from=manos.pitsidianakis@linaro.org; helo=mail-wm1-x330.google.com", "X-Spam_score_int": "-20", "X-Spam_score": "-2.1", "X-Spam_bar": "--", "X-Spam_report": "(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001,\n SPF_PASS=-0.001 autolearn=ham autolearn_force=no", "X-Spam_action": "no action", "X-BeenThere": "qemu-devel@nongnu.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "qemu development <qemu-devel.nongnu.org>", "List-Unsubscribe": "<https://lists.nongnu.org/mailman/options/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>", "List-Archive": "<https://lists.nongnu.org/archive/html/qemu-devel>", "List-Post": "<mailto:qemu-devel@nongnu.org>", "List-Help": "<mailto:qemu-devel-request@nongnu.org?subject=help>", "List-Subscribe": "<https://lists.nongnu.org/mailman/listinfo/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=subscribe>", "Errors-To": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org", "Sender": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org" }, "content": "Coverity points out one g_malloc0 overflow, but it seems to be a false\npositive. Add a check to it regardless to fortify the code, and also add\nchecks for every other g_malloc0 use.\n\nSigned-off-by: Manos Pitsidianakis <manos.pitsidianakis@linaro.org>\n---\n hw/audio/virtio-snd.c | 16 ++++++++++++----\n 1 file changed, 12 insertions(+), 4 deletions(-)", "diff": "diff --git a/hw/audio/virtio-snd.c b/hw/audio/virtio-snd.c\nindex 93fbcfb43f7fdcfd5c164b496015da743822f5eb..a294d267b097249d0171722a5ec131159a5e7027 100644\n--- a/hw/audio/virtio-snd.c\n+++ b/hw/audio/virtio-snd.c\n@@ -850,7 +850,7 @@ static void virtio_snd_handle_tx_xfer(VirtIODevice *vdev, VirtQueue *vq)\n VirtIOSound *vsnd = VIRTIO_SND(vdev);\n VirtIOSoundPCMBuffer *buffer;\n VirtQueueElement *elem;\n- size_t msg_sz, size;\n+ size_t msg_sz, size, tmp;\n virtio_snd_pcm_xfer hdr;\n uint32_t stream_id;\n /*\n@@ -880,6 +880,8 @@ static void virtio_snd_handle_tx_xfer(VirtIODevice *vdev, VirtQueue *vq)\n if (msg_sz != sizeof(virtio_snd_pcm_xfer)) {\n goto tx_err;\n }\n+ assert(iov_size(elem->out_sg, elem->out_num) >= msg_sz);\n+ size = iov_size(elem->out_sg, elem->out_num) - msg_sz;\n stream_id = le32_to_cpu(hdr.stream_id);\n \n if (stream_id >= vsnd->snd_conf.streams\n@@ -892,9 +894,11 @@ static void virtio_snd_handle_tx_xfer(VirtIODevice *vdev, VirtQueue *vq)\n goto tx_err;\n }\n \n+ /* Check for g_malloc0 overflow. */\n+ if (!g_uint_checked_add(&tmp, sizeof(VirtIOSoundPCMBuffer), size)) {\n+ goto tx_err;\n+ }\n WITH_QEMU_LOCK_GUARD(&stream->queue_mutex) {\n- size = iov_size(elem->out_sg, elem->out_num) - msg_sz;\n-\n buffer = g_malloc0(sizeof(VirtIOSoundPCMBuffer) + size);\n buffer->elem = elem;\n buffer->populated = false;\n@@ -932,7 +936,7 @@ static void virtio_snd_handle_rx_xfer(VirtIODevice *vdev, VirtQueue *vq)\n VirtIOSound *vsnd = VIRTIO_SND(vdev);\n VirtIOSoundPCMBuffer *buffer;\n VirtQueueElement *elem;\n- size_t msg_sz, size;\n+ size_t msg_sz, size, tmp;\n virtio_snd_pcm_xfer hdr;\n uint32_t stream_id;\n /*\n@@ -977,6 +981,10 @@ static void virtio_snd_handle_rx_xfer(VirtIODevice *vdev, VirtQueue *vq)\n goto rx_err;\n }\n size -= sizeof(virtio_snd_pcm_status);\n+ /* Check for g_malloc0 overflow. */\n+ if (!g_uint_checked_add(&tmp, sizeof(VirtIOSoundPCMBuffer), size)) {\n+ goto rx_err;\n+ }\n WITH_QEMU_LOCK_GUARD(&stream->queue_mutex) {\n buffer = g_malloc0(sizeof(VirtIOSoundPCMBuffer) + size);\n buffer->elem = elem;\n", "prefixes": [ "2/2" ] }