Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/1.1/patches/2223714/?format=api
{ "id": 2223714, "url": "http://patchwork.ozlabs.org/api/1.1/patches/2223714/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20260416014928.1279360-5-jamin_lin@aspeedtech.com/", "project": { "id": 14, "url": "http://patchwork.ozlabs.org/api/1.1/projects/14/?format=api", "name": "QEMU Development", "link_name": "qemu-devel", "list_id": "qemu-devel.nongnu.org", "list_email": "qemu-devel@nongnu.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20260416014928.1279360-5-jamin_lin@aspeedtech.com>", "date": "2026-04-16T01:49:38", "name": "[v3,04/17] hw/usb/hcd-ehci.c: Replace fprintf(stderr, ...) with qemu_log_mask(LOG_GUEST_ERROR)", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "14e07fc5c2c1b423a9a893b2776fd7853a6291e0", "submitter": { "id": 81768, "url": "http://patchwork.ozlabs.org/api/1.1/people/81768/?format=api", "name": "Jamin Lin", "email": "jamin_lin@aspeedtech.com" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20260416014928.1279360-5-jamin_lin@aspeedtech.com/mbox/", "series": [ { "id": 500066, "url": "http://patchwork.ozlabs.org/api/1.1/series/500066/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/list/?series=500066", "date": "2026-04-16T01:49:32", "name": "hw/usb/ehci: Add 64-bit descriptor addressing support", "version": 3, "mbox": "http://patchwork.ozlabs.org/series/500066/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/2223714/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/2223714/checks/", "tags": {}, "headers": { "Return-Path": "<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@legolas.ozlabs.org", "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=aspeedtech.com header.i=@aspeedtech.com\n header.a=rsa-sha256 header.s=selector1 header.b=qo0GL3T9;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists1p.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)", "dkim=none (message not signed)\n header.d=none;dmarc=none action=none header.from=aspeedtech.com;" ], "Received": [ "from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fx1GV3QC1z1yHV\n\tfor <incoming@patchwork.ozlabs.org>; Thu, 16 Apr 2026 11:52:02 +1000 (AEST)", "from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists1p.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from <qemu-devel-bounces@nongnu.org>)\n\tid 1wDBsO-0008JF-3p; Wed, 15 Apr 2026 21:50:40 -0400", "from eggs.gnu.org ([2001:470:142:3::10])\n by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <jamin_lin@aspeedtech.com>)\n id 1wDBrf-0007rU-DC; Wed, 15 Apr 2026 21:49:56 -0400", "from mail-japaneastazlp170120005.outbound.protection.outlook.com\n ([2a01:111:f403:c405::5] helo=TYPPR03CU001.outbound.protection.outlook.com)\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <jamin_lin@aspeedtech.com>)\n id 1wDBrd-0007Ut-AL; Wed, 15 Apr 2026 21:49:55 -0400", "from TYPPR06MB8206.apcprd06.prod.outlook.com (2603:1096:405:383::19)\n by SEYPR06MB6202.apcprd06.prod.outlook.com (2603:1096:101:c7::12)\n with Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9769.48; Thu, 16 Apr\n 2026 01:49:38 +0000", "from TYPPR06MB8206.apcprd06.prod.outlook.com\n ([fe80::e659:1ead:77cb:f6d3]) by TYPPR06MB8206.apcprd06.prod.outlook.com\n ([fe80::e659:1ead:77cb:f6d3%3]) with mapi id 15.20.9818.017; Thu, 16 Apr 2026\n 01:49:38 +0000" ], "ARC-Seal": "i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none;\n b=vSO8so45sVV/IY3qD9I4FDlXistynRyfePX+AiKygCd67VUdVzJCM319ue0HOBUbbep9r1lU4rtvq4k44UF9OGqKBzLdFq/qmMVzqTuVE2lv4BbPxt/j3sM5rZbJoWlN3RBZQ9ZAwKnVh05g15h6d3pMMkhUoMSXkYwj4cV0MvNy59hVhbwvvUt/EmiHaxM5wHDEnHGViXgU25pSFxpxkUfECjtp/EgzKkviqFJQe/Kfnp4GrzMfy87b6H04OOtlEoLV0kiCJ3rZdckqs8QoCoJ+nEIvkySZBc7tSK35f7fmatCvy5YzXGXsqP5DcqMIltN9E4iRpeJmrkMbslT0IQ==", "ARC-Message-Signature": "i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;\n s=arcselector10001;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;\n bh=DPUuYGkfIR6j1AbiEpDRbnOQ1Z8Qp5SXYAhDVwcsM6k=;\n b=f9loNBb2x49Px5zp//6jDcn4IRQosnmmupDcgAGNpKxKxg72hg62qhtG1GYo+TMGqF9F3hv6O/IzwJ3eyf+PUpXiRgY8JsNR7S3gyfJOQz4eAnlAkV/q/8oBNxwoalRQ6AK/PMiv2XMBLQ1TQwXJztskIAtIWe0XeRO8Z3NeqGL+LjM5RCBWXWoNYOaQ4tgHo21KUdOxUhEW3kn6yy/R/bMFxZmazlIwTWuEVsERgGxMTlBaKGymrBSOI/b8VHZzbLkKBrQH2KrNZFR0xHcLeU1kCtuQ1DFxPCjpk9rsGGzG5e4WkvrxviG+poJ8h+q8fOuc6EsH3Zh2H0N/CprpcQ==", "ARC-Authentication-Results": "i=1; mx.microsoft.com 1; spf=pass\n smtp.mailfrom=aspeedtech.com; dmarc=pass action=none\n header.from=aspeedtech.com; dkim=pass header.d=aspeedtech.com; arc=none", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=aspeedtech.com;\n s=selector1;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;\n bh=DPUuYGkfIR6j1AbiEpDRbnOQ1Z8Qp5SXYAhDVwcsM6k=;\n b=qo0GL3T9Ba+ynRpxo2AsQpn7/ZxKg8T9DJA5oQAjVFBiI93vZABzLqNR9TEX+Kj3gUZpqoaRivWajjt+bpbMx4WaIy8V8zQirw/WJuLgD4zxqOrgWFU4A6S1m4oqT7+preKAJ21pqkyNE0hmhxufANajik76uVir6yTVW4BUJlN/O87D2poxgVVtQTEQ3jz4IHVlgrCuV0T8GgCrBipWWv8A45cot7fWGnpnOF2x5ERoUZZPYEro9Cwl2POqvTOZey8xGNnarRTQjj89YhCvWiLHR+PLn6noMKZd7bVc8lGwcuNVI44Inl3GMn4Gv3amaIhPS6GOV3WgvYHtI9/q+w==", "From": "Jamin Lin <jamin_lin@aspeedtech.com>", "To": "\"philmd@linaro.org\" <philmd@linaro.org>, =?iso-8859-1?q?C=E9dric_Le_Goat?=\n\t=?iso-8859-1?q?er?= <clg@kaod.org>, Peter Maydell <peter.maydell@linaro.org>,\n Steven Lee <steven_lee@aspeedtech.com>, Troy Lee <leetroy@gmail.com>,\n Kane Chen <kane_chen@aspeedtech.com>,\n Andrew Jeffery <andrew@codeconstruct.com.au>, Joel Stanley <joel@jms.id.au>,\n \"open list:ASPEED BMCs\" <qemu-arm@nongnu.org>,\n \"open list:All patches CC here\" <qemu-devel@nongnu.org>", "CC": "Jamin Lin <jamin_lin@aspeedtech.com>, Troy Lee <troy_lee@aspeedtech.com>,\n \"flwu@google.com\" <flwu@google.com>, \"nabihestefan@google.com\"\n <nabihestefan@google.com>", "Subject": "[PATCH v3 04/17] hw/usb/hcd-ehci.c: Replace fprintf(stderr, ...) with\n qemu_log_mask(LOG_GUEST_ERROR)", "Thread-Topic": "[PATCH v3 04/17] hw/usb/hcd-ehci.c: Replace fprintf(stderr, ...)\n with qemu_log_mask(LOG_GUEST_ERROR)", "Thread-Index": "AQHczUNIl3qnO/08SECSdkVJPlcLgA==", "Date": "Thu, 16 Apr 2026 01:49:38 +0000", "Message-ID": "<20260416014928.1279360-5-jamin_lin@aspeedtech.com>", "References": "<20260416014928.1279360-1-jamin_lin@aspeedtech.com>", "In-Reply-To": "<20260416014928.1279360-1-jamin_lin@aspeedtech.com>", "Accept-Language": "zh-TW, en-US", "Content-Language": "en-US", "X-MS-Has-Attach": "", "X-MS-TNEF-Correlator": "", "authentication-results": [ "legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=aspeedtech.com header.i=@aspeedtech.com\n header.a=rsa-sha256 header.s=selector1 header.b=qo0GL3T9;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists1p.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)", "dkim=none (message not signed)\n header.d=none;dmarc=none action=none header.from=aspeedtech.com;" ], "x-ms-publictraffictype": "Email", "x-ms-traffictypediagnostic": "TYPPR06MB8206:EE_|SEYPR06MB6202:EE_", "x-ms-office365-filtering-correlation-id": "1e8c41dd-f38e-4a3f-c326-08de9b5a6b71", "x-ms-exchange-senderadcheck": "1", "x-ms-exchange-antispam-relay": "0", "x-microsoft-antispam": "BCL:0;\n ARA:13230040|376014|7416014|1800799024|366016|38070700021|921020|18002099003|22082099003|56012099003;", "x-microsoft-antispam-message-info": "\n Mbuq+qMGJmjvwmlYxQlota8PUBmeeyIug7oh4aCt44wrkOF82Zz3LVUsOXnekwtaXDb3NK6KdP/6gEdDMa4VhJ187doon6tfUQNh9EOmrTjD2R1k16t88B3y4HhjOgzH8vbqzifnhKAu56y36ef8YxVamjh0qyl97Zacy1HW1r6V36hoBzrsrvlPxLqgpjEokW4SdUoK+SSKp77nAI2gQdOjS9LuUHuJJyYEBt7VGhaa1ep7eS8hW/9Z7mnr8Aqr3lqKC3NnMThQwJgkeKum1LoHOAS6T5TxKx1bD8dLI0SUobtBnshetHLoJ492za6UYjiJAz3mpRkKI+XA9cZYFbyILJZjBbaYnqkJcjWrOucF20t7olLaeUloCxKfFe69wporErEvjWgUn0qXqdY5IWzDNT+qhhdwysPczskDl6PlcY4Ea8ARxziEMUaZu85CIh5s38ntDepPfFcl0OgFXx3PRo2A367L+07P5t26AHmX3kKJj+3FcX8sJWr9JNeDjbnPEiV4d/A7bF5SO8wKTSGfGSgHOdbP/FInEZloLl0soS06HB2Daq8t8wuv78FIhVsOm+Pg93tPc3Z425Ung60HvVUsCx15ZUT0aR4VcU4jvYM5htGI36D++TmudoYj29b9o23N551KuAA5MHJFQcg46JBaZpDSAi/Kzgv+4UFjEMEa2oNAAmThbUW3/lcQXQihJU89SsjwY2qwdF6cWJYJ15UbuG15BtjTiShNWEItqgkrdvCy/aVJMTBZ7T6qe5DOTwq5HBKS+Lq3AqYNK9vrN9M+Sv8qf7VDKoEMvv4/lEBrS4DVRKXuiryex8Y+", "x-forefront-antispam-report": "CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:;\n IPV:NLI; SFV:NSPM; H:TYPPR06MB8206.apcprd06.prod.outlook.com; PTR:; CAT:NONE;\n SFS:(13230040)(376014)(7416014)(1800799024)(366016)(38070700021)(921020)(18002099003)(22082099003)(56012099003);\n DIR:OUT; SFP:1102;", "x-ms-exchange-antispam-messagedata-chunkcount": "1", "x-ms-exchange-antispam-messagedata-0": "=?iso-8859-1?q?iGn3Y3jt5M1kh6V0zzOaue3?=\n\t=?iso-8859-1?q?PTOWrmrzuHefDXZ2OimX5gkkiBNriwKVJPiLXviJa3ZWo4NCa8Zx9O9cV9HN?=\n\t=?iso-8859-1?q?ofOmlq6eWH6WpKDaPj2I2q2aGanDcplVeKJaeGvhmOd7pTJpa8ir8VrsLsDE?=\n\t=?iso-8859-1?q?aNTxZgmlFgMarH5z2YSudo29QhZdl2zYhozWwN/GLsGmKKiJz4zWKVrh+3Od?=\n\t=?iso-8859-1?q?0+2SqWVdyrT//boIyRN7H8csUvauoryOfPniB2diGzZd/DmqLyK5OX8oWmJh?=\n\t=?iso-8859-1?q?okZO6LUKTwMpT7Inf5Gp2946+KFtXGrjs29XrtEyju4FvgmjW8537/albZed?=\n\t=?iso-8859-1?q?ynuH9LZevNSZpRml2uL4rhUZD73PGPyywS4JNVWvVSF+Yt/nVfxcyv2fxaOa?=\n\t=?iso-8859-1?q?OTMsumC8qKCXShVAW77uqOlQEBzaxf8tBEyiMqrdFEVf767XGgZDWjYSSyvf?=\n\t=?iso-8859-1?q?3IMNQt9ygEAcr+AfeKww0fHQf20yE6IoyP4gXErJeTLGs4MkKjgSFUflZ76N?=\n\t=?iso-8859-1?q?6Aj38jGkjctTxzatc1Tfib5fLJ8b1HB3jyZfyfb+frAUMPfEys8Nepf9EKpT?=\n\t=?iso-8859-1?q?YSLxcyN+C56B3W3tUzrsJJfS9SyTrEw9MPU0Zx4QBRffD7o+Vx1bQknP3OoR?=\n\t=?iso-8859-1?q?Hg6wDpd6PXN4HRlvjC8KxbVvRz5ph7AvV1MWsb24Ms789SM5+qlfAxA/rTDd?=\n\t=?iso-8859-1?q?rkYwbUlFZsMk1RhNsgMGq6QKeir2eF3rb87oGawAx+sU59NpTx8dpVt51OiH?=\n\t=?iso-8859-1?q?Nn0q03ZQl91UUNqr+d6IIpWZ60vcV8yd9WSNzhohzHptsmmY7xbnjTIPlNmr?=\n\t=?iso-8859-1?q?UDeEIi25m4LFMO7GLCQr8GN/oDmErvoAtcKhMo+BWFFk2l7Nk934qJEfpDvb?=\n\t=?iso-8859-1?q?OFXDvCLY6x73f+krHjRkltsShaDJz/Vhbkax+0vLRKAnCOGYIrajekz5ciNO?=\n\t=?iso-8859-1?q?/neDxYlQlKEbZczI0UGzoS5rYxGMwCGuybnucYC+0R/xU7rH9GC0/9NDy7sf?=\n\t=?iso-8859-1?q?3bIZa0SL5l7g0u5auPmxt0C8s6siSti6z7zINs/At95adoVGLHIn7Tgf76Ww?=\n\t=?iso-8859-1?q?eMP12HuaIEl6wiMqEj9ratwKL+55Ne8U2TD3vKudMtA9EvSvGtLdzFzjTpiL?=\n\t=?iso-8859-1?q?dWhNFOZQlopGmzsefP9rqL3cYCeDB13spGbGWD2wy1Zvpjr/GCcZsNhwH9z4?=\n\t=?iso-8859-1?q?KgiERz5SG/AE+tgje5JXhxDRizu/yXGO6lbkqXn2qx1aC/sjP57R/ex4R6++?=\n\t=?iso-8859-1?q?79Jjedbqlg//eEDlSgyRFt/0qoCJ9sQaHCWo5EazB/+tgyo6SAdL1d9oeJcM?=\n\t=?iso-8859-1?q?FLBxRDo+fJokSgiI5UZ4ZGCCt92cb0jI3BoHMECLtAawCV4vlHWYJKqYhpXE?=\n\t=?iso-8859-1?q?Yqo8FCwFcIdzdiPaT4Xdk8Xbgn5NVZMJWxSx5+b/nzcagiW2KEwXO+5FKGfL?=\n\t=?iso-8859-1?q?LJPxq+HsDdJBB61XbRvcNn3zLQvSQDH+ert/1X8TPm1/3HbPZ/KwaGDO93UR?=\n\t=?iso-8859-1?q?HIxGlTZ4owdVa9danW8wwxBOD8C3EUwnYmwbrYNWBmdOJQS3Jl2SKlJGQcIp?=\n\t=?iso-8859-1?q?TQKw62y13fwnX32VkXX0k8VgC+Owd4jhB1EBJrPWbnvoIjJTesFhF5mIsYLu?=\n\t=?iso-8859-1?q?rV7HF5FTZjy0rNeTe03gRBNHY+YLslnkCSOOMdrrG7Q0i3+lP5mZvLDzk17J?=\n\t=?iso-8859-1?q?MCSzhS8dx9PvLDDuWChvLNYkaJkqWkgianTDodC5IUqFAPGRVp0CVcj9wM5h?=\n\t=?iso-8859-1?q?JQVwNKeF+fictmwDd2UygCEXNUfSruuMsKplXvoU0vYUwaA=3D=3D?=", "Content-Type": "text/plain; charset=\"iso-8859-1\"", "Content-Transfer-Encoding": "quoted-printable", "MIME-Version": "1.0", "X-Exchange-RoutingPolicyChecked": "\n TF8KPomgOKoz/0bV6bEke5Lf2a9Rl5xlQWKcCRvIvKrzyb+yF8hc/SCT3hjVqvladmSBUkiOT/1Zjxn4i/XVaCH5r7DJGQmlBkCBWGJanDDZv9EMWfCr/SnDS5sICZVWtM89u6Ty6j6BGP+8Y9bryAkIVkAz9LeT84yiT9YOeES4JDz3S0Ur1gSil+I7AG6u4iv2TDiVjZzmb9lVtU80UUe08QRR0POyCIP+5MKRNUK3d87SSI/XO6Y5tpqxOD4Ur9qLsq2W6YucynK0pFoexwsjX3vgenHcVJnoK/7/ElVJjpU+7S9J036uQk/DCOLYv5O4bRannO+zqX9fENGPJw==", "X-OriginatorOrg": "aspeedtech.com", "X-MS-Exchange-CrossTenant-AuthAs": "Internal", "X-MS-Exchange-CrossTenant-AuthSource": "TYPPR06MB8206.apcprd06.prod.outlook.com", "X-MS-Exchange-CrossTenant-Network-Message-Id": "\n 1e8c41dd-f38e-4a3f-c326-08de9b5a6b71", "X-MS-Exchange-CrossTenant-originalarrivaltime": "16 Apr 2026 01:49:38.4947 (UTC)", "X-MS-Exchange-CrossTenant-fromentityheader": "Hosted", "X-MS-Exchange-CrossTenant-id": "43d4aa98-e35b-4575-8939-080e90d5a249", "X-MS-Exchange-CrossTenant-mailboxtype": "HOSTED", "X-MS-Exchange-CrossTenant-userprincipalname": "\n ASVQvH1Zt1EpNTgOhboFU2KZZqRTwtuUUXlrpvF4jGqVMRDEEhAyOTMBHFBh+3cagZVVkOHDHof1K7WbkFjPKmKQCp1mD29egGfSqjaC0Kk=", "X-MS-Exchange-Transport-CrossTenantHeadersStamped": "SEYPR06MB6202", "Received-SPF": "pass client-ip=2a01:111:f403:c405::5;\n envelope-from=jamin_lin@aspeedtech.com;\n helo=TYPPR03CU001.outbound.protection.outlook.com", "X-Spam_score_int": "-20", "X-Spam_score": "-2.1", "X-Spam_bar": "--", "X-Spam_report": "(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n SPF_HELO_PASS=-0.001,\n SPF_PASS=-0.001 autolearn=ham autolearn_force=no", "X-Spam_action": "no action", "X-BeenThere": "qemu-devel@nongnu.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "qemu development <qemu-devel.nongnu.org>", "List-Unsubscribe": "<https://lists.nongnu.org/mailman/options/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>", "List-Archive": "<https://lists.nongnu.org/archive/html/qemu-devel>", "List-Post": "<mailto:qemu-devel@nongnu.org>", "List-Help": "<mailto:qemu-devel-request@nongnu.org?subject=help>", "List-Subscribe": "<https://lists.nongnu.org/mailman/listinfo/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=subscribe>", "Errors-To": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org", "Sender": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org" }, "content": "Replace direct fprintf(stderr, ...) calls with qemu_log_mask()\nusing LOG_GUEST_ERROR in the EHCI controller implementation.\n\nDirect writes to stderr are discouraged in QEMU as they bypass\nthe logging framework and cannot be filtered or controlled at\nruntime. Using qemu_log_mask() ensures that guest-visible errors\nare properly categorized and can be managed via QEMU logging\noptions.\n\nAll affected messages correspond to guest-triggerable error\nconditions, so LOG_GUEST_ERROR is used consistently.\n\nThis change improves integration with QEMU's logging infrastructure\nand aligns with upstream coding guidelines.\n\nSigned-off-by: Jamin Lin <jamin_lin@aspeedtech.com>\n---\n hw/usb/hcd-ehci.c | 43 +++++++++++++++++++++++++------------------\n 1 file changed, 25 insertions(+), 18 deletions(-)", "diff": "diff --git a/hw/usb/hcd-ehci.c b/hw/usb/hcd-ehci.c\nindex 9b92384bac..bebd137f94 100644\n--- a/hw/usb/hcd-ehci.c\n+++ b/hw/usb/hcd-ehci.c\n@@ -36,6 +36,7 @@\n #include \"qemu/error-report.h\"\n #include \"qemu/main-loop.h\"\n #include \"system/runstate.h\"\n+#include \"qemu/log.h\"\n \n #define FRAME_TIMER_FREQ 1000\n #define FRAME_TIMER_NS (NANOSECONDS_PER_SECOND / FRAME_TIMER_FREQ)\n@@ -425,7 +426,7 @@ static int ehci_get_pid(EHCIqtd *qtd)\n case 2:\n return USB_TOKEN_SETUP;\n default:\n- fprintf(stderr, \"bad token\\n\");\n+ qemu_log_mask(LOG_GUEST_ERROR, \"bad token\\n\");\n return 0;\n }\n }\n@@ -532,7 +533,7 @@ static void ehci_free_packet(EHCIPacket *p)\n }\n if (p->async == EHCI_ASYNC_FINISHED &&\n p->packet.status == USB_RET_SUCCESS) {\n- fprintf(stderr,\n+ qemu_log_mask(LOG_GUEST_ERROR,\n \"EHCI: Dropping completed packet from halted %s ep %02X\\n\",\n (p->pid == USB_TOKEN_IN) ? \"in\" : \"out\",\n get_field(p->queue->qh.epchar, QH_EPCHAR_EP));\n@@ -1042,8 +1043,9 @@ static void ehci_opreg_write(void *ptr, hwaddr addr,\n \n /* not supporting dynamic frame list size at the moment */\n if ((val & USBCMD_FLS) && !(s->usbcmd & USBCMD_FLS)) {\n- fprintf(stderr, \"attempt to set frame list size -- value %d\\n\",\n- (int)val & USBCMD_FLS);\n+ qemu_log_mask(LOG_GUEST_ERROR,\n+ \"attempt to set frame list size -- value %d\\n\",\n+ (int)val & USBCMD_FLS);\n val &= ~USBCMD_FLS;\n }\n \n@@ -1101,7 +1103,7 @@ static void ehci_opreg_write(void *ptr, hwaddr addr,\n \n case PERIODICLISTBASE:\n if (ehci_periodic_enabled(s)) {\n- fprintf(stderr,\n+ qemu_log_mask(LOG_GUEST_ERROR,\n \"ehci: PERIODIC list base register set while periodic schedule\\n\"\n \" is enabled and HC is enabled\\n\");\n }\n@@ -1109,7 +1111,7 @@ static void ehci_opreg_write(void *ptr, hwaddr addr,\n \n case ASYNCLISTADDR:\n if (ehci_async_enabled(s)) {\n- fprintf(stderr,\n+ qemu_log_mask(LOG_GUEST_ERROR,\n \"ehci: ASYNC list address register set while async schedule\\n\"\n \" is enabled and HC is enabled\\n\");\n }\n@@ -1200,7 +1202,7 @@ static int ehci_init_transfer(EHCIPacket *p)\n \n while (bytes > 0) {\n if (cpage > 4) {\n- fprintf(stderr, \"cpage out of range (%u)\\n\", cpage);\n+ qemu_log_mask(LOG_GUEST_ERROR, \"cpage out of range (%u)\\n\", cpage);\n qemu_sglist_destroy(&p->sgl);\n return -1;\n }\n@@ -1306,7 +1308,8 @@ static void ehci_execute_complete(EHCIQueue *q)\n break;\n default:\n /* should not be triggerable */\n- fprintf(stderr, \"USB invalid response %d\\n\", p->packet.status);\n+ qemu_log_mask(LOG_GUEST_ERROR, \"USB invalid response %d\\n\",\n+ p->packet.status);\n g_assert_not_reached();\n }\n \n@@ -1354,7 +1357,7 @@ static int ehci_execute(EHCIPacket *p, const char *action)\n p->async == EHCI_ASYNC_INITIALIZED);\n \n if (!(p->qtd.token & QTD_TOKEN_ACTIVE)) {\n- fprintf(stderr, \"Attempting to execute inactive qtd\\n\");\n+ qemu_log_mask(LOG_GUEST_ERROR, \"Attempting to execute inactive qtd\\n\");\n return -1;\n }\n \n@@ -1395,7 +1398,8 @@ static int ehci_execute(EHCIPacket *p, const char *action)\n p->packet.actual_length);\n \n if (p->packet.actual_length > BUFF_SIZE) {\n- fprintf(stderr, \"ret from usb_handle_packet > BUFF_SIZE\\n\");\n+ qemu_log_mask(LOG_GUEST_ERROR,\n+ \"ret from usb_handle_packet > BUFF_SIZE\\n\");\n return -1;\n }\n \n@@ -1479,8 +1483,9 @@ static int ehci_process_itd(EHCIState *ehci,\n case USB_RET_SUCCESS:\n break;\n default:\n- fprintf(stderr, \"Unexpected iso usb result: %d\\n\",\n- ehci->ipacket.status);\n+ qemu_log_mask(LOG_GUEST_ERROR,\n+ \"Unexpected iso usb result: %d\\n\",\n+ ehci->ipacket.status);\n /* Fall through */\n case USB_RET_IOERROR:\n case USB_RET_NODEV:\n@@ -1584,7 +1589,8 @@ static int ehci_state_fetchentry(EHCIState *ehci, int async)\n \n /* section 4.8, only QH in async schedule */\n if (async && (NLPTR_TYPE_GET(entry) != NLPTR_TYPE_QH)) {\n- fprintf(stderr, \"non queue head request in async schedule\\n\");\n+ qemu_log_mask(LOG_GUEST_ERROR,\n+ \"non queue head request in async schedule\\n\");\n return -1;\n }\n \n@@ -1606,7 +1612,7 @@ static int ehci_state_fetchentry(EHCIState *ehci, int async)\n \n default:\n /* TODO: handle FSTN type */\n- fprintf(stderr, \"FETCHENTRY: entry at %X is of type %u \"\n+ qemu_log_mask(LOG_GUEST_ERROR, \"FETCHENTRY: entry at %X is of type %u \"\n \"which is not supported yet\\n\", entry, NLPTR_TYPE_GET(entry));\n return -1;\n }\n@@ -2112,13 +2118,14 @@ static void ehci_advance_state(EHCIState *ehci, int async)\n break;\n \n default:\n- fprintf(stderr, \"Bad state!\\n\");\n+ qemu_log_mask(LOG_GUEST_ERROR, \"Bad state!\\n\");\n g_assert_not_reached();\n }\n \n if (again < 0 || itd_count > 16) {\n /* TODO: notify guest (raise HSE irq?) */\n- fprintf(stderr, \"processing error - resetting ehci HC\\n\");\n+ qemu_log_mask(LOG_GUEST_ERROR,\n+ \"processing error - resetting ehci HC\\n\");\n ehci_reset(ehci);\n again = 0;\n }\n@@ -2175,7 +2182,7 @@ static void ehci_advance_async_state(EHCIState *ehci)\n \n default:\n /* this should only be due to a developer mistake */\n- fprintf(stderr, \"ehci: Bad asynchronous state %d. \"\n+ qemu_log_mask(LOG_GUEST_ERROR, \"ehci: Bad asynchronous state %d. \"\n \"Resetting to active\\n\", ehci->astate);\n g_assert_not_reached();\n }\n@@ -2225,7 +2232,7 @@ static void ehci_advance_periodic_state(EHCIState *ehci)\n \n default:\n /* this should only be due to a developer mistake */\n- fprintf(stderr, \"ehci: Bad periodic state %d. \"\n+ qemu_log_mask(LOG_GUEST_ERROR, \"ehci: Bad periodic state %d. \"\n \"Resetting to active\\n\", ehci->pstate);\n g_assert_not_reached();\n }\n", "prefixes": [ "v3", "04/17" ] }