Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/1.1/patches/2223563/?format=api
{ "id": 2223563, "url": "http://patchwork.ozlabs.org/api/1.1/patches/2223563/?format=api", "web_url": "http://patchwork.ozlabs.org/project/netfilter-devel/patch/20260415155720.313166-1-tt.rantala@gmail.com/", "project": { "id": 26, "url": "http://patchwork.ozlabs.org/api/1.1/projects/26/?format=api", "name": "Netfilter Development", "link_name": "netfilter-devel", "list_id": "netfilter-devel.vger.kernel.org", "list_email": "netfilter-devel@vger.kernel.org", "web_url": null, "scm_url": null, "webscm_url": null }, "msgid": "<20260415155720.313166-1-tt.rantala@gmail.com>", "date": "2026-04-15T15:57:20", "name": "[iptables] extensions: libipt_REJECT: Drop ancient kernel compat hack", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "0eb754283bc7cea717c5dd0ca6a5fca0177fec43", "submitter": { "id": 18990, "url": "http://patchwork.ozlabs.org/api/1.1/people/18990/?format=api", "name": "Tommi Rantala", "email": "tt.rantala@gmail.com" }, "delegate": { "id": 11902, "url": "http://patchwork.ozlabs.org/api/1.1/users/11902/?format=api", "username": "strlen", "first_name": "Florian", "last_name": "Westphal", "email": "fw@strlen.de" }, "mbox": "http://patchwork.ozlabs.org/project/netfilter-devel/patch/20260415155720.313166-1-tt.rantala@gmail.com/mbox/", "series": [ { "id": 500010, "url": "http://patchwork.ozlabs.org/api/1.1/series/500010/?format=api", "web_url": "http://patchwork.ozlabs.org/project/netfilter-devel/list/?series=500010", "date": "2026-04-15T15:57:20", "name": "[iptables] extensions: libipt_REJECT: Drop ancient kernel compat hack", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/500010/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/2223563/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/2223563/checks/", "tags": {}, "headers": { "Return-Path": "\n <netfilter-devel+bounces-11928-incoming=patchwork.ozlabs.org@vger.kernel.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "netfilter-devel@vger.kernel.org" ], "Delivered-To": "patchwork-incoming@legolas.ozlabs.org", "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256\n header.s=20251104 header.b=ekKll8Y/;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org\n (client-ip=172.234.253.10; helo=sea.lore.kernel.org;\n envelope-from=netfilter-devel+bounces-11928-incoming=patchwork.ozlabs.org@vger.kernel.org;\n receiver=patchwork.ozlabs.org)", "smtp.subspace.kernel.org;\n\tdkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com\n header.b=\"ekKll8Y/\"", "smtp.subspace.kernel.org;\n arc=none smtp.client-ip=209.85.167.48", "smtp.subspace.kernel.org;\n dmarc=pass (p=none dis=none) header.from=gmail.com", "smtp.subspace.kernel.org;\n spf=pass smtp.mailfrom=gmail.com" ], "Received": [ "from sea.lore.kernel.org (sea.lore.kernel.org [172.234.253.10])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fwm5M46Chz1yCv\n\tfor <incoming@patchwork.ozlabs.org>; Thu, 16 Apr 2026 01:58:15 +1000 (AEST)", "from smtp.subspace.kernel.org (conduit.subspace.kernel.org\n [100.90.174.1])\n\tby sea.lore.kernel.org (Postfix) with ESMTP id 04CC6302E406\n\tfor <incoming@patchwork.ozlabs.org>; Wed, 15 Apr 2026 15:57:36 +0000 (UTC)", "from localhost.localdomain (localhost.localdomain [127.0.0.1])\n\tby smtp.subspace.kernel.org (Postfix) with ESMTP id 375473DEAC8;\n\tWed, 15 Apr 2026 15:57:35 +0000 (UTC)", "from mail-lf1-f48.google.com (mail-lf1-f48.google.com\n [209.85.167.48])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits))\n\t(No client certificate requested)\n\tby smtp.subspace.kernel.org (Postfix) with ESMTPS id 55ABC3D9DBC\n\tfor <netfilter-devel@vger.kernel.org>; Wed, 15 Apr 2026 15:57:33 +0000 (UTC)", "by mail-lf1-f48.google.com with SMTP id\n 2adb3069b0e04-5a2c9c5ff87so7126760e87.0\n for <netfilter-devel@vger.kernel.org>;\n Wed, 15 Apr 2026 08:57:33 -0700 (PDT)", "from CNLFI0022 (91-156-17-56.elisa-laajakaista.fi. [91.156.17.56])\n by smtp.gmail.com with ESMTPSA id\n 2adb3069b0e04-5a40a2728d4sm558091e87.15.2026.04.15.08.57.29\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Wed, 15 Apr 2026 08:57:29 -0700 (PDT)" ], "ARC-Seal": "i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;\n\tt=1776268654; cv=none;\n b=AMd+uAdZ7iLqMLM3ZJWTqGox4iVGbBLuyq0UuiOUN+OMWLPsnx4xZQ9cpLs9RWpzKp3iIJ8VAmQ4L09rrnWhkUJh/Yt0Gt+MBn53w0ydEOiPEmvWGtkPQswLyVyG1X7++x2YFs5yIO7ZtgQaD7j9gAzLyh0FZ/K26uyCsIioHrY=", "ARC-Message-Signature": "i=1; a=rsa-sha256; d=subspace.kernel.org;\n\ts=arc-20240116; t=1776268654; c=relaxed/simple;\n\tbh=Y+5t2LUujsBeGQ2602CmouD/PmlA7btFSTn98swxgqE=;\n\th=From:To:Cc:Subject:Date:Message-ID:MIME-Version;\n b=IJ3PcL7vBt539KU48fjCYLjO3dFvxdPx31eZktIvgPf63wsq1y3QELYnJh31Y0LKdWnsAA0nG9ii0RSXDCn/Lb28rS6gl6l0MuArC/l15nP+CBhJCqlAmlClfdkF6ruo5ONLFo0Q7vjfcS81XP4zLv19TmtCsPZCxeK2ES9g6uk=", "ARC-Authentication-Results": "i=1; smtp.subspace.kernel.org;\n dmarc=pass (p=none dis=none) header.from=gmail.com;\n spf=pass smtp.mailfrom=gmail.com;\n dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com\n header.b=ekKll8Y/; arc=none smtp.client-ip=209.85.167.48", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=gmail.com; s=20251104; t=1776268650; x=1776873450;\n darn=vger.kernel.org;\n h=content-transfer-encoding:mime-version:message-id:date:subject:cc\n :to:from:from:to:cc:subject:date:message-id:reply-to;\n bh=8Oz7Hg5VPkcfsV8MYTcL9qKZLX0S8mgkehyBtj32+kM=;\n b=ekKll8Y/WJKqTkcElt3euQFBxpBb29SivKFtC/djBi/WbUMOnanQpAbCo/q7VI3zYE\n +HjkL6SAlnX9rRejGQueJSl6R5Nm/zXJiQAT6+P68ImQYgm3OnlziikN0pjZo3+oFoNo\n +54C0qGLkREHVgsgl/hj1wd5cZnX9iJSkzA0H80PnKlnBEsoPaf6maUMcVHSi6sfbs/g\n yiwXNu5SIpN/bo6Dft7XTBBAXW4lU02GQWDLq2NpYxlc3m/NuS0DiLOCn42/GY7I0gbN\n 2wkm4qQMOM6nVUzHFdjr8xaH0jrn6z9rRBbnP4B4dCssDlgWJ+/elIIF/wjMnchESuMJ\n Ag6A==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1776268650; x=1776873450;\n h=content-transfer-encoding:mime-version:message-id:date:subject:cc\n :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date\n :message-id:reply-to;\n bh=8Oz7Hg5VPkcfsV8MYTcL9qKZLX0S8mgkehyBtj32+kM=;\n b=HfyQdgjnjqqUZgSIzIXfWw1wq3faE9/2xNftdcqTT+Lk1PQP6yoNPodj9ivsdougza\n l9XXB75paVrky5LCZKoUCmjGw5dr2p4+iFzQZTmjzQWsUWD+QHiEugd+qpSnB2uBt2XJ\n 0dO6s9cnMJ0SuAf3+6VJjQIyep2+V2FVoGugAsc1xFZEs380+l5RQ7XNvh/Zc4sr8hqr\n dxU41Sce8hKG4T2n4UDOFL+6RrtojFiS/6iuM+KwZEeN7ncqjOi+XbxYbjKhudMpkIkw\n o3gKKhC8P6u3VeJ+cpgArIR6GSP8NRpq5QtCgas1Z4szgXBsYG1cVlnWIiuAnrtS+2qW\n FiyQ==", "X-Gm-Message-State": "AOJu0YwT6IGpzkl96BZaFKLMbUbXYuxrL7lrbERP/gCTxzKvSJKr33/o\n\tgE3bGCrLRq8LPd5VZklzqwplIjwOtjK/MrbrYxq4cLCWXSwrQ+p0iMDhZUwCdQgrzPA5NQ==", "X-Gm-Gg": "AeBDievl0xyF9WV1XpFhVliOmzLL/sHNFUpdgYfG9RFlOLLgTwy1Eo4kXuniUQkc4j8\n\t2b6LhnUQ2kU6+xfhgy7tSzQ7a7qthp4CuHTgU6fTb8SJe9tIRO/Wa0GeHZzkOSYsfXVWr4OWmEZ\n\t2TiWBIgNklQT6Gkcjb0xUClOMXKCYTYNUXT/UeOrLmc54zf+GFdz1mcwp55yweRbn0s6Z45WtLM\n\tXE04hmnsfNlUIzZ7IA/GFOrF6Ggi7lm8ST5wxQXZAty7cxg0OEc/+Z4otf4eIyeLae/7v3nlqff\n\tPRj2SmlqlqOy+hAgvitAtBPOJN58Y6DQfqzz3OCM26WEZwt0Cwet79RLcpNdw1k23EOQKfMjlLr\n\tGFt5et9YUG095mQIkztDcP0AGZec09gT65NkNtwCZHk/gRxRhlSGLPEXTnUAxgV2m0jTU2Ga5jl\n\teTHFzcszO9cOQ4JHG/qUPogqJVx2wTM89ssZygLurSsBtz+nFN52Vw1ve8ieO0JOhdCQ==", "X-Received": "by 2002:a05:6512:3e28:b0:5a2:ad98:3685 with SMTP id\n 2adb3069b0e04-5a3efd90bbfmr6708769e87.35.1776268650160;\n Wed, 15 Apr 2026 08:57:30 -0700 (PDT)", "From": "Tommi Rantala <tt.rantala@gmail.com>", "To": "netfilter-devel@vger.kernel.org", "Cc": "Tommi Rantala <tommi.rantala@cujo.com>", "Subject": "[PATCH iptables] extensions: libipt_REJECT: Drop ancient kernel\n compat hack", "Date": "Wed, 15 Apr 2026 18:57:20 +0300", "Message-ID": "<20260415155720.313166-1-tt.rantala@gmail.com>", "X-Mailer": "git-send-email 2.53.0", "Precedence": "bulk", "X-Mailing-List": "netfilter-devel@vger.kernel.org", "List-Id": "<netfilter-devel.vger.kernel.org>", "List-Subscribe": "<mailto:netfilter-devel+subscribe@vger.kernel.org>", "List-Unsubscribe": "<mailto:netfilter-devel+unsubscribe@vger.kernel.org>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit" }, "content": "From: Tommi Rantala <tommi.rantala@cujo.com>\n\nThe IPT_ICMP_ADMIN_PROHIBITED fallback define and associated\ncompatibility notes were relevant for 2.4 kernels. The INCOMPATIBILITIES\nfile referencing these was already dropped in commit 92ce78d04677\n(\"Drop INCOMPATIBILITIES file\"), so clean up the remaining leftovers in\nthe REJECT extension source and man page.\n\nSigned-off-by: Tommi Rantala <tommi.rantala@cujo.com>\n---\n extensions/libipt_REJECT.c | 14 +-------------\n extensions/libipt_REJECT.man | 4 +---\n 2 files changed, 2 insertions(+), 16 deletions(-)", "diff": "diff --git a/extensions/libipt_REJECT.c b/extensions/libipt_REJECT.c\nindex 743dfffc..8bfe0fd7 100644\n--- a/extensions/libipt_REJECT.c\n+++ b/extensions/libipt_REJECT.c\n@@ -6,16 +6,6 @@\n #include <string.h>\n #include <xtables.h>\n #include <linux/netfilter_ipv4/ipt_REJECT.h>\n-#include <linux/version.h>\n-\n-/* If we are compiling against a kernel that does not support\n- * IPT_ICMP_ADMIN_PROHIBITED, we are emulating it.\n- * The result will be a plain DROP of the packet instead of\n- * reject. -- Maciej Soltysiak <solt@dns.toxicfilms.tv>\n- */\n-#ifndef IPT_ICMP_ADMIN_PROHIBITED\n-#define IPT_ICMP_ADMIN_PROHIBITED\tIPT_TCP_RESET + 1\n-#endif\n \n struct reject_names {\n \tconst char *name;\n@@ -73,7 +63,7 @@ static const struct reject_names reject_table[] = {\n \t},\n \t[IPT_ICMP_ADMIN_PROHIBITED] = {\n \t\t\"icmp-admin-prohibited\", \"admin-prohib\",\n-\t\t\"ICMP administratively prohibited (*)\",\n+\t\t\"ICMP administratively prohibited\",\n \t\t\"admin-prohibited\",\n \t},\n };\n@@ -102,8 +92,6 @@ static void REJECT_help(void)\n \" a reply packet according to type:\\n\");\n \n \tprint_reject_types();\n-\n-\tprintf(\"(*) See man page or read the INCOMPATIBILITES file for compatibility issues.\\n\");\n }\n \n static const struct xt_option_entry REJECT_opts[] = {\ndiff --git a/extensions/libipt_REJECT.man b/extensions/libipt_REJECT.man\nindex a7196cdc..ea4d92e6 100644\n--- a/extensions/libipt_REJECT.man\n+++ b/extensions/libipt_REJECT.man\n@@ -19,7 +19,7 @@ The type given can be\n \\fBicmp\\-proto\\-unreachable\\fP,\n \\fBicmp\\-net\\-prohibited\\fP,\n \\fBicmp\\-host\\-prohibited\\fP, or\n-\\fBicmp\\-admin\\-prohibited\\fP (*),\n+\\fBicmp\\-admin\\-prohibited\\fP,\n which return the appropriate ICMP error message (\\fBicmp\\-port\\-unreachable\\fP is\n the default). The option\n \\fBtcp\\-reset\\fP\n@@ -28,8 +28,6 @@ TCP RST packet to be sent back. This is mainly useful for blocking\n .I ident\n (113/tcp) probes which frequently occur when sending mail to broken mail\n hosts (which won't accept your mail otherwise).\n-.IP\n-(*) Using icmp\\-admin\\-prohibited with kernels that do not support it will result in a plain DROP instead of REJECT\n .PP\n \\fIWarning:\\fP You should not indiscriminately apply the REJECT target to\n packets whose connection state is classified as INVALID; instead, you should\n", "prefixes": [ "iptables" ] }