Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/1.1/patches/2223115/?format=api
{ "id": 2223115, "url": "http://patchwork.ozlabs.org/api/1.1/patches/2223115/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20260414213523.1125859-1-junjie.cao@intel.com/", "project": { "id": 14, "url": "http://patchwork.ozlabs.org/api/1.1/projects/14/?format=api", "name": "QEMU Development", "link_name": "qemu-devel", "list_id": "qemu-devel.nongnu.org", "list_email": "qemu-devel@nongnu.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20260414213523.1125859-1-junjie.cao@intel.com>", "date": "2026-04-14T21:35:22", "name": "[v2,1/2] ati-vga: fix unsigned integer overflow in cursor bounds checks", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "cddd3feba53abe88b4ad029eb6946793d549d038", "submitter": { "id": 91537, "url": "http://patchwork.ozlabs.org/api/1.1/people/91537/?format=api", "name": "Junjie Cao", "email": "junjie.cao@intel.com" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20260414213523.1125859-1-junjie.cao@intel.com/mbox/", "series": [ { "id": 499846, "url": "http://patchwork.ozlabs.org/api/1.1/series/499846/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/list/?series=499846", "date": "2026-04-14T21:35:22", "name": "[v2,1/2] ati-vga: fix unsigned integer overflow in cursor bounds checks", "version": 2, "mbox": "http://patchwork.ozlabs.org/series/499846/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/2223115/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/2223115/checks/", "tags": {}, "headers": { "Return-Path": "<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@legolas.ozlabs.org", "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=intel.com header.i=@intel.com header.a=rsa-sha256\n header.s=Intel header.b=OZD95Wm6;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists1p.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)" ], "Received": [ "from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fw4wD2qLfz1yDF\n\tfor <incoming@patchwork.ozlabs.org>; Tue, 14 Apr 2026 23:33:00 +1000 (AEST)", "from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists1p.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from <qemu-devel-bounces@nongnu.org>)\n\tid 1wCdsk-0006KQ-Nl; Tue, 14 Apr 2026 09:32:46 -0400", "from eggs.gnu.org ([2001:470:142:3::10])\n by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <junjie.cao@intel.com>)\n id 1wCdse-0006K4-IG; Tue, 14 Apr 2026 09:32:40 -0400", "from mgamail.intel.com ([192.198.163.14])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <junjie.cao@intel.com>)\n id 1wCdsa-0004cu-Tt; Tue, 14 Apr 2026 09:32:38 -0400", "from fmviesa008.fm.intel.com ([10.60.135.148])\n by fmvoesa108.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 14 Apr 2026 06:32:34 -0700", "from junjie-optiplex-micro-plus-7010.bj.intel.com ([10.238.152.98])\n by fmviesa008-auth.fm.intel.com with\n ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 14 Apr 2026 06:32:32 -0700" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple;\n d=intel.com; i=@intel.com; q=dns/txt; s=Intel;\n t=1776173557; x=1807709557;\n h=from:to:cc:subject:date:message-id:mime-version:\n content-transfer-encoding;\n bh=aVLd6fAzNsrg8HssHvbjJoomKlJxcy2FIXt/dMBZIMo=;\n b=OZD95Wm6F9sO5RK8JmdvmPGCGY/ajpq3F2ZGZzq9vulTxWSsE1YJ3wji\n 3rKMa6D6iMnM4ft8m2XrcL8je5EFzpeHa7u2eW9O2trRuD7xRo+KCCNkX\n HxFo3r/gJSAbTkaiYdC5idEE3IIIJn+rwaIZRq7hioNBetj2xPGcxJlek\n tdoz7N6bwgL06KubhHryRAJTiEplM7j8BuDdkJWfbkB93OH9bSjdOb1/K\n JneW+1gkP63OfBSVcpdRpU63ivH0wUTUbUGrEsLq87bdNBpcqavtv7zcA\n RfkvTDcKLbM5Dibi++u6AKAX4VFsuz1JCoVWTmJOq24YzrC8LvvFm9Q94 g==;", "X-CSE-ConnectionGUID": [ "9rOChN1+QaWfsgKmftp6zA==", "Ko4ALbkaSQiHtRTIZ07LZg==" ], "X-CSE-MsgGUID": [ "zAd5NtvpRDalFICQsL+3Jw==", "tLsSbyNbT3m6529gryJCOQ==" ], "X-IronPort-AV": [ "E=McAfee;i=\"6800,10657,11759\"; a=\"77201411\"", "E=Sophos;i=\"6.23,179,1770624000\"; d=\"scan'208\";a=\"77201411\"", "E=Sophos;i=\"6.23,179,1770624000\"; d=\"scan'208\";a=\"227447816\"" ], "X-ExtLoop1": "1", "From": "Junjie Cao <junjie.cao@intel.com>", "To": "qemu-devel@nongnu.org", "Cc": "BALATON Zoltan <balaton@eik.bme.hu>, =?utf-8?q?Philippe_Mathieu-Daud?=\n\t=?utf-8?q?=C3=A9?= <philmd@linaro.org>, Chad Jablonski <chad@jablonski.xyz>,\n qemu-stable@nongnu.org, junjie.cao@intel.com", "Subject": "[PATCH v2 1/2] ati-vga: fix unsigned integer overflow in cursor\n bounds checks", "Date": "Wed, 15 Apr 2026 05:35:22 +0800", "Message-ID": "<20260414213523.1125859-1-junjie.cao@intel.com>", "X-Mailer": "git-send-email 2.43.0", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Received-SPF": "pass client-ip=192.198.163.14;\n envelope-from=junjie.cao@intel.com;\n helo=mgamail.intel.com", "X-Spam_score_int": "-29", "X-Spam_score": "-3.0", "X-Spam_bar": "---", "X-Spam_report": "(-3.0 / 5.0 requ) BAYES_00=-1.9, DATE_IN_FUTURE_06_12=1.947,\n DKIMWL_WL_HIGH=-0.54, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1,\n DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3,\n RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001,\n SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no", "X-Spam_action": "no action", "X-BeenThere": "qemu-devel@nongnu.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "qemu development <qemu-devel.nongnu.org>", "List-Unsubscribe": "<https://lists.nongnu.org/mailman/options/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>", "List-Archive": "<https://lists.nongnu.org/archive/html/qemu-devel>", "List-Post": "<mailto:qemu-devel@nongnu.org>", "List-Help": "<mailto:qemu-devel-request@nongnu.org?subject=help>", "List-Subscribe": "<https://lists.nongnu.org/mailman/listinfo/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=subscribe>", "Errors-To": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org", "Sender": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org" }, "content": "The cursor bounds checks compare (srcoff + N) against vram_size, but\nboth sides are uint32_t so the addition can wrap past UINT32_MAX when\nsrcoff underflows from the cur_hv_offs subtraction, causing the check\nto be bypassed.\n\nRewrite the checks as (srcoff > vram_size - N) to avoid the\noverflow-prone addition, matching the style already used in\nati_mm_read() and ati_mm_write().\n\nFixes: 2f1fbe6ee9b5 (\"ati-vga: Make sure hardware cursor data is within vram\")\nCc: qemu-stable@nongnu.org\nSigned-off-by: Junjie Cao <junjie.cao@intel.com>\nReviewed-by: BALATON Zoltan <balaton@eik.bme.hu>\n---\nFound while running local QEMU fuzz testing.\n\nv2: Collected Reviewed-by, added patch 2/2 to mask out the lock bit\n as suggested by BALATON Zoltan.\n\n hw/display/ati.c | 4 ++--\n 1 file changed, 2 insertions(+), 2 deletions(-)", "diff": "diff --git a/hw/display/ati.c b/hw/display/ati.c\nindex 88a5bbbf07..0489995d00 100644\n--- a/hw/display/ati.c\n+++ b/hw/display/ati.c\n@@ -149,7 +149,7 @@ static void ati_cursor_define(ATIVGAState *s)\n /* FIXME handle cur_hv_offs correctly */\n srcoff = s->regs.cur_offset - (s->regs.cur_hv_offs >> 16) -\n (s->regs.cur_hv_offs & 0xffff) * 16;\n- if (srcoff + 64 * 16 > s->vga.vram_size) {\n+ if (srcoff > s->vga.vram_size - 64 * 16) {\n return;\n }\n for (int i = 0; i < 64; i++, srcoff += 16) {\n@@ -206,7 +206,7 @@ static void ati_cursor_draw_line(VGACommonState *vga, uint8_t *d, int scr_y)\n }\n /* FIXME handle cur_hv_offs correctly */\n srcoff = s->cursor_offset + (scr_y - vga->hw_cursor_y) * 16;\n- if (srcoff + 16 > s->vga.vram_size) {\n+ if (srcoff > s->vga.vram_size - 16) {\n return;\n }\n dp = &dp[vga->hw_cursor_x];\n", "prefixes": [ "v2", "1/2" ] }