Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/1.1/patches/2222938/?format=api
{ "id": 2222938, "url": "http://patchwork.ozlabs.org/api/1.1/patches/2222938/?format=api", "web_url": "http://patchwork.ozlabs.org/project/linux-pci/patch/20260414031631.2107-2-emil.s.tantilov@intel.com/", "project": { "id": 28, "url": "http://patchwork.ozlabs.org/api/1.1/projects/28/?format=api", "name": "Linux PCI development", "link_name": "linux-pci", "list_id": "linux-pci.vger.kernel.org", "list_email": "linux-pci@vger.kernel.org", "web_url": null, "scm_url": null, "webscm_url": null }, "msgid": "<20260414031631.2107-2-emil.s.tantilov@intel.com>", "date": "2026-04-14T03:16:30", "name": "[iwl-next,v2,1/2] idpf: remove conditonal MBX deinit from idpf_vc_core_deinit()", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "ddcba813320dbe08ec54006f64074a35edac7547", "submitter": { "id": 1670, "url": "http://patchwork.ozlabs.org/api/1.1/people/1670/?format=api", "name": "Tantilov, Emil S", "email": "emil.s.tantilov@intel.com" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/linux-pci/patch/20260414031631.2107-2-emil.s.tantilov@intel.com/mbox/", "series": [ { "id": 499772, "url": "http://patchwork.ozlabs.org/api/1.1/series/499772/?format=api", "web_url": "http://patchwork.ozlabs.org/project/linux-pci/list/?series=499772", "date": "2026-04-14T03:16:31", "name": "Introduce IDPF PCI callbacks", "version": 2, "mbox": "http://patchwork.ozlabs.org/series/499772/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/2222938/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/2222938/checks/", "tags": {}, "headers": { "Return-Path": "\n <linux-pci+bounces-52469-incoming=patchwork.ozlabs.org@vger.kernel.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "linux-pci@vger.kernel.org" ], "Delivered-To": "patchwork-incoming@legolas.ozlabs.org", "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=intel.com header.i=@intel.com header.a=rsa-sha256\n header.s=Intel header.b=SDON4N/y;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org\n (client-ip=2600:3c0a:e001:db::12fc:5321; helo=sea.lore.kernel.org;\n envelope-from=linux-pci+bounces-52469-incoming=patchwork.ozlabs.org@vger.kernel.org;\n receiver=patchwork.ozlabs.org)", "smtp.subspace.kernel.org;\n\tdkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com\n header.b=\"SDON4N/y\"", "smtp.subspace.kernel.org;\n arc=none smtp.client-ip=192.198.163.11", "smtp.subspace.kernel.org;\n dmarc=pass (p=none dis=none) header.from=intel.com", "smtp.subspace.kernel.org;\n spf=pass smtp.mailfrom=intel.com" ], "Received": [ "from sea.lore.kernel.org (sea.lore.kernel.org\n [IPv6:2600:3c0a:e001:db::12fc:5321])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fvqH85FG4z1yDF\n\tfor <incoming@patchwork.ozlabs.org>; Tue, 14 Apr 2026 13:18:28 +1000 (AEST)", "from smtp.subspace.kernel.org (conduit.subspace.kernel.org\n [100.90.174.1])\n\tby sea.lore.kernel.org (Postfix) with ESMTP id 1C08D3066A3D\n\tfor <incoming@patchwork.ozlabs.org>; Tue, 14 Apr 2026 03:16:28 +0000 (UTC)", "from localhost.localdomain (localhost.localdomain [127.0.0.1])\n\tby smtp.subspace.kernel.org (Postfix) with ESMTP id 25342325491;\n\tTue, 14 Apr 2026 03:16:27 +0000 (UTC)", "from mgamail.intel.com (mgamail.intel.com [192.198.163.11])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby smtp.subspace.kernel.org (Postfix) with ESMTPS id 88562318B9B;\n\tTue, 14 Apr 2026 03:16:25 +0000 (UTC)", "from fmviesa007.fm.intel.com ([10.60.135.147])\n by fmvoesa105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 13 Apr 2026 20:16:25 -0700", "from estantil-desk.jf.intel.com ([10.166.241.24])\n by fmviesa007.fm.intel.com with ESMTP; 13 Apr 2026 20:16:23 -0700" ], "ARC-Seal": "i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;\n\tt=1776136587; cv=none;\n b=NNE2NnGioua8bdw3zsysH9HcXvHpF1nN2l7eUB5Q8ywSzi0J4iXdgaVBdT3GVCkSxeI8Rks96heMbw8JLnoqWAZVAEeFPjJzfbq4IciTCsoPQTAf9SsyPd+DjK03qOObm/ai3PLFEyoPSiAhva1UjGA28peSgBOF8KgfI0nbZpo=", "ARC-Message-Signature": "i=1; a=rsa-sha256; d=subspace.kernel.org;\n\ts=arc-20240116; t=1776136587; c=relaxed/simple;\n\tbh=fJ+x0FuS4kfTxKVTAiQAsAjahv+Ub5YWK+sKz1QUweY=;\n\th=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References;\n b=PUdoseRzkT+LsfLK6g7PH+xF3weYIDkY3JJuKJy8zVmI8K8P7r+pySO2wfIS2g8dbYu/5Qy4mjf5w8pl9t0ECUxAXI3vjPF9bcJ+pMNTkiq34l+bao9/mJc+6PW8ahxh9VzTse7SNfWSDc/dJBxKEhXmSgLOa/Py3M7W0/7e36E=", "ARC-Authentication-Results": "i=1; smtp.subspace.kernel.org;\n dmarc=pass (p=none dis=none) header.from=intel.com;\n spf=pass smtp.mailfrom=intel.com;\n dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com\n header.b=SDON4N/y; arc=none smtp.client-ip=192.198.163.11", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple;\n d=intel.com; i=@intel.com; q=dns/txt; s=Intel;\n t=1776136585; x=1807672585;\n h=from:to:cc:subject:date:message-id:in-reply-to:\n references;\n bh=fJ+x0FuS4kfTxKVTAiQAsAjahv+Ub5YWK+sKz1QUweY=;\n b=SDON4N/ykp5WS+ZGtBpCE8A2OBcQCRWAokV+idw7Ohcct0mfznxHsNNl\n HBUVY8r0hgoTG6MuXdCwZalkaekaGp8f9DBduZf5RFGo3kLbYb6Xw6SVF\n YEUtbGIlz7KwgX4jEwBWh/cWVwVOieT12DKDgSGEheK7ddh/uGTvLyJDG\n SHJKRWc+EVF9NG4uxYXh2paqMX8PT8UJ7wPsDGusixz0XgEtBSdS6IQ9Z\n 9q53QKJTtRAnl/F4WYSuCbvP4gmAsO9+ve9cE1Yltm/5xOQ1GjzVFu5ei\n Yz80hJIXDm6+f2OaOyZKMipbyxAfrWNvntZh9DL0adMMqzxxj/JyDbvW2\n Q==;", "X-CSE-ConnectionGUID": [ "8Y/6YnQFTmaKbd8IQOLasg==", "r4bOFk0+TgeGkwx+5EPfTw==" ], "X-CSE-MsgGUID": [ "wAYjH+xSR5qDC9vXliObuA==", "n54daRj9ROmi8Fhrks/EqQ==" ], "X-IronPort-AV": [ "E=McAfee;i=\"6800,10657,11758\"; a=\"87706571\"", "E=Sophos;i=\"6.23,178,1770624000\";\n d=\"scan'208\";a=\"87706571\"", "E=Sophos;i=\"6.23,178,1770624000\";\n d=\"scan'208\";a=\"226795514\"" ], "X-ExtLoop1": "1", "From": "Emil Tantilov <emil.s.tantilov@intel.com>", "To": "intel-wired-lan@lists.osuosl.org", "Cc": "netdev@vger.kernel.org,\n\tprzemyslaw.kitszel@intel.com,\n\tjay.bhat@intel.com,\n\tivan.d.barrera@intel.com,\n\taleksandr.loktionov@intel.com,\n\tlarysa.zaremba@intel.com,\n\tanthony.l.nguyen@intel.com,\n\tandrew+netdev@lunn.ch,\n\tdavem@davemloft.net,\n\tedumazet@google.com,\n\tkuba@kernel.org,\n\tpabeni@redhat.com,\n\taleksander.lobakin@intel.com,\n\tlinux-pci@vger.kernel.org,\n\tmadhu.chittim@intel.com,\n\tdecot@google.com,\n\twillemb@google.com,\n\tsheenamo@google.com,\n\tlukas@wunner.de", "Subject": "[PATCH iwl-next v2 1/2] idpf: remove conditonal MBX deinit from\n idpf_vc_core_deinit()", "Date": "Mon, 13 Apr 2026 20:16:30 -0700", "Message-Id": "<20260414031631.2107-2-emil.s.tantilov@intel.com>", "X-Mailer": "git-send-email 2.17.2", "In-Reply-To": "<20260414031631.2107-1-emil.s.tantilov@intel.com>", "References": "<20260414031631.2107-1-emil.s.tantilov@intel.com>", "Precedence": "bulk", "X-Mailing-List": "linux-pci@vger.kernel.org", "List-Id": "<linux-pci.vger.kernel.org>", "List-Subscribe": "<mailto:linux-pci+subscribe@vger.kernel.org>", "List-Unsubscribe": "<mailto:linux-pci+unsubscribe@vger.kernel.org>" }, "content": "Previously it was assumed that idpf_vc_core_deinit() is always being\ncalled during reset handling, with remove being an exception. Ideally\nthe driver needs to communicate the changes to FW in all instances where\nthe MBX is not already disabled. Remove the remove_in_prog check from\nidpf_vc_core_deinit() as the MBX was already disabled while handling the\nreset via libie_ctlq_xn_shutdown() by the service task. This is also\nneeded by the following patch, introducing PCI callbacks support.\n\nSigned-off-by: Emil Tantilov <emil.s.tantilov@intel.com>\nReviewed-by: Jay Bhat <jay.bhat@intel.com>\nReviewed-by: Madhu Chittim <madhu.chittim@intel.com>\n---\n drivers/net/ethernet/intel/idpf/idpf_virtchnl.c | 11 +----------\n 1 file changed, 1 insertion(+), 10 deletions(-)", "diff": "diff --git a/drivers/net/ethernet/intel/idpf/idpf_virtchnl.c b/drivers/net/ethernet/intel/idpf/idpf_virtchnl.c\nindex 129c8f6b0faa..fceaf3ec1cd4 100644\n--- a/drivers/net/ethernet/intel/idpf/idpf_virtchnl.c\n+++ b/drivers/net/ethernet/intel/idpf/idpf_virtchnl.c\n@@ -3229,24 +3229,15 @@ int idpf_vc_core_init(struct idpf_adapter *adapter)\n */\n void idpf_vc_core_deinit(struct idpf_adapter *adapter)\n {\n-\tbool remove_in_prog;\n-\n \tif (!test_bit(IDPF_VC_CORE_INIT, adapter->flags))\n \t\treturn;\n \n-\t/* Avoid transaction timeouts when called during reset */\n-\tremove_in_prog = test_bit(IDPF_REMOVE_IN_PROG, adapter->flags);\n-\tif (!remove_in_prog)\n-\t\tidpf_deinit_dflt_mbx(adapter);\n-\n \tidpf_ptp_release(adapter);\n \tidpf_deinit_task(adapter);\n \tidpf_idc_deinit_core_aux_device(adapter);\n \tidpf_rel_rx_pt_lkup(adapter);\n \tidpf_intr_rel(adapter);\n-\n-\tif (remove_in_prog)\n-\t\tidpf_deinit_dflt_mbx(adapter);\n+\tidpf_deinit_dflt_mbx(adapter);\n \n \tcancel_delayed_work_sync(&adapter->serv_task);\n \n", "prefixes": [ "iwl-next", "v2", "1/2" ] }