Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/1.1/patches/2222899/?format=api
{ "id": 2222899, "url": "http://patchwork.ozlabs.org/api/1.1/patches/2222899/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20260414003001.97571-20-philmd@linaro.org/", "project": { "id": 14, "url": "http://patchwork.ozlabs.org/api/1.1/projects/14/?format=api", "name": "QEMU Development", "link_name": "qemu-devel", "list_id": "qemu-devel.nongnu.org", "list_email": "qemu-devel@nongnu.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20260414003001.97571-20-philmd@linaro.org>", "date": "2026-04-14T00:29:51", "name": "[v3,19/27] monitor: Reduce target-specific methods further", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "e33300e8eb93fcc29ef4537bc498bdcf764bb35f", "submitter": { "id": 85046, "url": "http://patchwork.ozlabs.org/api/1.1/people/85046/?format=api", "name": "Philippe Mathieu-Daudé", "email": "philmd@linaro.org" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20260414003001.97571-20-philmd@linaro.org/mbox/", "series": [ { "id": 499762, "url": "http://patchwork.ozlabs.org/api/1.1/series/499762/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/list/?series=499762", "date": "2026-04-14T00:29:32", "name": "monitor: Remove need of per-target handlers", "version": 3, "mbox": "http://patchwork.ozlabs.org/series/499762/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/2222899/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/2222899/checks/", "tags": {}, "headers": { "Return-Path": "<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@legolas.ozlabs.org", "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256\n header.s=google header.b=p3H1mLNU;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists1p.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)" ], "Received": [ "from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fvlbg2gtQz1yCv\n\tfor <incoming@patchwork.ozlabs.org>; Tue, 14 Apr 2026 10:32:31 +1000 (AEST)", "from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists1p.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from <qemu-devel-bounces@nongnu.org>)\n\tid 1wCRhc-0006rl-Ii; Mon, 13 Apr 2026 20:32:28 -0400", "from eggs.gnu.org ([2001:470:142:3::10])\n by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <philmd@linaro.org>) id 1wCRhb-0006c3-78\n for qemu-devel@nongnu.org; Mon, 13 Apr 2026 20:32:27 -0400", "from mail-wr1-x42a.google.com ([2a00:1450:4864:20::42a])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)\n (Exim 4.90_1) (envelope-from <philmd@linaro.org>) id 1wCRhY-0003OO-KW\n for qemu-devel@nongnu.org; Mon, 13 Apr 2026 20:32:26 -0400", "by mail-wr1-x42a.google.com with SMTP id\n ffacd0b85a97d-43d01d6b50cso5066479f8f.1\n for <qemu-devel@nongnu.org>; Mon, 13 Apr 2026 17:32:24 -0700 (PDT)", "from localhost.localdomain (88-187-86-199.subs.proxad.net.\n [88.187.86.199]) by smtp.gmail.com with ESMTPSA id\n ffacd0b85a97d-43d7b219576sm9619728f8f.19.2026.04.13.17.32.21\n (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256);\n Mon, 13 Apr 2026 17:32:21 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=linaro.org; s=google; t=1776126742; x=1776731542; darn=nongnu.org;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:from:to:cc:subject:date\n :message-id:reply-to;\n bh=Yf0UOppZ5JAgjvZrWj0IpmyixhCJmn1cGuxvSP3WFgU=;\n b=p3H1mLNUPhuT4vzOw7pyTQpqcXf8kzI3nujN4Fda5Wp7hAGlQqldrFivXpAsTI/0nI\n WVJ+GOEzLFBH097I/N2SWkjZWAszor+sgsfCY7x5g5ZpEI4TBVqBgsKO/g6bvejYhjqG\n X5lQAIRyDivBMgUdvX3Ga7ATqsVq+ApptmHEywAOCJPNPgXN2Gu6lcnw8Uik/CvMHA9e\n s3/5cbOVLOI2onVdiUEWcutuq2B83i7LkbRod8JSWfio6ZiP/98vNdJ4pvKQ0ei29L3L\n tslXVSEgin8+dQGu+9gUtfW3UXzAbPpbGHsz6fP17+WAf18vdc9MGsCE6F6nRhCBEvII\n OJYg==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1776126742; x=1776731542;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from\n :to:cc:subject:date:message-id:reply-to;\n bh=Yf0UOppZ5JAgjvZrWj0IpmyixhCJmn1cGuxvSP3WFgU=;\n b=Imk5xvjB3i8auBzEiMQPiWc1xhtf3/VC4BxZNs1DGbx4gnX7NE7pRaSmSSkEToLKS+\n ELffB89DH7IT/zpy6jW4FfhdeKYE0vfwJvFDR4S8IYGfDRScevFVk+TWrf5d8mIPxMIk\n 5Cea+f9ZBVN4dciDBFKVj8j9Z1Iudp14afLHgEzv+TpYYmQUl5HLhvrdyl9JrVAOLTaK\n jZBEtcvcSE33thafL8IDvWZ1YeKCpZUCNgD1DsZWv0pvaG1u5fGNC8zUZPR4cOiK1LLB\n 31YMOeXGM9B/daS87ZWE7CwTvyL1NXrRWe9e/uNG4RekKU+MyIerVJgK8HwgmMck2eY+\n P4hg==", "X-Gm-Message-State": "AOJu0YzQGkbr7EZMAW0XHwu+wAXIB1dXD9Qb7cZZBtxybzO2ZimrVIYD\n 41TZJQREy0RIQtnb7twycKwnoc0gzyi+qedTJcTB0cNG346aEhHCUHJmkLYVcxqy2G2nDEUmiIN\n Da1yz6R8=", "X-Gm-Gg": "AeBDiesMKBkSis0IH3acAPxXaX05pTOgsYZ/wiGI8+nxKuC8PqYNKOWY6NVabovb+Gm\n kFsaoEcvqpHTy6KvLqQhFpzGV4bAY/7KTLcuDYbOunilgaM2NuMd8NRKuiJZpLE5Ga2BxfNx8Ka\n bv+Z/Bn9TXA2s/9BUnPJU3bpE0LmFXORG9zl6zeymh81UKdKjmdG/GdOkcb8IqCubxzZhBbFnHz\n fok+V1BH5Jjvsy+4uOYNQoWkXhD3H+5OzN6tkyTRHqyZRWcfFzbvy/QOdXGn1MGZZ5QGk4EGeRI\n cwlu5qVcjvZEtPDu/bgk+jfmSYevNwUo+YT3BlkLlfgq6XI1kL/g/ZO5n7FbtYQw1mi4OKZsEyK\n AnSv3NIKU5obBsfXKgGhjOxnmN3qiXnptojPyxzqMIM75un2nFXgM/JHfDvlsLPvUvSWzC2+6WO\n zh1wZVefioNV1c3SzYcAeNW+MBy+C9iX5SEPyviSPxFvHYafFKHA5KS74Efi5nOfKF0So/9FqR", "X-Received": "by 2002:a5d:64e9:0:b0:43d:76d8:5794 with SMTP id\n ffacd0b85a97d-43d76d8593emr10892707f8f.36.1776126742333;\n Mon, 13 Apr 2026 17:32:22 -0700 (PDT)", "From": "=?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= <philmd@linaro.org>", "To": "qemu-devel@nongnu.org", "Cc": "Pierrick Bouvier <pierrick.bouvier@linaro.org>,\n Markus Armbruster <armbru@redhat.com>,\n Richard Henderson <richard.henderson@linaro.org>,\n \"Dr. David Alan Gilbert\" <dave@treblig.org>,\n Paolo Bonzini <pbonzini@redhat.com>,\n =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= <philmd@linaro.org>", "Subject": "[PATCH v3 19/27] monitor: Reduce target-specific methods further", "Date": "Tue, 14 Apr 2026 02:29:51 +0200", "Message-ID": "<20260414003001.97571-20-philmd@linaro.org>", "X-Mailer": "git-send-email 2.53.0", "In-Reply-To": "<20260414003001.97571-1-philmd@linaro.org>", "References": "<20260414003001.97571-1-philmd@linaro.org>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=UTF-8", "Content-Transfer-Encoding": "8bit", "Received-SPF": "pass client-ip=2a00:1450:4864:20::42a;\n envelope-from=philmd@linaro.org; helo=mail-wr1-x42a.google.com", "X-Spam_score_int": "-20", "X-Spam_score": "-2.1", "X-Spam_bar": "--", "X-Spam_report": "(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001,\n SPF_PASS=-0.001 autolearn=ham autolearn_force=no", "X-Spam_action": "no action", "X-BeenThere": "qemu-devel@nongnu.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "qemu development <qemu-devel.nongnu.org>", "List-Unsubscribe": "<https://lists.nongnu.org/mailman/options/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>", "List-Archive": "<https://lists.nongnu.org/archive/html/qemu-devel>", "List-Post": "<mailto:qemu-devel@nongnu.org>", "List-Help": "<mailto:qemu-devel-request@nongnu.org?subject=help>", "List-Subscribe": "<https://lists.nongnu.org/mailman/listinfo/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=subscribe>", "Errors-To": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org", "Sender": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org" }, "content": "get_monitor_def() doesn't use any target-specific declaration\nanymore, move it to hmp.c to compile it once.\n\nSigned-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>\nReviewed-by: Dr. David Alan Gilbert <dave@treblig.org>\nReviewed-by: Richard Henderson <richard.henderson@linaro.org>\n---\n monitor/monitor-internal.h | 1 -\n monitor/hmp-target.c | 33 ---------------------------------\n monitor/hmp.c | 36 ++++++++++++++++++++++++++++++++++++\n 3 files changed, 36 insertions(+), 34 deletions(-)", "diff": "diff --git a/monitor/monitor-internal.h b/monitor/monitor-internal.h\nindex eaf9a607783..a5c4aba306e 100644\n--- a/monitor/monitor-internal.h\n+++ b/monitor/monitor-internal.h\n@@ -191,7 +191,6 @@ void monitor_data_destroy_qmp(MonitorQMP *mon);\n void coroutine_fn monitor_qmp_dispatcher_co(void *data);\n void qmp_dispatcher_co_wake(void);\n \n-int get_monitor_def(Monitor *mon, int64_t *pval, const char *name);\n void handle_hmp_command(MonitorHMP *mon, const char *cmdline);\n int hmp_compare_cmd(const char *name, const char *list);\n \ndiff --git a/monitor/hmp-target.c b/monitor/hmp-target.c\nindex c2ddcd67e51..550a7178052 100644\n--- a/monitor/hmp-target.c\n+++ b/monitor/hmp-target.c\n@@ -57,39 +57,6 @@ HMPCommand *hmp_cmds_for_target(bool info_command)\n return info_command ? hmp_info_cmds : hmp_cmds;\n }\n \n-/*\n- * Set @pval to the value in the register identified by @name.\n- * return 0 if OK, -1 if not found\n- */\n-int get_monitor_def(Monitor *mon, int64_t *pval, const char *name)\n-{\n- const MonitorDef *md = target_monitor_defs();\n- CPUState *cs = mon_get_cpu(mon);\n- void *ptr;\n-\n- if (cs == NULL || md == NULL) {\n- return -1;\n- }\n-\n- for(; md->name != NULL; md++) {\n- if (hmp_compare_cmd(name, md->name)) {\n- if (md->get_value) {\n- *pval = md->get_value(mon, md, md->offset);\n- } else {\n- CPUArchState *env = mon_get_cpu_env(mon);\n- ptr = (uint8_t *)env + md->offset;\n- *pval = *(int32_t *)ptr;\n- }\n- return 0;\n- }\n- }\n-\n- if (!cs->cc->sysemu_ops->monitor_get_register) {\n- return -1;\n- }\n- return cs->cc->sysemu_ops->monitor_get_register(cs, name, pval);\n-}\n-\n static int\n compare_mon_cmd(const void *a, const void *b)\n {\ndiff --git a/monitor/hmp.c b/monitor/hmp.c\nindex e881c26c305..618ded40207 100644\n--- a/monitor/hmp.c\n+++ b/monitor/hmp.c\n@@ -25,6 +25,7 @@\n #include \"qemu/osdep.h\"\n #include <dirent.h>\n #include \"hw/core/qdev.h\"\n+#include \"hw/core/sysemu-cpu-ops.h\"\n #include \"monitor-internal.h\"\n #include \"monitor/hmp.h\"\n #include \"monitor/hmp-target.h\"\n@@ -359,6 +360,8 @@ static bool gdb_get_register(Monitor *mon, int64_t *pval, const char *name)\n static const char *pch;\n static sigjmp_buf expr_env;\n \n+static int get_monitor_def(Monitor *mon, int64_t *pval, const char *name);\n+\n static G_NORETURN G_GNUC_PRINTF(2, 3)\n void expr_error(Monitor *mon, const char *fmt, ...)\n {\n@@ -1599,3 +1602,36 @@ void monitor_register_hmp_info_hrt(const char *name,\n }\n g_assert_not_reached();\n }\n+\n+/*\n+ * Set @pval to the value in the register identified by @name.\n+ * return 0 if OK, -1 if not found\n+ */\n+static int get_monitor_def(Monitor *mon, int64_t *pval, const char *name)\n+{\n+ const MonitorDef *md = target_monitor_defs();\n+ CPUState *cs = mon_get_cpu(mon);\n+ void *ptr;\n+\n+ if (cs == NULL || md == NULL) {\n+ return -1;\n+ }\n+\n+ for(; md->name != NULL; md++) {\n+ if (hmp_compare_cmd(name, md->name)) {\n+ if (md->get_value) {\n+ *pval = md->get_value(mon, md, md->offset);\n+ } else {\n+ CPUArchState *env = mon_get_cpu_env(mon);\n+ ptr = (uint8_t *)env + md->offset;\n+ *pval = *(int32_t *)ptr;\n+ }\n+ return 0;\n+ }\n+ }\n+\n+ if (!cs->cc->sysemu_ops->monitor_get_register) {\n+ return -1;\n+ }\n+ return cs->cc->sysemu_ops->monitor_get_register(cs, name, pval);\n+}\n", "prefixes": [ "v3", "19/27" ] }