Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/1.1/patches/2222853/?format=api
{ "id": 2222853, "url": "http://patchwork.ozlabs.org/api/1.1/patches/2222853/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20260413205208.50643-11-mohamed@unpredictable.fr/", "project": { "id": 14, "url": "http://patchwork.ozlabs.org/api/1.1/projects/14/?format=api", "name": "QEMU Development", "link_name": "qemu-devel", "list_id": "qemu-devel.nongnu.org", "list_email": "qemu-devel@nongnu.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20260413205208.50643-11-mohamed@unpredictable.fr>", "date": "2026-04-13T20:52:02", "name": "[v12,10/15] whpx: i386: disable kernel-irqchip on Windows 10 when PIC enabled", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "4c52cea858ed54c38b42b962ea42d6aeb03f3cd3", "submitter": { "id": 91318, "url": "http://patchwork.ozlabs.org/api/1.1/people/91318/?format=api", "name": "Mohamed Mediouni", "email": "mohamed@unpredictable.fr" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20260413205208.50643-11-mohamed@unpredictable.fr/mbox/", "series": [ { "id": 499753, "url": "http://patchwork.ozlabs.org/api/1.1/series/499753/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/list/?series=499753", "date": "2026-04-13T20:51:52", "name": "whpx: i386: bug fixes, feature probing and CPUID", "version": 12, "mbox": "http://patchwork.ozlabs.org/series/499753/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/2222853/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/2222853/checks/", "tags": {}, "headers": { "Return-Path": "<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@legolas.ozlabs.org", "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=unpredictable.fr header.i=@unpredictable.fr\n header.a=rsa-sha256 header.s=sig1 header.b=ETB+Hxkb;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists1p.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)" ], "Received": [ "from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fvflg5Vx0z1y2d\n\tfor <incoming@patchwork.ozlabs.org>; Tue, 14 Apr 2026 06:54:07 +1000 (AEST)", "from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists1p.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from <qemu-devel-bounces@nongnu.org>)\n\tid 1wCOGn-0007QP-78; Mon, 13 Apr 2026 16:52:33 -0400", "from eggs.gnu.org ([2001:470:142:3::10])\n by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <mohamed@unpredictable.fr>)\n id 1wCOGm-0007Pn-5Z\n for qemu-devel@nongnu.org; Mon, 13 Apr 2026 16:52:32 -0400", "from ci-2007c-snip4-4.eps.apple.com ([57.103.88.27]\n helo=outbound.ci.icloud.com)\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <mohamed@unpredictable.fr>)\n id 1wCOGk-0007w2-GL\n for qemu-devel@nongnu.org; Mon, 13 Apr 2026 16:52:31 -0400", "from outbound.ci.icloud.com (unknown [127.0.0.2])\n by p00-icloudmta-asmtp-us-central-1k-10-percent-2 (Postfix) with ESMTPS id\n 1FBFE180017C; Mon, 13 Apr 2026 20:52:27 +0000 (UTC)", "from localhost.localdomain (unknown [17.57.156.36])\n by p00-icloudmta-asmtp-us-central-1k-10-percent-2 (Postfix) with ESMTPSA id\n 3B3CB18000B4; Mon, 13 Apr 2026 20:52:26 +0000 (UTC)" ], "Dkim-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=unpredictable.fr;\n s=sig1; t=1776113549; x=1778705549;\n bh=UDUDDhSNImOkwjgegNmDYFGV0Ws4YLT0V61YNwqVXjA=;\n h=From:To:Subject:Date:Message-ID:MIME-Version:x-icloud-hme;\n b=ETB+HxkbskVjvhwmcV62cBFlST/oPod1G7vByTb/YFpZ1H0YH9uLYcY0yvLqJtjV0YXlcACcveBdb+kAkcd0oGUJw3e2OH+ROVrjCibfQpVJ4TtCJf/ZxdbEBKo0DFACU8uz71qdSZtJyFrkjA8e59mki2L1rFihoUsW7QQQ3QE2CS6hgRRaYwlZaSQacgaCHx0liq2rk7/5DclQIUxltbW+R/y9wVYxheOktXUyfCnayEMnSA8PGvT898UcZGDQmpWT56hYflOHZxoF+DjKHjVF1adxobNjbbW2I4c6ikYjybLyCfR4NiRvknVWX2CtFMXSjpfn6e8WMTKt+oVw1Q==", "mail-alias-created-date": "1752046281608", "From": "Mohamed Mediouni <mohamed@unpredictable.fr>", "To": "qemu-devel@nongnu.org", "Cc": "Phil Dennis-Jordan <phil@philjordan.eu>,\n Pedro Barbuda <pbarbuda@microsoft.com>,\n \"Michael S. Tsirkin\" <mst@redhat.com>, Wei Liu <wei.liu@kernel.org>,\n Paolo Bonzini <pbonzini@redhat.com>, Roman Bolshakov <rbolshakov@ddn.com>,\n Mohamed Mediouni <mohamed@unpredictable.fr>, Zhao Liu <zhao1.liu@intel.com>", "Subject": "[PATCH v12 10/15] whpx: i386: disable kernel-irqchip on Windows 10\n when PIC enabled", "Date": "Mon, 13 Apr 2026 22:52:02 +0200", "Message-ID": "<20260413205208.50643-11-mohamed@unpredictable.fr>", "X-Mailer": "git-send-email 2.50.1", "In-Reply-To": "<20260413205208.50643-1-mohamed@unpredictable.fr>", "References": "<20260413205208.50643-1-mohamed@unpredictable.fr>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-Proofpoint-Spam-Details-Enc": "AW1haW4tMjYwNDEzMDIwNSBTYWx0ZWRfX8oLNtJglNxxL\n iyiDhfrVf8ru/EFh39lXFP9HEipPVCNVqnX8VQg2rWGnCr+WefClake0dxBaHO4txGX1VVenNtY\n T6wm1ID42z6nu8qhKpYMKPMkmB7M6X2tFvZNgs0olSM/MbFht9KBtBKlSie6WMtaR9O1RhtSQT3\n N6BYXbxumrsITRngJepEh+EQ3mHgUw1IA++JZ+TAZXxCmAB6ICou4DYZsX4ssuXYJTHp8ivw+c7\n mfmauvEkyVA7w1HOW4ordDMdBEQ3MazO6hBAYjkJ5DcdbAE52Kuid249rEeOHu12Vr8DBXMlp6x\n s5cYXdyeMaPkZAGsljhaB/BrQfDJZTkYLNa+lyPlzcPzpBlNoI+Nl1YVv94fKs=", "X-Proofpoint-ORIG-GUID": "hnHiS7ByUdoszPJNpqPTpIm3iWzC2RIZ", "X-Authority-Info-Out": "v=2.4 cv=d4/4CBjE c=1 sm=1 tr=0 ts=69dd578c\n cx=c_apl:c_pps:t_out a=2G65uMN5HjSv0sBfM2Yj2w==:117\n a=2G65uMN5HjSv0sBfM2Yj2w==:17 a=A5OVakUREuEA:10 a=VkNPw1HP01LnGYTKEx00:22\n a=nUl_a9z44qMLw6SsMv4A:9", "X-Proofpoint-GUID": "hnHiS7ByUdoszPJNpqPTpIm3iWzC2RIZ", "X-Proofpoint-Virus-Version": "vendor=baseguard\n engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49\n definitions=2026-04-13_03,2026-04-13_04,2025-10-01_01", "X-Proofpoint-Spam-Details": "rule=notspam policy=default score=0 spamscore=0\n mlxlogscore=801 lowpriorityscore=0 adultscore=0 malwarescore=0 bulkscore=0\n mlxscore=0 clxscore=1030 phishscore=0 suspectscore=0 classifier=spam\n authscore=0 adjust=0 reason=mlx scancount=1 engine=8.22.0-2601150000\n definitions=main-2604130205", "Received-SPF": "pass client-ip=57.103.88.27;\n envelope-from=mohamed@unpredictable.fr; helo=outbound.ci.icloud.com", "X-Spam_score_int": "-20", "X-Spam_score": "-2.1", "X-Spam_bar": "--", "X-Spam_report": "(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001,\n SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no", "X-Spam_action": "no action", "X-BeenThere": "qemu-devel@nongnu.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "qemu development <qemu-devel.nongnu.org>", "List-Unsubscribe": "<https://lists.nongnu.org/mailman/options/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>", "List-Archive": "<https://lists.nongnu.org/archive/html/qemu-devel>", "List-Post": "<mailto:qemu-devel@nongnu.org>", "List-Help": "<mailto:qemu-devel-request@nongnu.org?subject=help>", "List-Subscribe": "<https://lists.nongnu.org/mailman/listinfo/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=subscribe>", "Errors-To": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org", "Sender": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org" }, "content": "Move WHvCapabilityCodeProcessorPerfmonFeatures queries\nas that's how we distinguish if on a legacy OS.\n\nNow that Windows guests are booting, disable kernel-irqchip=on\nby default for Windows 10 when the PIC is enabled.\n\nSigned-off-by: Mohamed Mediouni <mohamed@unpredictable.fr>\n---\n target/i386/whpx/whpx-all.c | 69 +++++++++++++++++++++----------------\n 1 file changed, 39 insertions(+), 30 deletions(-)", "diff": "diff --git a/target/i386/whpx/whpx-all.c b/target/i386/whpx/whpx-all.c\nindex 74b94b799e..7c80d653d1 100644\n--- a/target/i386/whpx/whpx-all.c\n+++ b/target/i386/whpx/whpx-all.c\n@@ -2447,6 +2447,13 @@ int whpx_accel_init(AccelState *as, MachineState *ms)\n 0x8000000A, 0x80000021, 0x80000022, 0xC0000000, 0xC0000001};\n UINT32 cpuidExitList_legacy_os[] = {1, 0x40000000, 0x40000001, 0x40000010};\n \n+ X86MachineState *x86ms = X86_MACHINE(ms);\n+ bool pic_enabled = false;\n+\n+ if (x86ms->pic == ON_OFF_AUTO_ON || x86ms->pic == ON_OFF_AUTO_AUTO) {\n+ pic_enabled = true;\n+ }\n+\n whpx = &whpx_global;\n \n if (!init_whp_dispatch()) {\n@@ -2518,6 +2525,35 @@ int whpx_accel_init(AccelState *as, MachineState *ms)\n goto error;\n }\n \n+ /* Enable supported performance monitoring capabilities */\n+ hr = whp_dispatch.WHvGetCapability(\n+ WHvCapabilityCodeProcessorPerfmonFeatures, &perfmon_features,\n+ sizeof(WHV_PROCESSOR_PERFMON_FEATURES), &whpx_cap_size);\n+ /*\n+ * Relying on this is a crutch to maintain Windows 10 support.\n+ *\n+ * WHvCapabilityCodeProcessorPerfmonFeatures and\n+ * WHvPartitionPropertyCodeSyntheticProcessorFeaturesBanks\n+ * are implemented starting from Windows Server 2022 (build 20348).\n+ */\n+ if (FAILED(hr)) {\n+ warn_report(\"WHPX: Failed to get performance \"\n+ \"monitoring features, hr=%08lx\", hr);\n+ is_modern_os = false;\n+ } else {\n+ hr = whp_dispatch.WHvSetPartitionProperty(\n+ whpx->partition,\n+ WHvPartitionPropertyCodeProcessorPerfmonFeatures,\n+ &perfmon_features,\n+ sizeof(WHV_PROCESSOR_PERFMON_FEATURES));\n+ if (FAILED(hr)) {\n+ error_report(\"WHPX: Failed to set performance \"\n+ \"monitoring features, hr=%08lx\", hr);\n+ ret = -EINVAL;\n+ goto error;\n+ }\n+ }\n+\n /*\n * Error out if WHP doesn't support apic emulation and user is requiring\n * it.\n@@ -2530,8 +2566,9 @@ int whpx_accel_init(AccelState *as, MachineState *ms)\n goto error;\n }\n \n- if (whpx->kernel_irqchip_allowed && features.LocalApicEmulation &&\n- whp_dispatch.WHvSetVirtualProcessorInterruptControllerState2) {\n+ if (whpx->kernel_irqchip_allowed && !(whpx_is_legacy_os() && pic_enabled\n+ && !whpx->kernel_irqchip_required) && features.LocalApicEmulation\n+ && whp_dispatch.WHvSetVirtualProcessorInterruptControllerState2) {\n WHV_X64_LOCAL_APIC_EMULATION_MODE mode =\n WHvX64LocalApicEmulationModeX2Apic;\n hr = whp_dispatch.WHvSetPartitionProperty(\n@@ -2590,34 +2627,6 @@ int whpx_accel_init(AccelState *as, MachineState *ms)\n goto error;\n }\n \n- /* Enable supported performance monitoring capabilities */\n- hr = whp_dispatch.WHvGetCapability(\n- WHvCapabilityCodeProcessorPerfmonFeatures, &perfmon_features,\n- sizeof(WHV_PROCESSOR_PERFMON_FEATURES), &whpx_cap_size);\n- /*\n- * Relying on this is a crutch to maintain Windows 10 support.\n- *\n- * WHvCapabilityCodeProcessorPerfmonFeatures and\n- * WHvPartitionPropertyCodeSyntheticProcessorFeaturesBanks\n- * are implemented starting from Windows Server 2022 (build 20348).\n- */\n- if (FAILED(hr)) {\n- warn_report(\"WHPX: Failed to get performance \"\n- \"monitoring features, hr=%08lx\", hr);\n- is_modern_os = false;\n- } else {\n- hr = whp_dispatch.WHvSetPartitionProperty(\n- whpx->partition,\n- WHvPartitionPropertyCodeProcessorPerfmonFeatures,\n- &perfmon_features,\n- sizeof(WHV_PROCESSOR_PERFMON_FEATURES));\n- if (FAILED(hr)) {\n- error_report(\"WHPX: Failed to set performance \"\n- \"monitoring features, hr=%08lx\", hr);\n- ret = -EINVAL;\n- goto error;\n- }\n- }\n \n /* Enable synthetic processor features */\n WHV_SYNTHETIC_PROCESSOR_FEATURES_BANKS synthetic_features;\n", "prefixes": [ "v12", "10/15" ] }