Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/1.1/patches/2222796/?format=api
{ "id": 2222796, "url": "http://patchwork.ozlabs.org/api/1.1/patches/2222796/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20260413164338.42894-4-mohamed@unpredictable.fr/", "project": { "id": 14, "url": "http://patchwork.ozlabs.org/api/1.1/projects/14/?format=api", "name": "QEMU Development", "link_name": "qemu-devel", "list_id": "qemu-devel.nongnu.org", "list_email": "qemu-devel@nongnu.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20260413164338.42894-4-mohamed@unpredictable.fr>", "date": "2026-04-13T16:43:38", "name": "[3/3] tap-win32: allocate separate tap state for each instance", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "6d5dd1377bcfe7264aed5db2710e6a372e3d4033", "submitter": { "id": 91318, "url": "http://patchwork.ozlabs.org/api/1.1/people/91318/?format=api", "name": "Mohamed Mediouni", "email": "mohamed@unpredictable.fr" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20260413164338.42894-4-mohamed@unpredictable.fr/mbox/", "series": [ { "id": 499732, "url": "http://patchwork.ozlabs.org/api/1.1/series/499732/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/list/?series=499732", "date": "2026-04-13T16:43:36", "name": "win32: Windows-specific fixes from the mailing list", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/499732/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/2222796/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/2222796/checks/", "tags": {}, "headers": { "Return-Path": "<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@legolas.ozlabs.org", "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=unpredictable.fr header.i=@unpredictable.fr\n header.a=rsa-sha256 header.s=sig1 header.b=A1WZd7/j;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists1p.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)" ], "Received": [ "from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fvYTT1Gx9z1xtJ\n\tfor <incoming@patchwork.ozlabs.org>; Tue, 14 Apr 2026 02:56:29 +1000 (AEST)", "from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists1p.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from <qemu-devel-bounces@nongnu.org>)\n\tid 1wCKa1-0004Kc-Ru; Mon, 13 Apr 2026 12:56:09 -0400", "from eggs.gnu.org ([2001:470:142:3::10])\n by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <mohamed@unpredictable.fr>)\n id 1wCKa0-0004KP-27\n for qemu-devel@nongnu.org; Mon, 13 Apr 2026 12:56:08 -0400", "from qs-2004g-snip4-7.eps.apple.com ([57.103.84.70]\n helo=outbound.qs.icloud.com)\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <mohamed@unpredictable.fr>)\n id 1wCKZy-0006Ns-I8\n for qemu-devel@nongnu.org; Mon, 13 Apr 2026 12:56:07 -0400", "from outbound.qs.icloud.com (unknown [127.0.0.2])\n by p00-icloudmta-asmtp-us-east-2d-100-percent-5 (Postfix) with ESMTPS id\n 0110B1800279; Mon, 13 Apr 2026 16:56:02 +0000 (UTC)", "from localhost.localdomain (unknown [17.57.155.37])\n by p00-icloudmta-asmtp-us-east-2d-100-percent-5 (Postfix) with ESMTPSA id\n 3E94E180057D; Mon, 13 Apr 2026 16:43:45 +0000 (UTC)" ], "Dkim-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=unpredictable.fr;\n s=sig1; t=1776099365; x=1778691365;\n bh=ToEMsnEimqSsQl70dsHQJi59glSBxpGleQUdKNrc4Sg=;\n h=From:To:Subject:Date:Message-ID:MIME-Version:x-icloud-hme;\n b=A1WZd7/jNpV6XPtSPQXNrZ/1LPOL7qzxFE/drbXPvN0H9TUKkQgu3T9FWsuItq2quM0cIiIfQB4ZexJfDiovnTsT8AX9OjG1z2PbakqwtjdcoYJEssaxreNGJXFjvrgNTDU56IhSJNpE2kPT1ka4iy0+z0KYUpvnyvPoKvQgl6YlqWnVV3/6nAwRaxGRObZJvRdYYeaIydZ4MzmO7693Pqjk5JNE5qsu7JbViqso0guC84ZjwJ3qKNvNBWM6hnlCdVJC2m35yeYOIEEJAr2Jx/zsNkDgMgrCZNY/hdu3dZDK8UaAA3Y3g27OhqYb1LKgyMVy6VY+C5regAEysb4IFA==", "mail-alias-created-date": "1752046281608", "From": "Mohamed Mediouni <mohamed@unpredictable.fr>", "To": "qemu-devel@nongnu.org", "Cc": "Stefan Weil <sw@weilnetz.de>, Paolo Bonzini <pbonzini@redhat.com>,\n\t=?utf-8?q?Marc-Andr=C3=A9_Lureau?= <marcandre.lureau@redhat.com>,\n Jason Wang <jasowang@redhat.com>, Gal Horowitz <galush.horowitz@gmail.com>", "Subject": "[PATCH 3/3] tap-win32: allocate separate tap state for each instance", "Date": "Mon, 13 Apr 2026 18:43:38 +0200", "Message-ID": "<20260413164338.42894-4-mohamed@unpredictable.fr>", "X-Mailer": "git-send-email 2.50.1", "In-Reply-To": "<20260413164338.42894-1-mohamed@unpredictable.fr>", "References": "<20260413164338.42894-1-mohamed@unpredictable.fr>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-Authority-Info-Out": "v=2.4 cv=eKYeTXp1 c=1 sm=1 tr=0 ts=69dd2023\n cx=c_apl:c_pps:t_out a=bsP7O+dXZ5uKcj+dsLqiMw==:117\n a=bsP7O+dXZ5uKcj+dsLqiMw==:17 a=A5OVakUREuEA:10 a=VkNPw1HP01LnGYTKEx00:22\n a=pGLkceISAAAA:8 a=UVr0gZAdEIgvgD1kzycA:9", "X-Proofpoint-ORIG-GUID": "t4_NenBNUQtl75rsT2b_LVfeaU-PQDb_", "X-Proofpoint-Spam-Details-Enc": "AW1haW4tMjYwNDEzMDE2NiBTYWx0ZWRfX5ISTb7o41Yzd\n 9DxXFLQWZFJtSnGaJZ7yuxgqgCN5ndD1BjAjJDzHtBOXdHXnA6Zei0+rCS2B7lNSN+e6heVTfgz\n ZFlzfYC3fq2iR/onmegYq2fhpquldLAmgZ+C9Y0jhYDb4EJD/oRIbla+1fKYCqac6vBCSlKLuVL\n nmVS9+dnudFvceKBIO/QlOrcaR57CYqUydr9QODulUAsKtcvejuXxAZF3gm9OjVcoZMy52EyiaA\n YGi2PyF84wTs9yf1irbvn3cHpaCQ0pp8MmaWxw5Aa87Xik8i9t1ybMFeL12IslM+tAxnJP6iLIB\n AWiO2SlIQqJT++Rr2fNqBXZJfiO2ouqCaORq2eW+seUhWcQWyw8H3UMYZj8vN8=", "X-Proofpoint-GUID": "t4_NenBNUQtl75rsT2b_LVfeaU-PQDb_", "X-Proofpoint-Virus-Version": "vendor=baseguard\n engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49\n definitions=2026-04-13_03,2026-04-13_04,2025-10-01_01", "X-Proofpoint-Spam-Details": "rule=notspam policy=default score=0 spamscore=0\n malwarescore=0 lowpriorityscore=0 mlxlogscore=999 mlxscore=0 bulkscore=0\n adultscore=0 suspectscore=0 phishscore=0 clxscore=1030 classifier=spam\n authscore=0 adjust=0 reason=mlx scancount=1 engine=8.22.0-2601150000\n definitions=main-2604130166", "Received-SPF": "pass client-ip=57.103.84.70;\n envelope-from=mohamed@unpredictable.fr; helo=outbound.qs.icloud.com", "X-Spam_score_int": "-20", "X-Spam_score": "-2.1", "X-Spam_bar": "--", "X-Spam_report": "(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001,\n SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no", "X-Spam_action": "no action", "X-BeenThere": "qemu-devel@nongnu.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "qemu development <qemu-devel.nongnu.org>", "List-Unsubscribe": "<https://lists.nongnu.org/mailman/options/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>", "List-Archive": "<https://lists.nongnu.org/archive/html/qemu-devel>", "List-Post": "<mailto:qemu-devel@nongnu.org>", "List-Help": "<mailto:qemu-devel-request@nongnu.org?subject=help>", "List-Subscribe": "<https://lists.nongnu.org/mailman/listinfo/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=subscribe>", "Errors-To": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org", "Sender": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org" }, "content": "From: Gal Horowitz <galush.horowitz@gmail.com>\n\nA static global is incorrectly used as the tap state for all win32 taps\ncreated. Instead, we now allocate per win32 tap.\n\nSigned-off-by: Gal Horowitz <galush.horowitz@gmail.com>\n---\n net/tap-win32.c | 15 +++++++++------\n 1 file changed, 9 insertions(+), 6 deletions(-)", "diff": "diff --git a/net/tap-win32.c b/net/tap-win32.c\nindex ae25e5a883..3d7227fcf4 100644\n--- a/net/tap-win32.c\n+++ b/net/tap-win32.c\n@@ -115,8 +115,6 @@ typedef struct tap_win32_overlapped {\n tun_buffer_t* output_queue_back;\n } tap_win32_overlapped_t;\n \n-static tap_win32_overlapped_t tap_overlapped;\n-\n static tun_buffer_t* get_buffer_from_free_list(tap_win32_overlapped_t* const overlapped)\n {\n tun_buffer_t* buffer = NULL;\n@@ -403,8 +401,10 @@ static int tap_win32_set_status(HANDLE handle, int status)\n &status, sizeof (status), &len, NULL);\n }\n \n-static void tap_win32_overlapped_init(tap_win32_overlapped_t* const overlapped, const HANDLE handle)\n+static tap_win32_overlapped_t *tap_win32_overlapped_new(const HANDLE handle)\n {\n+ tap_win32_overlapped_t *overlapped = g_new0(tap_win32_overlapped_t, 1);\n+\n overlapped->handle = handle;\n \n overlapped->read_event = CreateEvent(NULL, FALSE, FALSE, NULL);\n@@ -455,6 +455,8 @@ static void tap_win32_overlapped_init(tap_win32_overlapped_t* const overlapped,\n overlapped->tap_semaphore = CreateSemaphore(NULL, 0, TUN_MAX_BUFFER_COUNT, NULL);\n if(!overlapped->tap_semaphore)\n fprintf(stderr, \"error creating tap_semaphore.\\n\");\n+\n+ return overlapped;\n }\n \n static int tap_win32_write(tap_win32_overlapped_t *overlapped,\n@@ -625,6 +627,7 @@ static int tap_win32_open(tap_win32_overlapped_t **phandle,\n unsigned long debug;\n } version;\n DWORD version_len;\n+ tap_win32_overlapped_t *tap_overlapped = NULL;\n \n if (preferred_name != NULL) {\n snprintf(name_buffer, sizeof(name_buffer), \"%s\", preferred_name);\n@@ -666,10 +669,10 @@ static int tap_win32_open(tap_win32_overlapped_t **phandle,\n return -1;\n }\n \n- tap_win32_overlapped_init(&tap_overlapped, handle);\n+ tap_overlapped = tap_win32_overlapped_new(handle);\n \n- tap_overlapped.thread_handle = CreateThread(NULL, 0,\n- tap_win32_thread_entry, (LPVOID)&tap_overlapped, 0, NULL);\n+ tap_overlapped->thread_handle = CreateThread(NULL, 0,\n+ tap_win32_thread_entry, (LPVOID)tap_overlapped, 0, NULL);\n \n if (tap_overlapped->thread_handle == NULL) {\n tap_win32_close(tap_overlapped);\n", "prefixes": [ "3/3" ] }