Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/1.1/patches/2222706/?format=api
{ "id": 2222706, "url": "http://patchwork.ozlabs.org/api/1.1/patches/2222706/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20260413214549.926435-2-junjie.cao@intel.com/", "project": { "id": 14, "url": "http://patchwork.ozlabs.org/api/1.1/projects/14/?format=api", "name": "QEMU Development", "link_name": "qemu-devel", "list_id": "qemu-devel.nongnu.org", "list_email": "qemu-devel@nongnu.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20260413214549.926435-2-junjie.cao@intel.com>", "date": "2026-04-13T21:45:46", "name": "[v3,1/4] io/channel: introduce qio_channel_pread{v, }_all{, _eof}()", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "fb5b04646b05449c9ac847806d10758563950a1e", "submitter": { "id": 91537, "url": "http://patchwork.ozlabs.org/api/1.1/people/91537/?format=api", "name": "Junjie Cao", "email": "junjie.cao@intel.com" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20260413214549.926435-2-junjie.cao@intel.com/mbox/", "series": [ { "id": 499708, "url": "http://patchwork.ozlabs.org/api/1.1/series/499708/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/list/?series=499708", "date": "2026-04-13T21:45:46", "name": "io/channel: complete pread/pwrite_all API and fix multifd_file_recv_data", "version": 3, "mbox": "http://patchwork.ozlabs.org/series/499708/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/2222706/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/2222706/checks/", "tags": {}, "headers": { "Return-Path": "<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@legolas.ozlabs.org", "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n unprotected) header.d=intel.com header.i=@intel.com header.a=rsa-sha256\n header.s=Intel header.b=JEEBKhg1;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists1p.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)" ], "Received": [ "from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fvTGJ1HPKz1xtJ\n\tfor <incoming@patchwork.ozlabs.org>; Mon, 13 Apr 2026 23:46:32 +1000 (AEST)", "from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists1p.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from <qemu-devel-bounces@nongnu.org>)\n\tid 1wCHcE-0004zj-0P; Mon, 13 Apr 2026 09:46:14 -0400", "from eggs.gnu.org ([2001:470:142:3::10])\n by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <junjie.cao@intel.com>)\n id 1wCHcD-0004za-12\n for qemu-devel@nongnu.org; Mon, 13 Apr 2026 09:46:13 -0400", "from mgamail.intel.com ([198.175.65.14])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <junjie.cao@intel.com>)\n id 1wCHcB-0002B8-2T\n for qemu-devel@nongnu.org; Mon, 13 Apr 2026 09:46:12 -0400", "from orviesa005.jf.intel.com ([10.64.159.145])\n by orvoesa106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 13 Apr 2026 06:46:11 -0700", "from junjie-optiplex-micro-plus-7010.bj.intel.com ([10.238.152.98])\n by orviesa005-auth.jf.intel.com with\n ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 13 Apr 2026 06:46:09 -0700" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple;\n d=intel.com; i=@intel.com; q=dns/txt; s=Intel;\n t=1776087971; x=1807623971;\n h=from:to:cc:subject:date:message-id:in-reply-to:\n references:mime-version:content-transfer-encoding;\n bh=7MG2x1Tpck0f/s3FRgTmVdtUJNJSEk2UYFSH4EpXP04=;\n b=JEEBKhg1mNrMasBylcYCSk4ua14iXtBF8RSQxvN+XBKh7IQfzGCmYztk\n Bk2jRX4JSEkxb7lhHKls5HahljNvlage3SWHn+0/D8PHzm2QYYv9WGErI\n QJEedV9jeTKI90MpN/nY5hc9Rh4tGfVgqk10I99hkoqyXtc5IvDMZACdX\n f92yZZRUohBR1qoSxvy89PHXXgE0FFInpxSnR7IIzLqsvRkasbsKkk1Ik\n cTgX/tNm0rgwwqzDshV9IXUIzdjwY9lUxBWcHkhmRffNLe603s0pLADxA\n 8f/41JVhPLRZY5meqvdM1jblgXKtGO4IpoubcltbDwcvTScfEfJ9QfRZp g==;", "X-CSE-ConnectionGUID": [ "cpdLLcBOQuGeWD62R4hJmw==", "x3I1tAg6R8Cc1jAormWLEg==" ], "X-CSE-MsgGUID": [ "hFBq0FW2SUuZaVFc/jp04w==", "QflxPTWTT1mZkJxiG56OOQ==" ], "X-IronPort-AV": [ "E=McAfee;i=\"6800,10657,11758\"; a=\"80885625\"", "E=Sophos;i=\"6.23,177,1770624000\"; d=\"scan'208\";a=\"80885625\"", "E=Sophos;i=\"6.23,177,1770624000\"; d=\"scan'208\";a=\"234770373\"" ], "X-ExtLoop1": "1", "From": "Junjie Cao <junjie.cao@intel.com>", "To": "qemu-devel@nongnu.org", "Cc": "berrange@redhat.com, peterx@redhat.com, farosas@suse.de,\n junjie.cao@intel.com", "Subject": "[PATCH v3 1/4] io/channel: introduce qio_channel_pread{v, }_all{,\n _eof}()", "Date": "Tue, 14 Apr 2026 05:45:46 +0800", "Message-ID": "<20260413214549.926435-2-junjie.cao@intel.com>", "X-Mailer": "git-send-email 2.43.0", "In-Reply-To": "<20260413214549.926435-1-junjie.cao@intel.com>", "References": "<20260413214549.926435-1-junjie.cao@intel.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Received-SPF": "pass client-ip=198.175.65.14;\n envelope-from=junjie.cao@intel.com;\n helo=mgamail.intel.com", "X-Spam_score_int": "-29", "X-Spam_score": "-3.0", "X-Spam_bar": "---", "X-Spam_report": "(-3.0 / 5.0 requ) BAYES_00=-1.9, DATE_IN_FUTURE_06_12=1.947,\n DKIMWL_WL_HIGH=-0.54, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1,\n DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3,\n RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001,\n SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no", "X-Spam_action": "no action", "X-BeenThere": "qemu-devel@nongnu.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "qemu development <qemu-devel.nongnu.org>", "List-Unsubscribe": "<https://lists.nongnu.org/mailman/options/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>", "List-Archive": "<https://lists.nongnu.org/archive/html/qemu-devel>", "List-Post": "<mailto:qemu-devel@nongnu.org>", "List-Help": "<mailto:qemu-devel-request@nongnu.org?subject=help>", "List-Subscribe": "<https://lists.nongnu.org/mailman/listinfo/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=subscribe>", "Errors-To": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org", "Sender": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org" }, "content": "qio_channel_pread() and qio_channel_preadv() perform a single\npositioned read and may return a short result. Callers that need all\nbytes currently have to open-code a retry loop or simply treat a short\nread as an error.\n\nIntroduce four new helpers following the existing read_all / readv_all\npattern:\n\n qio_channel_preadv_all_eof() -- retry loop; returns 1 on success,\n 0 on clean EOF, -1 on error.\n qio_channel_preadv_all() -- wraps _eof; treats early EOF as\n error; returns 0 / -1.\n qio_channel_pread_all_eof() -- single-buffer convenience wrapper\n around preadv_all_eof().\n qio_channel_pread_all() -- single-buffer convenience wrapper\n around preadv_all().\n\nThese advance the file offset internally after each partial read.\nAll four are marked coroutine_mixed_fn, consistent with the existing\n_all helpers.\n\nSuggested-by: Peter Xu <peterx@redhat.com>\nSigned-off-by: Junjie Cao <junjie.cao@intel.com>\n---\n include/io/channel.h | 92 ++++++++++++++++++++++++++++++++++++++++++++\n io/channel.c | 91 +++++++++++++++++++++++++++++++++++++++++++\n 2 files changed, 183 insertions(+)", "diff": "diff --git a/include/io/channel.h b/include/io/channel.h\nindex 1b02350437..47af409ede 100644\n--- a/include/io/channel.h\n+++ b/include/io/channel.h\n@@ -634,6 +634,98 @@ ssize_t qio_channel_preadv(QIOChannel *ioc, const struct iovec *iov,\n ssize_t qio_channel_pread(QIOChannel *ioc, void *buf, size_t buflen,\n off_t offset, Error **errp);\n \n+/**\n+ * qio_channel_preadv_all_eof:\n+ * @ioc: the channel object\n+ * @iov: the array of memory regions to read data into\n+ * @niov: the length of the @iov array\n+ * @offset: the starting offset in the channel to read from\n+ * @errp: pointer to a NULL-initialized error object\n+ *\n+ * Reads @iov, possibly blocking or (if the channel is non-blocking)\n+ * yielding from the current coroutine multiple times until the entire\n+ * content is read. If end-of-file occurs immediately it is not an\n+ * error, but if it occurs after data has been read it will return\n+ * an error rather than a short-read. Otherwise behaves as\n+ * qio_channel_preadv().\n+ *\n+ * Returns: 1 if all bytes were read, 0 if end-of-file occurs\n+ * without data, or -1 on error\n+ */\n+int coroutine_mixed_fn qio_channel_preadv_all_eof(QIOChannel *ioc,\n+ const struct iovec *iov,\n+ size_t niov,\n+ off_t offset,\n+ Error **errp);\n+\n+/**\n+ * qio_channel_preadv_all:\n+ * @ioc: the channel object\n+ * @iov: the array of memory regions to read data into\n+ * @niov: the length of the @iov array\n+ * @offset: the starting offset in the channel to read from\n+ * @errp: pointer to a NULL-initialized error object\n+ *\n+ * Reads @iov, possibly blocking or (if the channel is non-blocking)\n+ * yielding from the current coroutine multiple times until the entire\n+ * content is read. If end-of-file occurs before all requested data\n+ * has been read, an error will be reported. Otherwise behaves as\n+ * qio_channel_preadv().\n+ *\n+ * Returns: 0 if all bytes were read, or -1 on error\n+ */\n+int coroutine_mixed_fn qio_channel_preadv_all(QIOChannel *ioc,\n+ const struct iovec *iov,\n+ size_t niov,\n+ off_t offset,\n+ Error **errp);\n+\n+/**\n+ * qio_channel_pread_all_eof:\n+ * @ioc: the channel object\n+ * @buf: the memory region to read data into\n+ * @buflen: the number of bytes to read into @buf\n+ * @offset: the starting offset in the channel to read from\n+ * @errp: pointer to a NULL-initialized error object\n+ *\n+ * Reads @buflen bytes, possibly blocking or (if the channel is\n+ * non-blocking) yielding from the current coroutine multiple times\n+ * until the entire content is read. If end-of-file occurs\n+ * immediately it is not an error, but if it occurs after data has\n+ * been read it will return an error rather than a short-read.\n+ * Otherwise behaves as qio_channel_pread().\n+ *\n+ * Returns: 1 if all bytes were read, 0 if end-of-file occurs\n+ * without data, or -1 on error\n+ */\n+int coroutine_mixed_fn qio_channel_pread_all_eof(QIOChannel *ioc,\n+ void *buf,\n+ size_t buflen,\n+ off_t offset,\n+ Error **errp);\n+\n+/**\n+ * qio_channel_pread_all:\n+ * @ioc: the channel object\n+ * @buf: the memory region to read data into\n+ * @buflen: the number of bytes to read into @buf\n+ * @offset: the starting offset in the channel to read from\n+ * @errp: pointer to a NULL-initialized error object\n+ *\n+ * Reads @buflen bytes, possibly blocking or (if the channel is\n+ * non-blocking) yielding from the current coroutine multiple times\n+ * until the entire content is read. If end-of-file occurs before\n+ * all requested data has been read, an error will be reported.\n+ * Otherwise behaves as qio_channel_pread().\n+ *\n+ * Returns: 0 if all bytes were read, or -1 on error\n+ */\n+int coroutine_mixed_fn qio_channel_pread_all(QIOChannel *ioc,\n+ void *buf,\n+ size_t buflen,\n+ off_t offset,\n+ Error **errp);\n+\n /**\n * qio_channel_shutdown:\n * @ioc: the channel object\ndiff --git a/io/channel.c b/io/channel.c\nindex cc02d997a4..52c1abfcbc 100644\n--- a/io/channel.c\n+++ b/io/channel.c\n@@ -507,6 +507,97 @@ ssize_t qio_channel_pread(QIOChannel *ioc, void *buf, size_t buflen,\n return qio_channel_preadv(ioc, &iov, 1, offset, errp);\n }\n \n+int coroutine_mixed_fn qio_channel_preadv_all_eof(QIOChannel *ioc,\n+ const struct iovec *iov,\n+ size_t niov,\n+ off_t offset,\n+ Error **errp)\n+{\n+ int ret = -1;\n+ struct iovec *local_iov = g_new(struct iovec, niov);\n+ struct iovec *local_iov_head = local_iov;\n+ unsigned int nlocal_iov = niov;\n+ bool partial = false;\n+\n+ nlocal_iov = iov_copy(local_iov, nlocal_iov,\n+ iov, niov,\n+ 0, iov_size(iov, niov));\n+\n+ while (nlocal_iov > 0) {\n+ ssize_t len;\n+ len = qio_channel_preadv(ioc, local_iov, nlocal_iov, offset, errp);\n+\n+ if (len == QIO_CHANNEL_ERR_BLOCK) {\n+ qio_channel_wait_cond(ioc, G_IO_IN);\n+ continue;\n+ }\n+\n+ if (len == 0) {\n+ if (!partial) {\n+ ret = 0;\n+ goto cleanup;\n+ }\n+ error_setg(errp,\n+ \"Unexpected end-of-file before all data were read\");\n+ goto cleanup;\n+ }\n+\n+ if (len < 0) {\n+ goto cleanup;\n+ }\n+\n+ partial = true;\n+ offset += len;\n+ iov_discard_front(&local_iov, &nlocal_iov, len);\n+ }\n+\n+ ret = 1;\n+\n+ cleanup:\n+ g_free(local_iov_head);\n+ return ret;\n+}\n+\n+int coroutine_mixed_fn qio_channel_preadv_all(QIOChannel *ioc,\n+ const struct iovec *iov,\n+ size_t niov,\n+ off_t offset,\n+ Error **errp)\n+{\n+ int ret = qio_channel_preadv_all_eof(ioc, iov, niov, offset, errp);\n+\n+ if (ret == 0) {\n+ error_setg(errp,\n+ \"Unexpected end-of-file before all data were read\");\n+ return -1;\n+ }\n+ if (ret == 1) {\n+ return 0;\n+ }\n+\n+ return ret;\n+}\n+\n+int coroutine_mixed_fn qio_channel_pread_all_eof(QIOChannel *ioc,\n+ void *buf,\n+ size_t buflen,\n+ off_t offset,\n+ Error **errp)\n+{\n+ struct iovec iov = { .iov_base = buf, .iov_len = buflen };\n+ return qio_channel_preadv_all_eof(ioc, &iov, 1, offset, errp);\n+}\n+\n+int coroutine_mixed_fn qio_channel_pread_all(QIOChannel *ioc,\n+ void *buf,\n+ size_t buflen,\n+ off_t offset,\n+ Error **errp)\n+{\n+ struct iovec iov = { .iov_base = buf, .iov_len = buflen };\n+ return qio_channel_preadv_all(ioc, &iov, 1, offset, errp);\n+}\n+\n int qio_channel_shutdown(QIOChannel *ioc,\n QIOChannelShutdown how,\n Error **errp)\n", "prefixes": [ "v3", "1/4" ] }