Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/1.1/patches/2222167/?format=api
{ "id": 2222167, "url": "http://patchwork.ozlabs.org/api/1.1/patches/2222167/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-ppc/patch/20260410195323.17937-14-philmd@linaro.org/", "project": { "id": 69, "url": "http://patchwork.ozlabs.org/api/1.1/projects/69/?format=api", "name": "QEMU powerpc development", "link_name": "qemu-ppc", "list_id": "qemu-ppc.nongnu.org", "list_email": "qemu-ppc@nongnu.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20260410195323.17937-14-philmd@linaro.org>", "date": "2026-04-10T19:53:07", "name": "[v2,13/27] monitor: Remove target_get_monitor_def()", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "f507ca758584d78f9abec186f4e6a948c4db8dda", "submitter": { "id": 85046, "url": "http://patchwork.ozlabs.org/api/1.1/people/85046/?format=api", "name": "Philippe Mathieu-Daudé", "email": "philmd@linaro.org" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/qemu-ppc/patch/20260410195323.17937-14-philmd@linaro.org/mbox/", "series": [ { "id": 499497, "url": "http://patchwork.ozlabs.org/api/1.1/series/499497/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-ppc/list/?series=499497", "date": "2026-04-10T19:52:55", "name": "monitor: Remove need of per-target handlers", "version": 2, "mbox": "http://patchwork.ozlabs.org/series/499497/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/2222167/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/2222167/checks/", "tags": {}, "headers": { "Return-Path": "<qemu-ppc-bounces+incoming=patchwork.ozlabs.org@nongnu.org>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@legolas.ozlabs.org", "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256\n header.s=google header.b=hDwdKDl7;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists.gnu.org;\n envelope-from=qemu-ppc-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)" ], "Received": [ "from lists.gnu.org (lists1p.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fsncS2Qglz1yCv\n\tfor <incoming@patchwork.ozlabs.org>; Sat, 11 Apr 2026 05:56:24 +1000 (AEST)", "from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from <qemu-ppc-bounces@nongnu.org>)\n\tid 1wBHwW-0002Eb-L2; Fri, 10 Apr 2026 15:55:04 -0400", "from eggs.gnu.org ([2001:470:142:3::10])\n by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <philmd@linaro.org>) id 1wBHwW-0002EE-4t\n for qemu-ppc@nongnu.org; Fri, 10 Apr 2026 15:55:04 -0400", "from mail-wm1-x331.google.com ([2a00:1450:4864:20::331])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)\n (Exim 4.90_1) (envelope-from <philmd@linaro.org>) id 1wBHwT-0001il-KT\n for qemu-ppc@nongnu.org; Fri, 10 Apr 2026 15:55:03 -0400", "by mail-wm1-x331.google.com with SMTP id\n 5b1f17b1804b1-488b00ed86fso25862105e9.3\n for <qemu-ppc@nongnu.org>; Fri, 10 Apr 2026 12:55:01 -0700 (PDT)", "from localhost.localdomain (88-187-86-199.subs.proxad.net.\n [88.187.86.199]) by smtp.gmail.com with ESMTPSA id\n 5b1f17b1804b1-488d592d606sm88600455e9.9.2026.04.10.12.54.58\n (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256);\n Fri, 10 Apr 2026 12:54:59 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=linaro.org; s=google; t=1775850900; x=1776455700; darn=nongnu.org;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:from:to:cc:subject:date\n :message-id:reply-to;\n bh=WQoGjEROfb1fZGcAyFP7wGDHaXz8m4JpMOdQttRvXaU=;\n b=hDwdKDl7XKAPOkK7kPQc5XoqlmAAHXUIARDvA/fb5kI2SKFNyGZRW7XLz3mYNBmk3x\n NBTkIhYVrqRdIBETJfqAvJhskn4LIUQF5I0rErM0yN67lSoMy4+xOogUrGmIP5wbfJD+\n 5O8W0CYd13ZyZ78rT5vL5PyPBQWWlvPEHNpkLnyCI2oN03hsbB7vK3eokDcL9maURGW6\n GXAq0d5vJXqgroNWz6GhdM/XMM83UM9y6UyHij8h8yUurd9u8u5fhnLCxkCIyJwHLeZ2\n 3UEKcOn3b6H1KGpcrJIjBv+hUDRLLZSFSzYnVFX2SyNAzIoILW6r+bMy92L2IM9mPcg1\n lCag==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1775850900; x=1776455700;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from\n :to:cc:subject:date:message-id:reply-to;\n bh=WQoGjEROfb1fZGcAyFP7wGDHaXz8m4JpMOdQttRvXaU=;\n b=Rs7U4pjwv0Uz/HaiDEqNIkvsWSH5Lcs68f+9XtiIjbMfmBR37HzuvVjuXTcYCc005/\n UFvWZvWOEFysjvIe+RT1pTuFhQ9ZECKG1atb216NBqFLgoJUdL07Mlr80Yv6ekw8VCG9\n r2Gwl+BuUyLxbhdNQcvCsJo1jwJtth5E92pAexQKWS+ScXxAKdpplL/+ivZVZNW+PHOI\n jpRhlTr/DzjiZB4fBD7llcuSY3GOu0Ct/jqmebqP62PYl7rCMzne262iuSK0uOuuzokC\n 0AaaCG1q+zSBs1B84WXaonzPGrKDkxlyRf0KO5ZWoOPwK5Q/rTDqZWupb0wohYRezSPg\n nNZA==", "X-Forwarded-Encrypted": "i=1;\n AJvYcCVgLHzWWVHuLqAj03p+IkT+kyKFicVeksw4SLWC7q4/RDf9x5WHuaJzXU6N6RxnKnjcguwt+miloA==@nongnu.org", "X-Gm-Message-State": "AOJu0Yy89TKar6aEWaX3c6p+805prxULudRMO0uk/s+oE8P1HEHyMRUt\n 5/wW13V8VFESB6F9m0FwQre9/csyb8o5u52+0456ZoTsuA5kQpeZBFalPMoy9ujWyx4=", "X-Gm-Gg": "AeBDiesN7D3IiPYadRTq7QtGTWWuLVNVyU6dYtxnlFPQpcS6mIhtIFQUN34B3UtiAD5\n eknxXcmH6fJP6ir30cMEtEExq+D0g7hXPC/+olhZ2lR5UshWO0HnbRqYLlf23ZivEioaPEb55AR\n HAojLZ4nh48BicnJnB4x5jH62noTengjNZ9bQtHLZIUFAB1/rQYUyPKwXhR2mS/DSyO7XwXOvz0\n mQTh/XYngdwxdfKgyhBULwpEh/EEE5Jj9o8iPjmm1kOcdIuiIHTKelJEQI11fJfBLEA2LZYIPBx\n 31tJpBzTqU08cw+4piG21/v+oq69iI68TWlZitVYuUCV5Z8ik0KnVJQ4Og28GgunJ91BjHHStEf\n GGC15VzaNa03D3vHluWtE/5znlMnesAnxQRJG6gEh8n4fIdgKKsMduShAiVoLCMxXPyuBFpBue7\n O20XtxkrkYpXO+GbpmB50huiGOJAAc0NYkncYvE7DGYBTjhYRMeB6wtfHOsPFn06D6yTNQL6be", "X-Received": "by 2002:a05:600c:c0c8:b0:488:8bdd:cfb9 with SMTP id\n 5b1f17b1804b1-488d67bbbf8mr42408135e9.1.1775850899858;\n Fri, 10 Apr 2026 12:54:59 -0700 (PDT)", "From": "=?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= <philmd@linaro.org>", "To": "qemu-devel@nongnu.org", "Cc": "Richard Henderson <richard.henderson@linaro.org>,\n \"Dr. David Alan Gilbert\" <dave@treblig.org>,\n Pierrick Bouvier <pierrick.bouvier@linaro.org>, qemu-riscv@nongnu.org,\n Markus Armbruster <armbru@redhat.com>, qemu-s390x@nongnu.org,\n kvm@vger.kernel.org, qemu-ppc@nongnu.org, =?utf-8?q?Philippe_Mathieu-Daud?=\n\t=?utf-8?q?=C3=A9?= <philmd@linaro.org>, Paolo Bonzini <pbonzini@redhat.com>", "Subject": "[PATCH v2 13/27] monitor: Remove target_get_monitor_def()", "Date": "Fri, 10 Apr 2026 21:53:07 +0200", "Message-ID": "<20260410195323.17937-14-philmd@linaro.org>", "X-Mailer": "git-send-email 2.53.0", "In-Reply-To": "<20260410195323.17937-1-philmd@linaro.org>", "References": "<20260410195323.17937-1-philmd@linaro.org>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=UTF-8", "Content-Transfer-Encoding": "8bit", "Received-SPF": "pass client-ip=2a00:1450:4864:20::331;\n envelope-from=philmd@linaro.org; helo=mail-wm1-x331.google.com", "X-Spam_score_int": "-20", "X-Spam_score": "-2.1", "X-Spam_bar": "--", "X-Spam_report": "(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001,\n SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no", "X-Spam_action": "no action", "X-BeenThere": "qemu-ppc@nongnu.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<qemu-ppc.nongnu.org>", "List-Unsubscribe": "<https://lists.nongnu.org/mailman/options/qemu-ppc>,\n <mailto:qemu-ppc-request@nongnu.org?subject=unsubscribe>", "List-Archive": "<https://lists.nongnu.org/archive/html/qemu-ppc>", "List-Post": "<mailto:qemu-ppc@nongnu.org>", "List-Help": "<mailto:qemu-ppc-request@nongnu.org?subject=help>", "List-Subscribe": "<https://lists.nongnu.org/mailman/listinfo/qemu-ppc>,\n <mailto:qemu-ppc-request@nongnu.org?subject=subscribe>", "Errors-To": "qemu-ppc-bounces+incoming=patchwork.ozlabs.org@nongnu.org", "Sender": "qemu-ppc-bounces+incoming=patchwork.ozlabs.org@nongnu.org" }, "content": "target_get_monitor_def() is now only a dead stub. Remove as pointless.\n\nSigned-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>\n---\n include/monitor/hmp.h | 2 --\n monitor/hmp.c | 7 +++----\n stubs/target-get-monitor-def.c | 29 -----------------------------\n stubs/meson.build | 1 -\n 4 files changed, 3 insertions(+), 36 deletions(-)\n delete mode 100644 stubs/target-get-monitor-def.c", "diff": "diff --git a/include/monitor/hmp.h b/include/monitor/hmp.h\nindex cabb2c55f8e..b444095f684 100644\n--- a/include/monitor/hmp.h\n+++ b/include/monitor/hmp.h\n@@ -23,8 +23,6 @@ struct MonitorDef {\n int64_t (*get_value)(Monitor *mon, const MonitorDef *md, int offset);\n };\n \n-int target_get_monitor_def(CPUState *cs, const char *name, uint64_t *pval);\n-\n CPUArchState *mon_get_cpu_env(Monitor *mon);\n CPUState *mon_get_cpu(Monitor *mon);\n \ndiff --git a/monitor/hmp.c b/monitor/hmp.c\nindex 799855f3f68..3b9e180c1ca 100644\n--- a/monitor/hmp.c\n+++ b/monitor/hmp.c\n@@ -1632,11 +1632,10 @@ static int get_monitor_def(Monitor *mon, int64_t *pval, const char *name)\n }\n }\n \n- if (cs->cc->sysemu_ops->monitor_get_register) {\n- ret = cs->cc->sysemu_ops->monitor_get_register(cs, name, &tmp);\n- } else {\n- ret = target_get_monitor_def(cs, name, &tmp);\n+ if (!cs->cc->sysemu_ops->monitor_get_register) {\n+ return -1;\n }\n+ ret = cs->cc->sysemu_ops->monitor_get_register(cs, name, &tmp);\n if (!ret) {\n *pval = target_long_bits() == 32 ? (int32_t)tmp : tmp;\n }\ndiff --git a/stubs/target-get-monitor-def.c b/stubs/target-get-monitor-def.c\ndeleted file mode 100644\nindex 394e0f9a7d2..00000000000\n--- a/stubs/target-get-monitor-def.c\n+++ /dev/null\n@@ -1,29 +0,0 @@\n-/*\n- * Stub for target_get_monitor_def.\n- *\n- * Copyright IBM Corp., 2015\n- *\n- * Author: Alexey Kardashevskiy <aik@ozlabs.ru>\n- *\n- * This program is free software; you can redistribute it and/or modify\n- * it under the terms of the GNU General Public License as published by\n- * the Free Software Foundation; either version 2 of the License,\n- * or (at your option) any later version.\n- *\n- * This program is distributed in the hope that it will be useful,\n- * but WITHOUT ANY WARRANTY; without even the implied warranty of\n- * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the\n- * GNU General Public License for more details.\n- *\n- * You should have received a copy of the GNU General Public License\n- * along with this program; if not, see <http://www.gnu.org/licenses/>.\n- */\n-\n-#include \"qemu/osdep.h\"\n-\n-int target_get_monitor_def(CPUState *cs, const char *name, uint64_t *pval);\n-\n-int target_get_monitor_def(CPUState *cs, const char *name, uint64_t *pval)\n-{\n- return -1;\n-}\ndiff --git a/stubs/meson.build b/stubs/meson.build\nindex 10eb68ab55e..85f9e3a4f23 100644\n--- a/stubs/meson.build\n+++ b/stubs/meson.build\n@@ -74,7 +74,6 @@ if have_system\n stub_ss.add(files('igvm.c'))\n endif\n stub_ss.add(files('kvm.c'))\n- stub_ss.add(files('target-get-monitor-def.c'))\n stub_ss.add(files('win32-kbd-hook.c'))\n stub_ss.add(files('xen-hw-stub.c'))\n stub_ss.add(files('monitor-arm-gic.c'))\n", "prefixes": [ "v2", "13/27" ] }