Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/1.1/patches/2222147/?format=api
{ "id": 2222147, "url": "http://patchwork.ozlabs.org/api/1.1/patches/2222147/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-ppc/patch/20260410195323.17937-8-philmd@linaro.org/", "project": { "id": 69, "url": "http://patchwork.ozlabs.org/api/1.1/projects/69/?format=api", "name": "QEMU powerpc development", "link_name": "qemu-ppc", "list_id": "qemu-ppc.nongnu.org", "list_email": "qemu-ppc@nongnu.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20260410195323.17937-8-philmd@linaro.org>", "date": "2026-04-10T19:53:01", "name": "[v2,07/27] target/i386: Replace target_monitor_defs -> SysemuCPUOps::monitor_defs", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "36f5953438c35385911a1537493e0d65f6bf5e74", "submitter": { "id": 85046, "url": "http://patchwork.ozlabs.org/api/1.1/people/85046/?format=api", "name": "Philippe Mathieu-Daudé", "email": "philmd@linaro.org" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/qemu-ppc/patch/20260410195323.17937-8-philmd@linaro.org/mbox/", "series": [ { "id": 499497, "url": "http://patchwork.ozlabs.org/api/1.1/series/499497/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-ppc/list/?series=499497", "date": "2026-04-10T19:52:55", "name": "monitor: Remove need of per-target handlers", "version": 2, "mbox": "http://patchwork.ozlabs.org/series/499497/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/2222147/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/2222147/checks/", "tags": {}, "headers": { "Return-Path": "<qemu-ppc-bounces+incoming=patchwork.ozlabs.org@nongnu.org>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@legolas.ozlabs.org", "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256\n header.s=google header.b=HsD9cOWa;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists.gnu.org;\n envelope-from=qemu-ppc-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)" ], "Received": [ "from lists.gnu.org (lists1p.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fsnbF2Fx4z1yCv\n\tfor <incoming@patchwork.ozlabs.org>; Sat, 11 Apr 2026 05:55:21 +1000 (AEST)", "from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from <qemu-ppc-bounces@nongnu.org>)\n\tid 1wBHvx-0000ob-IW; Fri, 10 Apr 2026 15:54:29 -0400", "from eggs.gnu.org ([2001:470:142:3::10])\n by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <philmd@linaro.org>) id 1wBHvp-0000eI-Oq\n for qemu-ppc@nongnu.org; Fri, 10 Apr 2026 15:54:22 -0400", "from mail-wr1-x42f.google.com ([2a00:1450:4864:20::42f])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)\n (Exim 4.90_1) (envelope-from <philmd@linaro.org>) id 1wBHvm-0001QT-AF\n for qemu-ppc@nongnu.org; Fri, 10 Apr 2026 15:54:20 -0400", "by mail-wr1-x42f.google.com with SMTP id\n ffacd0b85a97d-43cfd832155so1556274f8f.1\n for <qemu-ppc@nongnu.org>; Fri, 10 Apr 2026 12:54:17 -0700 (PDT)", "from localhost.localdomain (88-187-86-199.subs.proxad.net.\n [88.187.86.199]) by smtp.gmail.com with ESMTPSA id\n ffacd0b85a97d-43d63e469ddsm9737710f8f.17.2026.04.10.12.54.15\n (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256);\n Fri, 10 Apr 2026 12:54:16 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=linaro.org; s=google; t=1775850857; x=1776455657; darn=nongnu.org;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:from:to:cc:subject:date\n :message-id:reply-to;\n bh=5s/GIt0tTjsOfb6v9VaN6RJdqFFBKJGIkUaXvnC2hp0=;\n b=HsD9cOWagg8s0L96aQLSMgGu/flt1alHypu44f9dxNgzxWQCPFZBnoDPda05gqhMh1\n Yv3/pKuyBYrFRDFWI0FdkTUMrBcm+95ul8Gcke6OzEGk1DEZFOqFzKgmj6mBHeKuW8N8\n RqH2sOQbcKn86y8CexHoItP/AaDyeTCLEe6IBwx41deAHmXhV06JXfvO8FkiQ2mo5Rn2\n RjyEq4uP1NUeIJ6prToppFwTOlOZf2wnQQk1+4jExobPte8xclh2KDMKT1Z/uduvVK9K\n tJm3+uw+2XBzLZrW5mjYLtp8ZM/PSjSztiJSz58TuHQPpEMNVNEBfGvfHA40yUAu4XfS\n HJSw==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1775850857; x=1776455657;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from\n :to:cc:subject:date:message-id:reply-to;\n bh=5s/GIt0tTjsOfb6v9VaN6RJdqFFBKJGIkUaXvnC2hp0=;\n b=fT3zvKh9ytehy/cTlBH96QE7LE9WdZN/rBa/1xA/o3fu0mZPxlhG094++XrRQQsWFx\n TMJBdJNygOPKI6PVq7iBU6+um2FZtQ7czMpj8Q2e0IJcMm122KNrZscZn3KyvXHA7j/r\n j+n5/1rsYF1KpHo9/Q/9vGalpxp4UkdJd0amDymatmrsp21m0jzwJmXjfxJ04DQvK/y/\n u7HhQC8tj+7RqnMEf2dQyA3WN0zVoUfWs0Yd2Mi9j7lJBDKDpmfyKQZc08o5NWYWh8Gr\n acxczL7dP5dTH8yiZkxrSjJwZTuQ/1tdFtPI7u0GlaS13RmcdDTCVfhpzm4kQORkMfGE\n upXQ==", "X-Forwarded-Encrypted": "i=1;\n AJvYcCWfLm8w3tjQnGlncDG5J1Sr9KluD3nRGHBRS4pLaggovaSK+9FN5VY4ORQDWH58QjQ72hfM2xAx6Q==@nongnu.org", "X-Gm-Message-State": "AOJu0YyOOkouGsUIjl34/RPlpf0RO3zy6vB2zUXIBThwEJcdGTFdFAD1\n yiOMkLAW2SH+tdYG7iuwqkxYfDwtXxIua4ETTMmmIPplRse35RAQz+yOgYpQBCcpvaJoUhkTZGO\n OhDLNtEo=", "X-Gm-Gg": "AeBDievlogkCVj6ZH9REg03G6m8Y4cY/aPZrFdec8KyRbmDyN4cX/EwBB+sxxHQavDf\n AY0X0tugvCVfuAR0oX4k00X6fsld1MvN5OVYRFTEz3N6H+tjbsNzcOO1g5pP/1odOfi1Agelvg5\n OJTO6jBxEfH1pet1oL50bI/Ckyb7dlojoK7tFLxAHRdccU2hLb7XxKgFwcI4wB8l/7x+OwCOcBY\n +dSooRDRCSV6s6COinDxESaWVf0WeiNPb00HrqE/FleJGHSjq/qbGuZ3Waau6U5AFFiFJVpvd1/\n uTnXjaRFH4UDZZRTntqfMoLXqAWc9CJETP9TPNpfiuobit9yjfGVecHJVa/mj5dp/nh/cd+ImIG\n IBHmPJEtjnJuRcZx+2pZsT3tRKyBw5MJMdwM8/GVjHAH0bbri+gB5KqGC1GxIzYdVilB/RQLCKF\n 8wmN7fmfPQWtE4eKbS5LvOz2ENyEh5UKFTV4sqsPPlifptdaxVn7F/9D+9UnM1acc3PGOOGyPn", "X-Received": "by 2002:a5d:5f92:0:b0:43b:60f7:2283 with SMTP id\n ffacd0b85a97d-43d64289753mr6876436f8f.22.1775850856829;\n Fri, 10 Apr 2026 12:54:16 -0700 (PDT)", "From": "=?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= <philmd@linaro.org>", "To": "qemu-devel@nongnu.org", "Cc": "Richard Henderson <richard.henderson@linaro.org>,\n \"Dr. David Alan Gilbert\" <dave@treblig.org>,\n Pierrick Bouvier <pierrick.bouvier@linaro.org>, qemu-riscv@nongnu.org,\n Markus Armbruster <armbru@redhat.com>, qemu-s390x@nongnu.org,\n kvm@vger.kernel.org, qemu-ppc@nongnu.org, =?utf-8?q?Philippe_Mathieu-Daud?=\n\t=?utf-8?q?=C3=A9?= <philmd@linaro.org>, Paolo Bonzini <pbonzini@redhat.com>,\n Zhao Liu <zhao1.liu@intel.com>", "Subject": "[PATCH v2 07/27] target/i386: Replace target_monitor_defs ->\n SysemuCPUOps::monitor_defs", "Date": "Fri, 10 Apr 2026 21:53:01 +0200", "Message-ID": "<20260410195323.17937-8-philmd@linaro.org>", "X-Mailer": "git-send-email 2.53.0", "In-Reply-To": "<20260410195323.17937-1-philmd@linaro.org>", "References": "<20260410195323.17937-1-philmd@linaro.org>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=UTF-8", "Content-Transfer-Encoding": "8bit", "Received-SPF": "pass client-ip=2a00:1450:4864:20::42f;\n envelope-from=philmd@linaro.org; helo=mail-wr1-x42f.google.com", "X-Spam_score_int": "-20", "X-Spam_score": "-2.1", "X-Spam_bar": "--", "X-Spam_report": "(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001,\n SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no", "X-Spam_action": "no action", "X-BeenThere": "qemu-ppc@nongnu.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<qemu-ppc.nongnu.org>", "List-Unsubscribe": "<https://lists.nongnu.org/mailman/options/qemu-ppc>,\n <mailto:qemu-ppc-request@nongnu.org?subject=unsubscribe>", "List-Archive": "<https://lists.nongnu.org/archive/html/qemu-ppc>", "List-Post": "<mailto:qemu-ppc@nongnu.org>", "List-Help": "<mailto:qemu-ppc-request@nongnu.org?subject=help>", "List-Subscribe": "<https://lists.nongnu.org/mailman/listinfo/qemu-ppc>,\n <mailto:qemu-ppc-request@nongnu.org?subject=subscribe>", "Errors-To": "qemu-ppc-bounces+incoming=patchwork.ozlabs.org@nongnu.org", "Sender": "qemu-ppc-bounces+incoming=patchwork.ozlabs.org@nongnu.org" }, "content": "Restrict x86_monitor_defs[] to cpu.c, register it as\nSysemuCPUOps::monitor_defs hook, allowing to remove\nthe target_monitor_defs() method.\n\nSigned-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>\n---\n target/i386/cpu.c | 24 ++++++++++++++++++++++++\n target/i386/monitor.c | 25 -------------------------\n 2 files changed, 24 insertions(+), 25 deletions(-)", "diff": "diff --git a/target/i386/cpu.c b/target/i386/cpu.c\nindex c6fd1dc00eb..968414e7215 100644\n--- a/target/i386/cpu.c\n+++ b/target/i386/cpu.c\n@@ -39,6 +39,7 @@\n #include \"exec/watchpoint.h\"\n #ifndef CONFIG_USER_ONLY\n #include \"confidential-guest.h\"\n+#include \"monitor/hmp.h\"\n #include \"system/reset.h\"\n #include \"qapi/qapi-commands-machine.h\"\n #include \"system/address-spaces.h\"\n@@ -10685,6 +10686,28 @@ static const Property x86_cpu_properties[] = {\n };\n \n #ifndef CONFIG_USER_ONLY\n+\n+static int64_t monitor_get_pc(Monitor *mon, const struct MonitorDef *md,\n+ int offset)\n+{\n+ CPUArchState *env = mon_get_cpu_env(mon);\n+ return env->eip + env->segs[R_CS].base;\n+}\n+\n+static const MonitorDef x86_monitor_defs[] = {\n+#define SEG(name, seg) \\\n+ { name \".limit\", offsetof(CPUX86State, segs[seg].limit) },\n+ SEG(\"cs\", R_CS)\n+ SEG(\"ds\", R_DS)\n+ SEG(\"es\", R_ES)\n+ SEG(\"ss\", R_SS)\n+ SEG(\"fs\", R_FS)\n+ SEG(\"gs\", R_GS)\n+ { \"pc\", 0, monitor_get_pc, },\n+ { NULL },\n+#undef SEG\n+};\n+\n #include \"hw/core/sysemu-cpu-ops.h\"\n \n static const struct SysemuCPUOps i386_sysemu_ops = {\n@@ -10698,6 +10721,7 @@ static const struct SysemuCPUOps i386_sysemu_ops = {\n .write_elf64_note = x86_cpu_write_elf64_note,\n .write_elf32_qemunote = x86_cpu_write_elf32_qemunote,\n .write_elf64_qemunote = x86_cpu_write_elf64_qemunote,\n+ .monitor_defs = x86_monitor_defs,\n .legacy_vmsd = &vmstate_x86_cpu,\n };\n #endif\ndiff --git a/target/i386/monitor.c b/target/i386/monitor.c\nindex ddc666d3451..a536712c755 100644\n--- a/target/i386/monitor.c\n+++ b/target/i386/monitor.c\n@@ -591,28 +591,3 @@ void hmp_mce(Monitor *mon, const QDict *qdict)\n flags);\n }\n }\n-\n-static int64_t monitor_get_pc(Monitor *mon, const struct MonitorDef *md,\n- int offset)\n-{\n- CPUArchState *env = mon_get_cpu_env(mon);\n- return env->eip + env->segs[R_CS].base;\n-}\n-\n-const MonitorDef monitor_defs[] = {\n-#define SEG(name, seg) \\\n- { name \".limit\", offsetof(CPUX86State, segs[seg].limit) },\n- SEG(\"cs\", R_CS)\n- SEG(\"ds\", R_DS)\n- SEG(\"es\", R_ES)\n- SEG(\"ss\", R_SS)\n- SEG(\"fs\", R_FS)\n- SEG(\"gs\", R_GS)\n- { \"pc\", 0, monitor_get_pc, },\n- { NULL },\n-};\n-\n-const MonitorDef *target_monitor_defs(void)\n-{\n- return monitor_defs;\n-}\n", "prefixes": [ "v2", "07/27" ] }