Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/1.1/patches/2222146/?format=api
{ "id": 2222146, "url": "http://patchwork.ozlabs.org/api/1.1/patches/2222146/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20260410195323.17937-2-philmd@linaro.org/", "project": { "id": 14, "url": "http://patchwork.ozlabs.org/api/1.1/projects/14/?format=api", "name": "QEMU Development", "link_name": "qemu-devel", "list_id": "qemu-devel.nongnu.org", "list_email": "qemu-devel@nongnu.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20260410195323.17937-2-philmd@linaro.org>", "date": "2026-04-10T19:52:55", "name": "[v2,01/27] monitor: Have MonitorDef::get_value() always return int64_t type", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "1d6d91b6b8b726a15f2eaab506f0aea1f1a29571", "submitter": { "id": 85046, "url": "http://patchwork.ozlabs.org/api/1.1/people/85046/?format=api", "name": "Philippe Mathieu-Daudé", "email": "philmd@linaro.org" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20260410195323.17937-2-philmd@linaro.org/mbox/", "series": [ { "id": 499498, "url": "http://patchwork.ozlabs.org/api/1.1/series/499498/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/list/?series=499498", "date": "2026-04-10T19:52:54", "name": "monitor: Remove need of per-target handlers", "version": 2, "mbox": "http://patchwork.ozlabs.org/series/499498/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/2222146/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/2222146/checks/", "tags": {}, "headers": { "Return-Path": "<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@legolas.ozlabs.org", "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256\n header.s=google header.b=UWTA0ZCw;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)" ], "Received": [ "from lists.gnu.org (lists1p.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fsnb06VZSz1yCv\n\tfor <incoming@patchwork.ozlabs.org>; Sat, 11 Apr 2026 05:55:08 +1000 (AEST)", "from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from <qemu-devel-bounces@nongnu.org>)\n\tid 1wBHv8-0008T1-97; Fri, 10 Apr 2026 15:53:38 -0400", "from eggs.gnu.org ([2001:470:142:3::10])\n by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <philmd@linaro.org>) id 1wBHv6-0008Rt-DX\n for qemu-devel@nongnu.org; Fri, 10 Apr 2026 15:53:36 -0400", "from mail-wr1-x42c.google.com ([2a00:1450:4864:20::42c])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)\n (Exim 4.90_1) (envelope-from <philmd@linaro.org>) id 1wBHv4-0000Sv-Oe\n for qemu-devel@nongnu.org; Fri, 10 Apr 2026 15:53:36 -0400", "by mail-wr1-x42c.google.com with SMTP id\n ffacd0b85a97d-43cfce3a195so1524423f8f.2\n for <qemu-devel@nongnu.org>; Fri, 10 Apr 2026 12:53:34 -0700 (PDT)", "from localhost.localdomain (88-187-86-199.subs.proxad.net.\n [88.187.86.199]) by smtp.gmail.com with ESMTPSA id\n ffacd0b85a97d-43d63deba9esm10266885f8f.10.2026.04.10.12.53.31\n (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256);\n Fri, 10 Apr 2026 12:53:32 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=linaro.org; s=google; t=1775850813; x=1776455613; darn=nongnu.org;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:from:to:cc:subject:date\n :message-id:reply-to;\n bh=vgSDBpX5CLw08pNI+SPMIuoznTVCeN74IG0qPtzmxwM=;\n b=UWTA0ZCwd6DkBI7Zcydv37n/mKXNdg2B1rN/GlFMe7RfqsegtD3T1BeoVP+Jp0/Btj\n oCKybYrkdpcXq/zvXJIDRMm6Ydz7zZbwHU5vz0WuPPDlFgB8fi63uRgosx1kTcFqTclO\n Lua5hoSiF9WsmN3Nr+sfm7o/TFGiTUtzE+t9r0UUhvy860OrwPfB2HfPlH7brYznlH+m\n zflt0RQ+vlm7gbb3V7jBoMtaHN/3VwVeK9kht/4y2o94HwCH7jnNUc8DD6vY6kuVai5e\n WG4Yhwdc0iTDkZW3ItMv117AA5zTF5iJje8oeyXCGshVR9KKq9HaOVb5USQOvapzifTz\n NLIw==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1775850813; x=1776455613;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from\n :to:cc:subject:date:message-id:reply-to;\n bh=vgSDBpX5CLw08pNI+SPMIuoznTVCeN74IG0qPtzmxwM=;\n b=BNRth/7aBprNuEY+cUSbxJMe2JpjgtdughfZaknn1/wFUD1C959uNu/muFiZnxWl1y\n G+zwgSMGVtF1HpDzX4AdVa61CV6T78s9sz+ERrbL+wna105ayduo2//wlWXxb176p5Hb\n KnjKXzg2es1EAmaOnVohWEor1EpPRnLJeZbFCTY5fc3Ti/LB8nywj8SfOgNaZE5lxjFz\n XnW4bwFpNjGDpc+PsZM5bB2LGLhXbpO8Bgw2tH035aNqCACmlqlD1klfRZ6uybDQZvkS\n alfqZZAizVyW04AwruQn1l7mlGgh1HmkmGPiQLxgz8ti3XXzro9PCW5nAOaix3n/Zp7+\n nYnQ==", "X-Gm-Message-State": "AOJu0Yx7PB/F5gog+1gthmXHAc2R+997fBeoz8dgWmRlPMlYjpZp0H2i\n 68x5V507m3CP4MsyYR9Etb1/glKFe8vHOzxn6tjpcsgpR2PAe/FazjLgG5DeDiPJ542wDVwcHNT\n GOFGGz4E=", "X-Gm-Gg": "AeBDieuI49eo0CGczHh0Xe/h/pdx8PPrNwmedm4b1wR1XLFYozfL4pNJR0JQhiTWVqZ\n k+b/uzZytmsQL5sS6EUoelw1141K2wFFvXWh0oaMRwHBR/NlgZUuGJuX1DQsfmKx9yvilB/VW7t\n 7xemt88nBhsAVzDnqCsKfZe8VGVG4WHhk0GjqTDpX0XoXnqFaLOzNfEiyNW8wVlphG06ugwW5o/\n hiOIyk+Lmggapk/rY5NXCRkSQqrZnQscvshb58spWePLACSfiaObC1AiGTrGTlSIZGID9qgFGiJ\n ov1MbeSbE4EKPfylE89fff1jmR2BEVyzDdzlYfdrkaL0rtEgngKeaV4evnvyvLIb/E8506TPEH5\n DCJ+2MTUSqnKcB/hqFG6TJw8Jahx6ZjTPsxV+HYSsLEYDc8BMo6R7zdaRrbm2MtdRiZJKE8ar63\n FhXQcOVXEJoqpgWwGXs2f+bvtJsu13rXCpcQ78+TcXdjPGDHldn5jvWUAXJ1p8UlvKW9mT6WxV", "X-Received": "by 2002:a05:6000:420b:b0:43c:fd18:a30e with SMTP id\n ffacd0b85a97d-43d642b4653mr6664483f8f.35.1775850812787;\n Fri, 10 Apr 2026 12:53:32 -0700 (PDT)", "From": "=?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= <philmd@linaro.org>", "To": "qemu-devel@nongnu.org", "Cc": "Richard Henderson <richard.henderson@linaro.org>,\n \"Dr. David Alan Gilbert\" <dave@treblig.org>,\n Pierrick Bouvier <pierrick.bouvier@linaro.org>, qemu-riscv@nongnu.org,\n Markus Armbruster <armbru@redhat.com>, qemu-s390x@nongnu.org,\n kvm@vger.kernel.org, qemu-ppc@nongnu.org, =?utf-8?q?Philippe_Mathieu-Daud?=\n\t=?utf-8?q?=C3=A9?= <philmd@linaro.org>, Paolo Bonzini <pbonzini@redhat.com>,\n Zhao Liu <zhao1.liu@intel.com>", "Subject": "[PATCH v2 01/27] monitor: Have MonitorDef::get_value() always return\n int64_t type", "Date": "Fri, 10 Apr 2026 21:52:55 +0200", "Message-ID": "<20260410195323.17937-2-philmd@linaro.org>", "X-Mailer": "git-send-email 2.53.0", "In-Reply-To": "<20260410195323.17937-1-philmd@linaro.org>", "References": "<20260410195323.17937-1-philmd@linaro.org>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=UTF-8", "Content-Transfer-Encoding": "8bit", "Received-SPF": "pass client-ip=2a00:1450:4864:20::42c;\n envelope-from=philmd@linaro.org; helo=mail-wr1-x42c.google.com", "X-Spam_score_int": "-20", "X-Spam_score": "-2.1", "X-Spam_bar": "--", "X-Spam_report": "(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001,\n SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no", "X-Spam_action": "no action", "X-BeenThere": "qemu-devel@nongnu.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "qemu development <qemu-devel.nongnu.org>", "List-Unsubscribe": "<https://lists.nongnu.org/mailman/options/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>", "List-Archive": "<https://lists.nongnu.org/archive/html/qemu-devel>", "List-Post": "<mailto:qemu-devel@nongnu.org>", "List-Help": "<mailto:qemu-devel-request@nongnu.org?subject=help>", "List-Subscribe": "<https://lists.nongnu.org/mailman/listinfo/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=subscribe>", "Errors-To": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org", "Sender": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org" }, "content": "Simplify MonitorDef::get_value() handler by having it always\nreturn a int64_t type. Truncate to 32-bit in the single caller.\n\nNote, this handler is only implemented once for the x86 targets.\n\nSigned-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>\n---\n include/monitor/hmp-target.h | 6 +-----\n monitor/hmp-target.c | 4 +++-\n target/i386/monitor.c | 4 ++--\n 3 files changed, 6 insertions(+), 8 deletions(-)", "diff": "diff --git a/include/monitor/hmp-target.h b/include/monitor/hmp-target.h\nindex ce0bb1983cc..6364c94edf8 100644\n--- a/include/monitor/hmp-target.h\n+++ b/include/monitor/hmp-target.h\n@@ -27,15 +27,11 @@\n \n typedef struct MonitorDef MonitorDef;\n \n-#ifdef COMPILING_PER_TARGET\n-#include \"exec/target_long.h\"\n struct MonitorDef {\n const char *name;\n int offset;\n- target_long (*get_value)(Monitor *mon, const struct MonitorDef *md,\n- int val);\n+ int64_t (*get_value)(Monitor *mon, const struct MonitorDef *md, int offset);\n };\n-#endif\n \n const MonitorDef *target_monitor_defs(void);\n int target_get_monitor_def(CPUState *cs, const char *name, uint64_t *pval);\ndiff --git a/monitor/hmp-target.c b/monitor/hmp-target.c\nindex da7dd7f31f2..812714ada01 100644\n--- a/monitor/hmp-target.c\n+++ b/monitor/hmp-target.c\n@@ -23,6 +23,7 @@\n */\n \n #include \"qemu/osdep.h\"\n+#include \"qemu/target-info.h\"\n #include \"monitor-internal.h\"\n #include \"monitor/qdev.h\"\n #include \"net/slirp.h\"\n@@ -79,7 +80,8 @@ int get_monitor_def(Monitor *mon, int64_t *pval, const char *name)\n for(; md->name != NULL; md++) {\n if (hmp_compare_cmd(name, md->name)) {\n if (md->get_value) {\n- *pval = md->get_value(mon, md, md->offset);\n+ int64_t val = md->get_value(mon, md, md->offset);\n+ *pval = target_long_bits() == 32 ? (int32_t)val : val;\n } else {\n CPUArchState *env = mon_get_cpu_env(mon);\n ptr = (uint8_t *)env + md->offset;\ndiff --git a/target/i386/monitor.c b/target/i386/monitor.c\nindex 977f65fe16c..b128334e571 100644\n--- a/target/i386/monitor.c\n+++ b/target/i386/monitor.c\n@@ -593,8 +593,8 @@ void hmp_mce(Monitor *mon, const QDict *qdict)\n }\n }\n \n-static target_long monitor_get_pc(Monitor *mon, const struct MonitorDef *md,\n- int val)\n+static int64_t monitor_get_pc(Monitor *mon, const struct MonitorDef *md,\n+ int offset)\n {\n CPUArchState *env = mon_get_cpu_env(mon);\n return env->eip + env->segs[R_CS].base;\n", "prefixes": [ "v2", "01/27" ] }