Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/1.1/patches/2222128/?format=api
{ "id": 2222128, "url": "http://patchwork.ozlabs.org/api/1.1/patches/2222128/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20260410-qemu-vnc-v2-56-231416f76dc3@redhat.com/", "project": { "id": 14, "url": "http://patchwork.ozlabs.org/api/1.1/projects/14/?format=api", "name": "QEMU Development", "link_name": "qemu-devel", "list_id": "qemu-devel.nongnu.org", "list_email": "qemu-devel@nongnu.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20260410-qemu-vnc-v2-56-231416f76dc3@redhat.com>", "date": "2026-04-10T19:19:18", "name": "[v2,56/67] ui/console: remove qemu_console_is_visible()", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "7a27c2488e7da41bc6981a69b2f69a52b8d1c203", "submitter": { "id": 66774, "url": "http://patchwork.ozlabs.org/api/1.1/people/66774/?format=api", "name": "Marc-André Lureau", "email": "marcandre.lureau@redhat.com" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20260410-qemu-vnc-v2-56-231416f76dc3@redhat.com/mbox/", "series": [ { "id": 499494, "url": "http://patchwork.ozlabs.org/api/1.1/series/499494/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/list/?series=499494", "date": "2026-04-10T19:18:23", "name": "ui: add standalone VNC server over D-Bus", "version": 2, "mbox": "http://patchwork.ozlabs.org/series/499494/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/2222128/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/2222128/checks/", "tags": {}, "headers": { "Return-Path": "<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@legolas.ozlabs.org", "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256\n header.s=mimecast20190719 header.b=ZOoaJZMB;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)" ], "Received": [ "from lists.gnu.org (lists1p.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fsmzX4ZH8z1yGb\n\tfor <incoming@patchwork.ozlabs.org>; Sat, 11 Apr 2026 05:27:52 +1000 (AEST)", "from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from <qemu-devel-bounces@nongnu.org>)\n\tid 1wBHTD-0006wa-5e; Fri, 10 Apr 2026 15:24:47 -0400", "from eggs.gnu.org ([2001:470:142:3::10])\n by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <marcandre.lureau@redhat.com>)\n id 1wBHT9-0006uw-BC\n for qemu-devel@nongnu.org; Fri, 10 Apr 2026 15:24:43 -0400", "from us-smtp-delivery-124.mimecast.com ([170.10.133.124])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <marcandre.lureau@redhat.com>)\n id 1wBHT3-0002Wq-01\n for qemu-devel@nongnu.org; Fri, 10 Apr 2026 15:24:41 -0400", "from mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com\n (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by\n relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3,\n cipher=TLS_AES_256_GCM_SHA384) id us-mta-102-_D5yo8MAN4e06JH3MR72uA-1; Fri,\n 10 Apr 2026 15:24:30 -0400", "from mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com\n (mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.111])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest\n SHA256)\n (No client certificate requested)\n by mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS\n id 9154C1956054\n for <qemu-devel@nongnu.org>; Fri, 10 Apr 2026 19:24:29 +0000 (UTC)", "from localhost (unknown [10.44.22.4])\n by mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP\n id 3A5EF1800B7F; Fri, 10 Apr 2026 19:24:27 +0000 (UTC)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n s=mimecast20190719; t=1775849071;\n h=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n to:to:cc:cc:mime-version:mime-version:content-type:content-type:\n content-transfer-encoding:content-transfer-encoding:\n in-reply-to:in-reply-to:references:references;\n bh=47nHfE6Dd9pBt6quFAl/2E1llNWDswiln4ygrouj+gg=;\n b=ZOoaJZMB9Th8UqsDkQW2qLc/oXA2Pnq0ly2VA0Pyaj/dGbgNVab997JyJHU31WgSYZh5aU\n L7eW0Z7f9KHtpIIJd7gnbY4LbT/uI//Oy3wlFmBier1GSugvaLqRGZnNSmvb8k3RbbzfKX\n AD77fyFcNcmoYrftHbXuS/U14/7Zeyo=", "X-MC-Unique": "_D5yo8MAN4e06JH3MR72uA-1", "X-Mimecast-MFC-AGG-ID": "_D5yo8MAN4e06JH3MR72uA_1775849069", "From": "=?utf-8?q?Marc-Andr=C3=A9_Lureau?= <marcandre.lureau@redhat.com>", "Date": "Fri, 10 Apr 2026 23:19:18 +0400", "Subject": "[PATCH v2 56/67] ui/console: remove qemu_console_is_visible()", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"utf-8\"", "Content-Transfer-Encoding": "8bit", "Message-Id": "<20260410-qemu-vnc-v2-56-231416f76dc3@redhat.com>", "References": "<20260410-qemu-vnc-v2-0-231416f76dc3@redhat.com>", "In-Reply-To": "<20260410-qemu-vnc-v2-0-231416f76dc3@redhat.com>", "To": "qemu-devel@nongnu.org", "Cc": "=?utf-8?q?Marc-Andr=C3=A9_Lureau?= <marcandre.lureau@redhat.com>,\n\t=?utf-8?q?Daniel_P=2E_Berrang=C3=A9?= <berrange@redhat.com>", "X-Developer-Signature": "v=1; a=openpgp-sha256; l=4788;\n i=marcandre.lureau@redhat.com; h=from:subject:message-id;\n bh=bhOtDgVb1DVTenfIM+HhCL9wwiQsu901e9ovryHDGss=;\n b=owEBbQKS/ZANAwAKAdro4Ql1lpzlAcsmYgBp2U0WKugkNcO1CV/g75fF1+WLsZe8xJrL04bPc\n 3TW1FYBHCKJAjMEAAEKAB0WIQSHqb2TP4fGBtJ29i3a6OEJdZac5QUCadlNFgAKCRDa6OEJdZac\n 5ZBqEACBp2I4fJr0Qhn8DKAjRPEF/BAumW7Q4SwO5Tmt8ZEmq2MbsjoiE9QfaVQXnFY80j4MhZi\n 2ltqmjQPzOnSmywsNqEKaeL3FNu6qtzvc8t1ncQXsTe65zzp5D30632OmBlO+sSPOKT/ml8gj5H\n K+2UAWim4XG4lVR7hHHfklj3hNN07q9zW1lv6gT6x21wdnWT9v4Zwwi6XsFD5KzAcTuOLbqBKDR\n sa1mur0jLsL5hnXvzSBqzNKJKundjvECeHXP2Zs3KDJK8ShjiOnXsFiB8ZTNZT7vPBd6RAgGUYY\n BcJnoyM8XjEpWs2V8d0yAzgvisJ1fmiBN4cKLRsQjzo7qAFWc0kc0OvHD1Wz1XqPwPYDT86Au3G\n Qv2tSTGq6TCW4pj+q8vkrcJYB6imoZ8F7KV1E9l0eBbIHhgE1ZqDORC3Mb5SftVZq5UBBclATXP\n seJ572Im2LkYkqwM/Jc7pc5ULChjB4K7NbJJUAJj6ytU81vWVDBp+DMoRIrxN5sQXfCrRHlhr2A\n IQQEuLWTNATtxdWGyjigoYGBGj83ETKqexgediHspoznTUo5AWbhUuAl4GyrtIA3jQuWKCSQbvd\n hUQdvW+pDdtUIaQ5Siom2iZt2ukDJJABfKTYFrW+OZLrsAmWrjd5ApAHV5pF3Ml/sJSskdDp89q\n NH9jYmcKFtw4H3g==", "X-Developer-Key": "i=marcandre.lureau@redhat.com; a=openpgp;\n fpr=87A9BD933F87C606D276F62DDAE8E10975969CE5", "X-Scanned-By": "MIMEDefang 3.4.1 on 10.30.177.111", "Received-SPF": "pass client-ip=170.10.133.124;\n envelope-from=marcandre.lureau@redhat.com;\n helo=us-smtp-delivery-124.mimecast.com", "X-Spam_score_int": "7", "X-Spam_score": "0.7", "X-Spam_bar": "/", "X-Spam_report": "(0.7 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.54,\n DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=0.001, RCVD_IN_SBL_CSS=3.335,\n RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001,\n SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no", "X-Spam_action": "no action", "X-BeenThere": "qemu-devel@nongnu.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "qemu development <qemu-devel.nongnu.org>", "List-Unsubscribe": "<https://lists.nongnu.org/mailman/options/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>", "List-Archive": "<https://lists.nongnu.org/archive/html/qemu-devel>", "List-Post": "<mailto:qemu-devel@nongnu.org>", "List-Help": "<mailto:qemu-devel-request@nongnu.org?subject=help>", "List-Subscribe": "<https://lists.nongnu.org/mailman/listinfo/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=subscribe>", "Errors-To": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org", "Sender": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org" }, "content": "Drop the bookkeeping, we can simply afford an empty \"foreach\".\n\nNotice that dpy_gfx_update_texture() is now called even when there are\nno listeners. This is more correct, as the texture is not fully\nrefreshed when a listener connects, so it may be outdated/garbaged.\n\nReviewed-by: Daniel P. Berrangé <berrange@redhat.com>\nSigned-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>\n---\n include/ui/console.h | 1 -\n ui/console-priv.h | 1 -\n ui/console.c | 29 -----------------------------\n 3 files changed, 31 deletions(-)", "diff": "diff --git a/include/ui/console.h b/include/ui/console.h\nindex b3aaf3ff12b..472c188a727 100644\n--- a/include/ui/console.h\n+++ b/include/ui/console.h\n@@ -392,7 +392,6 @@ QemuConsole *qemu_console_lookup_by_device(DeviceState *dev, uint32_t head);\n QemuConsole *qemu_console_lookup_by_device_name(const char *device_id,\n uint32_t head, Error **errp);\n QEMUCursor *qemu_console_get_cursor(QemuConsole *con);\n-bool qemu_console_is_visible(QemuConsole *con);\n bool qemu_console_is_graphic(QemuConsole *con);\n bool qemu_console_is_fixedsize(QemuConsole *con);\n bool qemu_console_is_gl_blocked(QemuConsole *con);\ndiff --git a/ui/console-priv.h b/ui/console-priv.h\nindex f8855753e30..4f731b4f9ce 100644\n--- a/ui/console-priv.h\n+++ b/ui/console-priv.h\n@@ -16,7 +16,6 @@ struct QemuConsole {\n DisplayState *ds;\n DisplaySurface *surface;\n DisplayScanout scanout;\n- int dcls;\n DisplayGLCtx *gl;\n int gl_block;\n QEMUTimer *gl_unblock_timer;\ndiff --git a/ui/console.c b/ui/console.c\nindex a9132e09eac..baffdeb22b1 100644\n--- a/ui/console.c\n+++ b/ui/console.c\n@@ -650,9 +650,6 @@ void register_displaychangelistener(DisplayChangeListener *dcl)\n dcl->ds = get_alloc_displaystate();\n QLIST_INSERT_HEAD(&dcl->ds->listeners, dcl, next);\n gui_setup_refresh(dcl->ds);\n- if (dcl->con) {\n- dcl->con->dcls++;\n- }\n displaychangelistener_display_console(dcl, &error_fatal);\n if (QEMU_IS_GRAPHIC_CONSOLE(dcl->con)) {\n dcl_set_graphic_cursor(dcl, QEMU_GRAPHIC_CONSOLE(dcl->con));\n@@ -680,9 +677,6 @@ void unregister_displaychangelistener(DisplayChangeListener *dcl)\n if (!ds) {\n return;\n }\n- if (dcl->con) {\n- dcl->con->dcls--;\n- }\n QLIST_REMOVE(dcl, next);\n dcl->ds = NULL;\n gui_setup_refresh(ds);\n@@ -747,9 +741,6 @@ void dpy_gfx_update(QemuConsole *con, int x, int y, int w, int h)\n w = MIN(w, width - x);\n h = MIN(h, height - y);\n \n- if (!qemu_console_is_visible(con)) {\n- return;\n- }\n dpy_gfx_update_texture(con, con->surface, x, y, w, h);\n QLIST_FOREACH(dcl, &s->listeners, next) {\n if (con != dcl->con) {\n@@ -848,9 +839,6 @@ void dpy_text_cursor(QemuConsole *con, int x, int y)\n DisplayState *s = con->ds;\n DisplayChangeListener *dcl;\n \n- if (!qemu_console_is_visible(con)) {\n- return;\n- }\n QLIST_FOREACH(dcl, &s->listeners, next) {\n if (con != dcl->con) {\n continue;\n@@ -866,9 +854,6 @@ void dpy_text_update(QemuConsole *con, int x, int y, int w, int h)\n DisplayState *s = con->ds;\n DisplayChangeListener *dcl;\n \n- if (!qemu_console_is_visible(con)) {\n- return;\n- }\n QLIST_FOREACH(dcl, &s->listeners, next) {\n if (con != dcl->con) {\n continue;\n@@ -884,9 +869,6 @@ void dpy_text_resize(QemuConsole *con, int w, int h)\n DisplayState *s = con->ds;\n DisplayChangeListener *dcl;\n \n- if (!qemu_console_is_visible(con)) {\n- return;\n- }\n QLIST_FOREACH(dcl, &s->listeners, next) {\n if (con != dcl->con) {\n continue;\n@@ -906,9 +888,6 @@ void dpy_mouse_set(QemuConsole *c, int x, int y, bool on)\n con->cursor_x = x;\n con->cursor_y = y;\n con->cursor_on = on;\n- if (!qemu_console_is_visible(c)) {\n- return;\n- }\n QLIST_FOREACH(dcl, &s->listeners, next) {\n if (c != dcl->con) {\n continue;\n@@ -927,9 +906,6 @@ void dpy_cursor_define(QemuConsole *c, QEMUCursor *cursor)\n \n cursor_unref(con->cursor);\n con->cursor = cursor_ref(cursor);\n- if (!qemu_console_is_visible(c)) {\n- return;\n- }\n QLIST_FOREACH(dcl, &s->listeners, next) {\n if (c != dcl->con) {\n continue;\n@@ -1287,11 +1263,6 @@ QEMUCursor *qemu_console_get_cursor(QemuConsole *con)\n return QEMU_IS_GRAPHIC_CONSOLE(con) ? QEMU_GRAPHIC_CONSOLE(con)->cursor : NULL;\n }\n \n-bool qemu_console_is_visible(QemuConsole *con)\n-{\n- return con->dcls > 0;\n-}\n-\n bool qemu_console_is_graphic(QemuConsole *con)\n {\n return con && QEMU_IS_GRAPHIC_CONSOLE(con);\n", "prefixes": [ "v2", "56/67" ] }