Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/1.1/patches/2222104/?format=api
{ "id": 2222104, "url": "http://patchwork.ozlabs.org/api/1.1/patches/2222104/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20260410-qemu-vnc-v2-40-231416f76dc3@redhat.com/", "project": { "id": 14, "url": "http://patchwork.ozlabs.org/api/1.1/projects/14/?format=api", "name": "QEMU Development", "link_name": "qemu-devel", "list_id": "qemu-devel.nongnu.org", "list_email": "qemu-devel@nongnu.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20260410-qemu-vnc-v2-40-231416f76dc3@redhat.com>", "date": "2026-04-10T19:19:02", "name": "[v2,40/67] ui/vnc: assert preconditions instead of silently returning", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "2ab032bd0490e6b6c37337d89904d677b5d42ffd", "submitter": { "id": 66774, "url": "http://patchwork.ozlabs.org/api/1.1/people/66774/?format=api", "name": "Marc-André Lureau", "email": "marcandre.lureau@redhat.com" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20260410-qemu-vnc-v2-40-231416f76dc3@redhat.com/mbox/", "series": [ { "id": 499494, "url": "http://patchwork.ozlabs.org/api/1.1/series/499494/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/list/?series=499494", "date": "2026-04-10T19:18:23", "name": "ui: add standalone VNC server over D-Bus", "version": 2, "mbox": "http://patchwork.ozlabs.org/series/499494/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/2222104/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/2222104/checks/", "tags": {}, "headers": { "Return-Path": "<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@legolas.ozlabs.org", "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256\n header.s=mimecast20190719 header.b=ViSOSgB4;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)" ], "Received": [ "from lists.gnu.org (lists1p.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fsmws4CnLz20HT\n\tfor <incoming@patchwork.ozlabs.org>; Sat, 11 Apr 2026 05:25:33 +1000 (AEST)", "from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from <qemu-devel-bounces@nongnu.org>)\n\tid 1wBHRX-0005gm-Uz; Fri, 10 Apr 2026 15:23:03 -0400", "from eggs.gnu.org ([2001:470:142:3::10])\n by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <marcandre.lureau@redhat.com>)\n id 1wBHRW-0005c3-06\n for qemu-devel@nongnu.org; Fri, 10 Apr 2026 15:23:02 -0400", "from us-smtp-delivery-124.mimecast.com ([170.10.133.124])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <marcandre.lureau@redhat.com>)\n id 1wBHRU-00021j-ML\n for qemu-devel@nongnu.org; Fri, 10 Apr 2026 15:23:01 -0400", "from mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com\n (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by\n relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3,\n cipher=TLS_AES_256_GCM_SHA384) id us-mta-594-l0V46jO-MjK_dbROrs67Qg-1; Fri,\n 10 Apr 2026 15:22:57 -0400", "from mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com\n (mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.17])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest\n SHA256)\n (No client certificate requested)\n by mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS\n id 5335519560A7; Fri, 10 Apr 2026 19:22:56 +0000 (UTC)", "from localhost (unknown [10.44.22.4])\n by mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP\n id F00A2195608E; Fri, 10 Apr 2026 19:22:54 +0000 (UTC)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n s=mimecast20190719; t=1775848979;\n h=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n to:to:cc:cc:mime-version:mime-version:content-type:content-type:\n content-transfer-encoding:content-transfer-encoding:\n in-reply-to:in-reply-to:references:references;\n bh=4kWlbYarbpq8q7vX6x2MmnM15GIOhf9S8XQMmsXaO9s=;\n b=ViSOSgB46VTQ2vjXVYQn1EPr7yqUVsKGKaSvkYMAuJr6RuyTJFYGekpMwGfSq9C560rPnc\n uWugUJwdGPnUTeM/NvQwCJPhpXKc5qc3YqrIL0u1nYCCgcC7VCJhlbW4HzoG6Lc71lBIqt\n KyrV6GWc4xPT14Qk0LBfATwVM31NzKE=", "X-MC-Unique": "l0V46jO-MjK_dbROrs67Qg-1", "X-Mimecast-MFC-AGG-ID": "l0V46jO-MjK_dbROrs67Qg_1775848976", "From": "=?utf-8?q?Marc-Andr=C3=A9_Lureau?= <marcandre.lureau@redhat.com>", "Date": "Fri, 10 Apr 2026 23:19:02 +0400", "Subject": "[PATCH v2 40/67] ui/vnc: assert preconditions instead of silently\n returning", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"utf-8\"", "Content-Transfer-Encoding": "8bit", "Message-Id": "<20260410-qemu-vnc-v2-40-231416f76dc3@redhat.com>", "References": "<20260410-qemu-vnc-v2-0-231416f76dc3@redhat.com>", "In-Reply-To": "<20260410-qemu-vnc-v2-0-231416f76dc3@redhat.com>", "To": "qemu-devel@nongnu.org", "Cc": "=?utf-8?q?Marc-Andr=C3=A9_Lureau?= <marcandre.lureau@redhat.com>,\n\t=?utf-8?q?Daniel_P=2E_Berrang=C3=A9?= <berrange@redhat.com>, =?utf-8?q?Phil?=\n\t=?utf-8?q?ippe_Mathieu-Daud=C3=A9?= <philmd@linaro.org>", "X-Developer-Signature": "v=1; a=openpgp-sha256; l=1439;\n i=marcandre.lureau@redhat.com; h=from:subject:message-id;\n bh=da7UZtFscHYGKLrYZuUkMO/YLUmJ4YfpeTA/WP9zdYE=;\n b=owEBbQKS/ZANAwAKAdro4Ql1lpzlAcsmYgBp2U0Vydsrx4tA+tY+1afN3tj6rYtyIpSK7bgbm\n IT1fiD91F+JAjMEAAEKAB0WIQSHqb2TP4fGBtJ29i3a6OEJdZac5QUCadlNFQAKCRDa6OEJdZac\n 5fyHD/4y5jUz4y1iEgQGRBG23K69av/mdL8wDipxaueP84smEmQfsl1dHylFCM2mkcAoqUPozQn\n mMXESWJ9p78HXK21oCYmRN3hPfBoLPho+afJJtuw4IB1TT7j7NYiMFF4lE9waR0ZLjOZ3ClJw5o\n 2DAF6T9O9IL9+Ekfh/qKLlTqzYWKBlTBJel6FDrvAR9NL07tQyOgSjn9JmGzuKn689TCE/3Nsvo\n nBL2U73PRbZSbY0Wjs9vBtdK/AS4ab8h+4sjsv1Jr7DTULDkzZMpMeTlqTP0VlZWH2t3sRz2WhM\n rUjVrINzOBfPadKFGTBjklt/G+KwHwPeQtkAEqmXE7RIc2FlnqV/PpiqapTnvKgaUrQWGk1arLx\n cU0GFVHOyfU0GSHPGpHh3tK3QRyfSTc56Qs7/0Xe77Xn8zfItpi88tDadGqkHPacxBkmFebycOr\n TC539gu3QxOx7Movx3c9CCbAGXDhUbsJl64dChTjrO8Bo6fkkHC9zpJXPmNBiKsAwiKIYpKuyQJ\n Gaa2rEPN4ma7JxwCUg4D3VP+iKwGcJjIEOethhMpLIqhjW2hW8vpBUWR2DkcG4akuqS4Nr9R9H1\n bq0CG+8cBVbo6t8M9viuofLfQguk/aFlnp/fKL9gjzqRB8JCuCgXloBVafQMNcMthJGpr13EPg+\n +dPKwbIgrFI5/Lw==", "X-Developer-Key": "i=marcandre.lureau@redhat.com; a=openpgp;\n fpr=87A9BD933F87C606D276F62DDAE8E10975969CE5", "X-Scanned-By": "MIMEDefang 3.0 on 10.30.177.17", "Received-SPF": "pass client-ip=170.10.133.124;\n envelope-from=marcandre.lureau@redhat.com;\n helo=us-smtp-delivery-124.mimecast.com", "X-Spam_score_int": "7", "X-Spam_score": "0.7", "X-Spam_bar": "/", "X-Spam_report": "(0.7 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.54,\n DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=0.001, RCVD_IN_SBL_CSS=3.335,\n RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001,\n SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no", "X-Spam_action": "no action", "X-BeenThere": "qemu-devel@nongnu.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "qemu development <qemu-devel.nongnu.org>", "List-Unsubscribe": "<https://lists.nongnu.org/mailman/options/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>", "List-Archive": "<https://lists.nongnu.org/archive/html/qemu-devel>", "List-Post": "<mailto:qemu-devel@nongnu.org>", "List-Help": "<mailto:qemu-devel-request@nongnu.org?subject=help>", "List-Subscribe": "<https://lists.nongnu.org/mailman/listinfo/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=subscribe>", "Errors-To": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org", "Sender": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org" }, "content": "Replace defensive NULL guards with assert() in vnc_display_close()\nand vnc_display_open(). These are internal functions whose callers\nguarantee non-NULL arguments, so a NULL value would indicate a\nprogramming error rather than a runtime condition.\n\nReviewed-by: Daniel P. Berrangé <berrange@redhat.com>\nReviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>\nSigned-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>\n---\n ui/vnc.c | 15 ++++-----------\n 1 file changed, 4 insertions(+), 11 deletions(-)", "diff": "diff --git a/ui/vnc.c b/ui/vnc.c\nindex 9c8fe280bc9..3633fbeb6ce 100644\n--- a/ui/vnc.c\n+++ b/ui/vnc.c\n@@ -3465,9 +3465,7 @@ void vnc_display_init(const char *id, Error **errp)\n \n static void vnc_display_close(VncDisplay *vd)\n {\n- if (!vd) {\n- return;\n- }\n+ assert(vd);\n \n if (vd->listener) {\n qio_net_listener_disconnect(vd->listener);\n@@ -4068,15 +4066,10 @@ void vnc_display_open(const char *id, Error **errp)\n const char *audiodev;\n const char *passwordSecret;\n \n- if (!vd) {\n- error_setg(errp, \"VNC display not active\");\n- return;\n- }\n- vnc_display_close(vd);\n+ assert(vd);\n+ assert(opts);\n \n- if (!opts) {\n- return;\n- }\n+ vnc_display_close(vd);\n \n reverse = qemu_opt_get_bool(opts, \"reverse\", false);\n if (vnc_display_get_addresses(opts, reverse, &saddr_list, &wsaddr_list,\n", "prefixes": [ "v2", "40/67" ] }