Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/1.1/patches/2222092/?format=api
{ "id": 2222092, "url": "http://patchwork.ozlabs.org/api/1.1/patches/2222092/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20260410-qemu-vnc-v2-28-231416f76dc3@redhat.com/", "project": { "id": 14, "url": "http://patchwork.ozlabs.org/api/1.1/projects/14/?format=api", "name": "QEMU Development", "link_name": "qemu-devel", "list_id": "qemu-devel.nongnu.org", "list_email": "qemu-devel@nongnu.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20260410-qemu-vnc-v2-28-231416f76dc3@redhat.com>", "date": "2026-04-10T19:18:50", "name": "[v2,28/67] ui/console-vc: extract vt100_init() and vt100_fini()", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "0aedd29880d6cb918341f9accaa7ffba3991c4e9", "submitter": { "id": 66774, "url": "http://patchwork.ozlabs.org/api/1.1/people/66774/?format=api", "name": "Marc-André Lureau", "email": "marcandre.lureau@redhat.com" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20260410-qemu-vnc-v2-28-231416f76dc3@redhat.com/mbox/", "series": [ { "id": 499494, "url": "http://patchwork.ozlabs.org/api/1.1/series/499494/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/list/?series=499494", "date": "2026-04-10T19:18:23", "name": "ui: add standalone VNC server over D-Bus", "version": 2, "mbox": "http://patchwork.ozlabs.org/series/499494/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/2222092/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/2222092/checks/", "tags": {}, "headers": { "Return-Path": "<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@legolas.ozlabs.org", "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256\n header.s=mimecast20190719 header.b=YHVxxAhF;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)" ], "Received": [ "from lists.gnu.org (lists1p.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fsmry1dYdz1y2d\n\tfor <incoming@patchwork.ozlabs.org>; Sat, 11 Apr 2026 05:22:10 +1000 (AEST)", "from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from <qemu-devel-bounces@nongnu.org>)\n\tid 1wBHQL-000148-K8; Fri, 10 Apr 2026 15:21:49 -0400", "from eggs.gnu.org ([2001:470:142:3::10])\n by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <marcandre.lureau@redhat.com>)\n id 1wBHQK-0000wj-GU\n for qemu-devel@nongnu.org; Fri, 10 Apr 2026 15:21:48 -0400", "from us-smtp-delivery-124.mimecast.com ([170.10.133.124])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <marcandre.lureau@redhat.com>)\n id 1wBHQI-0001f3-RH\n for qemu-devel@nongnu.org; Fri, 10 Apr 2026 15:21:48 -0400", "from mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com\n (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by\n relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3,\n cipher=TLS_AES_256_GCM_SHA384) id us-mta-122-tDXGYv-7ORGlXlUSR0ftFQ-1; Fri,\n 10 Apr 2026 15:21:43 -0400", "from mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com\n (mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.4])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest\n SHA256)\n (No client certificate requested)\n by mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS\n id 79FB8180034F; Fri, 10 Apr 2026 19:21:42 +0000 (UTC)", "from localhost (unknown [10.44.22.4])\n by mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP\n id 5AC5A3000C16; Fri, 10 Apr 2026 19:21:40 +0000 (UTC)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n s=mimecast20190719; t=1775848906;\n h=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n to:to:cc:cc:mime-version:mime-version:content-type:content-type:\n content-transfer-encoding:content-transfer-encoding:\n in-reply-to:in-reply-to:references:references;\n bh=PlKFwmWjmC8Lncf18Tdazfm1QoSVzgcnfKazbHyaKp4=;\n b=YHVxxAhF1y0atuY/OByx+3OCcbEWUoULNxKthr2xDAKDSsK6efjOIfmV+azh5yWpM3cA/e\n gKTQyhVhfR0nG5rUniHqC1KNgtHseRX9iq3HqGptuHbapRYQXrqU82d2q8EceC+EH8VnmJ\n xkNM4waIPDyZLTPsxHwPzNmJMKXQJZU=", "X-MC-Unique": "tDXGYv-7ORGlXlUSR0ftFQ-1", "X-Mimecast-MFC-AGG-ID": "tDXGYv-7ORGlXlUSR0ftFQ_1775848902", "From": "=?utf-8?q?Marc-Andr=C3=A9_Lureau?= <marcandre.lureau@redhat.com>", "Date": "Fri, 10 Apr 2026 23:18:50 +0400", "Subject": "[PATCH v2 28/67] ui/console-vc: extract vt100_init() and vt100_fini()", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"utf-8\"", "Content-Transfer-Encoding": "8bit", "Message-Id": "<20260410-qemu-vnc-v2-28-231416f76dc3@redhat.com>", "References": "<20260410-qemu-vnc-v2-0-231416f76dc3@redhat.com>", "In-Reply-To": "<20260410-qemu-vnc-v2-0-231416f76dc3@redhat.com>", "To": "qemu-devel@nongnu.org", "Cc": "=?utf-8?q?Marc-Andr=C3=A9_Lureau?= <marcandre.lureau@redhat.com>,\n\t=?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= <philmd@linaro.org>", "X-Developer-Signature": "v=1; a=openpgp-sha256; l=3601;\n i=marcandre.lureau@redhat.com; h=from:subject:message-id;\n bh=Zhp6CmSbOUhHIMaEnP1CemI0/3Yw4E1NhjHME/nu10Y=;\n b=owEBbQKS/ZANAwAKAdro4Ql1lpzlAcsmYgBp2U0VpE3etBJUMcNi+ptl4BrW55cT9JMcpDHCr\n BOQnQqsii+JAjMEAAEKAB0WIQSHqb2TP4fGBtJ29i3a6OEJdZac5QUCadlNFQAKCRDa6OEJdZac\n 5Y9QEAC11lsjNwwM37vnUAH+upQxOaUp62dJNnAiIh0z2IozourdPhmj5j7sSkDpIdTpS14yzUl\n IWncyp75mfwUDLn+mx+8/smy5WkYbIC241ZVt7FmsnaeKEGo/MuIFtaehbMLZe6K011tzcPCjcC\n tJEm/VUu19finhGWPbTnhiyMgExa2RoDMVlB4ZNMvBEhvPF4pet3CLAKcIn2ktDwtNyeevCDnAP\n /KtTrUIH8BAl4xcq04ri5Qf6vU9kf7GLFjH8kmrWYh8PapGRIGAuiqnxNwkdU4NdLpK0bSHvO0e\n +tdLo4Nu2uDZRgontHBV2CUtR6w/6XgKREgLT2/l96ZWUfh5q9SdY5q7gQ8WsRU/UdLHmFfnfVi\n 1MPf3Py6c2PS8L6rOi3ThIeaU0t3fbR0eqRz1PmTtktgLe2/KoN7OE4F3bJmkfvKzKqM2NeCJb6\n 18c1P0mKC4o3BuPVlM4p+HiGF/R8fd/rmrcASDbXZ+7tmIQfTqqJuZ5DOb1m1wDCuALtnm7Piiz\n 9KHIaOBeqOuyTXAtHx/3uyVlmwB2QrlYVXPidErPPoAobH+tNt17erK2/fPVzF4nS9d+nsX/Lxf\n WPMqAjL5M5kVejnoufpBgFa1b5IipjNLa1EHJKejseoFj0DioKoL/7TOdkC2FrZRNQPrlVFlDFz\n sCshkIRZKWSg/wQ==", "X-Developer-Key": "i=marcandre.lureau@redhat.com; a=openpgp;\n fpr=87A9BD933F87C606D276F62DDAE8E10975969CE5", "X-Scanned-By": "MIMEDefang 3.4.1 on 10.30.177.4", "Received-SPF": "pass client-ip=170.10.133.124;\n envelope-from=marcandre.lureau@redhat.com;\n helo=us-smtp-delivery-124.mimecast.com", "X-Spam_score_int": "-25", "X-Spam_score": "-2.6", "X-Spam_bar": "--", "X-Spam_report": "(-2.6 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.54,\n DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=0.001,\n RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001,\n SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no", "X-Spam_action": "no action", "X-BeenThere": "qemu-devel@nongnu.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "qemu development <qemu-devel.nongnu.org>", "List-Unsubscribe": "<https://lists.nongnu.org/mailman/options/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>", "List-Archive": "<https://lists.nongnu.org/archive/html/qemu-devel>", "List-Post": "<mailto:qemu-devel@nongnu.org>", "List-Help": "<mailto:qemu-devel-request@nongnu.org?subject=help>", "List-Subscribe": "<https://lists.nongnu.org/mailman/listinfo/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=subscribe>", "Errors-To": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org", "Sender": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org" }, "content": "Consolidate VT100 initialization and finalization into dedicated\nfunctions, continuing the extraction of the VT100 layer from the\nconsole/chardev code.\n\nvt100_init() gathers the scattered setup (cursor timer, list insertion,\nFIFO creation, default attributes, and image) that was previously spread\nacross vc_chr_open() and qemu_text_console_class_init().\n\nvt100_fini() pairs with it by handling list removal, FIFO destruction,\nand cells cleanup, replacing the open-coded QTAILQ_REMOVE in\nqemu_text_console_finalize().\n\nReviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>\nSigned-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>\n---\n ui/console-vc.c | 44 ++++++++++++++++++++++++++++++--------------\n 1 file changed, 30 insertions(+), 14 deletions(-)", "diff": "diff --git a/ui/console-vc.c b/ui/console-vc.c\nindex 194233f41df..84944f845e1 100644\n--- a/ui/console-vc.c\n+++ b/ui/console-vc.c\n@@ -1127,12 +1127,19 @@ static void text_console_invalidate(void *opaque)\n vt100_refresh(&s->vt);\n }\n \n+static void vt100_fini(QemuVT100 *vt)\n+{\n+ QTAILQ_REMOVE(&vt100s, vt, list);\n+ fifo8_destroy(&vt->out_fifo);\n+ g_free(vt->cells);\n+}\n+\n static void\n qemu_text_console_finalize(Object *obj)\n {\n QemuTextConsole *s = QEMU_TEXT_CONSOLE(obj);\n \n- QTAILQ_REMOVE(&vt100s, &s->vt, list);\n+ vt100_fini(&s->vt);\n }\n \n static void\n@@ -1140,10 +1147,6 @@ qemu_text_console_class_init(ObjectClass *oc, const void *data)\n {\n QemuConsoleClass *cc = QEMU_CONSOLE_CLASS(oc);\n \n- if (!cursor_timer) {\n- cursor_timer = timer_new_ms(QEMU_CLOCK_REALTIME, cursor_timer_cb, NULL);\n- }\n-\n cc->get_label = qemu_text_console_get_label;\n }\n \n@@ -1209,6 +1212,25 @@ static void text_console_out_flush(QemuVT100 *vt)\n qemu_text_console_out_flush(console);\n }\n \n+static void vt100_init(QemuVT100 *vt,\n+ pixman_image_t *image,\n+ void (*image_update)(QemuVT100 *vt, int x, int y, int w, int h),\n+ void (*out_flush)(QemuVT100 *vt))\n+{\n+ if (!cursor_timer) {\n+ cursor_timer = timer_new_ms(QEMU_CLOCK_REALTIME, cursor_timer_cb, NULL);\n+ }\n+\n+ QTAILQ_INSERT_HEAD(&vt100s, vt, list);\n+ fifo8_create(&vt->out_fifo, 16);\n+ vt->total_height = DEFAULT_BACKSCROLL;\n+ vt->image_update = image_update;\n+ vt->out_flush = out_flush;\n+ /* set current text attributes to default */\n+ vt->t_attrib = TEXT_ATTRIBUTES_DEFAULT;\n+ vt100_set_image(vt, image);\n+}\n+\n static bool vc_chr_open(Chardev *chr, ChardevBackend *backend, Error **errp)\n {\n ChardevVC *vc = backend->u.vc.data;\n@@ -1238,20 +1260,14 @@ static bool vc_chr_open(Chardev *chr, ChardevBackend *backend, Error **errp)\n s = QEMU_TEXT_CONSOLE(object_new(TYPE_QEMU_FIXED_TEXT_CONSOLE));\n }\n \n- QTAILQ_INSERT_HEAD(&vt100s, &s->vt, list);\n- fifo8_create(&s->vt.out_fifo, 16);\n- s->vt.total_height = DEFAULT_BACKSCROLL;\n dpy_gfx_replace_surface(QEMU_CONSOLE(s), qemu_create_displaysurface(width, height));\n- s->vt.image_update = text_console_image_update;\n- s->vt.out_flush = text_console_out_flush;\n+ vt100_init(&s->vt, QEMU_CONSOLE(s)->surface->image,\n+ text_console_image_update,\n+ text_console_out_flush);\n \n s->chr = chr;\n drv->console = s;\n \n- /* set current text attributes to default */\n- s->vt.t_attrib = TEXT_ATTRIBUTES_DEFAULT;\n- vt100_set_image(&s->vt, QEMU_CONSOLE(s)->surface->image);\n-\n if (chr->label) {\n char *msg;\n \n", "prefixes": [ "v2", "28/67" ] }