Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/1.1/patches/2222086/?format=api
{ "id": 2222086, "url": "http://patchwork.ozlabs.org/api/1.1/patches/2222086/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20260410-qemu-vnc-v2-15-231416f76dc3@redhat.com/", "project": { "id": 14, "url": "http://patchwork.ozlabs.org/api/1.1/projects/14/?format=api", "name": "QEMU Development", "link_name": "qemu-devel", "list_id": "qemu-devel.nongnu.org", "list_email": "qemu-devel@nongnu.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20260410-qemu-vnc-v2-15-231416f76dc3@redhat.com>", "date": "2026-04-10T19:18:37", "name": "[v2,15/67] ui/console-vc: vga_putcharxy()->vt100_putcharxy()", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "583027280b909c067739766038ee1a6d53675dfc", "submitter": { "id": 66774, "url": "http://patchwork.ozlabs.org/api/1.1/people/66774/?format=api", "name": "Marc-André Lureau", "email": "marcandre.lureau@redhat.com" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20260410-qemu-vnc-v2-15-231416f76dc3@redhat.com/mbox/", "series": [ { "id": 499494, "url": "http://patchwork.ozlabs.org/api/1.1/series/499494/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/list/?series=499494", "date": "2026-04-10T19:18:23", "name": "ui: add standalone VNC server over D-Bus", "version": 2, "mbox": "http://patchwork.ozlabs.org/series/499494/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/2222086/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/2222086/checks/", "tags": {}, "headers": { "Return-Path": "<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@legolas.ozlabs.org", "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256\n header.s=mimecast20190719 header.b=emplc0/z;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)" ], "Received": [ "from lists.gnu.org (lists1p.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fsmrJ6pZZz1y2d\n\tfor <incoming@patchwork.ozlabs.org>; Sat, 11 Apr 2026 05:21:36 +1000 (AEST)", "from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from <qemu-devel-bounces@nongnu.org>)\n\tid 1wBHPj-0005kd-42; Fri, 10 Apr 2026 15:21:11 -0400", "from eggs.gnu.org ([2001:470:142:3::10])\n by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <marcandre.lureau@redhat.com>)\n id 1wBHP4-0004wW-Qg\n for qemu-devel@nongnu.org; Fri, 10 Apr 2026 15:20:34 -0400", "from us-smtp-delivery-124.mimecast.com ([170.10.133.124])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <marcandre.lureau@redhat.com>)\n id 1wBHP2-00019S-Ou\n for qemu-devel@nongnu.org; Fri, 10 Apr 2026 15:20:30 -0400", "from mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com\n (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by\n relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3,\n cipher=TLS_AES_256_GCM_SHA384) id us-mta-678-Ircw8FBgMVyrEHqCKOJBww-1; Fri,\n 10 Apr 2026 15:20:26 -0400", "from mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com\n (mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.4])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest\n SHA256)\n (No client certificate requested)\n by mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS\n id E9458180034C; Fri, 10 Apr 2026 19:20:25 +0000 (UTC)", "from localhost (unknown [10.44.22.4])\n by mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP\n id B64BC3000C16; Fri, 10 Apr 2026 19:20:23 +0000 (UTC)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n s=mimecast20190719; t=1775848828;\n h=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n to:to:cc:cc:mime-version:mime-version:content-type:content-type:\n content-transfer-encoding:content-transfer-encoding:\n in-reply-to:in-reply-to:references:references;\n bh=lcRo5CAEdOjBKNJZHbtN+cZpcnk/HQwcXTjPRUQ1/pE=;\n b=emplc0/zuznbgyJHuNRmOe/AhXJbT3wiO+fgZtliqOVBRVFlunnArLryPE4cqIb7MBc6pT\n NdmQ6QWWFjLLUMh+umh9Yk6YNDQTKN9SixVnJoCRyHWqjMo96n79Z8GZcA3C4/VPzv4N8K\n c7yJfr0LyFypEZJmt9d/UoZl9+dZywE=", "X-MC-Unique": "Ircw8FBgMVyrEHqCKOJBww-1", "X-Mimecast-MFC-AGG-ID": "Ircw8FBgMVyrEHqCKOJBww_1775848826", "From": "=?utf-8?q?Marc-Andr=C3=A9_Lureau?= <marcandre.lureau@redhat.com>", "Date": "Fri, 10 Apr 2026 23:18:37 +0400", "Subject": "[PATCH v2 15/67] ui/console-vc: vga_putcharxy()->vt100_putcharxy()", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"utf-8\"", "Content-Transfer-Encoding": "8bit", "Message-Id": "<20260410-qemu-vnc-v2-15-231416f76dc3@redhat.com>", "References": "<20260410-qemu-vnc-v2-0-231416f76dc3@redhat.com>", "In-Reply-To": "<20260410-qemu-vnc-v2-0-231416f76dc3@redhat.com>", "To": "qemu-devel@nongnu.org", "Cc": "=?utf-8?q?Marc-Andr=C3=A9_Lureau?= <marcandre.lureau@redhat.com>,\n\t=?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= <philmd@linaro.org>", "X-Developer-Signature": "v=1; a=openpgp-sha256; l=3119;\n i=marcandre.lureau@redhat.com; h=from:subject:message-id;\n bh=dJnrgMgCNfQEna7bGX8u4UyoRqB7oR/YhWc7dLzoiB4=;\n b=owEBbQKS/ZANAwAKAdro4Ql1lpzlAcsmYgBp2U0U0QucN7JfDEej9Oa6Ra67Dz528AdEQkzoP\n 6fwa/KloHaJAjMEAAEKAB0WIQSHqb2TP4fGBtJ29i3a6OEJdZac5QUCadlNFAAKCRDa6OEJdZac\n 5d+FD/wOXk0on7NYopkFwW/T1dRMhCfcIPrj+PQzJwe+Ar/FUfGPqagBjjPV8XoTUKybukUbOhY\n btgJo6jaa5ul+TAJTcCm4azYNEbO2M/ho8jyVslmNtst3275gaYT6ohhpaaNoHR3fQgdteIX6Ra\n gKBRtE7gHLqWLctuC7aOL7iuARmQLeOYBy59syc1oyH4IATTr3B4TrzHW2wEoPsvoD4OPQlKqyg\n 5HwSRFvmH6AcsuGoiM8wzHF5Cbzpn7M7bZ5X4NF32gxvhvRAOLQfOC20JxvE3s4DwG2e2pCMQsW\n xMiCNJlUFxjkcLtsdpN2Q82QDbpoM1IerKISAdtZb2Ebf+yl62rP0UP7qD9vXLTTghYjPw+boOH\n i2IcywMTUEKUq4UYJ+8NgPoqsl43PqrOaab9Gx3qsLywa+qUDXx3+txhE5sbfwBk83liNb+9Thx\n HoJomGd/Vd2Q/PvMnyxJ1IImCD28O/cP7/24z5qXQltmUYaBM8furmxbQWNmWiwBw/flBHQKogd\n o42F2t6BUNxFYM0Koplzh870VvgRxRau7dsebvUWCcE5letdFmvTfN/JDNGbb7PVQCbSElL7hMZ\n 3lHZdQPkGITAvj42TskUhBC5U/fJTLS7OcaNjbC81F3zI3J0mmFC3uRH8LgPO00NcLxyRMvVVJX\n yFZeIbNesPeog/w==", "X-Developer-Key": "i=marcandre.lureau@redhat.com; a=openpgp;\n fpr=87A9BD933F87C606D276F62DDAE8E10975969CE5", "X-Scanned-By": "MIMEDefang 3.4.1 on 10.30.177.4", "Received-SPF": "pass client-ip=170.10.133.124;\n envelope-from=marcandre.lureau@redhat.com;\n helo=us-smtp-delivery-124.mimecast.com", "X-Spam_score_int": "-25", "X-Spam_score": "-2.6", "X-Spam_bar": "--", "X-Spam_report": "(-2.6 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.54,\n DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=0.001,\n RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001,\n SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no", "X-Spam_action": "no action", "X-BeenThere": "qemu-devel@nongnu.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "qemu development <qemu-devel.nongnu.org>", "List-Unsubscribe": "<https://lists.nongnu.org/mailman/options/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>", "List-Archive": "<https://lists.nongnu.org/archive/html/qemu-devel>", "List-Post": "<mailto:qemu-devel@nongnu.org>", "List-Help": "<mailto:qemu-devel-request@nongnu.org?subject=help>", "List-Subscribe": "<https://lists.nongnu.org/mailman/listinfo/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=subscribe>", "Errors-To": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org", "Sender": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org" }, "content": "Have the character rendering function operate on QemuVT100 directly\ninstead of taking a QemuConsole and extracting the VT100 state\ninternally. This decouples glyph rendering from the console object,\ncontinuing the QemuVT100 abstraction introduced in the previous commits.\n\nReviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>\nSigned-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>\n---\n ui/console-vc.c | 17 ++++++++---------\n 1 file changed, 8 insertions(+), 9 deletions(-)", "diff": "diff --git a/ui/console-vc.c b/ui/console-vc.c\nindex 267620689e4..cf087c64fb2 100644\n--- a/ui/console-vc.c\n+++ b/ui/console-vc.c\n@@ -157,14 +157,13 @@ static void image_bitblt(pixman_image_t *image,\n xs, ys, 0, 0, xd, yd, w, h);\n }\n \n-static void vga_putcharxy(QemuConsole *s, int x, int y, int ch,\n- TextAttributes *t_attrib)\n+static void vt100_putcharxy(QemuVT100 *vt, int x, int y, int ch,\n+ TextAttributes *t_attrib)\n {\n static pixman_image_t *glyphs[256];\n- pixman_image_t *image = QEMU_TEXT_CONSOLE(s)->vt.image;\n pixman_color_t fgcol, bgcol;\n \n- assert(image);\n+ assert(vt->image);\n if (t_attrib->invers) {\n bgcol = color_table_rgb[t_attrib->bold][t_attrib->fgcol];\n fgcol = color_table_rgb[t_attrib->bold][t_attrib->bgcol];\n@@ -176,7 +175,7 @@ static void vga_putcharxy(QemuConsole *s, int x, int y, int ch,\n if (!glyphs[ch]) {\n glyphs[ch] = qemu_pixman_glyph_from_vgafont(FONT_HEIGHT, vgafont16, ch);\n }\n- qemu_pixman_glyph_render(glyphs[ch], image,\n+ qemu_pixman_glyph_render(glyphs[ch], vt->image,\n &fgcol, &bgcol, x, y, FONT_WIDTH, FONT_HEIGHT);\n }\n \n@@ -219,9 +218,9 @@ static void console_show_cursor(QemuTextConsole *s, int show)\n if (show && cursor_visible_phase) {\n TextAttributes t_attrib = TEXT_ATTRIBUTES_DEFAULT;\n t_attrib.invers = !(t_attrib.invers); /* invert fg and bg */\n- vga_putcharxy(QEMU_CONSOLE(s), x, y, c->ch, &t_attrib);\n+ vt100_putcharxy(&s->vt, x, y, c->ch, &t_attrib);\n } else {\n- vga_putcharxy(QEMU_CONSOLE(s), x, y, c->ch, &(c->t_attrib));\n+ vt100_putcharxy(&s->vt, x, y, c->ch, &(c->t_attrib));\n }\n invalidate_xy(s, x, y);\n }\n@@ -247,7 +246,7 @@ static void console_refresh(QemuTextConsole *s)\n for (y = 0; y < vt->height; y++) {\n c = vt->cells + y1 * vt->width;\n for (x = 0; x < vt->width; x++) {\n- vga_putcharxy(QEMU_CONSOLE(s), x, y, c->ch,\n+ vt100_putcharxy(vt, x, y, c->ch,\n &(c->t_attrib));\n c++;\n }\n@@ -593,7 +592,7 @@ static void vc_update_xy(VCChardev *vc, int x, int y)\n x = vt->width - 1;\n }\n c = &vt->cells[y1 * vt->width + x];\n- vga_putcharxy(QEMU_CONSOLE(s), x, y2, c->ch,\n+ vt100_putcharxy(vt, x, y2, c->ch,\n &(c->t_attrib));\n invalidate_xy(s, x, y2);\n }\n", "prefixes": [ "v2", "15/67" ] }