Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/1.1/patches/2222082/?format=api
{ "id": 2222082, "url": "http://patchwork.ozlabs.org/api/1.1/patches/2222082/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20260410-qemu-vnc-v2-20-231416f76dc3@redhat.com/", "project": { "id": 14, "url": "http://patchwork.ozlabs.org/api/1.1/projects/14/?format=api", "name": "QEMU Development", "link_name": "qemu-devel", "list_id": "qemu-devel.nongnu.org", "list_email": "qemu-devel@nongnu.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20260410-qemu-vnc-v2-20-231416f76dc3@redhat.com>", "date": "2026-04-10T19:18:42", "name": "[v2,20/67] ui/console-vc: move cursor blinking logic into VT100 layer", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "bcb878ad1588a6f42ad6e6a5ff6ebebcb14d21f6", "submitter": { "id": 66774, "url": "http://patchwork.ozlabs.org/api/1.1/people/66774/?format=api", "name": "Marc-André Lureau", "email": "marcandre.lureau@redhat.com" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20260410-qemu-vnc-v2-20-231416f76dc3@redhat.com/mbox/", "series": [ { "id": 499494, "url": "http://patchwork.ozlabs.org/api/1.1/series/499494/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/list/?series=499494", "date": "2026-04-10T19:18:23", "name": "ui: add standalone VNC server over D-Bus", "version": 2, "mbox": "http://patchwork.ozlabs.org/series/499494/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/2222082/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/2222082/checks/", "tags": {}, "headers": { "Return-Path": "<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@legolas.ozlabs.org", "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256\n header.s=mimecast20190719 header.b=IJMjoJxM;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)" ], "Received": [ "from lists.gnu.org (lists1p.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fsmqz00Q3z1y2d\n\tfor <incoming@patchwork.ozlabs.org>; Sat, 11 Apr 2026 05:21:18 +1000 (AEST)", "from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from <qemu-devel-bounces@nongnu.org>)\n\tid 1wBHPn-0006TS-Cy; Fri, 10 Apr 2026 15:21:15 -0400", "from eggs.gnu.org ([2001:470:142:3::10])\n by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <marcandre.lureau@redhat.com>)\n id 1wBHPY-0005Qx-1W\n for qemu-devel@nongnu.org; Fri, 10 Apr 2026 15:21:03 -0400", "from us-smtp-delivery-124.mimecast.com ([170.10.133.124])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <marcandre.lureau@redhat.com>)\n id 1wBHPV-0001YU-Ui\n for qemu-devel@nongnu.org; Fri, 10 Apr 2026 15:20:59 -0400", "from mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com\n (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by\n relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3,\n cipher=TLS_AES_256_GCM_SHA384) id us-mta-442-EIFxwp4OP1GJH1JKv9NcDg-1; Fri,\n 10 Apr 2026 15:20:56 -0400", "from mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com\n (mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.4])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest\n SHA256)\n (No client certificate requested)\n by mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS\n id 3D8DA195608D\n for <qemu-devel@nongnu.org>; Fri, 10 Apr 2026 19:20:55 +0000 (UTC)", "from localhost (unknown [10.44.22.4])\n by mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP\n id 1BA913000C16; Fri, 10 Apr 2026 19:20:53 +0000 (UTC)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n s=mimecast20190719; t=1775848857;\n h=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n to:to:cc:cc:mime-version:mime-version:content-type:content-type:\n content-transfer-encoding:content-transfer-encoding:\n in-reply-to:in-reply-to:references:references;\n bh=GJtPVEml1iOK2+K7tckw0IWuMjNfHvInu91vVbDRD40=;\n b=IJMjoJxMZZMM9xI/77POhJkmO1MiHAsBxL/riCiQEgsVP4LnJP8ekDkOolD3hiOhJd8lci\n u+zC2oIjU7Q4lZMsULAxWU4TIqhi0r34UxQHoAOfwaQ5hSIAiOcdWMFdBgqNewcIlXnr9T\n Q8N+DpPy7NkHw/mTfV6Fok8sGeqrAiM=", "X-MC-Unique": "EIFxwp4OP1GJH1JKv9NcDg-1", "X-Mimecast-MFC-AGG-ID": "EIFxwp4OP1GJH1JKv9NcDg_1775848855", "From": "=?utf-8?q?Marc-Andr=C3=A9_Lureau?= <marcandre.lureau@redhat.com>", "Date": "Fri, 10 Apr 2026 23:18:42 +0400", "Subject": "[PATCH v2 20/67] ui/console-vc: move cursor blinking logic into\n VT100 layer", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"utf-8\"", "Content-Transfer-Encoding": "8bit", "Message-Id": "<20260410-qemu-vnc-v2-20-231416f76dc3@redhat.com>", "References": "<20260410-qemu-vnc-v2-0-231416f76dc3@redhat.com>", "In-Reply-To": "<20260410-qemu-vnc-v2-0-231416f76dc3@redhat.com>", "To": "qemu-devel@nongnu.org", "Cc": "=?utf-8?q?Marc-Andr=C3=A9_Lureau?= <marcandre.lureau@redhat.com>", "X-Developer-Signature": "v=1; a=openpgp-sha256; l=5150;\n i=marcandre.lureau@redhat.com; h=from:subject:message-id;\n bh=THg3kb3eky9MQNSqzzOIG7g/WozpZqAHz7OdHuv3imo=;\n b=kA0DAAoB2ujhCXWWnOUByyZiAGnZTRSix9Nz3xQgMaMgO+PKBvxcrO7zsLK3O1s5aVYSstfyB\n 4kCMwQAAQoAHRYhBIepvZM/h8YG0nb2Ldro4Ql1lpzlBQJp2U0UAAoJENro4Ql1lpzl7joP/jCu\n aJXbvew5GD+IMbRIrXTLZnImIhQgFaEMzci/Erq7eopbI0VqPZAyfJmO41ZR0n1MSe58pQC/ujj\n VEWepK6foHCrpPQ8g/AXAeFB5BZT8b9z1ll8SBvLYwMw1h1T/Y6QgPPon2z/uhdvrBqfIFySzf2\n OQutk/tqETjJ8KdC9PJ8L5rHEDXQvRaCTVkTvGPP/bgfe56sMp/u7AiIoo/qJZf0LtnYkMla9o2\n ZK/rcUdIgaHrGWWHEoHQ3Kcc6g/8OfpyN183Rr8xT2Zbq/89ZDKIntLpMskiFCZwsrUiOCU/r8x\n S420v0yNm3TqjGe/EepNJ3WjYLemgP90k/4QSlRw+mlmDC7i/Ps5v8oPIp9g+Q6wyq0ysDz5H//\n iwraXfz9cS9QragNShIhYZv1lpus8zKoUhCXDAofwdMwpQ70kDBya4FncWdH8Se2FDWSuI139Y8\n rII3BxKxQIsWzU0xw8Ecso2MwSpbDxYgougncF0WiSUM40gJsUEBm+9zhse+QBGWqEq59DbOMK4\n 9QmoVgUjhqwjkzMRgotD5wSSl/qHOmNH4euQF4gampQFsPuAlN0H33mr5MqN7yNjOUOGvPDVoLs\n ooo+JPK8PwsT+pZXY6k9cWddOwo1yTXjZSucnqcGowXbNyAfJu7d5gj1r5+rjIX0JlZivf+FnOX\n XTij5", "X-Developer-Key": "i=marcandre.lureau@redhat.com; a=openpgp;\n fpr=87A9BD933F87C606D276F62DDAE8E10975969CE5", "X-Scanned-By": "MIMEDefang 3.4.1 on 10.30.177.4", "Received-SPF": "pass client-ip=170.10.133.124;\n envelope-from=marcandre.lureau@redhat.com;\n helo=us-smtp-delivery-124.mimecast.com", "X-Spam_score_int": "7", "X-Spam_score": "0.7", "X-Spam_bar": "/", "X-Spam_report": "(0.7 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.54,\n DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=0.001, RCVD_IN_SBL_CSS=3.335,\n RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001,\n SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no", "X-Spam_action": "no action", "X-BeenThere": "qemu-devel@nongnu.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "qemu development <qemu-devel.nongnu.org>", "List-Unsubscribe": "<https://lists.nongnu.org/mailman/options/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>", "List-Archive": "<https://lists.nongnu.org/archive/html/qemu-devel>", "List-Post": "<mailto:qemu-devel@nongnu.org>", "List-Help": "<mailto:qemu-devel-request@nongnu.org?subject=help>", "List-Subscribe": "<https://lists.nongnu.org/mailman/listinfo/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=subscribe>", "Errors-To": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org", "Sender": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org" }, "content": "Maintain a list of QemuVT100 instances so the cursor timer can directly\niterate over them and call vt100_refresh(), instead of going through\nqemu_invalidate_text_consoles() which iterated over all consoles\n(including graphic ones) and called back into the generic display layer.\n\nThis removes the qemu_invalidate_text_consoles() function from\nconsole.c, further decoupling VT100 text rendering from the console\ncore.\n\nSigned-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>\n---\n include/ui/console.h | 1 -\n ui/console-priv.h | 2 +-\n ui/console-vc-stubs.c | 2 +-\n ui/console-vc.c | 28 +++++++++++++++++++++++-----\n ui/console.c | 19 +------------------\n 5 files changed, 26 insertions(+), 26 deletions(-)", "diff": "diff --git a/include/ui/console.h b/include/ui/console.h\nindex 395a723e318..5b5bba46ec2 100644\n--- a/include/ui/console.h\n+++ b/include/ui/console.h\n@@ -416,7 +416,6 @@ void qemu_console_set_window_id(QemuConsole *con, int window_id);\n void qemu_console_resize(QemuConsole *con, int width, int height);\n DisplaySurface *qemu_console_surface(QemuConsole *con);\n void coroutine_fn qemu_console_co_wait_update(QemuConsole *con);\n-int qemu_invalidate_text_consoles(void);\n \n /* console-gl.c */\n #ifdef CONFIG_OPENGL\ndiff --git a/ui/console-priv.h b/ui/console-priv.h\nindex 2c2cfd99570..8bcdb79d914 100644\n--- a/ui/console-priv.h\n+++ b/ui/console-priv.h\n@@ -36,7 +36,7 @@ struct QemuConsole {\n };\n \n void qemu_text_console_update_size(QemuTextConsole *c);\n-void qemu_text_console_update_cursor(void);\n+void vt100_update_cursor(void);\n void qemu_text_console_handle_keysym(QemuTextConsole *s, int keysym);\n \n #endif\ndiff --git a/ui/console-vc-stubs.c b/ui/console-vc-stubs.c\nindex 8a7f19c1f44..d911a82f263 100644\n--- a/ui/console-vc-stubs.c\n+++ b/ui/console-vc-stubs.c\n@@ -14,7 +14,7 @@ void qemu_text_console_update_size(QemuTextConsole *c)\n {\n }\n \n-void qemu_text_console_update_cursor(void)\n+void vt100_update_cursor(void)\n {\n }\n \ndiff --git a/ui/console-vc.c b/ui/console-vc.c\nindex d46dcb6a678..6694c5082f8 100644\n--- a/ui/console-vc.c\n+++ b/ui/console-vc.c\n@@ -8,6 +8,7 @@\n #include \"qapi/error.h\"\n #include \"qemu/fifo8.h\"\n #include \"qemu/option.h\"\n+#include \"qemu/queue.h\"\n #include \"ui/console.h\"\n #include \"ui/cp437.h\"\n \n@@ -69,8 +70,13 @@ struct QemuVT100 {\n int update_y0;\n int update_x1;\n int update_y1;\n+\n+ QTAILQ_ENTRY(QemuVT100) list;\n };\n \n+static QTAILQ_HEAD(QemuVT100Head, QemuVT100) vt100s =\n+ QTAILQ_HEAD_INITIALIZER(vt100s);\n+\n typedef struct QemuTextConsole {\n QemuConsole parent;\n \n@@ -1103,20 +1109,28 @@ static int vc_chr_write(Chardev *chr, const uint8_t *buf, int len)\n return len;\n }\n \n-void qemu_text_console_update_cursor(void)\n+void vt100_update_cursor(void)\n {\n+ QemuVT100 *vt;\n+\n cursor_visible_phase = !cursor_visible_phase;\n \n- if (qemu_invalidate_text_consoles()) {\n- timer_mod(cursor_timer,\n- qemu_clock_get_ms(QEMU_CLOCK_REALTIME) + CONSOLE_CURSOR_PERIOD / 2);\n+ if (QTAILQ_EMPTY(&vt100s)) {\n+ return;\n+ }\n+\n+ QTAILQ_FOREACH(vt, &vt100s, list) {\n+ vt100_refresh(vt);\n }\n+\n+ timer_mod(cursor_timer,\n+ qemu_clock_get_ms(QEMU_CLOCK_REALTIME) + CONSOLE_CURSOR_PERIOD / 2);\n }\n \n static void\n cursor_timer_cb(void *opaque)\n {\n- qemu_text_console_update_cursor();\n+ vt100_update_cursor();\n }\n \n static void text_console_invalidate(void *opaque)\n@@ -1132,6 +1146,9 @@ static void text_console_invalidate(void *opaque)\n static void\n qemu_text_console_finalize(Object *obj)\n {\n+ QemuTextConsole *s = QEMU_TEXT_CONSOLE(obj);\n+\n+ QTAILQ_REMOVE(&vt100s, &s->vt, list);\n }\n \n static void\n@@ -1156,6 +1173,7 @@ qemu_text_console_init(Object *obj)\n {\n QemuTextConsole *c = QEMU_TEXT_CONSOLE(obj);\n \n+ QTAILQ_INSERT_HEAD(&vt100s, &c->vt, list);\n fifo8_create(&c->out_fifo, 16);\n c->vt.total_height = DEFAULT_BACKSCROLL;\n QEMU_CONSOLE(c)->hw_ops = &text_console_ops;\ndiff --git a/ui/console.c b/ui/console.c\nindex 24e4761e1f9..8af1dee0e22 100644\n--- a/ui/console.c\n+++ b/ui/console.c\n@@ -752,7 +752,7 @@ void register_displaychangelistener(DisplayChangeListener *dcl)\n } else if (QEMU_IS_TEXT_CONSOLE(dcl->con)) {\n qemu_text_console_update_size(QEMU_TEXT_CONSOLE(dcl->con));\n }\n- qemu_text_console_update_cursor();\n+ vt100_update_cursor();\n }\n \n void update_displaychangelistener(DisplayChangeListener *dcl,\n@@ -1457,23 +1457,6 @@ int qemu_console_get_height(QemuConsole *con, int fallback)\n }\n }\n \n-int qemu_invalidate_text_consoles(void)\n-{\n- QemuConsole *s;\n- int count = 0;\n-\n- QTAILQ_FOREACH(s, &consoles, next) {\n- if (qemu_console_is_graphic(s) ||\n- !qemu_console_is_visible(s)) {\n- continue;\n- }\n- count++;\n- graphic_hw_invalidate(s);\n- }\n-\n- return count;\n-}\n-\n void qemu_console_resize(QemuConsole *s, int width, int height)\n {\n DisplaySurface *surface = qemu_console_surface(s);\n", "prefixes": [ "v2", "20/67" ] }