Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/1.1/patches/2222074/?format=api
{ "id": 2222074, "url": "http://patchwork.ozlabs.org/api/1.1/patches/2222074/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20260410-qemu-vnc-v2-5-231416f76dc3@redhat.com/", "project": { "id": 14, "url": "http://patchwork.ozlabs.org/api/1.1/projects/14/?format=api", "name": "QEMU Development", "link_name": "qemu-devel", "list_id": "qemu-devel.nongnu.org", "list_email": "qemu-devel@nongnu.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20260410-qemu-vnc-v2-5-231416f76dc3@redhat.com>", "date": "2026-04-10T19:18:27", "name": "[v2,05/67] ui/vnc-jobs: remove vnc_queue_clear()", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "af005f1b8a771163eb320ab0dd34bcce2540bdd7", "submitter": { "id": 66774, "url": "http://patchwork.ozlabs.org/api/1.1/people/66774/?format=api", "name": "Marc-André Lureau", "email": "marcandre.lureau@redhat.com" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20260410-qemu-vnc-v2-5-231416f76dc3@redhat.com/mbox/", "series": [ { "id": 499494, "url": "http://patchwork.ozlabs.org/api/1.1/series/499494/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/list/?series=499494", "date": "2026-04-10T19:18:23", "name": "ui: add standalone VNC server over D-Bus", "version": 2, "mbox": "http://patchwork.ozlabs.org/series/499494/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/2222074/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/2222074/checks/", "tags": {}, "headers": { "Return-Path": "<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@legolas.ozlabs.org", "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256\n header.s=mimecast20190719 header.b=RaJjVn3e;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)" ], "Received": [ "from lists.gnu.org (lists1p.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fsmpm47Tbz20HT\n\tfor <incoming@patchwork.ozlabs.org>; Sat, 11 Apr 2026 05:20:16 +1000 (AEST)", "from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from <qemu-devel-bounces@nongnu.org>)\n\tid 1wBHO7-0002OD-IC; Fri, 10 Apr 2026 15:19:31 -0400", "from eggs.gnu.org ([2001:470:142:3::10])\n by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <marcandre.lureau@redhat.com>)\n id 1wBHO5-0002Ne-MN\n for qemu-devel@nongnu.org; Fri, 10 Apr 2026 15:19:29 -0400", "from us-smtp-delivery-124.mimecast.com ([170.10.133.124])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <marcandre.lureau@redhat.com>)\n id 1wBHO4-0000S1-DY\n for qemu-devel@nongnu.org; Fri, 10 Apr 2026 15:19:29 -0400", "from mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com\n (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by\n relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3,\n cipher=TLS_AES_256_GCM_SHA384) id us-mta-44-vO80eM5qMpGfWVfZrSApQQ-1; Fri,\n 10 Apr 2026 15:19:26 -0400", "from mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com\n (mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.4])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest\n SHA256)\n (No client certificate requested)\n by mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS\n id 294E3195D03E\n for <qemu-devel@nongnu.org>; Fri, 10 Apr 2026 19:19:24 +0000 (UTC)", "from localhost (unknown [10.44.22.4])\n by mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP\n id EC6003000C1D; Fri, 10 Apr 2026 19:19:22 +0000 (UTC)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n s=mimecast20190719; t=1775848767;\n h=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n to:to:cc:cc:mime-version:mime-version:content-type:content-type:\n content-transfer-encoding:content-transfer-encoding:\n in-reply-to:in-reply-to:references:references;\n bh=ROmzbrl3g/helr+i5FS/DorPr+JmvWFeR0/3EHyzpto=;\n b=RaJjVn3eX147oqCa17qfZ3oO9wwRvCr5Eq7WaH92bxo0uYx+vA35ltNWfUN+IVCMEqOjiM\n MnSMiOa9rlWkHPmdHoW1RBCe7Oscxz7g4+1PjTpMSkqnBdFTf+cTyy+u9FwiykPsuZPec1\n OnYeNB8sSA+fg07ZquiejwUIJpN7HB4=", "X-MC-Unique": "vO80eM5qMpGfWVfZrSApQQ-1", "X-Mimecast-MFC-AGG-ID": "vO80eM5qMpGfWVfZrSApQQ_1775848765", "From": "=?utf-8?q?Marc-Andr=C3=A9_Lureau?= <marcandre.lureau@redhat.com>", "Date": "Fri, 10 Apr 2026 23:18:27 +0400", "Subject": "[PATCH v2 05/67] ui/vnc-jobs: remove vnc_queue_clear()", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"utf-8\"", "Content-Transfer-Encoding": "8bit", "Message-Id": "<20260410-qemu-vnc-v2-5-231416f76dc3@redhat.com>", "References": "<20260410-qemu-vnc-v2-0-231416f76dc3@redhat.com>", "In-Reply-To": "<20260410-qemu-vnc-v2-0-231416f76dc3@redhat.com>", "To": "qemu-devel@nongnu.org", "Cc": "=?utf-8?q?Marc-Andr=C3=A9_Lureau?= <marcandre.lureau@redhat.com>,\n\t=?utf-8?q?Daniel_P=2E_Berrang=C3=A9?= <berrange@redhat.com>", "X-Developer-Signature": "v=1; a=openpgp-sha256; l=1255;\n i=marcandre.lureau@redhat.com; h=from:subject:message-id;\n bh=Qyc2bReAPSXL8Tu4TqrZ5PYPjMmPgsbSEM8+ZDWFQ8Q=;\n b=owEBbQKS/ZANAwAKAdro4Ql1lpzlAcsmYgBp2U0TcAMQRTArg5i3X9RzaNGMtsasVL0Ux8HY3\n fnG2V/1aVSJAjMEAAEKAB0WIQSHqb2TP4fGBtJ29i3a6OEJdZac5QUCadlNEwAKCRDa6OEJdZac\n 5a3MD/9DZfaOdJNQpTLK4CIhE7F7Aua1exC+ycY6Udu21QKvWMQELQGi/QGR4eZi05W3JlOiTzK\n Qn31eL8YqBm7J7Uo/scZEmZtcwG3Qfp5fZu0HU4V5mcUBH/wpWQG7jEqys9/f9/wf78xp4vtUx8\n lzvJzXd7oKZAnsmjlJcZC+7FfZC51WIfLdbEpi0Snil8Wt3e31tIH7LhLMUVxBV10qHBM8zRhnB\n SdhVo+jPXpdpFhIByv12I1jraSu1tuzo0o/i1jstdAI0cfNPz2TIAHMPv6daKbkyhDY0CqbJ540\n UP+8cSg/tpS1B4VUesoT/ZK4gkg3F55MIylXbTmSFmVVVEC23tQQuouS7GcYCnfTVEtTIMB7gWV\n XsuTt753AGMvZscIEstM0vreoG+QGEPe20ygDQys5JPnyj2WJE7w8D/W2BpweBAz8KlAfI+Ejrh\n uxqDTHzBVsP3ZXj4K3tR0aQ3LItPzNMeANh5SEI9hjRpyTi3b2UkVcJqJ4x2mkBsd5hEg3BzObI\n 5JLTCwltxhBg9DVx02Zby/QPfKkTYpbraePTf4HYCE+BZNgjj9e6UvPHqZBtQZvAxDYChV9kUrA\n 4ATe/JLCN8Po6QmmFoMz7ggDvIw7bZsE+G7FVvRJrEWVbIvgjMAQgtb5J/FORLD0Ay3778ij1DY\n DR2p3cVf00bRt7Q==", "X-Developer-Key": "i=marcandre.lureau@redhat.com; a=openpgp;\n fpr=87A9BD933F87C606D276F62DDAE8E10975969CE5", "X-Scanned-By": "MIMEDefang 3.4.1 on 10.30.177.4", "Received-SPF": "pass client-ip=170.10.133.124;\n envelope-from=marcandre.lureau@redhat.com;\n helo=us-smtp-delivery-124.mimecast.com", "X-Spam_score_int": "7", "X-Spam_score": "0.7", "X-Spam_bar": "/", "X-Spam_report": "(0.7 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.54,\n DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=0.001, RCVD_IN_SBL_CSS=3.335,\n RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001,\n SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no", "X-Spam_action": "no action", "X-BeenThere": "qemu-devel@nongnu.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "qemu development <qemu-devel.nongnu.org>", "List-Unsubscribe": "<https://lists.nongnu.org/mailman/options/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>", "List-Archive": "<https://lists.nongnu.org/archive/html/qemu-devel>", "List-Post": "<mailto:qemu-devel@nongnu.org>", "List-Help": "<mailto:qemu-devel-request@nongnu.org?subject=help>", "List-Subscribe": "<https://lists.nongnu.org/mailman/listinfo/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=subscribe>", "Errors-To": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org", "Sender": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org" }, "content": "The function was never called, since the worker thread was never\nexiting. Also it was incomplete (not clearing pending job list) and\nmixing global queue and argument. Let's remove it.\n\nNote: maybe the worker thread could be torn down when vnc_jobs_join()\nrealizes there is no job left.\n\nReviewed-by: Daniel P. Berrangé <berrange@redhat.com>\nSigned-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>\n---\n ui/vnc-jobs.c | 10 +---------\n 1 file changed, 1 insertion(+), 9 deletions(-)", "diff": "diff --git a/ui/vnc-jobs.c b/ui/vnc-jobs.c\nindex 9e536b07b90..28a4738f1ec 100644\n--- a/ui/vnc-jobs.c\n+++ b/ui/vnc-jobs.c\n@@ -345,14 +345,6 @@ static VncJobQueue *vnc_queue_init(void)\n return queue;\n }\n \n-static void vnc_queue_clear(VncJobQueue *q)\n-{\n- qemu_cond_destroy(&queue->cond);\n- qemu_mutex_destroy(&queue->mutex);\n- g_free(q);\n- queue = NULL; /* Unset global queue */\n-}\n-\n static void *vnc_worker_thread(void *arg)\n {\n VncJobQueue *queue = arg;\n@@ -360,7 +352,7 @@ static void *vnc_worker_thread(void *arg)\n qemu_thread_get_self(&queue->thread);\n \n while (!vnc_worker_thread_loop(queue)) ;\n- vnc_queue_clear(queue);\n+ g_assert_not_reached();\n return NULL;\n }\n \n", "prefixes": [ "v2", "05/67" ] }