Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/1.1/patches/2222039/?format=api
{ "id": 2222039, "url": "http://patchwork.ozlabs.org/api/1.1/patches/2222039/?format=api", "web_url": "http://patchwork.ozlabs.org/project/linux-mtd/patch/20260410-winbond-6-19-rc1-oddr-v1-1-2ac4827a3868@bootlin.com/", "project": { "id": 3, "url": "http://patchwork.ozlabs.org/api/1.1/projects/3/?format=api", "name": "Linux MTD development", "link_name": "linux-mtd", "list_id": "linux-mtd.lists.infradead.org", "list_email": "linux-mtd@lists.infradead.org", "web_url": null, "scm_url": null, "webscm_url": null }, "msgid": "<20260410-winbond-6-19-rc1-oddr-v1-1-2ac4827a3868@bootlin.com>", "date": "2026-04-10T17:41:01", "name": "[1/5] spi: cadence-qspi: Revert the filtering of certain opcodes in ODTR", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "0b9ffcf5b03ec24a7a8e4f2d6be3633704bc7b45", "submitter": { "id": 73368, "url": "http://patchwork.ozlabs.org/api/1.1/people/73368/?format=api", "name": "Miquel Raynal", "email": "miquel.raynal@bootlin.com" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/linux-mtd/patch/20260410-winbond-6-19-rc1-oddr-v1-1-2ac4827a3868@bootlin.com/mbox/", "series": [ { "id": 499489, "url": "http://patchwork.ozlabs.org/api/1.1/series/499489/?format=api", "web_url": "http://patchwork.ozlabs.org/project/linux-mtd/list/?series=499489", "date": "2026-04-10T17:41:01", "name": "mtd/spi: Fix Winbond W35N02JW / W35N04JW support", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/499489/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/2222039/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/2222039/checks/", "tags": {}, "headers": { "Return-Path": "\n <linux-mtd-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@legolas.ozlabs.org", "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n secure) header.d=lists.infradead.org header.i=@lists.infradead.org\n header.a=rsa-sha256 header.s=bombadil.20210309 header.b=jo160K4h;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n unprotected) header.d=bootlin.com header.i=@bootlin.com header.a=rsa-sha256\n header.s=dkim header.b=xCTfkMry;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=none (no SPF record) smtp.mailfrom=lists.infradead.org\n (client-ip=2607:7c80:54:3::133; helo=bombadil.infradead.org;\n envelope-from=linux-mtd-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org;\n receiver=patchwork.ozlabs.org)" ], "Received": [ "from bombadil.infradead.org (bombadil.infradead.org\n [IPv6:2607:7c80:54:3::133])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fskcm6L3kz1y2d\n\tfor <incoming@patchwork.ozlabs.org>; Sat, 11 Apr 2026 03:41:28 +1000 (AEST)", "from localhost ([::1] helo=bombadil.infradead.org)\n\tby bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux))\n\tid 1wBFr8-0000000CdRO-44KG;\n\tFri, 10 Apr 2026 17:41:22 +0000", "from smtpout-03.galae.net ([185.246.85.4])\n\tby bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux))\n\tid 1wBFr5-0000000CdPf-0X4k\n\tfor linux-mtd@lists.infradead.org;\n\tFri, 10 Apr 2026 17:41:21 +0000", "from smtpout-01.galae.net (smtpout-01.galae.net [212.83.139.233])\n\tby smtpout-03.galae.net (Postfix) with ESMTPS id 26D914E429B3;\n\tFri, 10 Apr 2026 17:41:17 +0000 (UTC)", "from mail.galae.net (mail.galae.net [212.83.136.155])\n\tby smtpout-01.galae.net (Postfix) with ESMTPS id F3378603F0;\n\tFri, 10 Apr 2026 17:41:16 +0000 (UTC)", "from [127.0.0.1] (localhost [127.0.0.1]) by localhost (Mailerdaemon)\n with ESMTPSA id F281010450082;\n\tFri, 10 Apr 2026 19:41:14 +0200 (CEST)" ], "DKIM-Signature": [ "v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;\n\td=lists.infradead.org; s=bombadil.20210309; h=Sender:\n\tContent-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post:\n\tList-Archive:List-Unsubscribe:List-Id:Cc:To:In-Reply-To:References:Message-Id\n\t:MIME-Version:Subject:Date:From:Reply-To:Content-ID:Content-Description:\n\tResent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:\n\tList-Owner; bh=rH6lEMcmmWIxq96pZMf3n5f5oimC3u8ofxQjo9MtN4c=; b=jo160K4hJ1S6lS\n\tTfv87RVV9m6cMbRLPNu+KsEQxAA23B3//lbaTY0QQEfBhTqV8n5fI6KbXNCp2rIeVe623spSGgLv7\n\tAtc2yE0+g0uLuT6plK8d7fZJ7knfSh1KBMQpnFFsdvMeks62PO/4VuvQw588VoxAR2QBCfVEhVHpO\n\t9+cVT0jWjZc6/uWc887WrwK9fNjeSFGawEgkW2Aaaiqq/ucpGeDf9ZWYrJK4aql/4/nmPZu8bCAr1\n\tEH/MIWrNH4szuS3qj4whrZsFSp+S0mfNyXFP9nIR8q3Ss9S+1ufqBB2IjGu5BiW/bWRWRHFrba/vc\n\tMSTnrZs72JJNy02nEccw==;", "v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=dkim;\n\tt=1775842876; h=from:subject:date:message-id:to:cc:mime-version:content-type:\n\t content-transfer-encoding:in-reply-to:references;\n\tbh=KwQcWNOtwSww1tE4Ej8T9s6pqrHBg9EZ9z5kc47zF+c=;\n\tb=xCTfkMrymL7P7nBQyGQfECaGcvz4IFCFaydu29//TvtvzOMR/p6/NZbHpKfUoI+rHF5seq\n\tE4svM5ZGM/TArGt1N8OV6wV7MxYQ0JtdS/FWVjtqgGScjfOghwarKUM1qPmAXkVQfGAyfj\n\tpYHHo+XGDhKl6bLmGj9Ot9FtHjcD0LqFLqSYVhzyvBYHNqBwugPMtTHstiVI8LylpKLbA0\n\tTKxV/3dGFRzOG/aghhRLcIMxR8sIRwKKWg83mYfjDIqr1tqrEMLY6VswGCPc6tfZ6mJ8/M\n\tbuMw+mygFJzGPeDkrrNU1mUd1FRe8Xh8Bnbn3fM9t7QqDd1v/rW5389uFSRJtw==" ], "From": "Miquel Raynal <miquel.raynal@bootlin.com>", "Date": "Fri, 10 Apr 2026 19:41:01 +0200", "Subject": "[PATCH 1/5] spi: cadence-qspi: Revert the filtering of certain\n opcodes in ODTR", "MIME-Version": "1.0", "Message-Id": "<20260410-winbond-6-19-rc1-oddr-v1-1-2ac4827a3868@bootlin.com>", "References": "<20260410-winbond-6-19-rc1-oddr-v1-0-2ac4827a3868@bootlin.com>", "In-Reply-To": "<20260410-winbond-6-19-rc1-oddr-v1-0-2ac4827a3868@bootlin.com>", "To": "Mark Brown <broonie@kernel.org>, Richard Weinberger <richard@nod.at>,\n Vignesh Raghavendra <vigneshr@ti.com>, Pratyush Yadav <pratyush@kernel.org>", "Cc": "Steam Lin <STLin2@winbond.com>,\n Thomas Petazzoni <thomas.petazzoni@bootlin.com>, linux-spi@vger.kernel.org,\n linux-kernel@vger.kernel.org, linux-mtd@lists.infradead.org,\n Miquel Raynal <miquel.raynal@bootlin.com>", "X-Mailer": "b4 0.14.3", "X-Last-TLS-Session-Version": "TLSv1.3", "X-CRM114-Version": "20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 ", "X-CRM114-CacheID": "sfid-20260410_104119_303210_A433213E ", "X-CRM114-Status": "GOOD ( 10.02 )", "X-Spam-Score": "-2.1 (--)", "X-Spam-Report": "Spam detection software,\n running on the system \"bombadil.infradead.org\",\n has NOT identified this incoming email as spam. The original\n message has been attached to this so you can view it or label\n similar future email. If you have any questions, see\n the administrator of that system for details.\n Content preview: I got mislead while analyzing the driver by the fact that\n the second opcode byte was in all cases smashed: if (op->cmd.dtr) opcode =\n op->cmd.opcode >> 8; else opcode = op->cmd.opcode; While at a first glance\n this doesn't let a chance to the second byte to be shifted out on the bus,\n this is actually the second step of an initialization,\n where the byte being\n apparently \"ignored\" in D [...]\n Content analysis details: (-2.1 points, 5.0 required)\n pts rule name description\n ---- ----------------------\n --------------------------------------------------\n 0.0 RCVD_IN_VALIDITY_CERTIFIED_BLOCKED RBL: ADMINISTRATOR NOTICE: The\n query to Validity was blocked. See\n https://knowledge.validity.com/hc/en-us/articles/20961730681243\n for more information.\n [185.246.85.4 listed in\n sa-trusted.bondedsender.org]\n 0.0 RCVD_IN_VALIDITY_SAFE_BLOCKED RBL: ADMINISTRATOR NOTICE: The query to\n Validity was blocked. See\n https://knowledge.validity.com/hc/en-us/articles/20961730681243\n for more information.\n [185.246.85.4 listed in sa-accredit.habeas.com]\n 0.0 RCVD_IN_VALIDITY_RPBL_BLOCKED RBL: ADMINISTRATOR NOTICE: The query to\n Validity was blocked. See\n https://knowledge.validity.com/hc/en-us/articles/20961730681243\n for more information.\n [185.246.85.4 listed in bl.score.senderscore.com]\n -0.0 SPF_PASS SPF: sender matches SPF record\n -0.0 SPF_HELO_PASS SPF: HELO matches SPF record\n -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from\n envelope-from domain\n 0.1 DKIM_SIGNED Message has a DKIM or DK signature,\n not necessarily valid\n -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from\n author's\n domain\n -0.1 DKIM_VALID Message has at least one valid DKIM or DK\n signature\n -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1%\n [score: 0.0000]", "X-BeenThere": "linux-mtd@lists.infradead.org", "X-Mailman-Version": "2.1.34", "Precedence": "list", "List-Id": "Linux MTD discussion mailing list <linux-mtd.lists.infradead.org>", "List-Unsubscribe": "<http://lists.infradead.org/mailman/options/linux-mtd>,\n <mailto:linux-mtd-request@lists.infradead.org?subject=unsubscribe>", "List-Archive": "<http://lists.infradead.org/pipermail/linux-mtd/>", "List-Post": "<mailto:linux-mtd@lists.infradead.org>", "List-Help": "<mailto:linux-mtd-request@lists.infradead.org?subject=help>", "List-Subscribe": "<http://lists.infradead.org/mailman/listinfo/linux-mtd>,\n <mailto:linux-mtd-request@lists.infradead.org?subject=subscribe>", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Sender": "\"linux-mtd\" <linux-mtd-bounces@lists.infradead.org>", "Errors-To": "linux-mtd-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org" }, "content": "I got mislead while analyzing the driver by the fact that the second\nopcode byte was in all cases smashed:\n\n if (op->cmd.dtr)\n opcode = op->cmd.opcode >> 8;\n else\n opcode = op->cmd.opcode;\n\nWhile at a first glance this doesn't let a chance to the second byte to\nbe shifted out on the bus, this is actually the second step of an\ninitialization, where the byte being apparently \"ignored\" in DTR mode\nhas already been written in a dedicated \"extended opcode\" register. As\nsuch, the comment and the extra check that I proposed were entirely\nwrong, remove them.\n\nFixes: bee085476d27 (\"spi: cadence-qspi: Make sure we filter out unsupported ops\")\nSigned-off-by: Miquel Raynal <miquel.raynal@bootlin.com>\n---\nMy apologies for this mistake. Until now I never had to deal with \"non\nrepeated\" opcodes. Now that I do, I realize that this was wrong.\n---\n drivers/spi/spi-cadence-quadspi.c | 4 ----\n 1 file changed, 4 deletions(-)", "diff": "diff --git a/drivers/spi/spi-cadence-quadspi.c b/drivers/spi/spi-cadence-quadspi.c\nindex 649ff55333f0..87e49d913591 100644\n--- a/drivers/spi/spi-cadence-quadspi.c\n+++ b/drivers/spi/spi-cadence-quadspi.c\n@@ -1538,10 +1538,6 @@ static bool cqspi_supports_mem_op(struct spi_mem *mem,\n \t\tif (op->data.nbytes && op->data.buswidth != 8)\n \t\t\treturn false;\n \n-\t\t/* A single opcode is supported, it will be repeated */\n-\t\tif ((op->cmd.opcode >> 8) != (op->cmd.opcode & 0xFF))\n-\t\t\treturn false;\n-\n \t\tif (cqspi->is_rzn1)\n \t\t\treturn false;\n \t} else if (!all_false) {\n", "prefixes": [ "1/5" ] }