Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/1.1/patches/2222030/?format=api
{ "id": 2222030, "url": "http://patchwork.ozlabs.org/api/1.1/patches/2222030/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20260410160458.3778874-8-berrange@redhat.com/", "project": { "id": 14, "url": "http://patchwork.ozlabs.org/api/1.1/projects/14/?format=api", "name": "QEMU Development", "link_name": "qemu-devel", "list_id": "qemu-devel.nongnu.org", "list_email": "qemu-devel@nongnu.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20260410160458.3778874-8-berrange@redhat.com>", "date": "2026-04-10T16:04:48", "name": "[07/17] monitor: use class methods for monitor_vprintf", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "2d1e670841ecf37c4c284a60923bb111829d73d1", "submitter": { "id": 2694, "url": "http://patchwork.ozlabs.org/api/1.1/people/2694/?format=api", "name": "Daniel P. Berrangé", "email": "berrange@redhat.com" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20260410160458.3778874-8-berrange@redhat.com/mbox/", "series": [ { "id": 499483, "url": "http://patchwork.ozlabs.org/api/1.1/series/499483/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/list/?series=499483", "date": "2026-04-10T16:04:41", "name": "monitor: turn QMP and HMP into QOM objects", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/499483/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/2222030/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/2222030/checks/", "tags": {}, "headers": { "Return-Path": "<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@legolas.ozlabs.org", "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256\n header.s=mimecast20190719 header.b=WMHXtbkY;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)" ], "Received": [ "from lists.gnu.org (lists1p.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fshXT1S5wz1yGb\n\tfor <incoming@patchwork.ozlabs.org>; Sat, 11 Apr 2026 02:07:37 +1000 (AEST)", "from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from <qemu-devel-bounces@nongnu.org>)\n\tid 1wBEMi-00049v-9T; Fri, 10 Apr 2026 12:05:52 -0400", "from eggs.gnu.org ([2001:470:142:3::10])\n by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <berrange@redhat.com>)\n id 1wBEMW-00042L-6o\n for qemu-devel@nongnu.org; Fri, 10 Apr 2026 12:05:43 -0400", "from us-smtp-delivery-124.mimecast.com ([170.10.133.124])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <berrange@redhat.com>)\n id 1wBEMT-0006Qp-I6\n for qemu-devel@nongnu.org; Fri, 10 Apr 2026 12:05:39 -0400", "from mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com\n (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by\n relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3,\n cipher=TLS_AES_256_GCM_SHA384) id us-mta-64-_APAEGAtPRirmIKqEcObPw-1; Fri,\n 10 Apr 2026 12:05:33 -0400", "from mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com\n (mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.17])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest\n SHA256)\n (No client certificate requested)\n by mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS\n id 92F981800361; Fri, 10 Apr 2026 16:05:30 +0000 (UTC)", "from toolbx.redhat.corp (headnet01.pony-001.prod.iad2.dc.redhat.com\n [10.2.32.101])\n by mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP\n id 752FB195608E; Fri, 10 Apr 2026 16:05:27 +0000 (UTC)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n s=mimecast20190719; t=1775837135;\n h=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n to:to:cc:cc:mime-version:mime-version:content-type:content-type:\n content-transfer-encoding:content-transfer-encoding:\n in-reply-to:in-reply-to:references:references;\n bh=CvSkhUVa0BQXOqBV5xKSGKJv0S+rk4U3SVFX6QIUiAQ=;\n b=WMHXtbkYvWr55dkjfSSB7J0914j/hdd2gZrTWtZNlF5pPCHDsqQLzXhFuE3hZpY0sTaBnI\n Ix2VOM1xqi5foDKUXh2HfsnXm7fYmJcqRZTnb13RWCWD1MuZ7j7w0hR6U8/webcYikFhDj\n dSJ49yFUbjrO2T74LFBfAPSRkcLRll4=", "X-MC-Unique": "_APAEGAtPRirmIKqEcObPw-1", "X-Mimecast-MFC-AGG-ID": "_APAEGAtPRirmIKqEcObPw_1775837130", "From": "=?utf-8?q?Daniel_P=2E_Berrang=C3=A9?= <berrange@redhat.com>", "To": "qemu-devel@nongnu.org", "Cc": "Paolo Bonzini <pbonzini@redhat.com>,\n Markus Armbruster <armbru@redhat.com>,\n Christian Brauner <brauner@kernel.org>,\n =?utf-8?q?Alex_Benn=C3=A9e?= <alex.bennee@linaro.org>, =?utf-8?q?Philippe_M?=\n\t=?utf-8?q?athieu-Daud=C3=A9?= <philmd@linaro.org>,\n Fabiano Rosas <farosas@suse.de>,\n =?utf-8?q?Marc-Andr=C3=A9_Lureau?= <marcandre.lureau@redhat.com>,\n Peter Xu <peterx@redhat.com>, Kevin Wolf <kwolf@redhat.com>, =?utf-8?q?Dani?=\n\t=?utf-8?q?el_P=2E_Berrang=C3=A9?= <berrange@redhat.com>,\n qemu-block@nongnu.org, \"Dr. David Alan Gilbert\" <dave@treblig.org>,\n Eric Blake <eblake@redhat.com>", "Subject": "[PATCH 07/17] monitor: use class methods for monitor_vprintf", "Date": "Fri, 10 Apr 2026 17:04:48 +0100", "Message-ID": "<20260410160458.3778874-8-berrange@redhat.com>", "In-Reply-To": "<20260410160458.3778874-1-berrange@redhat.com>", "References": "<20260410160458.3778874-1-berrange@redhat.com>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=UTF-8", "Content-Transfer-Encoding": "8bit", "X-Scanned-By": "MIMEDefang 3.0 on 10.30.177.17", "Received-SPF": "pass client-ip=170.10.133.124;\n envelope-from=berrange@redhat.com;\n helo=us-smtp-delivery-124.mimecast.com", "X-Spam_score_int": "-25", "X-Spam_score": "-2.6", "X-Spam_bar": "--", "X-Spam_report": "(-2.6 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.54,\n DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=0.001,\n RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001,\n SPF_HELO_PASS=-0.001,\n SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no", "X-Spam_action": "no action", "X-BeenThere": "qemu-devel@nongnu.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "qemu development <qemu-devel.nongnu.org>", "List-Unsubscribe": "<https://lists.nongnu.org/mailman/options/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>", "List-Archive": "<https://lists.nongnu.org/archive/html/qemu-devel>", "List-Post": "<mailto:qemu-devel@nongnu.org>", "List-Help": "<mailto:qemu-devel-request@nongnu.org?subject=help>", "List-Subscribe": "<https://lists.nongnu.org/mailman/listinfo/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=subscribe>", "Errors-To": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org", "Sender": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org" }, "content": "This removes the need for using monitor_is_qmp() to check the\nsubclass type, which is an anti-pattern.\n\nSigned-off-by: Daniel P. Berrangé <berrange@redhat.com>\n---\n monitor/hmp.c | 12 ++++++++++++\n monitor/monitor-internal.h | 3 +++\n monitor/monitor.c | 11 ++++-------\n 3 files changed, 19 insertions(+), 7 deletions(-)", "diff": "diff --git a/monitor/hmp.c b/monitor/hmp.c\nindex 833de0eee8..3fe6f5715a 100644\n--- a/monitor/hmp.c\n+++ b/monitor/hmp.c\n@@ -50,14 +50,26 @@ static void monitor_hmp_finalize(Object *obj)\n readline_free(mon->rs);\n }\n \n+int monitor_hmp_vprintf(Monitor *mon, const char *fmt, va_list ap)\n+ G_GNUC_PRINTF(2, 0);\n+\n static void monitor_hmp_class_init(ObjectClass *cls, const void *data)\n {\n+ MonitorClass *moncls = MONITOR_CLASS(cls);\n+\n+ moncls->vprintf = monitor_hmp_vprintf;\n }\n \n static void monitor_hmp_init(Object *obj)\n {\n }\n \n+int monitor_hmp_vprintf(Monitor *mon, const char *fmt, va_list ap)\n+{\n+ g_autofree char *buf = g_strdup_vprintf(fmt, ap);\n+ return monitor_puts(mon, buf);\n+}\n+\n static void monitor_command_cb(void *opaque, const char *cmdline,\n void *readline_opaque)\n {\ndiff --git a/monitor/monitor-internal.h b/monitor/monitor-internal.h\nindex 5bfe3b7325..3f05c46e88 100644\n--- a/monitor/monitor-internal.h\n+++ b/monitor/monitor-internal.h\n@@ -95,6 +95,9 @@ typedef struct HMPCommand {\n \n struct MonitorClass {\n ObjectClass parent_class;\n+\n+ int (*vprintf)(Monitor *mon, const char *fmt, va_list ap)\n+ G_GNUC_PRINTF(2, 0);\n };\n \n struct Monitor {\ndiff --git a/monitor/monitor.c b/monitor/monitor.c\nindex f6c90145f6..b51046c0c9 100644\n--- a/monitor/monitor.c\n+++ b/monitor/monitor.c\n@@ -243,21 +243,18 @@ int monitor_puts(Monitor *mon, const char *str)\n \n int monitor_vprintf(Monitor *mon, const char *fmt, va_list ap)\n {\n- char *buf;\n- int n;\n+ MonitorClass *moncls;\n \n if (!mon) {\n return -1;\n }\n \n- if (monitor_is_qmp(mon)) {\n+ moncls = MONITOR_GET_CLASS(mon);\n+ if (!moncls->vprintf) {\n return -1;\n }\n \n- buf = g_strdup_vprintf(fmt, ap);\n- n = monitor_puts(mon, buf);\n- g_free(buf);\n- return n;\n+ return moncls->vprintf(mon, fmt, ap);\n }\n \n int monitor_printf(Monitor *mon, const char *fmt, ...)\n", "prefixes": [ "07/17" ] }