Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/1.1/patches/2222023/?format=api
{ "id": 2222023, "url": "http://patchwork.ozlabs.org/api/1.1/patches/2222023/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20260410160458.3778874-9-berrange@redhat.com/", "project": { "id": 14, "url": "http://patchwork.ozlabs.org/api/1.1/projects/14/?format=api", "name": "QEMU Development", "link_name": "qemu-devel", "list_id": "qemu-devel.nongnu.org", "list_email": "qemu-devel@nongnu.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20260410160458.3778874-9-berrange@redhat.com>", "date": "2026-04-10T16:04:49", "name": "[08/17] monitor: use class methods for monitor_qapi_event_emit", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "23279c1017199dfd5ad8efb98489b187b38876bd", "submitter": { "id": 2694, "url": "http://patchwork.ozlabs.org/api/1.1/people/2694/?format=api", "name": "Daniel P. Berrangé", "email": "berrange@redhat.com" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20260410160458.3778874-9-berrange@redhat.com/mbox/", "series": [ { "id": 499483, "url": "http://patchwork.ozlabs.org/api/1.1/series/499483/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/list/?series=499483", "date": "2026-04-10T16:04:41", "name": "monitor: turn QMP and HMP into QOM objects", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/499483/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/2222023/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/2222023/checks/", "tags": {}, "headers": { "Return-Path": "<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@legolas.ozlabs.org", "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256\n header.s=mimecast20190719 header.b=SeLjDcSD;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)" ], "Received": [ "from lists.gnu.org (lists1p.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fshWV5lnyz1yGb\n\tfor <incoming@patchwork.ozlabs.org>; Sat, 11 Apr 2026 02:06:46 +1000 (AEST)", "from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from <qemu-devel-bounces@nongnu.org>)\n\tid 1wBEMo-0004CM-Bu; Fri, 10 Apr 2026 12:06:02 -0400", "from eggs.gnu.org ([2001:470:142:3::10])\n by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <berrange@redhat.com>)\n id 1wBEMe-00043w-5d\n for qemu-devel@nongnu.org; Fri, 10 Apr 2026 12:05:48 -0400", "from us-smtp-delivery-124.mimecast.com ([170.10.129.124])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <berrange@redhat.com>)\n id 1wBEMX-0006Rg-Gh\n for qemu-devel@nongnu.org; Fri, 10 Apr 2026 12:05:42 -0400", "from mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com\n (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by\n relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3,\n cipher=TLS_AES_256_GCM_SHA384) id us-mta-693-1KYX9G3aOAyKs99N_dtifA-1; Fri,\n 10 Apr 2026 12:05:35 -0400", "from mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com\n (mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.17])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest\n SHA256)\n (No client certificate requested)\n by mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS\n id 5E41E195606F; Fri, 10 Apr 2026 16:05:34 +0000 (UTC)", "from toolbx.redhat.corp (headnet01.pony-001.prod.iad2.dc.redhat.com\n [10.2.32.101])\n by mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP\n id E5E1E195608E; Fri, 10 Apr 2026 16:05:30 +0000 (UTC)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n s=mimecast20190719; t=1775837140;\n h=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n to:to:cc:cc:mime-version:mime-version:content-type:content-type:\n content-transfer-encoding:content-transfer-encoding:\n in-reply-to:in-reply-to:references:references;\n bh=fMbukjWxlkK6SymUOEl2+2+nh1GCzU/KKEQabDiuCTQ=;\n b=SeLjDcSDBToFD6BGOI9fPb3NY0U2wVgR1G5FvlVrqR7/vv+v6RrqCNpiHtLM3oe00Y/D0i\n rf6BEasQ+lFZjIDUJJbPvmPgOAeBT7GuB1D5TxBW7YUf5mV4lWJtJNPDYLHmcbeH73KixH\n 629eopicnP5KeLVy2KTZOMZMdPFa5zU=", "X-MC-Unique": "1KYX9G3aOAyKs99N_dtifA-1", "X-Mimecast-MFC-AGG-ID": "1KYX9G3aOAyKs99N_dtifA_1775837134", "From": "=?utf-8?q?Daniel_P=2E_Berrang=C3=A9?= <berrange@redhat.com>", "To": "qemu-devel@nongnu.org", "Cc": "Paolo Bonzini <pbonzini@redhat.com>,\n Markus Armbruster <armbru@redhat.com>,\n Christian Brauner <brauner@kernel.org>,\n =?utf-8?q?Alex_Benn=C3=A9e?= <alex.bennee@linaro.org>, =?utf-8?q?Philippe_M?=\n\t=?utf-8?q?athieu-Daud=C3=A9?= <philmd@linaro.org>,\n Fabiano Rosas <farosas@suse.de>,\n =?utf-8?q?Marc-Andr=C3=A9_Lureau?= <marcandre.lureau@redhat.com>,\n Peter Xu <peterx@redhat.com>, Kevin Wolf <kwolf@redhat.com>, =?utf-8?q?Dani?=\n\t=?utf-8?q?el_P=2E_Berrang=C3=A9?= <berrange@redhat.com>,\n qemu-block@nongnu.org, \"Dr. David Alan Gilbert\" <dave@treblig.org>,\n Eric Blake <eblake@redhat.com>", "Subject": "[PATCH 08/17] monitor: use class methods for monitor_qapi_event_emit", "Date": "Fri, 10 Apr 2026 17:04:49 +0100", "Message-ID": "<20260410160458.3778874-9-berrange@redhat.com>", "In-Reply-To": "<20260410160458.3778874-1-berrange@redhat.com>", "References": "<20260410160458.3778874-1-berrange@redhat.com>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=UTF-8", "Content-Transfer-Encoding": "8bit", "X-Scanned-By": "MIMEDefang 3.0 on 10.30.177.17", "Received-SPF": "pass client-ip=170.10.129.124;\n envelope-from=berrange@redhat.com;\n helo=us-smtp-delivery-124.mimecast.com", "X-Spam_score_int": "7", "X-Spam_score": "0.7", "X-Spam_bar": "/", "X-Spam_report": "(0.7 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.54,\n DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001,\n RCVD_IN_SBL_CSS=3.335, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001,\n RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001, SPF_HELO_PASS=-0.001,\n SPF_PASS=-0.001 autolearn=no autolearn_force=no", "X-Spam_action": "no action", "X-BeenThere": "qemu-devel@nongnu.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "qemu development <qemu-devel.nongnu.org>", "List-Unsubscribe": "<https://lists.nongnu.org/mailman/options/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>", "List-Archive": "<https://lists.nongnu.org/archive/html/qemu-devel>", "List-Post": "<mailto:qemu-devel@nongnu.org>", "List-Help": "<mailto:qemu-devel-request@nongnu.org?subject=help>", "List-Subscribe": "<https://lists.nongnu.org/mailman/listinfo/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=subscribe>", "Errors-To": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org", "Sender": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org" }, "content": "This removes the need for using monitor_is_qmp() to check the\nsubclass type, which is an anti-pattern.\n\nSigned-off-by: Daniel P. Berrangé <berrange@redhat.com>\n---\n include/monitor/monitor.h | 1 +\n monitor/monitor-internal.h | 1 +\n monitor/monitor.c | 15 +++------------\n monitor/qmp.c | 19 +++++++++++++++++++\n 4 files changed, 24 insertions(+), 12 deletions(-)", "diff": "diff --git a/include/monitor/monitor.h b/include/monitor/monitor.h\nindex b349b12c34..7b0bda42c4 100644\n--- a/include/monitor/monitor.h\n+++ b/include/monitor/monitor.h\n@@ -3,6 +3,7 @@\n \n #include \"block/block.h\"\n #include \"qapi/qapi-types-misc.h\"\n+#include \"qapi/qapi-emit-events.h\"\n #include \"qemu/readline.h\"\n #include \"exec/hwaddr.h\"\n #include \"qom/object.h\"\ndiff --git a/monitor/monitor-internal.h b/monitor/monitor-internal.h\nindex 3f05c46e88..4b5e708f14 100644\n--- a/monitor/monitor-internal.h\n+++ b/monitor/monitor-internal.h\n@@ -98,6 +98,7 @@ struct MonitorClass {\n \n int (*vprintf)(Monitor *mon, const char *fmt, va_list ap)\n G_GNUC_PRINTF(2, 0);\n+ void (*emit_event)(Monitor *mon, QAPIEvent event, QDict *qdict);\n };\n \n struct Monitor {\ndiff --git a/monitor/monitor.c b/monitor/monitor.c\nindex b51046c0c9..5f55d33476 100644\n--- a/monitor/monitor.c\n+++ b/monitor/monitor.c\n@@ -327,22 +327,13 @@ static inline QEMUClockType monitor_get_event_clock(void)\n static void monitor_qapi_event_emit(QAPIEvent event, QDict *qdict)\n {\n Monitor *mon;\n- MonitorQMP *qmp_mon;\n \n trace_monitor_protocol_event_emit(event, qdict);\n QTAILQ_FOREACH(mon, &mon_list, entry) {\n- if (!monitor_is_qmp(mon)) {\n- continue;\n+ MonitorClass *cls = MONITOR_GET_CLASS(mon);\n+ if (cls->emit_event) {\n+ cls->emit_event(mon, event, qdict);\n }\n-\n- qmp_mon = container_of(mon, MonitorQMP, parent);\n- {\n- QEMU_LOCK_GUARD(&mon->mon_lock);\n- if (qmp_mon->commands == &qmp_cap_negotiation_commands) {\n- continue;\n- }\n- }\n- qmp_send_response(qmp_mon, qdict);\n }\n }\n \ndiff --git a/monitor/qmp.c b/monitor/qmp.c\nindex 0de98b33fe..9c3e8e2678 100644\n--- a/monitor/qmp.c\n+++ b/monitor/qmp.c\n@@ -85,14 +85,33 @@ static void monitor_qmp_finalize(Object *obj)\n g_queue_free(mon->qmp_requests);\n }\n \n+static void monitor_qmp_emit_event(Monitor *mon, QAPIEvent event, QDict *qdict);\n+\n static void monitor_qmp_class_init(ObjectClass *cls, const void *data)\n {\n+ MonitorClass *moncls = MONITOR_CLASS(cls);\n+\n+ moncls->emit_event = monitor_qmp_emit_event;\n }\n \n static void monitor_qmp_init(Object *obj)\n {\n }\n \n+static void monitor_qmp_emit_event(Monitor *mon, QAPIEvent event, QDict *qdict)\n+{\n+ MonitorQMP *qmp = MONITOR_QMP(mon);\n+\n+ WITH_QEMU_LOCK_GUARD(&mon->mon_lock) {\n+ if (qmp->commands == &qmp_cap_negotiation_commands) {\n+ return;\n+ }\n+ }\n+\n+ qmp_send_response(qmp, qdict);\n+}\n+\n+\n static bool qmp_oob_enabled(MonitorQMP *mon)\n {\n return mon->capab[QMP_CAPABILITY_OOB];\n", "prefixes": [ "08/17" ] }