Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/1.1/patches/2222019/?format=api
{ "id": 2222019, "url": "http://patchwork.ozlabs.org/api/1.1/patches/2222019/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20260410160458.3778874-6-berrange@redhat.com/", "project": { "id": 14, "url": "http://patchwork.ozlabs.org/api/1.1/projects/14/?format=api", "name": "QEMU Development", "link_name": "qemu-devel", "list_id": "qemu-devel.nongnu.org", "list_email": "qemu-devel@nongnu.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20260410160458.3778874-6-berrange@redhat.com>", "date": "2026-04-10T16:04:46", "name": "[05/17] monitor: remove 'skip_flush' field", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "40e66a333b4ebf2f6c3779b3201bbd4c70a21366", "submitter": { "id": 2694, "url": "http://patchwork.ozlabs.org/api/1.1/people/2694/?format=api", "name": "Daniel P. Berrangé", "email": "berrange@redhat.com" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20260410160458.3778874-6-berrange@redhat.com/mbox/", "series": [ { "id": 499483, "url": "http://patchwork.ozlabs.org/api/1.1/series/499483/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/list/?series=499483", "date": "2026-04-10T16:04:41", "name": "monitor: turn QMP and HMP into QOM objects", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/499483/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/2222019/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/2222019/checks/", "tags": {}, "headers": { "Return-Path": "<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@legolas.ozlabs.org", "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256\n header.s=mimecast20190719 header.b=JHhzcTwD;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)" ], "Received": [ "from lists.gnu.org (lists1p.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fshVp6QNgz20HX\n\tfor <incoming@patchwork.ozlabs.org>; Sat, 11 Apr 2026 02:06:09 +1000 (AEST)", "from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from <qemu-devel-bounces@nongnu.org>)\n\tid 1wBEMh-00047w-9i; Fri, 10 Apr 2026 12:05:51 -0400", "from eggs.gnu.org ([2001:470:142:3::10])\n by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <berrange@redhat.com>)\n id 1wBEMN-000407-4G\n for qemu-devel@nongnu.org; Fri, 10 Apr 2026 12:05:37 -0400", "from us-smtp-delivery-124.mimecast.com ([170.10.133.124])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <berrange@redhat.com>)\n id 1wBEMJ-0006PM-DR\n for qemu-devel@nongnu.org; Fri, 10 Apr 2026 12:05:29 -0400", "from mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com\n (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by\n relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3,\n cipher=TLS_AES_256_GCM_SHA384) id us-mta-108-KPtk6W_MM2yZrIw5iqzi9g-1; Fri,\n 10 Apr 2026 12:05:24 -0400", "from mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com\n (mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.17])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest\n SHA256)\n (No client certificate requested)\n by mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS\n id AEAFB195608F; Fri, 10 Apr 2026 16:05:22 +0000 (UTC)", "from toolbx.redhat.corp (headnet01.pony-001.prod.iad2.dc.redhat.com\n [10.2.32.101])\n by mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP\n id 4706B19560AB; Fri, 10 Apr 2026 16:05:19 +0000 (UTC)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n s=mimecast20190719; t=1775837126;\n h=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n to:to:cc:cc:mime-version:mime-version:content-type:content-type:\n content-transfer-encoding:content-transfer-encoding:\n in-reply-to:in-reply-to:references:references;\n bh=I/ymzSVFiDdbZziVAA2OJ+MKr20f95MwjR7x1NCCHUE=;\n b=JHhzcTwDerGki4OsrKoKLT5aCyuWbzzyGNGz3eFYrrwkYr2gWStdhz1MTK7MEz3iK6x+Az\n ZiLzRJ1s7lVEN3OHFsgsFox3H+6NZgpQYNIXigTx8kvtfQHeDjMCeMQ5oONJ4Yl9nN5oBh\n eGNLfDzUUSXsLFLI7U8F7HIlG+nR0es=", "X-MC-Unique": "KPtk6W_MM2yZrIw5iqzi9g-1", "X-Mimecast-MFC-AGG-ID": "KPtk6W_MM2yZrIw5iqzi9g_1775837122", "From": "=?utf-8?q?Daniel_P=2E_Berrang=C3=A9?= <berrange@redhat.com>", "To": "qemu-devel@nongnu.org", "Cc": "Paolo Bonzini <pbonzini@redhat.com>,\n Markus Armbruster <armbru@redhat.com>,\n Christian Brauner <brauner@kernel.org>,\n =?utf-8?q?Alex_Benn=C3=A9e?= <alex.bennee@linaro.org>, =?utf-8?q?Philippe_M?=\n\t=?utf-8?q?athieu-Daud=C3=A9?= <philmd@linaro.org>,\n Fabiano Rosas <farosas@suse.de>,\n =?utf-8?q?Marc-Andr=C3=A9_Lureau?= <marcandre.lureau@redhat.com>,\n Peter Xu <peterx@redhat.com>, Kevin Wolf <kwolf@redhat.com>, =?utf-8?q?Dani?=\n\t=?utf-8?q?el_P=2E_Berrang=C3=A9?= <berrange@redhat.com>,\n qemu-block@nongnu.org, \"Dr. David Alan Gilbert\" <dave@treblig.org>,\n Eric Blake <eblake@redhat.com>", "Subject": "[PATCH 05/17] monitor: remove 'skip_flush' field", "Date": "Fri, 10 Apr 2026 17:04:46 +0100", "Message-ID": "<20260410160458.3778874-6-berrange@redhat.com>", "In-Reply-To": "<20260410160458.3778874-1-berrange@redhat.com>", "References": "<20260410160458.3778874-1-berrange@redhat.com>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=UTF-8", "Content-Transfer-Encoding": "8bit", "X-Scanned-By": "MIMEDefang 3.0 on 10.30.177.17", "Received-SPF": "pass client-ip=170.10.133.124;\n envelope-from=berrange@redhat.com;\n helo=us-smtp-delivery-124.mimecast.com", "X-Spam_score_int": "7", "X-Spam_score": "0.7", "X-Spam_bar": "/", "X-Spam_report": "(0.7 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.54,\n DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=0.001, RCVD_IN_SBL_CSS=3.335,\n RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001,\n SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no", "X-Spam_action": "no action", "X-BeenThere": "qemu-devel@nongnu.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "qemu development <qemu-devel.nongnu.org>", "List-Unsubscribe": "<https://lists.nongnu.org/mailman/options/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>", "List-Archive": "<https://lists.nongnu.org/archive/html/qemu-devel>", "List-Post": "<mailto:qemu-devel@nongnu.org>", "List-Help": "<mailto:qemu-devel-request@nongnu.org?subject=help>", "List-Subscribe": "<https://lists.nongnu.org/mailman/listinfo/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=subscribe>", "Errors-To": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org", "Sender": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org" }, "content": "The 'skip_flush' field is set on the dummy throwaway HMP monitor\nobject created by QMP's 'human-monitor-command', as an indication\nnot to try to write data to the chardev. Instead the QMP command\nimpl will grab the data straight out of the in-memory buffer.\n\nThe flag is redundant, however, as the monitor code could instead\nsimply check the 'fe_is_open' field on the CharFrontend, which\nwill be false in the same scenarios that 'skip_flush' is true.\n\nSigned-off-by: Daniel P. Berrangé <berrange@redhat.com>\n---\n monitor/hmp.c | 2 +-\n monitor/monitor-internal.h | 4 +---\n monitor/monitor.c | 11 +++++++----\n monitor/qmp-cmds.c | 2 +-\n monitor/qmp.c | 2 +-\n 5 files changed, 11 insertions(+), 10 deletions(-)", "diff": "diff --git a/monitor/hmp.c b/monitor/hmp.c\nindex 614d9a3707..72f8303662 100644\n--- a/monitor/hmp.c\n+++ b/monitor/hmp.c\n@@ -1539,7 +1539,7 @@ void monitor_new_hmp(Chardev *chr, bool use_readline, Error **errp)\n return;\n }\n \n- monitor_data_init(&mon->parent, false, false, false);\n+ monitor_data_init(&mon->parent, false, false);\n \n mon->use_readline = use_readline;\n if (mon->use_readline) {\ndiff --git a/monitor/monitor-internal.h b/monitor/monitor-internal.h\nindex 25320928a7..84117805b7 100644\n--- a/monitor/monitor-internal.h\n+++ b/monitor/monitor-internal.h\n@@ -102,7 +102,6 @@ struct Monitor {\n CharFrontend chr;\n int suspend_cnt; /* Needs to be accessed atomically */\n bool is_qmp;\n- bool skip_flush;\n bool use_io_thread;\n \n char *mon_cpu_path;\n@@ -183,8 +182,7 @@ extern QmpCommandList qmp_commands, qmp_cap_negotiation_commands;\n extern QemuMutex monitor_lock;\n extern MonitorList mon_list;\n \n-void monitor_data_init(Monitor *mon, bool is_qmp, bool skip_flush,\n- bool use_io_thread);\n+void monitor_data_init(Monitor *mon, bool is_qmp, bool use_io_thread);\n void monitor_data_destroy(Monitor *mon);\n int monitor_can_read(void *opaque);\n void monitor_list_append(Monitor *mon);\ndiff --git a/monitor/monitor.c b/monitor/monitor.c\nindex 7936e2ab22..f7e3708d2f 100644\n--- a/monitor/monitor.c\n+++ b/monitor/monitor.c\n@@ -167,7 +167,12 @@ void monitor_flush_locked(Monitor *mon)\n size_t len;\n const char *buf;\n \n- if (mon->skip_flush) {\n+ /*\n+ * When used by QMP human-monitor-command, no chardev\n+ * will be connected, as we want to just collect the\n+ * output in the buffer\n+ */\n+ if (!mon->chr.fe_is_open) {\n return;\n }\n \n@@ -621,8 +626,7 @@ static void monitor_iothread_init(void)\n mon_iothread = iothread_create(\"mon_iothread\", &error_abort);\n }\n \n-void monitor_data_init(Monitor *mon, bool is_qmp, bool skip_flush,\n- bool use_io_thread)\n+void monitor_data_init(Monitor *mon, bool is_qmp, bool use_io_thread)\n {\n if (use_io_thread && !mon_iothread) {\n monitor_iothread_init();\n@@ -630,7 +634,6 @@ void monitor_data_init(Monitor *mon, bool is_qmp, bool skip_flush,\n qemu_mutex_init(&mon->mon_lock);\n mon->is_qmp = is_qmp;\n mon->outbuf = g_string_new(NULL);\n- mon->skip_flush = skip_flush;\n mon->use_io_thread = use_io_thread;\n }\n \ndiff --git a/monitor/qmp-cmds.c b/monitor/qmp-cmds.c\nindex d0ed241d6a..be2bd985b7 100644\n--- a/monitor/qmp-cmds.c\n+++ b/monitor/qmp-cmds.c\n@@ -168,7 +168,7 @@ char *qmp_human_monitor_command(const char *command_line, bool has_cpu_index,\n char *output = NULL;\n MonitorHMP *hmp = MONITOR_HMP(object_new(TYPE_MONITOR_HMP));\n \n- monitor_data_init(&hmp->parent, false, true, false);\n+ monitor_data_init(&hmp->parent, false, false);\n \n if (has_cpu_index) {\n int ret = monitor_set_cpu(&hmp->parent, cpu_index);\ndiff --git a/monitor/qmp.c b/monitor/qmp.c\nindex 36cb078f30..fe2aec9ce9 100644\n--- a/monitor/qmp.c\n+++ b/monitor/qmp.c\n@@ -538,7 +538,7 @@ void monitor_new_qmp(Chardev *chr, bool pretty, Error **errp)\n qemu_chr_fe_set_echo(&mon->parent.chr, true);\n \n /* Note: we run QMP monitor in I/O thread when @chr supports that */\n- monitor_data_init(&mon->parent, true, false,\n+ monitor_data_init(&mon->parent, true,\n qemu_chr_has_feature(chr, QEMU_CHAR_FEATURE_GCONTEXT));\n \n mon->pretty = pretty;\n", "prefixes": [ "05/17" ] }