Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/1.1/patches/2221999/?format=api
{ "id": 2221999, "url": "http://patchwork.ozlabs.org/api/1.1/patches/2221999/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20260410150457.85190-6-zhangckid@gmail.com/", "project": { "id": 14, "url": "http://patchwork.ozlabs.org/api/1.1/projects/14/?format=api", "name": "QEMU Development", "link_name": "qemu-devel", "list_id": "qemu-devel.nongnu.org", "list_email": "qemu-devel@nongnu.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20260410150457.85190-6-zhangckid@gmail.com>", "date": "2026-04-10T15:04:48", "name": "[V6,05/14] block/export: track IOThread reference in BlockExport", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "153ba8486f550cb3b4d0b543ccbda3e5dc01c3d3", "submitter": { "id": 72278, "url": "http://patchwork.ozlabs.org/api/1.1/people/72278/?format=api", "name": "Zhang Chen", "email": "zhangckid@gmail.com" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20260410150457.85190-6-zhangckid@gmail.com/mbox/", "series": [ { "id": 499477, "url": "http://patchwork.ozlabs.org/api/1.1/series/499477/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/list/?series=499477", "date": "2026-04-10T15:04:43", "name": "iothread: Support tracking and querying IOThread holders", "version": 6, "mbox": "http://patchwork.ozlabs.org/series/499477/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/2221999/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/2221999/checks/", "tags": {}, "headers": { "Return-Path": "<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@legolas.ozlabs.org", "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256\n header.s=20251104 header.b=Livk5s4i;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)" ], "Received": [ "from lists.gnu.org (lists1p.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fsgBM2Cskz1yGS\n\tfor <incoming@patchwork.ozlabs.org>; Sat, 11 Apr 2026 01:06:51 +1000 (AEST)", "from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from <qemu-devel-bounces@nongnu.org>)\n\tid 1wBDQL-0006pF-EQ; Fri, 10 Apr 2026 11:05:33 -0400", "from eggs.gnu.org ([2001:470:142:3::10])\n by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <zhangckid@gmail.com>)\n id 1wBDQK-0006l6-0w\n for qemu-devel@nongnu.org; Fri, 10 Apr 2026 11:05:32 -0400", "from mail-pj1-x102d.google.com ([2607:f8b0:4864:20::102d])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)\n (Exim 4.90_1) (envelope-from <zhangckid@gmail.com>)\n id 1wBDQH-0002LW-O2\n for qemu-devel@nongnu.org; Fri, 10 Apr 2026 11:05:31 -0400", "by mail-pj1-x102d.google.com with SMTP id\n 98e67ed59e1d1-35d90833cacso1542931a91.2\n for <qemu-devel@nongnu.org>; Fri, 10 Apr 2026 08:05:29 -0700 (PDT)", "from ZBMac-LWN10QXKQ0.taila0cd24.ts.net ([104.168.88.121])\n by smtp.gmail.com with ESMTPSA id\n 98e67ed59e1d1-35e4131cfacsm3565785a91.10.2026.04.10.08.05.23\n (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256);\n Fri, 10 Apr 2026 08:05:26 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=gmail.com; s=20251104; t=1775833528; x=1776438328; darn=nongnu.org;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:from:to:cc:subject:date\n :message-id:reply-to;\n bh=6M/hoXWqBMvPhrdOYgRm4aU7iBbj+zMMvv5Gl5LllJg=;\n b=Livk5s4iJrbYf9+e4iZU96kPP0FKJVmXw1n5roxOrimeuMn7p5b0irMjci7BP+rs5b\n JzkRSC8Tis91gWmWHEi4W6Js3FXSYgtwySMIRbin9VPVc7kXNeeZNCycyPjufEvcqG0e\n sdCoSLAtfbwtB9VquJ0TJ0jPQ+qoAxtT+oVs83cOeUsETu5veDM7wD0A1mL1s15g3B8s\n 3g0RkEqURNJyLshI0skHEkP+2Bg++E5KKJe9V8yRAn595jAJZibmcIeXYCR+Lrie63xJ\n 8Rntfd2yT6wrmzt8UHl59Onv/eMr6m9XuUehjPercT/0Wz1RsifGzL9XlWkF6EvTWP25\n 9NyQ==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1775833528; x=1776438328;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from\n :to:cc:subject:date:message-id:reply-to;\n bh=6M/hoXWqBMvPhrdOYgRm4aU7iBbj+zMMvv5Gl5LllJg=;\n b=NeSh3xm3f8NwznlBZzMHzlIyn2tu0YjCM+qdkMAXppHWelkhGB2ASrP3J2y8zZoqK/\n H7LFD8wPEgK7p6BBTg06BJdRVWmP3IB1pMjsNPBzmZa1iP0K00jZtuL4H8Yu4QLRmD13\n O1A9N6Ag010qtlyma3EZs3fnOKUfEHsnj/czMCt6iH4Tgm3oWDRfIUD3O9stFyK4r87F\n twa6mBW8PmmlAdNnJvSfS2HVxcVUAIym+3VIHxEWOckyftKEdLmJbTmCHKvcZ7IjuSmL\n Jf2zbwMPLl3Q+L2vX2q2eEfmcALf6AND2oVUB8PQ5Rf2jBOUDhLFpbPmWI/XrVSjy2q8\n Ma5Q==", "X-Gm-Message-State": "AOJu0YyNeJyjMzNv3iMxVPRuFdEs/x72BaoElfbFFwWFRNEj3rnmNl6g\n CaCTT2xMUGdVMM+e7sI9QjxvK/DN5+48Yp9LI7BG1QvNwFUW9TPc1m9E3TiV5yWE", "X-Gm-Gg": "AeBDiev9o5iHqNN3Cdyx21Jt+3qhGyLLihu/vw0EjxkPUuw6KnC3VSMgF7EXguTt911\n CBcG34Xu3FZGQMJPzscSufPqSukh/bIdMyHbAlec/sPUuSXyJ1LvHBcfzau8uz2S2+QEAAKIfM/\n SFDpN8g4OCsaNLeDuDqxZ1SQVOw7/xH+ZfDm2n727RRwtd06vo/gPJTf+mQtn71mzRdq26f9MkL\n XIPhvFZEMl9zk5Xustx4RsRG9SB4546b10jYdPkUUV2vpzLUY26B+Vu/dtsnQclAUxrkeEq5WKb\n gZhGlNMh7ubi5EJDuWBDhD8uqkyubWB+xadLTWfA4VW3IcuhkrUvJ/UK3+2vENHtndgF/Bh5XY5\n Cf3dKSxSei1PyrPWTtQ3Ii4hT60wbnHbi2IMKqMT3SfBIGlGivbJrWn8zFCQ2u72iJf7b+Bo15Q\n FZtFVKk8De94Y2ytGEc/0Df/XKO6Hn8l4pNdRUV+JARzD5jjCeUmAr", "X-Received": "by 2002:a17:90b:3c48:b0:35b:e690:c5ad with SMTP id\n 98e67ed59e1d1-35e42849e8cmr3830790a91.25.1775833527394;\n Fri, 10 Apr 2026 08:05:27 -0700 (PDT)", "From": "Zhang Chen <zhangckid@gmail.com>", "To": "qemu-devel <qemu-devel@nongnu.org>,\n \"Dr . David Alan Gilbert\" <dave@treblig.org>,\n Eric Blake <eblake@redhat.com>, Markus Armbruster <armbru@redhat.com>,\n \"Michael S . Tsirkin\" <mst@redhat.com>,\n Stefan Hajnoczi <stefanha@redhat.com>", "Cc": "Zhang Chen <zhangckid@gmail.com>", "Subject": "[PATCH V6 05/14] block/export: track IOThread reference in\n BlockExport", "Date": "Fri, 10 Apr 2026 23:04:48 +0800", "Message-ID": "<20260410150457.85190-6-zhangckid@gmail.com>", "X-Mailer": "git-send-email 2.49.0", "In-Reply-To": "<20260410150457.85190-1-zhangckid@gmail.com>", "References": "<20260410150457.85190-1-zhangckid@gmail.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Received-SPF": "pass client-ip=2607:f8b0:4864:20::102d;\n envelope-from=zhangckid@gmail.com; helo=mail-pj1-x102d.google.com", "X-Spam_score_int": "-20", "X-Spam_score": "-2.1", "X-Spam_bar": "--", "X-Spam_report": "(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001,\n RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001,\n SPF_PASS=-0.001 autolearn=ham autolearn_force=no", "X-Spam_action": "no action", "X-BeenThere": "qemu-devel@nongnu.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "qemu development <qemu-devel.nongnu.org>", "List-Unsubscribe": "<https://lists.nongnu.org/mailman/options/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>", "List-Archive": "<https://lists.nongnu.org/archive/html/qemu-devel>", "List-Post": "<mailto:qemu-devel@nongnu.org>", "List-Help": "<mailto:qemu-devel-request@nongnu.org?subject=help>", "List-Subscribe": "<https://lists.nongnu.org/mailman/listinfo/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=subscribe>", "Errors-To": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org", "Sender": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org" }, "content": "Users currently lack visibility into which block exports\nare utilizing specific IOThreads. This patch integrates IOThread\nreferencing into the BlockExport lifecycle.\n\n- Add iothreads array and holder_name to BlockExport struct.\n- Use iothread_ref_and_get_aio_context during export creation.\n- Implement proper cleanup in blk_exp_add fail path and blk_exp_delete_bh.\n- Support both single and multi-iothread export configurations.\n\nThis ensures IOThread 'holders' status correctly reflects active block\nexports for better debugging and resource tracking.\n\nSigned-off-by: Zhang Chen <zhangckid@gmail.com>\n---\n block/export/export.c | 44 +++++++++++++++++++++++++++++++++---------\n include/block/export.h | 6 ++++++\n 2 files changed, 41 insertions(+), 9 deletions(-)", "diff": "diff --git a/block/export/export.c b/block/export/export.c\nindex b733f269f3..636633c324 100644\n--- a/block/export/export.c\n+++ b/block/export/export.c\n@@ -15,7 +15,6 @@\n \n #include \"block/block.h\"\n #include \"system/block-backend.h\"\n-#include \"system/iothread.h\"\n #include \"block/export.h\"\n #include \"block/fuse.h\"\n #include \"block/nbd.h\"\n@@ -85,6 +84,8 @@ BlockExport *blk_exp_add(BlockExportOptions *export, Error **errp)\n AioContext *ctx;\n AioContext **multithread_ctxs = NULL;\n size_t multithread_count = 0;\n+ g_autofree IOThread **local_iothreads = NULL;\n+ const char *holder_name = NULL;\n uint64_t perm;\n int ret;\n \n@@ -139,7 +140,11 @@ BlockExport *blk_exp_add(BlockExportOptions *export, Error **errp)\n goto fail;\n }\n \n- new_ctx = iothread_get_aio_context(iothread);\n+ holder_name = bdrv_get_node_name(bs);\n+ new_ctx = iothread_ref_and_get_aio_context(iothread, holder_name);\n+ multithread_count = 1;\n+ local_iothreads = g_new0(IOThread *, 1);\n+ local_iothreads[0] = iothread;\n \n /* Ignore errors with fixed-iothread=false */\n set_context_errp = fixed_iothread ? errp : NULL;\n@@ -163,8 +168,10 @@ BlockExport *blk_exp_add(BlockExportOptions *export, Error **errp)\n return NULL;\n }\n \n+ local_iothreads = g_new0(IOThread *, multithread_count);\n multithread_ctxs = g_new(AioContext *, multithread_count);\n i = 0;\n+ holder_name = bdrv_get_node_name(bs);\n for (strList *e = iothread_list; e; e = e->next) {\n IOThread *iothread = iothread_by_id(e->value);\n \n@@ -172,7 +179,9 @@ BlockExport *blk_exp_add(BlockExportOptions *export, Error **errp)\n error_setg(errp, \"iothread \\\"%s\\\" not found\", e->value);\n goto fail;\n }\n- multithread_ctxs[i++] = iothread_get_aio_context(iothread);\n+ local_iothreads[i] = iothread;\n+ multithread_ctxs[i++] = iothread_ref_and_get_aio_context(iothread,\n+ holder_name);\n }\n assert(i == multithread_count);\n }\n@@ -225,12 +234,15 @@ BlockExport *blk_exp_add(BlockExportOptions *export, Error **errp)\n assert(drv->instance_size >= sizeof(BlockExport));\n exp = g_malloc0(drv->instance_size);\n *exp = (BlockExport) {\n- .drv = drv,\n- .refcount = 1,\n- .user_owned = true,\n- .id = g_strdup(export->id),\n- .ctx = ctx,\n- .blk = blk,\n+ .drv = drv,\n+ .refcount = 1,\n+ .user_owned = true,\n+ .id = g_strdup(export->id),\n+ .ctx = ctx,\n+ .blk = blk,\n+ .iothreads = g_steal_pointer(&local_iothreads),\n+ .iothread_count = multithread_count,\n+ .iothread_holder_name = g_strdup(holder_name),\n };\n \n ret = drv->create(exp, export, multithread_ctxs, multithread_count, errp);\n@@ -253,6 +265,13 @@ fail:\n g_free(exp->id);\n g_free(exp);\n }\n+ if (local_iothreads) {\n+ for (size_t j = 0; j < multithread_count; j++) {\n+ if (local_iothreads[j]) {\n+ iothread_put_aio_context(local_iothreads[j], holder_name);\n+ }\n+ }\n+ }\n g_free(multithread_ctxs);\n return NULL;\n }\n@@ -269,6 +288,13 @@ static void blk_exp_delete_bh(void *opaque)\n BlockExport *exp = opaque;\n \n assert(exp->refcount == 0);\n+ if (exp->iothreads) {\n+ for (size_t i = 0; i < exp->iothread_count; i++) {\n+ iothread_put_aio_context(exp->iothreads[i],\n+ exp->iothread_holder_name);\n+ }\n+ g_free(exp->iothreads);\n+ }\n QLIST_REMOVE(exp, next);\n exp->drv->delete(exp);\n blk_set_dev_ops(exp->blk, NULL, NULL);\ndiff --git a/include/block/export.h b/include/block/export.h\nindex ca45da928c..2bb98aae31 100644\n--- a/include/block/export.h\n+++ b/include/block/export.h\n@@ -16,6 +16,7 @@\n \n #include \"qapi/qapi-types-block-export.h\"\n #include \"qemu/queue.h\"\n+#include \"system/iothread.h\"\n \n typedef struct BlockExport BlockExport;\n \n@@ -89,6 +90,11 @@ struct BlockExport {\n \n /* List entry for block_exports */\n QLIST_ENTRY(BlockExport) next;\n+\n+ /* The iothreads list for block_exports */\n+ IOThread **iothreads;\n+ size_t iothread_count;\n+ char *iothread_holder_name;\n };\n \n BlockExport *blk_exp_add(BlockExportOptions *export, Error **errp);\n", "prefixes": [ "V6", "05/14" ] }