Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/1.1/patches/2221948/?format=api
{ "id": 2221948, "url": "http://patchwork.ozlabs.org/api/1.1/patches/2221948/?format=api", "web_url": "http://patchwork.ozlabs.org/project/linux-pci/patch/20260410-sdxi-base-v1-13-1d184cb5c60a@amd.com/", "project": { "id": 28, "url": "http://patchwork.ozlabs.org/api/1.1/projects/28/?format=api", "name": "Linux PCI development", "link_name": "linux-pci", "list_id": "linux-pci.vger.kernel.org", "list_email": "linux-pci@vger.kernel.org", "web_url": null, "scm_url": null, "webscm_url": null }, "msgid": "<20260410-sdxi-base-v1-13-1d184cb5c60a@amd.com>", "date": "2026-04-10T13:07:23", "name": "[13/23] dmaengine: sdxi: Add unit tests for descriptor ring reservations", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "79fcb92f36f6b2918b5f67010cb6f00c7c863e29", "submitter": { "id": 91626, "url": "http://patchwork.ozlabs.org/api/1.1/people/91626/?format=api", "name": "Nathan Lynch via B4 Relay", "email": "devnull+nathan.lynch.amd.com@kernel.org" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/linux-pci/patch/20260410-sdxi-base-v1-13-1d184cb5c60a@amd.com/mbox/", "series": [ { "id": 499458, "url": "http://patchwork.ozlabs.org/api/1.1/series/499458/?format=api", "web_url": "http://patchwork.ozlabs.org/project/linux-pci/list/?series=499458", "date": "2026-04-10T13:07:10", "name": "dmaengine: Smart Data Accelerator Interface (SDXI) basic support", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/499458/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/2221948/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/2221948/checks/", "tags": {}, "headers": { "Return-Path": "\n <linux-pci+bounces-52324-incoming=patchwork.ozlabs.org@vger.kernel.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "linux-pci@vger.kernel.org" ], "Delivered-To": "patchwork-incoming@legolas.ozlabs.org", "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256\n header.s=k20201202 header.b=JuH2bBoI;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org\n (client-ip=2600:3c0a:e001:db::12fc:5321; helo=sea.lore.kernel.org;\n envelope-from=linux-pci+bounces-52324-incoming=patchwork.ozlabs.org@vger.kernel.org;\n receiver=patchwork.ozlabs.org)", "smtp.subspace.kernel.org;\n\tdkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org\n header.b=\"JuH2bBoI\"", "smtp.subspace.kernel.org;\n arc=none smtp.client-ip=10.30.226.201" ], "Received": [ "from sea.lore.kernel.org (sea.lore.kernel.org\n [IPv6:2600:3c0a:e001:db::12fc:5321])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fsccx0gN0z1yGS\n\tfor <incoming@patchwork.ozlabs.org>; Fri, 10 Apr 2026 23:11:13 +1000 (AEST)", "from smtp.subspace.kernel.org (conduit.subspace.kernel.org\n [100.90.174.1])\n\tby sea.lore.kernel.org (Postfix) with ESMTP id BE3223063D73\n\tfor <incoming@patchwork.ozlabs.org>; Fri, 10 Apr 2026 13:08:00 +0000 (UTC)", "from localhost.localdomain (localhost.localdomain [127.0.0.1])\n\tby smtp.subspace.kernel.org (Postfix) with ESMTP id C06703BADBC;\n\tFri, 10 Apr 2026 13:07:50 +0000 (UTC)", "from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org\n [10.30.226.201])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby smtp.subspace.kernel.org (Postfix) with ESMTPS id 8CCE93A7859;\n\tFri, 10 Apr 2026 13:07:50 +0000 (UTC)", "by smtp.kernel.org (Postfix) with ESMTPS id 59D07C2BCC6;\n\tFri, 10 Apr 2026 13:07:50 +0000 (UTC)", "from aws-us-west-2-korg-lkml-1.web.codeaurora.org\n (localhost.localdomain [127.0.0.1])\n\tby smtp.lore.kernel.org (Postfix) with ESMTP id 51C98F4485F;\n\tFri, 10 Apr 2026 13:07:50 +0000 (UTC)" ], "ARC-Seal": "i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;\n\tt=1775826470; cv=none;\n b=Mox8p7b+s5un1YQmQCLmuP5tlIhvp140Sexe0oNvMTST1ppNz5M9GENveDkXUIVcZ2WNiWw1JG6T1hM+eu0SE0x3/ZdJHBNP5FZFDthcQRhQ+qa8liipcTQbnJQCJTgM5Cr/IoVba3So8MewXEtDGwx6zDbwuxHIW2qw7G47qKI=", "ARC-Message-Signature": "i=1; a=rsa-sha256; d=subspace.kernel.org;\n\ts=arc-20240116; t=1775826470; c=relaxed/simple;\n\tbh=GZXFFlTnzKdbEZFmQMlw20A/Pi6qX85elHZMjhsouqY=;\n\th=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References:\n\t In-Reply-To:To:Cc;\n b=lT0RpynSHWV3TdXBi+PZGAzacpxmGHO+Uc14ma0mcf0otd4ATXZtZmRYr9FFEIPFLQ3n7INW95EUpWNrby3u5/kRuCB1jsMdze76qlW9W1BkELQJqFjUN4MbdjuyLkEYN3aAOcSvqZDxl6d9lB9uKhznJ6b5cbM7NmVXYwlLrRg=", "ARC-Authentication-Results": "i=1; smtp.subspace.kernel.org;\n dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org\n header.b=JuH2bBoI; arc=none smtp.client-ip=10.30.226.201", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;\n\ts=k20201202; t=1775826470;\n\tbh=GZXFFlTnzKdbEZFmQMlw20A/Pi6qX85elHZMjhsouqY=;\n\th=From:Date:Subject:References:In-Reply-To:To:Cc:Reply-To:From;\n\tb=JuH2bBoIG9m6GkN6JhjEz7Dy9ZRoEnSOiQbLQdByGX/NfLAPZ0MOemEBZ0iLi9ywc\n\t I/4OsvWS8Mrei021+yNzh7f57v3ZbYvelNc869X7jaXcWOuTf085yGqRvGM2VtMOAy\n\t FxGkz51hMjr7CE2cVntHGqb0ueCwO+3MPqY9WIgDXCsXoD/jh4oIjqW0SHNOt8sT1g\n\t erKkRPGydp3E3DxFGfJfIq7+SX8uc8u71L86RzZyhFz+o9nte5cz7tJqwTU5rxZE76\n\t 78da0wHKFGL8LobY21NrMWJKUzE5fZ3yu5JxLOBb1K6tRWDZUBy+BEGAoRqHalFNt/\n\t PsdkLUStlRpug==", "From": "Nathan Lynch via B4 Relay <devnull+nathan.lynch.amd.com@kernel.org>", "Date": "Fri, 10 Apr 2026 08:07:23 -0500", "Subject": "[PATCH 13/23] dmaengine: sdxi: Add unit tests for descriptor ring\n reservations", "Precedence": "bulk", "X-Mailing-List": "linux-pci@vger.kernel.org", "List-Id": "<linux-pci.vger.kernel.org>", "List-Subscribe": "<mailto:linux-pci+subscribe@vger.kernel.org>", "List-Unsubscribe": "<mailto:linux-pci+unsubscribe@vger.kernel.org>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"utf-8\"", "Content-Transfer-Encoding": "7bit", "Message-Id": "<20260410-sdxi-base-v1-13-1d184cb5c60a@amd.com>", "References": "<20260410-sdxi-base-v1-0-1d184cb5c60a@amd.com>", "In-Reply-To": "<20260410-sdxi-base-v1-0-1d184cb5c60a@amd.com>", "To": "Vinod Koul <vkoul@kernel.org>", "Cc": "Wei Huang <wei.huang2@amd.com>,\n Mario Limonciello <mario.limonciello@amd.com>,\n Bjorn Helgaas <bhelgaas@google.com>,\n Jonathan Cameron <jonathan.cameron@huawei.com>,\n Stephen Bates <Stephen.Bates@amd.com>, PradeepVineshReddy.Kodamati@amd.com,\n John.Kariuki@amd.com, linux-pci@vger.kernel.org,\n linux-kernel@vger.kernel.org, dmaengine@vger.kernel.org,\n Nathan Lynch <nathan.lynch@amd.com>", "X-Mailer": "b4 0.15.2", "X-Developer-Signature": "v=1; a=ed25519-sha256; t=1775826467; l=5269;\n i=nathan.lynch@amd.com; s=20260410; h=from:subject:message-id;\n bh=96M0WH79Yh/L9470L8b4C78AEBFI/SqNNfiQfEX5P3w=;\n b=0kiv+rFYk3O+HIB4rLGkttlP47zUaUiDRxHnrUNrT9OwF4HW7fidZvrEiVcyM/6SxrW+1zYNZ\n aj87bdlfu4/BeN7GcSxDwCgqj7X2LS6RCfksPVVCya3JtkzOeU5v/VK", "X-Developer-Key": "i=nathan.lynch@amd.com; a=ed25519;\n pk=PK4ozhq+/z9/2Jl5rgDmvHa9raVomv79qM8p1RAFpEw=", "X-Endpoint-Received": "by B4 Relay for nathan.lynch@amd.com/20260410 with\n auth_id=728", "X-Original-From": "Nathan Lynch <nathan.lynch@amd.com>", "Reply-To": "nathan.lynch@amd.com" }, "content": "From: Nathan Lynch <nathan.lynch@amd.com>\n\nAdd KUnit tests for the descriptor ring reservation API, covering:\n\n- Valid reservations: full-ring and single-slot after advancing the\n read pointer.\n\n- Error paths: zero or over-capacity count (-EINVAL), inconsistent\n index state (-EIO), and insufficient space (-EBUSY).\n\nA .kunitconfig is included ease of use:\n\n $ tools/testing/kunit/kunit.py run \\\n --kunitconfig=drivers/dma/sdxi/.kunitconfig\n\nNo SDXI hardware is required to run these tests.\n\nCo-developed-by: Wei Huang <wei.huang2@amd.com>\nSigned-off-by: Wei Huang <wei.huang2@amd.com>\nSigned-off-by: Nathan Lynch <nathan.lynch@amd.com>\n---\n drivers/dma/sdxi/.kunitconfig | 4 ++\n drivers/dma/sdxi/Kconfig | 8 ++++\n drivers/dma/sdxi/Makefile | 3 ++\n drivers/dma/sdxi/ring_kunit.c | 105 ++++++++++++++++++++++++++++++++++++++++++\n 4 files changed, 120 insertions(+)", "diff": "diff --git a/drivers/dma/sdxi/.kunitconfig b/drivers/dma/sdxi/.kunitconfig\nnew file mode 100644\nindex 000000000000..a98cf19770f0\n--- /dev/null\n+++ b/drivers/dma/sdxi/.kunitconfig\n@@ -0,0 +1,4 @@\n+CONFIG_KUNIT=y\n+CONFIG_DMADEVICES=y\n+CONFIG_SDXI=y\n+CONFIG_SDXI_KUNIT_TEST=y\ndiff --git a/drivers/dma/sdxi/Kconfig b/drivers/dma/sdxi/Kconfig\nindex a568284cd583..e616d3e323bc 100644\n--- a/drivers/dma/sdxi/Kconfig\n+++ b/drivers/dma/sdxi/Kconfig\n@@ -6,3 +6,11 @@ config SDXI\n \t Platform Data Mover devices. SDXI is a vendor-neutral\n \t standard for a memory-to-memory data mover and acceleration\n \t interface.\n+\n+config SDXI_KUNIT_TEST\n+\ttristate \"SDXI unit tests\" if !KUNIT_ALL_TESTS\n+\tdepends on SDXI && KUNIT\n+\tdefault KUNIT_ALL_TESTS\n+\thelp\n+\t KUnit tests for parts of the SDXI driver. Does not require\n+\t SDXI hardware.\ndiff --git a/drivers/dma/sdxi/Makefile b/drivers/dma/sdxi/Makefile\nindex 23536a1defc3..372f793c15b1 100644\n--- a/drivers/dma/sdxi/Makefile\n+++ b/drivers/dma/sdxi/Makefile\n@@ -7,3 +7,6 @@ sdxi-objs += \\\n \tring.o\n \n sdxi-$(CONFIG_PCI_MSI) += pci.o\n+\n+obj-$(CONFIG_SDXI_KUNIT_TEST) += \\\n+\tring_kunit.o\ndiff --git a/drivers/dma/sdxi/ring_kunit.c b/drivers/dma/sdxi/ring_kunit.c\nnew file mode 100644\nindex 000000000000..3bc7073e0c39\n--- /dev/null\n+++ b/drivers/dma/sdxi/ring_kunit.c\n@@ -0,0 +1,105 @@\n+// SPDX-License-Identifier: GPL-2.0-only\n+/*\n+ * SDXI descriptor ring management tests.\n+ *\n+ * Copyright Advanced Micro Devices, Inc.\n+ */\n+#include <kunit/device.h>\n+#include <kunit/test-bug.h>\n+#include <kunit/test.h>\n+#include <linux/container_of.h>\n+#include <linux/dma-mapping.h>\n+#include <linux/module.h>\n+#include <linux/packing.h>\n+#include <linux/string.h>\n+\n+#include \"ring.h\"\n+\n+MODULE_IMPORT_NS(\"EXPORTED_FOR_KUNIT_TESTING\");\n+\n+static void valid(struct kunit *t)\n+{\n+\t__le64 wi, ri;\n+\tstruct sdxi_ring_state r;\n+\tstruct sdxi_ring_resv resv;\n+\tstruct sdxi_desc *descs, *desc;\n+\n+\n+\tdescs = kunit_kmalloc_array(t, SZ_1K, sizeof(descs[0]),\n+\t\t\t\t GFP_KERNEL | __GFP_ZERO);\n+\tKUNIT_ASSERT_NOT_NULL(t, descs);\n+\n+\tri = wi = 0;\n+\tsdxi_ring_state_init(&r, &ri, &wi, SZ_1K, descs);\n+\n+\tKUNIT_EXPECT_EQ(t, sdxi_ring_try_reserve(&r, r.entries, &resv), 0);\n+\tKUNIT_EXPECT_EQ(t, resv.range.start, 0);\n+\tKUNIT_EXPECT_EQ(t, resv.range.end, r.entries - 1);\n+\tKUNIT_EXPECT_EQ(t, le64_to_cpu(wi), r.entries);\n+\tsdxi_ring_resv_foreach(&resv, desc) {\n+\t\tKUNIT_EXPECT_NOT_NULL_MSG(t, sdxi_ring_resv_next(&resv),\n+\t\t\t\"unexpected null descriptor for index %llu\", resv.iter);\n+\t}\n+\n+\tri = cpu_to_le64(1);\n+\tKUNIT_EXPECT_EQ(t, sdxi_ring_try_reserve(&r, 1, &resv), 0);\n+\tKUNIT_EXPECT_EQ(t, le64_to_cpu(wi), r.entries + 1);\n+\tKUNIT_EXPECT_NOT_NULL(t, sdxi_ring_resv_next(&resv));\n+}\n+\n+static void invalid(struct kunit *t)\n+{\n+\t__le64 wi, ri;\n+\tstruct sdxi_ring_state rs;\n+\tstruct sdxi_ring_resv resv;\n+\tstruct sdxi_desc *descs;\n+\n+\tdescs = kunit_kmalloc_array(t, SZ_1K, sizeof(descs[0]),\n+\t\t\t\t GFP_KERNEL | __GFP_ZERO);\n+\tKUNIT_ASSERT_NOT_NULL(t, descs);\n+\n+\tri = wi = 0;\n+\tsdxi_ring_state_init(&rs, &ri, &wi, SZ_1K, descs);\n+\n+\tKUNIT_EXPECT_EQ(t, sdxi_ring_try_reserve(&rs, 0, &resv), -EINVAL);\n+\tKUNIT_EXPECT_EQ(t, sdxi_ring_try_reserve(&rs, rs.entries + 1, &resv), -EINVAL);\n+\n+\tri = cpu_to_le64(1);\n+\tKUNIT_EXPECT_EQ(t, sdxi_ring_try_reserve(&rs, 1, &resv), -EIO);\n+\n+\tri = 0;\n+\twi = cpu_to_le64(rs.entries);\n+\tsdxi_ring_state_init(&rs, &ri, &wi, SZ_1K, descs);\n+\tKUNIT_EXPECT_EQ(t, sdxi_ring_try_reserve(&rs, 1, &resv), -EBUSY);\n+\n+\tri = cpu_to_le64(rs.entries);\n+\twi = cpu_to_le64(rs.entries + 1);\n+\tsdxi_ring_state_init(&rs, &ri, &wi, SZ_1K, descs);\n+\tKUNIT_EXPECT_EQ(t, sdxi_ring_try_reserve(&rs, rs.entries, &resv), -EBUSY);\n+}\n+\n+static struct kunit_case testcases[] = {\n+\tKUNIT_CASE(valid),\n+\tKUNIT_CASE(invalid),\n+\t{}\n+};\n+\n+static int setup_device(struct kunit *t)\n+{\n+\tstruct device *dev = kunit_device_register(t, \"sdxi-mock-device\");\n+\n+\tKUNIT_ASSERT_NOT_ERR_OR_NULL(t, dev);\n+\tt->priv = dev;\n+\treturn 0;\n+}\n+\n+static struct kunit_suite generic_desc_ts = {\n+\t.name = \"SDXI descriptor ring management\",\n+\t.test_cases = testcases,\n+\t.init = setup_device,\n+};\n+kunit_test_suite(generic_desc_ts);\n+\n+MODULE_DESCRIPTION(\"SDXI descriptor ring tests\");\n+MODULE_AUTHOR(\"Nathan Lynch\");\n+MODULE_LICENSE(\"GPL\");\n", "prefixes": [ "13/23" ] }