Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/1.1/patches/2221735/?format=api
{ "id": 2221735, "url": "http://patchwork.ozlabs.org/api/1.1/patches/2221735/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20260410074921.1254213-6-aleksandr.loktionov@intel.com/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/1.1/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20260410074921.1254213-6-aleksandr.loktionov@intel.com>", "date": "2026-04-10T07:49:16", "name": "[iwl-next,5/10] ice: improve Add/Update VSI error messages in ice_vsi_init()", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "69b301d2eae8d42fae04f7d1a6762312ca5b8a41", "submitter": { "id": 75597, "url": "http://patchwork.ozlabs.org/api/1.1/people/75597/?format=api", "name": "Loktionov, Aleksandr", "email": "aleksandr.loktionov@intel.com" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20260410074921.1254213-6-aleksandr.loktionov@intel.com/mbox/", "series": [ { "id": 499419, "url": "http://patchwork.ozlabs.org/api/1.1/series/499419/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/list/?series=499419", "date": "2026-04-10T07:49:11", "name": "ice: misc cleanups and improvements", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/499419/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/2221735/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/2221735/checks/", "tags": {}, "headers": { "Return-Path": "<intel-wired-lan-bounces@osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@legolas.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=osuosl.org header.i=@osuosl.org header.a=rsa-sha256\n header.s=default header.b=wWpcQhWH;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=osuosl.org\n (client-ip=2605:bc80:3010::136; helo=smtp3.osuosl.org;\n envelope-from=intel-wired-lan-bounces@osuosl.org;\n receiver=patchwork.ozlabs.org)" ], "Received": [ "from smtp3.osuosl.org (smtp3.osuosl.org [IPv6:2605:bc80:3010::136])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fsTV22VQVz1yCv\n\tfor <incoming@patchwork.ozlabs.org>; Fri, 10 Apr 2026 17:49:46 +1000 (AEST)", "from localhost (localhost [127.0.0.1])\n\tby smtp3.osuosl.org (Postfix) with ESMTP id E0A8960B9B;\n\tFri, 10 Apr 2026 07:49:37 +0000 (UTC)", "from smtp3.osuosl.org ([127.0.0.1])\n by localhost (smtp3.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP\n id nYpicmPZc63e; Fri, 10 Apr 2026 07:49:36 +0000 (UTC)", "from lists1.osuosl.org (lists1.osuosl.org [140.211.166.142])\n\tby smtp3.osuosl.org (Postfix) with ESMTP id 1A91B60AFB;\n\tFri, 10 Apr 2026 07:49:36 +0000 (UTC)", "from smtp1.osuosl.org (smtp1.osuosl.org [140.211.166.138])\n by lists1.osuosl.org (Postfix) with ESMTP id 0C92C1F6\n for <intel-wired-lan@lists.osuosl.org>; Fri, 10 Apr 2026 07:49:33 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n by smtp1.osuosl.org (Postfix) with ESMTP id 0A73481A81\n for <intel-wired-lan@lists.osuosl.org>; Fri, 10 Apr 2026 07:49:33 +0000 (UTC)", "from smtp1.osuosl.org ([127.0.0.1])\n by localhost (smtp1.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP\n id q9DmDhYqyTdD for <intel-wired-lan@lists.osuosl.org>;\n Fri, 10 Apr 2026 07:49:32 +0000 (UTC)", "from mgamail.intel.com (mgamail.intel.com [198.175.65.16])\n by smtp1.osuosl.org (Postfix) with ESMTPS id 0E7F3816EE\n for <intel-wired-lan@lists.osuosl.org>; Fri, 10 Apr 2026 07:49:32 +0000 (UTC)", "from orviesa008.jf.intel.com ([10.64.159.148])\n by orvoesa108.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 10 Apr 2026 00:49:32 -0700", "from amlin-019-225.igk.intel.com ([10.102.19.225])\n by orviesa008.jf.intel.com with ESMTP; 10 Apr 2026 00:49:31 -0700" ], "X-Virus-Scanned": [ "amavis at osuosl.org", "amavis at osuosl.org" ], "X-Comment": "SPF check N/A for local connections - client-ip=140.211.166.142;\n helo=lists1.osuosl.org; envelope-from=intel-wired-lan-bounces@osuosl.org;\n receiver=<UNKNOWN> ", "DKIM-Filter": [ "OpenDKIM Filter v2.11.0 smtp3.osuosl.org 1A91B60AFB", "OpenDKIM Filter v2.11.0 smtp1.osuosl.org 0E7F3816EE" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=osuosl.org;\n\ts=default; t=1775807376;\n\tbh=ZAuzYMcFaSAKnKPc86I3mepkCNQp2LDHGxT9J17Irq0=;\n\th=From:To:Cc:Date:In-Reply-To:References:Subject:List-Id:\n\t List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe:\n\t From;\n\tb=wWpcQhWHR5vDIXidZPP4I9DovKRAu3/+MQAsfEAy5Q4yY8EQ3dX1AgXqQS8uku+of\n\t PACPwTRnIhqx9RgTKkpN7Bb6WGePtoBd4GxWIJNUTaDLvlL+2OfxStNZcQbw8fmQ3p\n\t 9OjFQNq4zSPDFg2wNB0VZyl/9PGt7gDbgPjCk1LR/G+lrxF+pMhecSrNjoFr/+Yk5A\n\t l8PnLDMpK9drgEP2MJsPezlPMzbsz/KTjzXrBxr7DJN9w4w2lLxUCO7UXHh+u6KvOm\n\t ewKoLvPWxW27k3/R+Fu0ukN6dSLMNYDNmMpsL8h7JEBb566xCBkQC9xge5LNZttxj2\n\t jMEN/TZOtNGhA==", "Received-SPF": "Pass (mailfrom) identity=mailfrom; client-ip=198.175.65.16;\n helo=mgamail.intel.com; envelope-from=aleksandr.loktionov@intel.com;\n receiver=<UNKNOWN>", "DMARC-Filter": "OpenDMARC Filter v1.4.2 smtp1.osuosl.org 0E7F3816EE", "X-CSE-ConnectionGUID": [ "Mmi8M05rTZGm025Y+orb4Q==", "IWi7wY0FTW6hVjjbQHDDbg==" ], "X-CSE-MsgGUID": [ "qBUpbn0wSsWP01gGuAXn9A==", "X7frBN/QSRaZvfiy19Qa2w==" ], "X-IronPort-AV": [ "E=McAfee;i=\"6800,10657,11754\"; a=\"77007931\"", "E=Sophos;i=\"6.23,171,1770624000\"; d=\"scan'208\";a=\"77007931\"", "E=Sophos;i=\"6.23,171,1770624000\"; d=\"scan'208\";a=\"228941880\"" ], "X-ExtLoop1": "1", "From": "Aleksandr Loktionov <aleksandr.loktionov@intel.com>", "To": "intel-wired-lan@lists.osuosl.org, anthony.l.nguyen@intel.com,\n aleksandr.loktionov@intel.com", "Cc": "netdev@vger.kernel.org", "Date": "Fri, 10 Apr 2026 09:49:16 +0200", "Message-ID": "<20260410074921.1254213-6-aleksandr.loktionov@intel.com>", "X-Mailer": "git-send-email 2.52.0", "In-Reply-To": "<20260410074921.1254213-1-aleksandr.loktionov@intel.com>", "References": "<20260410074921.1254213-1-aleksandr.loktionov@intel.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-Mailman-Original-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple;\n d=intel.com; i=@intel.com; q=dns/txt; s=Intel;\n t=1775807372; x=1807343372;\n h=from:to:cc:subject:date:message-id:in-reply-to:\n references:mime-version:content-transfer-encoding;\n bh=k4iVYr4cQFswdWaUcb7d4oIndXtfp8j3uUYioC/j5M4=;\n b=GKFOwnTSWlZ93lMW8DPiHtwHtGPEE6uLe5Z5LZqJAAZGUcIUlZ+DjUXp\n pdovqi7mm1wfDc3vYTMDf88hcSHNbgcCnUlBgnFL4jBUShqiM3Z6iIbM3\n +nyBGZUtEbWZInYgT63NwC2M0etmF/H8+Odw2IW+eaNvey1mLDfzRk2Qe\n l3qmNO84IaV+Cc+j8kPhQ5OjyXyzJDp/JgPNcxEBKqDmPmardskTqKt7G\n 4LCBTnojnd+aEpo7kTIbBpEZEFNyHmH+GPLBRaVZpWykufhNtHhjWOFnQ\n 4kSP2ligcL9b4kBE0bGriRL9UIA6uUChZly+IRP+PkvRz4lpr368tCwo2\n g==;", "X-Mailman-Original-Authentication-Results": [ "smtp1.osuosl.org;\n dmarc=pass (p=none dis=none)\n header.from=intel.com", "smtp1.osuosl.org;\n dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com\n header.a=rsa-sha256 header.s=Intel header.b=GKFOwnTS" ], "Subject": "[Intel-wired-lan] [PATCH iwl-next 5/10] ice: improve Add/Update VSI\n error messages in ice_vsi_init()", "X-BeenThere": "intel-wired-lan@osuosl.org", "X-Mailman-Version": "2.1.30", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n <intel-wired-lan.osuosl.org>", "List-Unsubscribe": "<https://lists.osuosl.org/mailman/options/intel-wired-lan>,\n <mailto:intel-wired-lan-request@osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@osuosl.org?subject=help>", "List-Subscribe": "<https://lists.osuosl.org/mailman/listinfo/intel-wired-lan>,\n <mailto:intel-wired-lan-request@osuosl.org?subject=subscribe>", "Errors-To": "intel-wired-lan-bounces@osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@osuosl.org>" }, "content": "The error messages emitted when Add VSI or Update VSI Admin\nQueue commands fail are missing the VSI index and the last AQ\nerror code. Add both to match the pattern used elsewhere in\nthe driver for AQ-command failures, which helps narrow down\nfirmware issues without requiring debug logs.\n\nSigned-off-by: Eric Joyner <eric.joyner@intel.com>\nSigned-off-by: Aleksandr Loktionov <aleksandr.loktionov@intel.com>\n---\n drivers/net/ethernet/intel/ice/ice_lib.c | 8 ++++++--\n 1 file changed, 6 insertions(+), 2 deletions(-)", "diff": "diff --git a/drivers/net/ethernet/intel/ice/ice_lib.c b/drivers/net/ethernet/intel/ice/ice_lib.c\nindex 689c602..0e79d66 100644\n--- a/drivers/net/ethernet/intel/ice/ice_lib.c\n+++ b/drivers/net/ethernet/intel/ice/ice_lib.c\n@@ -1320,14 +1320,18 @@ static int ice_vsi_init(struct ice_vsi *vsi, u32 vsi_flags)\n \tif (vsi_flags & ICE_VSI_FLAG_INIT) {\n \t\tret = ice_add_vsi(hw, vsi->idx, ctxt, NULL);\n \t\tif (ret) {\n-\t\t\tdev_err(dev, \"Add VSI failed, err %d\\n\", ret);\n+\t\t\tdev_err(dev, \"Add VSI %d failed, err %d aq_err %s\\n\",\n+\t\t\t\tvsi->idx, ret,\n+\t\t\t\tlibie_aq_str(hw->adminq.sq_last_status));\n \t\t\tret = -EIO;\n \t\t\tgoto out;\n \t\t}\n \t} else {\n \t\tret = ice_update_vsi(hw, vsi->idx, ctxt, NULL);\n \t\tif (ret) {\n-\t\t\tdev_err(dev, \"Update VSI failed, err %d\\n\", ret);\n+\t\t\tdev_err(dev, \"Update VSI %d failed, err %d aq_err %s\\n\",\n+\t\t\t\tvsi->idx, ret,\n+\t\t\t\tlibie_aq_str(hw->adminq.sq_last_status));\n \t\t\tret = -EIO;\n \t\t\tgoto out;\n \t\t}\n", "prefixes": [ "iwl-next", "5/10" ] }