Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/1.1/patches/2221731/?format=api
{ "id": 2221731, "url": "http://patchwork.ozlabs.org/api/1.1/patches/2221731/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20260410074921.1254213-3-aleksandr.loktionov@intel.com/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/1.1/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20260410074921.1254213-3-aleksandr.loktionov@intel.com>", "date": "2026-04-10T07:49:13", "name": "[iwl-next,2/10] ice: allow setting advertised speed and duplex for all media types", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "703d0fdb8b9fa5e5266df667d278bc7031212da6", "submitter": { "id": 75597, "url": "http://patchwork.ozlabs.org/api/1.1/people/75597/?format=api", "name": "Loktionov, Aleksandr", "email": "aleksandr.loktionov@intel.com" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20260410074921.1254213-3-aleksandr.loktionov@intel.com/mbox/", "series": [ { "id": 499419, "url": "http://patchwork.ozlabs.org/api/1.1/series/499419/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/list/?series=499419", "date": "2026-04-10T07:49:11", "name": "ice: misc cleanups and improvements", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/499419/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/2221731/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/2221731/checks/", "tags": {}, "headers": { "Return-Path": "<intel-wired-lan-bounces@osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@legolas.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=osuosl.org header.i=@osuosl.org header.a=rsa-sha256\n header.s=default header.b=TtWFPRBJ;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=osuosl.org\n (client-ip=140.211.166.136; helo=smtp3.osuosl.org;\n envelope-from=intel-wired-lan-bounces@osuosl.org;\n receiver=patchwork.ozlabs.org)" ], "Received": [ "from smtp3.osuosl.org (smtp3.osuosl.org [140.211.166.136])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fsTTs0LnKz1yCv\n\tfor <incoming@patchwork.ozlabs.org>; Fri, 10 Apr 2026 17:49:37 +1000 (AEST)", "from localhost (localhost [127.0.0.1])\n\tby smtp3.osuosl.org (Postfix) with ESMTP id 5884F60AF1;\n\tFri, 10 Apr 2026 07:49:31 +0000 (UTC)", "from smtp3.osuosl.org ([127.0.0.1])\n by localhost (smtp3.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP\n id ghiOpVZSnNo2; Fri, 10 Apr 2026 07:49:30 +0000 (UTC)", "from lists1.osuosl.org (lists1.osuosl.org [140.211.166.142])\n\tby smtp3.osuosl.org (Postfix) with ESMTP id 8750C60B01;\n\tFri, 10 Apr 2026 07:49:30 +0000 (UTC)", "from smtp1.osuosl.org (smtp1.osuosl.org [IPv6:2605:bc80:3010::138])\n by lists1.osuosl.org (Postfix) with ESMTP id CD4AD237\n for <intel-wired-lan@lists.osuosl.org>; Fri, 10 Apr 2026 07:49:28 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n by smtp1.osuosl.org (Postfix) with ESMTP id AF7EB816EE\n for <intel-wired-lan@lists.osuosl.org>; Fri, 10 Apr 2026 07:49:28 +0000 (UTC)", "from smtp1.osuosl.org ([127.0.0.1])\n by localhost (smtp1.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP\n id uSCLsmurdC3Y for <intel-wired-lan@lists.osuosl.org>;\n Fri, 10 Apr 2026 07:49:27 +0000 (UTC)", "from mgamail.intel.com (mgamail.intel.com [198.175.65.16])\n by smtp1.osuosl.org (Postfix) with ESMTPS id B477181A81\n for <intel-wired-lan@lists.osuosl.org>; Fri, 10 Apr 2026 07:49:27 +0000 (UTC)", "from orviesa008.jf.intel.com ([10.64.159.148])\n by orvoesa108.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 10 Apr 2026 00:49:28 -0700", "from amlin-019-225.igk.intel.com ([10.102.19.225])\n by orviesa008.jf.intel.com with ESMTP; 10 Apr 2026 00:49:26 -0700" ], "X-Virus-Scanned": [ "amavis at osuosl.org", "amavis at osuosl.org" ], "X-Comment": "SPF check N/A for local connections - client-ip=140.211.166.142;\n helo=lists1.osuosl.org; envelope-from=intel-wired-lan-bounces@osuosl.org;\n receiver=<UNKNOWN> ", "DKIM-Filter": [ "OpenDKIM Filter v2.11.0 smtp3.osuosl.org 8750C60B01", "OpenDKIM Filter v2.11.0 smtp1.osuosl.org B477181A81" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=osuosl.org;\n\ts=default; t=1775807370;\n\tbh=X3CB25MK+kkcc/nONlvLcndRmgxZKhxv63XbXUXuRYE=;\n\th=From:To:Cc:Date:In-Reply-To:References:Subject:List-Id:\n\t List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe:\n\t From;\n\tb=TtWFPRBJR+nocXCK02qkvBp5bNn2+SosSoyKR66NM4/a5fSReQ/P6CJXBUdZ8+e1w\n\t tZ6YqI9UWK2TJGlWfpLcp4owHpeMOiZS9sq5ee1UGItW/M19nzn5blKLG+CeN5AaWZ\n\t ICBCw4YrEBMI3gQgFQr90ritzB3DXiGl6TZ60tArPz3DjhxdgGX1/wmZTmvSMAP2sE\n\t lTUVNYedL+ecccP7+mj8Xyvbh/VlnEXPfh+RMCQwrMqyQ6ttE3lo0Bvggak24KtqTy\n\t SHluUu8LPr4egBRauk9q7nXq/6wbvKtZEhc9POuvkJdIYtpNugUM9+EhNXRoRBjDxD\n\t N6v3s/B0PvCew==", "Received-SPF": "Pass (mailfrom) identity=mailfrom; client-ip=198.175.65.16;\n helo=mgamail.intel.com; envelope-from=aleksandr.loktionov@intel.com;\n receiver=<UNKNOWN>", "DMARC-Filter": "OpenDMARC Filter v1.4.2 smtp1.osuosl.org B477181A81", "X-CSE-ConnectionGUID": [ "59YgRRqXRM6UaZcyXfbgpg==", "BGghsdzWSX+egzL449Q2nw==" ], "X-CSE-MsgGUID": [ "V8ZnFX2mS6qzOjp04PzhPQ==", "aznF2ibFQ+6jUPvJqzkiFQ==" ], "X-IronPort-AV": [ "E=McAfee;i=\"6800,10657,11754\"; a=\"77007923\"", "E=Sophos;i=\"6.23,171,1770624000\"; d=\"scan'208\";a=\"77007923\"", "E=Sophos;i=\"6.23,171,1770624000\"; d=\"scan'208\";a=\"228941857\"" ], "X-ExtLoop1": "1", "From": "Aleksandr Loktionov <aleksandr.loktionov@intel.com>", "To": "intel-wired-lan@lists.osuosl.org, anthony.l.nguyen@intel.com,\n aleksandr.loktionov@intel.com", "Cc": "netdev@vger.kernel.org,\n\tPaul Greenwalt <paul.greenwalt@intel.com>", "Date": "Fri, 10 Apr 2026 09:49:13 +0200", "Message-ID": "<20260410074921.1254213-3-aleksandr.loktionov@intel.com>", "X-Mailer": "git-send-email 2.52.0", "In-Reply-To": "<20260410074921.1254213-1-aleksandr.loktionov@intel.com>", "References": "<20260410074921.1254213-1-aleksandr.loktionov@intel.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-Mailman-Original-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple;\n d=intel.com; i=@intel.com; q=dns/txt; s=Intel;\n t=1775807368; x=1807343368;\n h=from:to:cc:subject:date:message-id:in-reply-to:\n references:mime-version:content-transfer-encoding;\n bh=76l1DpkeYFYQbHgxmmAEoNFOKiq3yLo1D4+eNocGcQQ=;\n b=dUjPmbQKVwCk2D/e0JEdwAASFbMnGumxOZszoWHLtcLLyyCAnVrmCTFc\n qtNokuxjPN3B24hUrJM+vJgyVuA3wgK74NEOEb6ryejh+qzfXbmu+pPLF\n RgLaNDlGtbXBKtLAfBbXEmFjCIcsKSis5VVaqMc0SlsbOIyi09ZqIzRHZ\n OtNWf8yYVYi+5cz+GBGHpjFwG1uCpED9T83N0jYNw016N4+n3EP5SVD1T\n szOcO0Lp0WYUEOqsEZl5rWBhIHRWsNKCRp/vAVOHKVpW4zRIjtCcmxrIK\n 80c/UhwhpDws+QA5iXVDpUTyrm+YJZ1NoTL6W33dzF/4ssGHsPHQJprhy\n A==;", "X-Mailman-Original-Authentication-Results": [ "smtp1.osuosl.org;\n dmarc=pass (p=none dis=none)\n header.from=intel.com", "smtp1.osuosl.org;\n dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com\n header.a=rsa-sha256 header.s=Intel header.b=dUjPmbQK" ], "Subject": "[Intel-wired-lan] [PATCH iwl-next 2/10] ice: allow setting\n advertised speed and duplex for all media types", "X-BeenThere": "intel-wired-lan@osuosl.org", "X-Mailman-Version": "2.1.30", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n <intel-wired-lan.osuosl.org>", "List-Unsubscribe": "<https://lists.osuosl.org/mailman/options/intel-wired-lan>,\n <mailto:intel-wired-lan-request@osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@osuosl.org?subject=help>", "List-Subscribe": "<https://lists.osuosl.org/mailman/listinfo/intel-wired-lan>,\n <mailto:intel-wired-lan-request@osuosl.org?subject=subscribe>", "Errors-To": "intel-wired-lan-bounces@osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@osuosl.org>" }, "content": "From: Paul Greenwalt <paul.greenwalt@intel.com>\n\nWhen AUI media type support was added, the set of media types that\nsupport configuring speed and duplex via autonegotiation was not\nupdated. This results in AUI media types being rejected when the user\nsets speed and duplex via ethtool.\n\nFix this by only refusing media type NONE or UNKNOWN (in strict mode);\nall other media types should support setting speed and duplex.\n\nSigned-off-by: Paul Greenwalt <paul.greenwalt@intel.com>\nSigned-off-by: Aleksandr Loktionov <aleksandr.loktionov@intel.com>\n---\n drivers/net/ethernet/intel/ice/ice_ethtool.c | 17 +++++++++++------\n drivers/net/ethernet/intel/ice/ice_type.h | 2 ++\n 2 files changed, 13 insertions(+), 6 deletions(-)", "diff": "diff --git a/drivers/net/ethernet/intel/ice/ice_ethtool.c b/drivers/net/ethernet/intel/ice/ice_ethtool.c\nindex b5a63b1..96ce6b3 100644\n--- a/drivers/net/ethernet/intel/ice/ice_ethtool.c\n+++ b/drivers/net/ethernet/intel/ice/ice_ethtool.c\n@@ -2217,6 +2217,7 @@ ice_set_link_ksettings(struct net_device *netdev,\n \tu8 autoneg_changed = 0;\n \tu64 phy_type_high = 0;\n \tu64 phy_type_low = 0;\n+\tbool lenient_mode;\n \tbool linkup;\n \tint err;\n \n@@ -2225,10 +2226,14 @@ ice_set_link_ksettings(struct net_device *netdev,\n \tif (!pi)\n \t\treturn -EIO;\n \n-\tif (pi->phy.media_type != ICE_MEDIA_BASET &&\n-\t pi->phy.media_type != ICE_MEDIA_FIBER &&\n-\t pi->phy.media_type != ICE_MEDIA_BACKPLANE &&\n-\t pi->phy.media_type != ICE_MEDIA_DA &&\n+\tlenient_mode = test_bit(ICE_FLAG_LINK_LENIENT_MODE_ENA, pf->flags);\n+\n+\t/* Setting the speed and duplex advertised by autonegotiation is\n+\t * supported for all media types, so only return unsupported for media\n+\t * type none or unknown in strict mode.\n+\t */\n+\tif ((pi->phy.media_type == ICE_MEDIA_NONE ||\n+\t (pi->phy.media_type == ICE_MEDIA_UNKNOWN && !lenient_mode)) &&\n \t pi->phy.link_info.link_info & ICE_AQ_LINK_UP)\n \t\treturn -EOPNOTSUPP;\n \n@@ -2258,7 +2263,7 @@ ice_set_link_ksettings(struct net_device *netdev,\n \tif (!bitmap_subset(copy_ks.link_modes.advertising,\n \t\t\t safe_ks.link_modes.supported,\n \t\t\t __ETHTOOL_LINK_MODE_MASK_NBITS)) {\n-\t\tif (!test_bit(ICE_FLAG_LINK_LENIENT_MODE_ENA, pf->flags))\n+\t\tif (!lenient_mode)\n \t\t\tnetdev_info(netdev, \"The selected speed is not supported by the current media. Please select a link speed that is supported by the current media.\\n\");\n \t\terr = -EOPNOTSUPP;\n \t\tgoto done;\n@@ -2359,7 +2364,7 @@ ice_set_link_ksettings(struct net_device *netdev,\n \t\t * intersect the requested advertised speed with NVM media type\n \t\t * PHY types.\n \t\t */\n-\t\tif (test_bit(ICE_FLAG_LINK_LENIENT_MODE_ENA, pf->flags)) {\n+\t\tif (lenient_mode) {\n \t\t\tconfig.phy_type_high = cpu_to_le64(phy_type_high) &\n \t\t\t\t\t pf->nvm_phy_type_hi;\n \t\t\tconfig.phy_type_low = cpu_to_le64(phy_type_low) &\n\ndiff --git a/drivers/net/ethernet/intel/ice/ice_type.h b/drivers/net/ethernet/intel/ice/ice_type.h\n--- a/drivers/net/ethernet/intel/ice/ice_type.h\n+++ b/drivers/net/ethernet/intel/ice/ice_type.h\n@@ -151,6 +151,8 @@ enum ice_media_type {\n \tICE_MEDIA_UNKNOWN = 0,\n \tICE_MEDIA_FIBER,\n \tICE_MEDIA_BASET,\n \tICE_MEDIA_BACKPLANE,\n \tICE_MEDIA_DA,\n+\tICE_MEDIA_AUI,\n+\tICE_MEDIA_NONE,\n };\n", "prefixes": [ "iwl-next", "2/10" ] }