Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/1.1/patches/2221719/?format=api
{ "id": 2221719, "url": "http://patchwork.ozlabs.org/api/1.1/patches/2221719/?format=api", "web_url": "http://patchwork.ozlabs.org/project/linuxppc-dev/patch/20260410055040.39233-17-kwilczynski@kernel.org/", "project": { "id": 2, "url": "http://patchwork.ozlabs.org/api/1.1/projects/2/?format=api", "name": "Linux PPC development", "link_name": "linuxppc-dev", "list_id": "linuxppc-dev.lists.ozlabs.org", "list_email": "linuxppc-dev@lists.ozlabs.org", "web_url": "https://github.com/linuxppc/wiki/wiki", "scm_url": "https://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux.git", "webscm_url": "https://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux.git/" }, "msgid": "<20260410055040.39233-17-kwilczynski@kernel.org>", "date": "2026-04-10T05:50:36", "name": "[16/20] PCI/sysfs: Remove pci_{create,remove}_sysfs_dev_files()", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "b0019529819a2f9834e22db25003ec769bd4d01b", "submitter": { "id": 86709, "url": "http://patchwork.ozlabs.org/api/1.1/people/86709/?format=api", "name": "Krzysztof Wilczyński", "email": "kwilczynski@kernel.org" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/linuxppc-dev/patch/20260410055040.39233-17-kwilczynski@kernel.org/mbox/", "series": [ { "id": 499413, "url": "http://patchwork.ozlabs.org/api/1.1/series/499413/?format=api", "web_url": "http://patchwork.ozlabs.org/project/linuxppc-dev/list/?series=499413", "date": "2026-04-10T05:50:20", "name": "PCI: Convert all dynamic sysfs attributes to static", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/499413/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/2221719/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/2221719/checks/", "tags": {}, "headers": { "Return-Path": "\n <linuxppc-dev+bounces-19548-incoming=patchwork.ozlabs.org@lists.ozlabs.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "linuxppc-dev@lists.ozlabs.org" ], "Delivered-To": "patchwork-incoming@legolas.ozlabs.org", "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256\n header.s=k20201202 header.b=fKo56qqF;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=lists.ozlabs.org\n (client-ip=2404:9400:21b9:f100::1; helo=lists.ozlabs.org;\n envelope-from=linuxppc-dev+bounces-19548-incoming=patchwork.ozlabs.org@lists.ozlabs.org;\n receiver=patchwork.ozlabs.org)", "lists.ozlabs.org;\n arc=none smtp.remote-ip=172.105.4.254", "lists.ozlabs.org;\n dmarc=pass (p=quarantine dis=none) header.from=kernel.org", "lists.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256\n header.s=k20201202 header.b=fKo56qqF;\n\tdkim-atps=neutral", "lists.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=kernel.org\n (client-ip=172.105.4.254; helo=tor.source.kernel.org;\n envelope-from=kwilczynski@kernel.org; receiver=lists.ozlabs.org)" ], "Received": [ "from lists.ozlabs.org (lists.ozlabs.org\n [IPv6:2404:9400:21b9:f100::1])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fsSkV47bRz1yCv\n\tfor <incoming@patchwork.ozlabs.org>; Fri, 10 Apr 2026 17:15:30 +1000 (AEST)", "from boromir.ozlabs.org (localhost [127.0.0.1])\n\tby lists.ozlabs.org (Postfix) with ESMTP id 4fsSkV2t3Fz2yjq;\n\tFri, 10 Apr 2026 17:15:30 +1000 (AEST)", "from tor.source.kernel.org (tor.source.kernel.org [172.105.4.254])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519)\n\t(No client certificate requested)\n\tby lists.ozlabs.org (Postfix) with ESMTPS id 4fsQss32Nqz2yRl\n\tfor <linuxppc-dev@lists.ozlabs.org>; Fri, 10 Apr 2026 15:51:45 +1000 (AEST)", "from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58])\n\tby tor.source.kernel.org (Postfix) with ESMTP id 69E8C60128;\n\tFri, 10 Apr 2026 05:51:43 +0000 (UTC)", "by smtp.kernel.org (Postfix) with ESMTPSA id BEE0EC2BCAF;\n\tFri, 10 Apr 2026 05:51:39 +0000 (UTC)" ], "ARC-Seal": "i=1; a=rsa-sha256; d=lists.ozlabs.org; s=201707; t=1775800306;\n\tcv=none;\n b=Zst9NACO8HofNR1AkCCva+mlq1BJgWGqGEsEwktUyjPR1JQvRKIKmlaZpPfWXJnhn5m8idLfhIQV+ebaqBukH7fm3rwMuC5q+eN91mUkQn5BjpBQRI8MR9LYKz+BTpxBkbikVC2EUS31jKtox8BhW1+eTqnC5xr7kWvKLXG8tPSBco1Mb+YsTpc7k2gCXKz/jfhUfUj9hmtl1PbZ0ZtONsGv7LO03j/4qFajyUns58eggUx+WdQ9jktgLkQhVu3qvtNVZ/LZkEoDl5atpEB5eKpkCzzGCeQ2pXZXe6aS/OWS6SgGCH8ARhfm5zTqOgG5zgOMvlU9DI9t06JQMjLSwg==", "ARC-Message-Signature": "i=1; a=rsa-sha256; d=lists.ozlabs.org; s=201707;\n\tt=1775800306; c=relaxed/relaxed;\n\tbh=dCYgudYHHOWWBef8ctNMRWHZz4BpARsdhTyPU9lZoEs=;\n\th=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References:\n\t MIME-Version:Content-Type;\n b=MNOT2Fl7rcvLj4vdK1holm/oFrHNMoiRyXE6FBZe5LGdoC4HA6edAgGw3QGFAeSaIDa6vL3OiMJbq1ONgt1khppVE/uzUyl3HEAYJDymiBQg2d4vQgB0uqRzlHC+pyCKcZH43mm2eVwY5uAjGMlVq+VI4QYi4KWtS49MNIrjt74LwOtd6I0Jsvix/OdobzSA+xzzM8PGuT0pINQ/x1xOh5sJT9oMkLXwp2mN2mD4l9YCt1RKNaFNUBrNY8qaSvAv/wD5jLKq2vPhlaRhHiWgDWyaCH+lVRTEtGj7xiPVFGvhQbJXmjWY5oMurbtOiAtNCjEEQOghsqy/x8wC2MEa1g==", "ARC-Authentication-Results": "i=1; lists.ozlabs.org;\n dmarc=pass (p=quarantine dis=none) header.from=kernel.org;\n dkim=pass (2048-bit key;\n unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256\n header.s=k20201202 header.b=fKo56qqF; dkim-atps=neutral;\n spf=pass (client-ip=172.105.4.254; helo=tor.source.kernel.org;\n envelope-from=kwilczynski@kernel.org;\n receiver=lists.ozlabs.org) smtp.mailfrom=kernel.org", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;\n\ts=k20201202; t=1775800303;\n\tbh=lMntqWv4FJlC5Eob4H2wN2PzFM5mxJOGAsB5cVrnmM4=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=fKo56qqFu7ujSnOWOqagKgX3VWv0GT5NKAEujmYnOzF9h0sRpa8zJ3on/SH6oj1kL\n\t xp5QljIGWbZEzixMNHy8hUhJbn+QBGR01XazochBtVcwgbDdTEI0mBQYDCJMKEtog7\n\t 2Q86p32GVBMbeUQaRIxEPrCsO8CKU2MZn0ma7X3v62w4WVEf1XqA8HQ/ulDtcG+H6M\n\t BE0Gw9zYvNdQUzAdNKZXcWDa7MX/D1jeWiGNjNJ+nDjom79bErOIVjtm0lkpzQZqz8\n\t gXJoTFNXUcJEsJ20VbYQZ3goYpRJWcYt8/dGZfrJ92dEpS5nYvzHoQAr/D3H8Y/q1E\n\t yjOKLgrOifclw==", "From": "=?utf-8?q?Krzysztof_Wilczy=C5=84ski?= <kwilczynski@kernel.org>", "To": "Bjorn Helgaas <bhelgaas@google.com>", "Cc": "Bjorn Helgaas <helgaas@kernel.org>,\n Manivannan Sadhasivam <mani@kernel.org>,\n Lorenzo Pieralisi <lpieralisi@kernel.org>,\n Magnus Lindholm <linmag7@gmail.com>, Matt Turner <mattst88@gmail.com>,\n Richard Henderson <richard.henderson@linaro.org>,\n Christophe Leroy <chleroy@kernel.org>,\n Madhavan Srinivasan <maddy@linux.ibm.com>,\n Michael Ellerman <mpe@ellerman.id.au>, Nicholas Piggin <npiggin@gmail.com>,\n Dexuan Cui <decui@microsoft.com>,\n =?utf-8?q?Krzysztof_Ha=C5=82asa?= <khalasa@piap.pl>,\n Lukas Wunner <lukas@wunner.de>, \"Oliver O'Halloran\" <oohall@gmail.com>,\n Saurabh Singh Sengar <ssengar@microsoft.com>,\n Shuan He <heshuan@bytedance.com>, Srivatsa Bhat <srivatsabhat@microsoft.com>,\n\t=?utf-8?q?Ilpo_J=C3=A4rvinen?= <ilpo.jarvinen@linux.intel.com>,\n linux-pci@vger.kernel.org, linux-alpha@vger.kernel.org,\n linuxppc-dev@lists.ozlabs.org", "Subject": "[PATCH 16/20] PCI/sysfs: Remove pci_{create,remove}_sysfs_dev_files()", "Date": "Fri, 10 Apr 2026 05:50:36 +0000", "Message-ID": "<20260410055040.39233-17-kwilczynski@kernel.org>", "X-Mailer": "git-send-email 2.53.0", "In-Reply-To": "<20260410055040.39233-1-kwilczynski@kernel.org>", "References": "<20260410055040.39233-1-kwilczynski@kernel.org>", "X-Mailing-List": "linuxppc-dev@lists.ozlabs.org", "List-Id": "<linuxppc-dev.lists.ozlabs.org>", "List-Help": "<mailto:linuxppc-dev+help@lists.ozlabs.org>", "List-Owner": "<mailto:linuxppc-dev+owner@lists.ozlabs.org>", "List-Post": "<mailto:linuxppc-dev@lists.ozlabs.org>", "List-Archive": "<https://lore.kernel.org/linuxppc-dev/>,\n <https://lists.ozlabs.org/pipermail/linuxppc-dev/>", "List-Subscribe": "<mailto:linuxppc-dev+subscribe@lists.ozlabs.org>,\n <mailto:linuxppc-dev+subscribe-digest@lists.ozlabs.org>,\n <mailto:linuxppc-dev+subscribe-nomail@lists.ozlabs.org>", "List-Unsubscribe": "<mailto:linuxppc-dev+unsubscribe@lists.ozlabs.org>", "Precedence": "list", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=UTF-8", "Content-Transfer-Encoding": "8bit", "X-Spam-Status": "No, score=-0.2 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED,\n\tDKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,SPF_PASS\n\tautolearn=disabled version=4.0.1 OzLabs 8", "X-Spam-Checker-Version": "SpamAssassin 4.0.1 (2024-03-25) on lists.ozlabs.org" }, "content": "Currently, pci_create_sysfs_dev_files() and pci_remove_sysfs_dev_files()\nare no-op stubs. With both the generic and Alpha resource files now\nhandled by static attribute groups, no platform needs dynamic per-device\nsysfs file creation.\n\nThus, remove both functions, their declarations, and the call sites in\npci_bus_add_device() and pci_stop_bus_device().\n\nRemove __weak pci_create_resource_files() and pci_remove_resource_files()\nstubs and their declarations in pci.h, as no architecture overrides them\nanymore.\n\nRemove the res_attr[] and res_attr_wc[] fields from struct pci_dev\nwhich were used to track dynamically allocated resource attributes.\n\nFinally, simplify pci_sysfs_init() to only handle legacy file creation\nunder HAVE_PCI_LEGACY, removing the per-device loop and the\nHAVE_PCI_SYSFS_INIT helper added earlier.\n\nSigned-off-by: Krzysztof Wilczyński <kwilczynski@kernel.org>\n---\n drivers/pci/bus.c | 1 -\n drivers/pci/pci-sysfs.c | 53 ++---------------------------------------\n drivers/pci/pci.h | 4 ----\n drivers/pci/remove.c | 1 -\n include/linux/pci.h | 9 -------\n 5 files changed, 2 insertions(+), 66 deletions(-)", "diff": "diff --git a/drivers/pci/bus.c b/drivers/pci/bus.c\nindex 6c1ad1f542d9..655ed53436d3 100644\n--- a/drivers/pci/bus.c\n+++ b/drivers/pci/bus.c\n@@ -354,7 +354,6 @@ void pci_bus_add_device(struct pci_dev *dev)\n \tpci_fixup_device(pci_fixup_final, dev);\n \tif (pci_is_bridge(dev))\n \t\tof_pci_make_dev_node(dev);\n-\tpci_create_sysfs_dev_files(dev);\n \tpci_proc_attach_device(dev);\n \tpci_bridge_d3_update(dev);\n \ndiff --git a/drivers/pci/pci-sysfs.c b/drivers/pci/pci-sysfs.c\nindex 062921d5df9b..40b5e21d77f3 100644\n--- a/drivers/pci/pci-sysfs.c\n+++ b/drivers/pci/pci-sysfs.c\n@@ -37,12 +37,7 @@\n #define ARCH_PCI_DEV_GROUPS\n #endif\n \n-#if defined(HAVE_PCI_LEGACY) || \\\n-\t!defined(HAVE_PCI_MMAP) && !defined(ARCH_GENERIC_PCI_MMAP_RESOURCE)\n-#define HAVE_PCI_SYSFS_INIT\n-#endif\n-\n-#ifdef HAVE_PCI_SYSFS_INIT\n+#ifdef HAVE_PCI_LEGACY\n static int sysfs_initialized;\t/* = 0 */\n #endif\n \n@@ -1399,9 +1394,6 @@ static const struct attribute_group *pci_dev_resource_attr_groups[] = {\n \t&pci_dev_resource_wc_attr_group,\n \tNULL,\n };\n-#else\n-int __weak pci_create_resource_files(struct pci_dev *dev) { return 0; }\n-void __weak pci_remove_resource_files(struct pci_dev *dev) { }\n #endif\n \n /**\n@@ -1771,54 +1763,13 @@ static const struct attribute_group pci_dev_resource_resize_attr_group = {\n };\n #endif\n \n-#if defined(HAVE_PCI_MMAP) || defined(ARCH_GENERIC_PCI_MMAP_RESOURCE)\n-int pci_create_sysfs_dev_files(struct pci_dev *pdev) { return 0; }\n-void pci_remove_sysfs_dev_files(struct pci_dev *pdev) { }\n-#else\n-int __must_check pci_create_sysfs_dev_files(struct pci_dev *pdev)\n-{\n-\tif (!sysfs_initialized)\n-\t\treturn -EACCES;\n-\n-\treturn pci_create_resource_files(pdev);\n-}\n-\n-/**\n- * pci_remove_sysfs_dev_files - cleanup PCI specific sysfs files\n- * @pdev: device whose entries we should free\n- *\n- * Cleanup when @pdev is removed from sysfs.\n- */\n-void pci_remove_sysfs_dev_files(struct pci_dev *pdev)\n-{\n-\tif (!sysfs_initialized)\n-\t\treturn;\n-\n-\tpci_remove_resource_files(pdev);\n-}\n-#endif\n-\n-#ifdef HAVE_PCI_SYSFS_INIT\n+#ifdef HAVE_PCI_LEGACY\n static int __init pci_sysfs_init(void)\n {\n-#if defined(HAVE_PCI_MMAP) || defined(ARCH_GENERIC_PCI_MMAP_RESOURCE)\n \tstruct pci_bus *pbus = NULL;\n \n \tsysfs_initialized = 1;\n-#else\n-\tstruct pci_dev *pdev = NULL;\n-\tstruct pci_bus *pbus = NULL;\n-\tint retval;\n \n-\tsysfs_initialized = 1;\n-\tfor_each_pci_dev(pdev) {\n-\t\tretval = pci_create_sysfs_dev_files(pdev);\n-\t\tif (retval) {\n-\t\t\tpci_dev_put(pdev);\n-\t\t\treturn retval;\n-\t\t}\n-\t}\n-#endif\n \twhile ((pbus = pci_find_next_bus(pbus)))\n \t\tpci_create_legacy_files(pbus);\n \ndiff --git a/drivers/pci/pci.h b/drivers/pci/pci.h\nindex 13d998fbacce..1bf165595583 100644\n--- a/drivers/pci/pci.h\n+++ b/drivers/pci/pci.h\n@@ -391,16 +391,12 @@ static inline int pci_no_d1d2(struct pci_dev *dev)\n }\n \n #ifdef CONFIG_SYSFS\n-int pci_create_sysfs_dev_files(struct pci_dev *pdev);\n-void pci_remove_sysfs_dev_files(struct pci_dev *pdev);\n extern const struct attribute_group *pci_dev_groups[];\n extern const struct attribute_group *pci_dev_attr_groups[];\n extern const struct attribute_group *pcibus_groups[];\n extern const struct attribute_group *pci_bus_groups[];\n extern const struct attribute_group pci_doe_sysfs_group;\n #else\n-static inline int pci_create_sysfs_dev_files(struct pci_dev *pdev) { return 0; }\n-static inline void pci_remove_sysfs_dev_files(struct pci_dev *pdev) { }\n #define pci_dev_groups NULL\n #define pci_dev_attr_groups NULL\n #define pcibus_groups NULL\ndiff --git a/drivers/pci/remove.c b/drivers/pci/remove.c\nindex e9d519993853..6e796dbc5b29 100644\n--- a/drivers/pci/remove.c\n+++ b/drivers/pci/remove.c\n@@ -26,7 +26,6 @@ static void pci_stop_dev(struct pci_dev *dev)\n \n \tdevice_release_driver(&dev->dev);\n \tpci_proc_detach_device(dev);\n-\tpci_remove_sysfs_dev_files(dev);\n \tof_pci_remove_node(dev);\n }\n \ndiff --git a/include/linux/pci.h b/include/linux/pci.h\nindex 2940c80fd7c5..5a418fbe5a5f 100644\n--- a/include/linux/pci.h\n+++ b/include/linux/pci.h\n@@ -507,10 +507,6 @@ struct pci_dev {\n \tspinlock_t\tpcie_cap_lock;\t\t/* Protects RMW ops in capability accessors */\n \tu32\t\tsaved_config_space[16]; /* Config space saved at suspend time */\n \tstruct hlist_head saved_cap_space;\n-#if !defined(HAVE_PCI_MMAP) && !defined(ARCH_GENERIC_PCI_MMAP_RESOURCE)\n-\tstruct bin_attribute *res_attr[DEVICE_COUNT_RESOURCE]; /* sysfs file for resources */\n-\tstruct bin_attribute *res_attr_wc[DEVICE_COUNT_RESOURCE]; /* sysfs file for WC mapping of resources */\n-#endif\n \n #ifdef CONFIG_HOTPLUG_PCI_PCIE\n \tunsigned int\tbroken_cmd_compl:1;\t/* No compl for some cmds */\n@@ -2503,11 +2499,6 @@ int pcibios_alloc_irq(struct pci_dev *dev);\n void pcibios_free_irq(struct pci_dev *dev);\n resource_size_t pcibios_default_alignment(void);\n \n-#if !defined(HAVE_PCI_MMAP) && !defined(ARCH_GENERIC_PCI_MMAP_RESOURCE)\n-extern int pci_create_resource_files(struct pci_dev *dev);\n-extern void pci_remove_resource_files(struct pci_dev *dev);\n-#endif\n-\n #if defined(CONFIG_PCI_MMCONFIG) || defined(CONFIG_ACPI_MCFG)\n void __init pci_mmcfg_early_init(void);\n void __init pci_mmcfg_late_init(void);\n", "prefixes": [ "16/20" ] }