Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/1.1/patches/2221579/?format=api
{ "id": 2221579, "url": "http://patchwork.ozlabs.org/api/1.1/patches/2221579/?format=api", "web_url": "http://patchwork.ozlabs.org/project/uboot/patch/20260409-mtk-pmic-fixes-v2-3-73e83aa6345b@baylibre.com/", "project": { "id": 18, "url": "http://patchwork.ozlabs.org/api/1.1/projects/18/?format=api", "name": "U-Boot", "link_name": "uboot", "list_id": "u-boot.lists.denx.de", "list_email": "u-boot@lists.denx.de", "web_url": null, "scm_url": null, "webscm_url": null }, "msgid": "<20260409-mtk-pmic-fixes-v2-3-73e83aa6345b@baylibre.com>", "date": "2026-04-09T20:30:35", "name": "[v2,3/8] power: pmic: mtk-pwrap: add init capability flag", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "3526ce160c9f2fe0de2de175466275fa1859c1f9", "submitter": { "id": 87228, "url": "http://patchwork.ozlabs.org/api/1.1/people/87228/?format=api", "name": "David Lechner", "email": "dlechner@baylibre.com" }, "delegate": { "id": 12423, "url": "http://patchwork.ozlabs.org/api/1.1/users/12423/?format=api", "username": "Jaehoon", "first_name": "Jaehoon", "last_name": "Chung", "email": "jh80.chung@samsung.com" }, "mbox": "http://patchwork.ozlabs.org/project/uboot/patch/20260409-mtk-pmic-fixes-v2-3-73e83aa6345b@baylibre.com/mbox/", "series": [ { "id": 499358, "url": "http://patchwork.ozlabs.org/api/1.1/series/499358/?format=api", "web_url": "http://patchwork.ozlabs.org/project/uboot/list/?series=499358", "date": "2026-04-09T20:30:32", "name": "power: pmic: mtk-pwrap: add more capability flags", "version": 2, "mbox": "http://patchwork.ozlabs.org/series/499358/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/2221579/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/2221579/checks/", "tags": {}, "headers": { "Return-Path": "<u-boot-bounces@lists.denx.de>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@legolas.ozlabs.org", "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=baylibre-com.20251104.gappssmtp.com\n header.i=@baylibre-com.20251104.gappssmtp.com header.a=rsa-sha256\n header.s=20251104 header.b=gxtcEoXE;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=lists.denx.de\n (client-ip=2a01:238:438b:c500:173d:9f52:ddab:ee01; helo=phobos.denx.de;\n envelope-from=u-boot-bounces@lists.denx.de; receiver=patchwork.ozlabs.org)", "phobos.denx.de;\n dmarc=none (p=none dis=none) header.from=baylibre.com", "phobos.denx.de;\n spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de", "phobos.denx.de;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=baylibre-com.20251104.gappssmtp.com\n header.i=@baylibre-com.20251104.gappssmtp.com header.b=\"gxtcEoXE\";\n\tdkim-atps=neutral", "phobos.denx.de;\n dmarc=none (p=none dis=none) header.from=baylibre.com", "phobos.denx.de;\n spf=pass smtp.mailfrom=dlechner@baylibre.com" ], "Received": [ "from phobos.denx.de (phobos.denx.de\n [IPv6:2a01:238:438b:c500:173d:9f52:ddab:ee01])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fsBSH57n6z1xy1\n\tfor <incoming@patchwork.ozlabs.org>; Fri, 10 Apr 2026 06:32:15 +1000 (AEST)", "from h2850616.stratoserver.net (localhost [IPv6:::1])\n\tby phobos.denx.de (Postfix) with ESMTP id 824A784154;\n\tThu, 9 Apr 2026 22:32:05 +0200 (CEST)", "by phobos.denx.de (Postfix, from userid 109)\n id 7E20883CF5; Thu, 9 Apr 2026 22:32:00 +0200 (CEST)", "from mail-oi1-x233.google.com (mail-oi1-x233.google.com\n [IPv6:2607:f8b0:4864:20::233])\n (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits))\n (No client certificate requested)\n by phobos.denx.de (Postfix) with ESMTPS id EBC5E83CF5\n for <u-boot@lists.denx.de>; Thu, 9 Apr 2026 22:31:53 +0200 (CEST)", "by mail-oi1-x233.google.com with SMTP id\n 5614622812f47-464ba2bb3aeso764420b6e.1\n for <u-boot@lists.denx.de>; Thu, 09 Apr 2026 13:31:53 -0700 (PDT)", "from [127.0.1.1] ([2600:8803:e7e4:500:a548:cf0c:d054:fd01])\n by smtp.gmail.com with ESMTPSA id\n 5614622812f47-478a101b75esm293075b6e.6.2026.04.09.13.31.51\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Thu, 09 Apr 2026 13:31:52 -0700 (PDT)" ], "X-Spam-Checker-Version": "SpamAssassin 3.4.2 (2018-09-13) on phobos.denx.de", "X-Spam-Level": "", "X-Spam-Status": "No, score=-1.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,\n DKIM_VALID,RCVD_IN_DNSWL_BLOCKED,SPF_HELO_NONE,SPF_PASS autolearn=ham\n autolearn_force=no version=3.4.2", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=baylibre-com.20251104.gappssmtp.com; s=20251104; t=1775766713;\n x=1776371513;\n darn=lists.denx.de;\n h=cc:to:in-reply-to:references:message-id:content-transfer-encoding\n :mime-version:subject:date:from:from:to:cc:subject:date:message-id\n :reply-to; bh=HJNTH+IdV5MnBWRgdyE//pLg1ulj3fSydNceAS4hmX0=;\n b=gxtcEoXEbyex9wa3cmJDx+DHSQ0Sg/OAA6FfAmhf2ygiPVkgRYiFf0/nQ8g4LFXg1a\n 1JS9fNnjAKXJwVVFQ79gLTtJ4Psr787EEf/NI1jnKeFHGxuK7SZyJ2J79cGNpQ1JFuyn\n izd526bN7truRCchdKRS7Jx0CH3aWZIxCV6h5mJaaUhMTVGJfn1HBSSF4za8XzQLIvGj\n YoecRojM+UwglHvlOx1VJmY6IJkFVopcrH1wKydscbXI4gf77X74G+XqASFfJTTqJWkr\n Fo10qUWzzFnNHNswkcoVG7Fhti8MgQQwXK+yLLoFNdpthr9c26/S11CNRfCRFjqZUeVJ\n pMvA==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1775766713; x=1776371513;\n h=cc:to:in-reply-to:references:message-id:content-transfer-encoding\n :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to\n :cc:subject:date:message-id:reply-to;\n bh=HJNTH+IdV5MnBWRgdyE//pLg1ulj3fSydNceAS4hmX0=;\n b=GJhH20lyPHj5WoEC3jIbU8Aw+scP/qDOWVaK1oAKIrIUhavsWc3ESGAzvDXhoq652S\n ra1cABI5tXfDv1Hr74eP0UrBYR1WT1QCw3h1eNaiQznZhGcT8NuqY093PsHD5M2iNveQ\n SKcp8XDqvzb2vSzC+KGjfFvOI+xX9Ogxjyfodj0G7k6XyYGLpFtuuTbWFnbv6VYRXKP4\n 3tzqGLdH0sjxm8SPLyBZS02YAEzBgrZzbqZPlKlxHUlmcucAFHygtzm5Jt1CmzkwmH3+\n miiid4/q2gybFazGw4zb8VAmNqllxVdYdATCHcmbY8Ti7caHz32Fy1n/JklOSb7YXjcf\n GI6A==", "X-Forwarded-Encrypted": "i=1;\n AJvYcCUBYbuAy6acZBJcdMgzu+JS/iTiLXPLEYMTsygIIkH5uYuFHGycLzxKpNKQo33MHok3bzaJc/8=@lists.denx.de", "X-Gm-Message-State": "AOJu0YzdEMKA+TbNK+H81tf5rQyPl6ingUppOwBlsi/qmIKYQFRItutL\n FIKk339WWLFyp7xvXVACSIHIkxGH6c+3FRZWzWwDy18nrmnSXC+kY5zMdXDoVGVQENo=", "X-Gm-Gg": "AeBDietTpVIxGZ3j7fl6R35ssJwP+LOivWvMg4AnoAbs1DRwGqQfQ1OQbum3inkwaSo\n 9sHJJg1G0x3N4o5Si7H4Lg24E+F/F5eEM45hYivpj68tUXWVIxF7G/i9Dy9YqLO2AGmXexYDGNI\n mckOWAGs8COFekMSMvVdz+lnAg1OmGwCq/FHjW++/W7pA/7uF7Q6hUGFDHaUSy55vAIQjTX5sbP\n lip3NxYEUz7mawc1qaBNdN6PgDOe7tZfSGvds5si5dtfP7HRwwlPbihwn/1YAKFk3vCOVaRMcWO\n aCIFj8+zzwuOlZCcwcNfwx6mBZdEdVr5fAXZGhhvZbwXhHr1qCDt35CvG25LClLt/PusNu3y2dl\n eSd0E999dRkj5NJpRsdzHsOw9JGQ5A4+65aE1xkHtX7RldMmbG7WeHAOGZpRtEMdmZnVivXAA3+\n G+jEwlqE4PKzgdB6JTxesJJsbqC+bZ", "X-Received": "by 2002:a05:6808:3095:b0:467:da0d:537e with SMTP id\n 5614622812f47-478b69b77e4mr136064b6e.7.1775766712642;\n Thu, 09 Apr 2026 13:31:52 -0700 (PDT)", "From": "David Lechner <dlechner@baylibre.com>", "Date": "Thu, 09 Apr 2026 15:30:35 -0500", "Subject": "[PATCH v2 3/8] power: pmic: mtk-pwrap: add init capability flag", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"utf-8\"", "Content-Transfer-Encoding": "7bit", "Message-Id": "<20260409-mtk-pmic-fixes-v2-3-73e83aa6345b@baylibre.com>", "References": "<20260409-mtk-pmic-fixes-v2-0-73e83aa6345b@baylibre.com>", "In-Reply-To": "<20260409-mtk-pmic-fixes-v2-0-73e83aa6345b@baylibre.com>", "To": "Ryder Lee <ryder.lee@mediatek.com>, Weijie Gao <weijie.gao@mediatek.com>,\n Chunfeng Yun <chunfeng.yun@mediatek.com>,\n Igor Belwon <igor.belwon@mentallysanemainliners.org>,\n GSS_MTK_Uboot_upstream <GSS_MTK_Uboot_upstream@mediatek.com>,\n Jaehoon Chung <jh80.chung@samsung.com>, Peng Fan <peng.fan@nxp.com>,\n Tom Rini <trini@konsulko.com>", "Cc": "Julien Stephan <jstephan@baylibre.com>, u-boot@lists.denx.de,\n David Lechner <dlechner@baylibre.com>", "X-Mailer": "b4 0.16-dev", "X-Developer-Signature": "v=1; a=openpgp-sha256; l=1856; i=dlechner@baylibre.com;\n h=from:subject:message-id;\n bh=igRoS02hI5x6XRIulhM6vY+UmhZJmfbsSIpeu6V78tU=;\n b=owEBhAF7/pANAwAKAcLMIAH/AY/AAcsmYgBp2AyL0zs37UI1XHztHF0rtSVyMYAOnyJvrJpyK\n zegd7FUqsKJAUoEAAEKADQWIQTsGNmeYg6D1pzYaJjCzCAB/wGPwAUCadgMixYcZGxlY2huZXJA\n YmF5bGlicmUuY29tAAoJEMLMIAH/AY/AlhAIAJcW5kt8PhalDbehfvdvvWogZerA54NDCZsvXnj\n m0A+d4Qo9MdgwtTgJDCzeiEXLMJmIIBfgzlp4okBnx9koE4QnueOCMm0FP0Mg35jIASY0qIMz7D\n 6URByA9S6h4ZEWejbJ+maE9tbdGlevMfnMmpoDKdBed85nHSM0XkS/c0zuTO7nzWtEdwOnkkhLE\n A5vQBxTWgI2eSfMpZqWGQEFmB6Jp8niFPFwIbpqO/mMm4epHGOnHyPQGrALzG2qm+iGLpwaeSUs\n hsP7PHeagu+zBxBE21tI9RdOujkBjeDfiS5vsXvx2Zvhcpe2iXXt9ULTgYsHZFGOO3EO3AlF/24\n UVFc=", "X-Developer-Key": "i=dlechner@baylibre.com; a=openpgp;\n fpr=8A73D82A6A1F509907F373881F8AF88C82F77C03", "X-BeenThere": "u-boot@lists.denx.de", "X-Mailman-Version": "2.1.39", "Precedence": "list", "List-Id": "U-Boot discussion <u-boot.lists.denx.de>", "List-Unsubscribe": "<https://lists.denx.de/options/u-boot>,\n <mailto:u-boot-request@lists.denx.de?subject=unsubscribe>", "List-Archive": "<https://lists.denx.de/pipermail/u-boot/>", "List-Post": "<mailto:u-boot@lists.denx.de>", "List-Help": "<mailto:u-boot-request@lists.denx.de?subject=help>", "List-Subscribe": "<https://lists.denx.de/listinfo/u-boot>,\n <mailto:u-boot-request@lists.denx.de?subject=subscribe>", "Errors-To": "u-boot-bounces@lists.denx.de", "Sender": "\"U-Boot\" <u-boot-bounces@lists.denx.de>", "X-Virus-Scanned": "clamav-milter 0.103.8 at phobos.denx.de", "X-Virus-Status": "Clean" }, "content": "Add a PWRAP_CAP_INIT capability flag to specify if it is safe to call\npwrap_init() or not. Not all targets define the registers accessed\nby pwrap_init(). In that case, it is expected that an earlier bootloader\nhas already initialized the PMIC. If not, we now return an error instead\nof trying to access undefined registers.\n\nSigned-off-by: David Lechner <dlechner@baylibre.com>\n---\n drivers/power/pmic/mtk-pwrap.c | 9 ++++++++-\n 1 file changed, 8 insertions(+), 1 deletion(-)", "diff": "diff --git a/drivers/power/pmic/mtk-pwrap.c b/drivers/power/pmic/mtk-pwrap.c\nindex 3ed21dcf2ef..38ae44f0abf 100644\n--- a/drivers/power/pmic/mtk-pwrap.c\n+++ b/drivers/power/pmic/mtk-pwrap.c\n@@ -63,6 +63,8 @@ static const struct pmic_child_info mt6359_pmic_children_info[] = {\n #define PWRAP_CAP_WDT_SRC\t\tBIT(4)\n #define PWRAP_CAP_WDT_SRC1\t\tBIT(5)\n #define PWRAP_CAP_ARB\t\t\tBIT(6)\n+/* To implement this capability, the registers used in pwrap_init() must be defined. */\n+#define PWRAP_CAP_INIT\t\t\tBIT(7)\n \n /* defines for slave device wrapper registers */\n enum dew_regs {\n@@ -735,6 +737,11 @@ static int mtk_pwrap_probe(struct udevice *dev)\n \t * Skip initialization here in this case.\n \t */\n \tif (!pwrap_readl(wrp, PWRAP_INIT_DONE2)) {\n+\t\tif (!HAS_CAP(wrp->master->caps, PWRAP_CAP_INIT)) {\n+\t\t\tdev_err(dev, \"initialization is required but not supported\\n\");\n+\t\t\treturn -EOPNOTSUPP;\n+\t\t}\n+\n \t\tret = pwrap_init(wrp);\n \t\tif (ret) {\n \t\t\tdev_err(dev, \"init failed with %d\\n\", ret);\n@@ -877,7 +884,7 @@ static const struct pmic_wrapper_type pwrap_mt8365 = {\n \t.int1_en_all = 0x0,\n \t.spi_w = PWRAP_MAN_CMD_SPI_WRITE,\n \t.wdt_src = PWRAP_WDT_SRC_MASK_ALL,\n-\t.caps = PWRAP_CAP_INT1_EN | PWRAP_CAP_WDT_SRC1,\n+\t.caps = PWRAP_CAP_INT1_EN | PWRAP_CAP_WDT_SRC1 | PWRAP_CAP_INIT,\n };\n \n static const struct udevice_id mtk_pwrap_ids[] = {\n", "prefixes": [ "v2", "3/8" ] }