Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/1.1/patches/2221310/?format=api
{ "id": 2221310, "url": "http://patchwork.ozlabs.org/api/1.1/patches/2221310/?format=api", "web_url": "http://patchwork.ozlabs.org/project/gcc/patch/20260409080243.196495-1-tkaminsk@redhat.com/", "project": { "id": 17, "url": "http://patchwork.ozlabs.org/api/1.1/projects/17/?format=api", "name": "GNU Compiler Collection", "link_name": "gcc", "list_id": "gcc-patches.gcc.gnu.org", "list_email": "gcc-patches@gcc.gnu.org", "web_url": null, "scm_url": null, "webscm_url": null }, "msgid": "<20260409080243.196495-1-tkaminsk@redhat.com>", "date": "2026-04-09T08:01:19", "name": "[v2] libstdc++: Implement structured binding support for integer_sequence", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "c0fc0240a2d11da85bc781db3e8a063e7d9cd643", "submitter": { "id": 90409, "url": "http://patchwork.ozlabs.org/api/1.1/people/90409/?format=api", "name": "Tomasz Kamiński", "email": "tkaminsk@redhat.com" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/gcc/patch/20260409080243.196495-1-tkaminsk@redhat.com/mbox/", "series": [ { "id": 499251, "url": "http://patchwork.ozlabs.org/api/1.1/series/499251/?format=api", "web_url": "http://patchwork.ozlabs.org/project/gcc/list/?series=499251", "date": "2026-04-09T08:01:19", "name": "[v2] libstdc++: Implement structured binding support for integer_sequence", "version": 2, "mbox": "http://patchwork.ozlabs.org/series/499251/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/2221310/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/2221310/checks/", "tags": {}, "headers": { "Return-Path": "<gcc-patches-bounces~incoming=patchwork.ozlabs.org@gcc.gnu.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "gcc-patches@gcc.gnu.org" ], "Delivered-To": [ "patchwork-incoming@legolas.ozlabs.org", "gcc-patches@gcc.gnu.org" ], "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256\n header.s=mimecast20190719 header.b=fp0v+5XO;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=gcc.gnu.org\n (client-ip=2620:52:6:3111::32; helo=vm01.sourceware.org;\n envelope-from=gcc-patches-bounces~incoming=patchwork.ozlabs.org@gcc.gnu.org;\n receiver=patchwork.ozlabs.org)", "sourceware.org;\n\tdkim=pass (1024-bit key,\n unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256\n header.s=mimecast20190719 header.b=fp0v+5XO", "sourceware.org; dmarc=pass (p=quarantine dis=none)\n header.from=redhat.com", "sourceware.org; spf=pass smtp.mailfrom=redhat.com", "server2.sourceware.org;\n arc=none smtp.remote-ip=170.10.133.124" ], "Received": [ "from vm01.sourceware.org (vm01.sourceware.org\n [IPv6:2620:52:6:3111::32])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4frsrR0Ywyz1xtJ\n\tfor <incoming@patchwork.ozlabs.org>; Thu, 09 Apr 2026 18:03:35 +1000 (AEST)", "from vm01.sourceware.org (localhost [127.0.0.1])\n\tby sourceware.org (Postfix) with ESMTP id 121894BA2E04\n\tfor <incoming@patchwork.ozlabs.org>; Thu, 9 Apr 2026 08:03:33 +0000 (GMT)", "from us-smtp-delivery-124.mimecast.com\n (us-smtp-delivery-124.mimecast.com [170.10.133.124])\n by sourceware.org (Postfix) with ESMTP id 37A904BA2E33\n for <gcc-patches@gcc.gnu.org>; Thu, 9 Apr 2026 08:02:51 +0000 (GMT)", "from mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com\n (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by\n relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3,\n cipher=TLS_AES_256_GCM_SHA384) id us-mta-694-F85WGM6WPdeB3S5-iWzAJw-1; Thu,\n 09 Apr 2026 04:02:47 -0400", "from mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com\n (mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.4])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest\n SHA256)\n (No client certificate requested)\n by mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS\n id 3AA2319560B3; Thu, 9 Apr 2026 08:02:46 +0000 (UTC)", "from localhost (unknown [10.44.33.240])\n by mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP\n id 90C1F3000C16; Thu, 9 Apr 2026 08:02:45 +0000 (UTC)" ], "DKIM-Filter": [ "OpenDKIM Filter v2.11.0 sourceware.org 121894BA2E04", "OpenDKIM Filter v2.11.0 sourceware.org 37A904BA2E33" ], "DMARC-Filter": "OpenDMARC Filter v1.4.2 sourceware.org 37A904BA2E33", "ARC-Filter": "OpenARC Filter v1.0.0 sourceware.org 37A904BA2E33", "ARC-Seal": "i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1775721771; cv=none;\n b=gT1513In7SY/TEth6EjfY1H0h9V11wHifXUrR9pDBSkLRrsaeC/9TS0DkKTNcBFprxhUP/FmJ0HUejvqkaV8cbdyehcX/mCQdZQSt8EnpcayWcIkQ0dHkYIfyqt/KTRaDSPHCcSSpDViUQqKXvRHnPklZOo/cFoLNoWENNlzlpc=", "ARC-Message-Signature": "i=1; a=rsa-sha256; d=sourceware.org; s=key;\n t=1775721771; c=relaxed/simple;\n bh=5v1H6+H/YK2h3ns5G9QTaW+HrhdD2c2eO6ghtV8ewDk=;\n h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version;\n b=eTrupr6bjZzKa/I+f7SyYEh11SZRwvuMYMejV/EA94VIpEyZ4rdJ6oZwOAwjAkdNIZPk2qWtzLsNqsKameoFRMVVm48QbGwCk3wVdkHVDTS5jhacTnTzX3wX3+Qar2QblY4g8aoKUyKD9wzp2ffmzRW3m/iiNFHJ6tGHs2gZQ1c=", "ARC-Authentication-Results": "i=1; server2.sourceware.org", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n s=mimecast20190719; t=1775721770;\n h=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n to:to:cc:cc:mime-version:mime-version:content-type:content-type:\n content-transfer-encoding:content-transfer-encoding:\n in-reply-to:in-reply-to:references:references;\n bh=OtJjFLZEMhiGFR09D1BPLKmCFDFP8NvAZBLYxb/UKWs=;\n b=fp0v+5XOukXQ9/emQoDtdEybrQupvq2hkM4cg/riQXiAOPXEq0jYzsF3B3HHVER5Ssi8ty\n XNoqvRhySeAKKUdg21JJ0PrvZzoIwOJzLBSL1N3FNplFnC8Y5jPry4TDMnJijrPRhtoq0D\n qWSzkStOAKnthGeRJ6JkeUzBMijT+M0=", "X-MC-Unique": "F85WGM6WPdeB3S5-iWzAJw-1", "X-Mimecast-MFC-AGG-ID": "F85WGM6WPdeB3S5-iWzAJw_1775721766", "From": "=?utf-8?q?Tomasz_Kami=C5=84ski?= <tkaminsk@redhat.com>", "To": "libstdc++@gcc.gnu.org,\n\tgcc-patches@gcc.gnu.org", "Cc": "Matthias Wippich <mfwippich@gmail.com>,\n Ivan Lazaric <ivan.lazaric1@gmail.com>", "Subject": "[PATCH v2] libstdc++: Implement structured binding support for\n integer_sequence", "Date": "Thu, 9 Apr 2026 10:01:19 +0200", "Message-ID": "<20260409080243.196495-1-tkaminsk@redhat.com>", "In-Reply-To": "\n <CAKvuMXARGgP=nX0sedLruVdEtLsoyNxyPmOdmy5_9nhyZD8aYw@mail.gmail.com>", "References": "\n <CAKvuMXARGgP=nX0sedLruVdEtLsoyNxyPmOdmy5_9nhyZD8aYw@mail.gmail.com>", "MIME-Version": "1.0", "X-Scanned-By": "MIMEDefang 3.4.1 on 10.30.177.4", "X-Mimecast-Spam-Score": "0", "X-Mimecast-MFC-PROC-ID": "Sba7-zsQStcTG99XS9TKgbEH2ZEY4KbVgXR8qK4L010_1775721766", "X-Mimecast-Originator": "redhat.com", "Content-Transfer-Encoding": "8bit", "content-type": "text/plain; charset=\"US-ASCII\"; x-default=true", "X-BeenThere": "gcc-patches@gcc.gnu.org", "X-Mailman-Version": "2.1.30", "Precedence": "list", "List-Id": "Gcc-patches mailing list <gcc-patches.gcc.gnu.org>", "List-Unsubscribe": "<https://gcc.gnu.org/mailman/options/gcc-patches>,\n <mailto:gcc-patches-request@gcc.gnu.org?subject=unsubscribe>", "List-Archive": "<https://gcc.gnu.org/pipermail/gcc-patches/>", "List-Post": "<mailto:gcc-patches@gcc.gnu.org>", "List-Help": "<mailto:gcc-patches-request@gcc.gnu.org?subject=help>", "List-Subscribe": "<https://gcc.gnu.org/mailman/listinfo/gcc-patches>,\n <mailto:gcc-patches-request@gcc.gnu.org?subject=subscribe>", "Errors-To": "gcc-patches-bounces~incoming=patchwork.ozlabs.org@gcc.gnu.org" }, "content": "From: Matthias Wippich <mfwippich@gmail.com>\n\nThis implements P1789R3 Library Support for Expansion Statements.\nhttps://www.open-std.org/jtc1/sc22/wg21/docs/papers/2025/p1789r3.pdf\n\nlibstdc++-v3/ChangeLog:\n\n\t* include/bits/utility.h (std::tuple_size, std::tuple_element):\n\tAdd partrial specializations for integer_sequence.\n\t(std::get(integer_sequence<_Tp, _Idx...>)): Define.\n\t* include/bits/version.def (integer_sequence): Bump to 202511L.\n\t* include/bits/version.h: Regenerate.\n\t* testsuite/20_util/integer_sequence/tuple_access.cc: New test.\n\t* testsuite/20_util/integer_sequence/tuple_access_neg.cc: New test.\n\t* testsuite/experimental/feat-cxx14.cc: Updated check for\n\t__cpp_lib_integer_sequence value.\n\nCo-authored-by: Ivan Lazaric <ivan.lazaric1@gmail.com>\nSigned-off-by: Matthias Wippich <mfwippich@gmail.com>\n---\nv3:\n - updates changelog\n - fixes __cpp_lib_integer_sequence check in feat-cxx14.cc\n - replaces dg-excess-errors in tuple_access_neg.cc\n - add few testcasse to tuple_access.cc \n\nTesting on x86_64-linux. OK for trunk when all test passes?\n\n libstdc++-v3/include/bits/utility.h | 30 ++++\n libstdc++-v3/include/bits/version.def | 5 +\n libstdc++-v3/include/bits/version.h | 7 +-\n .../20_util/integer_sequence/tuple_access.cc | 143 ++++++++++++++++++\n .../integer_sequence/tuple_access_neg.cc | 22 +++\n .../testsuite/experimental/feat-cxx14.cc | 4 +-\n 6 files changed, 208 insertions(+), 3 deletions(-)\n create mode 100644 libstdc++-v3/testsuite/20_util/integer_sequence/tuple_access.cc\n create mode 100644 libstdc++-v3/testsuite/20_util/integer_sequence/tuple_access_neg.cc", "diff": "diff --git a/libstdc++-v3/include/bits/utility.h b/libstdc++-v3/include/bits/utility.h\nindex 93e9e9f9dba..363aed478c5 100644\n--- a/libstdc++-v3/include/bits/utility.h\n+++ b/libstdc++-v3/include/bits/utility.h\n@@ -481,6 +481,36 @@ _GLIBCXX_BEGIN_NAMESPACE_VERSION\n static constexpr size_t size() noexcept { return sizeof...(_Idx); }\n };\n \n+#if __glibcxx_integer_sequence >= 202511L // C++ >= 26\n+\n+ /// Structured binding support\n+ template<typename _Tp, _Tp... _Idx>\n+ struct tuple_size<integer_sequence<_Tp, _Idx...>>\n+ : integral_constant<size_t, sizeof...(_Idx)> { };\n+\n+ template<size_t __i, class _Tp, _Tp... _Idx>\n+ struct tuple_element<__i, integer_sequence<_Tp, _Idx...>>\n+ {\n+ static_assert(__i < sizeof...(_Idx));\n+ using type = _Tp;\n+ };\n+\n+ template<size_t __i, class _Tp, _Tp... _Idx>\n+ struct tuple_element<__i, const integer_sequence<_Tp, _Idx...>>\n+ {\n+ static_assert(__i < sizeof...(_Idx));\n+ using type = _Tp;\n+ };\n+\n+ template<size_t __i, class _Tp, _Tp... _Idx>\n+ constexpr _Tp\n+ get (integer_sequence<_Tp, _Idx...>) noexcept\n+ {\n+ static_assert(__i < sizeof...(_Idx));\n+ return _Idx...[__i];\n+ }\n+#endif // __glibcxx_integer_sequence >= 202511L\n+\n /// Alias template make_integer_sequence\n template<typename _Tp, _Tp _Num>\n using make_integer_sequence\ndiff --git a/libstdc++-v3/include/bits/version.def b/libstdc++-v3/include/bits/version.def\nindex cfb90533ce4..8db3c1d2df3 100644\n--- a/libstdc++-v3/include/bits/version.def\n+++ b/libstdc++-v3/include/bits/version.def\n@@ -184,6 +184,11 @@ ftms = {\n \n ftms = {\n name = integer_sequence;\n+ values = {\n+ v = 202511;\n+ cxxmin = 26;\n+ extra_cond = \"__cpp_pack_indexing\";\n+ };\n values = {\n v = 201304;\n cxxmin = 14;\ndiff --git a/libstdc++-v3/include/bits/version.h b/libstdc++-v3/include/bits/version.h\nindex 22dd31b9d32..455d7190e90 100644\n--- a/libstdc++-v3/include/bits/version.h\n+++ b/libstdc++-v3/include/bits/version.h\n@@ -186,7 +186,12 @@\n #undef __glibcxx_want_exchange_function\n \n #if !defined(__cpp_lib_integer_sequence)\n-# if (__cplusplus >= 201402L)\n+# if (__cplusplus > 202302L) && (__cpp_pack_indexing)\n+# define __glibcxx_integer_sequence 202511L\n+# if defined(__glibcxx_want_all) || defined(__glibcxx_want_integer_sequence)\n+# define __cpp_lib_integer_sequence 202511L\n+# endif\n+# elif (__cplusplus >= 201402L)\n # define __glibcxx_integer_sequence 201304L\n # if defined(__glibcxx_want_all) || defined(__glibcxx_want_integer_sequence)\n # define __cpp_lib_integer_sequence 201304L\ndiff --git a/libstdc++-v3/testsuite/20_util/integer_sequence/tuple_access.cc b/libstdc++-v3/testsuite/20_util/integer_sequence/tuple_access.cc\nnew file mode 100644\nindex 00000000000..afa644e7dab\n--- /dev/null\n+++ b/libstdc++-v3/testsuite/20_util/integer_sequence/tuple_access.cc\n@@ -0,0 +1,143 @@\n+// { dg-do compile { target c++26 } }\n+\n+#include <utility>\n+#include <tuple>\n+#include <testsuite_hooks.h>\n+\n+#if __cpp_lib_integer_sequence < 202511L\n+# error \"Feature-test macro __cpp_lib_integer_sequence is incorrect\"\n+#endif\n+\n+constexpr auto\n+destructure_sum(auto seq)\n+{\n+ auto [...elems] = seq;\n+ return (0 + ... + elems);\n+}\n+\n+using IS1 = std::make_index_sequence<10>;\n+static_assert( std::tuple_size_v<IS1> == 10 );\n+static_assert( std::is_same_v<std::tuple_element_t<3, IS1>, std::size_t> );\n+static_assert( std::get<7>(IS1{}) == 7 );\n+static_assert( destructure_sum(IS1{}) == 45 );\n+static_assert( noexcept(get<0>(IS1{})) );\n+\n+using IS2 = std::integer_sequence<int, 42, 101, -13>;\n+static_assert( std::tuple_size_v<IS2> == 3 );\n+static_assert( std::is_same_v<std::tuple_element_t<1, IS2>, int> );\n+static_assert( std::get<2>(IS2{}) == -13 );\n+static_assert( destructure_sum(IS2{}) == 130 );\n+static_assert( noexcept(get<0>(IS2{})) );\n+\n+using IS3 = std::integer_sequence<char>;\n+static_assert( std::tuple_size_v<IS3> == 0 );\n+\n+using IS4 = std::integer_sequence<int, 1, 2>;\n+static_assert( !std::is_constructible_v<std::pair<int, int>, IS4> );\n+static_assert( !std::is_constructible_v<std::tuple<int, int>, IS4> );\n+\n+template<typename = void>\n+constexpr bool\n+test_basic()\n+{\n+ {\n+ auto [...elems] = std::make_index_sequence<0>{};\n+ static_assert( sizeof...(elems) == 0 );\n+ }\n+\n+ {\n+ auto [...elems] = std::integer_sequence<int, 3, 5, 7, 11>{};\n+\n+ static_assert( sizeof...(elems) == 4 );\n+\n+ VERIFY( elems...[0] == 3 );\n+ VERIFY( elems...[1] == 5 );\n+ VERIFY( elems...[2] == 7 );\n+ VERIFY( elems...[3] == 11 );\n+ }\n+\n+ {\n+ static constexpr auto [...elems] = std::integer_sequence<short, 2, 4, 8, 16>{};\n+\n+ static_assert( sizeof...(elems) == 4 );\n+\n+ static_assert( elems...[0] == 2 );\n+ static_assert( elems...[1] == 4 );\n+ static_assert( elems...[2] == 8 );\n+ static_assert( elems...[3] == 16 );\n+ }\n+\n+ {\n+ constexpr auto [...elems] = std::integer_sequence<int, 1, 8, 2, 11>{};\n+\n+ static_assert( sizeof...(elems) == 4 );\n+\n+ static_assert( elems...[0] == 1 );\n+ static_assert( elems...[1] == 8 );\n+ static_assert( elems...[2] == 2 );\n+ static_assert( elems...[3] == 11 );\n+ }\n+\n+ {\n+ static constexpr auto&& [...elems] = std::integer_sequence<short, 2, 4, 8, 16>{};\n+\n+ static_assert( sizeof...(elems) == 4 );\n+\n+ static_assert( elems...[0] == 2 );\n+ static_assert( elems...[1] == 4 );\n+ static_assert( elems...[2] == 8 );\n+ static_assert( elems...[3] == 16 );\n+ }\n+\n+ /* Unimplemented, see PR117784\n+ {\n+ constexpr auto&& [...elems] = std::integer_sequence<int, 1, 8, 2, 11>{};\n+\n+ static_assert( sizeof...(elems) == 4 );\n+\n+ static_assert( elems...[0] == 1 );\n+ static_assert( elems...[1] == 8 );\n+ static_assert( elems...[2] == 2 );\n+ static_assert( elems...[3] == 11 );\n+ }\n+ */\n+\n+ {\n+ auto idx = 0;\n+ static constexpr auto seq = std::make_index_sequence<4>{};\n+ template for (constexpr auto elem : seq)\n+ {\n+\tVERIFY( elem == idx );\n+\t++idx;\n+ }\n+ VERIFY( idx == 4 );\n+ }\n+\n+\n+ /* Unimplemented, see PR117784\n+ {\n+ auto idx = 0;\n+ constexpr auto seq = std::make_index_sequence<4>{};\n+ template for (constexpr auto elem : seq)\n+ {\n+\tVERIFY( elem == idx );\n+\t++idx;\n+ }\n+ VERIFY( idx == 4 );\n+ }\n+ \n+ {\n+ auto idx = 0;\n+ template for (constexpr auto elem : std::make_index_sequence<4>{})\n+ {\n+\tVERIFY( elem == idx );\n+\t++idx;\n+ }\n+ VERIFY( idx == 4 );\n+ }\n+ */\n+\n+ return true;\n+}\n+\n+static_assert( test_basic() );\ndiff --git a/libstdc++-v3/testsuite/20_util/integer_sequence/tuple_access_neg.cc b/libstdc++-v3/testsuite/20_util/integer_sequence/tuple_access_neg.cc\nnew file mode 100644\nindex 00000000000..8640114e7d3\n--- /dev/null\n+++ b/libstdc++-v3/testsuite/20_util/integer_sequence/tuple_access_neg.cc\n@@ -0,0 +1,22 @@\n+// { dg-do compile { target c++26 } }\n+\n+#include <utility>\n+\n+using empty = std::integer_sequence<int>;\n+static_assert( std::is_same_v<std::tuple_element_t<0, empty>, int> ); // { dg-error \"here\" }\n+static_assert( std::is_same_v<std::tuple_element_t<0, const empty>, int> ); // { dg-error \"here\" }\n+\n+using size4 = std::integer_sequence<int, 1, 9, 7, 15>;\n+static_assert( std::is_same_v<std::tuple_element_t<4, size4>, int> ); // { dg-error \"here\" }\n+static_assert( std::is_same_v<std::tuple_element_t<4, const size4>, int> ); // { dg-error \"here\" }\n+\n+void\n+test()\n+{\n+ (void)std::get<0>(empty{}); // { dg-error \"here\" }\n+ (void)std::get<4>(size4{}); // { dg-error \"here\" }\n+}\n+\n+// { dg-error \"static assertion failed\" \"\" { target *-*-* } 0 }\n+// { dg-error \"cannot index an empty pack\" \"\" { target *-*-* } 0 }\n+// { dg-error \"pack index '.' is out of range for pack of length\" \"\" { target *-*-* } 0 }\ndiff --git a/libstdc++-v3/testsuite/experimental/feat-cxx14.cc b/libstdc++-v3/testsuite/experimental/feat-cxx14.cc\nindex c009062b55c..4cc56c5f76e 100644\n--- a/libstdc++-v3/testsuite/experimental/feat-cxx14.cc\n+++ b/libstdc++-v3/testsuite/experimental/feat-cxx14.cc\n@@ -18,8 +18,8 @@\n \n #ifndef __cpp_lib_integer_sequence\n # error \"__cpp_lib_integer_sequence\"\n-#elif __cpp_lib_integer_sequence != 201304\n-# error \"__cpp_lib_integer_sequence != 201304\"\n+#elif __cpp_lib_integer_sequence < 201304\n+# error \"__cpp_lib_integer_sequence < 201304\"\n #endif\n \n #ifndef __cpp_lib_exchange_function\n", "prefixes": [ "v2" ] }