Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/1.1/patches/2221264/?format=api
{ "id": 2221264, "url": "http://patchwork.ozlabs.org/api/1.1/patches/2221264/?format=api", "web_url": "http://patchwork.ozlabs.org/project/linux-ext4/patch/20260409010730.5508-1-yi.zhang@huaweicloud.com/", "project": { "id": 8, "url": "http://patchwork.ozlabs.org/api/1.1/projects/8/?format=api", "name": "Linux ext4 filesystem development", "link_name": "linux-ext4", "list_id": "linux-ext4.vger.kernel.org", "list_email": "linux-ext4@vger.kernel.org", "web_url": null, "scm_url": null, "webscm_url": null }, "msgid": "<20260409010730.5508-1-yi.zhang@huaweicloud.com>", "date": "2026-04-09T01:07:30", "name": "jbd2: fix deadlock in jbd2_journal_cancel_revoke()", "commit_ref": null, "pull_url": null, "state": "rejected", "archived": false, "hash": "5324fb99e58b1175cf38d8803f862682606b4251", "submitter": { "id": 85428, "url": "http://patchwork.ozlabs.org/api/1.1/people/85428/?format=api", "name": "Zhang Yi", "email": "yi.zhang@huaweicloud.com" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/linux-ext4/patch/20260409010730.5508-1-yi.zhang@huaweicloud.com/mbox/", "series": [ { "id": 499230, "url": "http://patchwork.ozlabs.org/api/1.1/series/499230/?format=api", "web_url": "http://patchwork.ozlabs.org/project/linux-ext4/list/?series=499230", "date": "2026-04-09T01:07:30", "name": "jbd2: fix deadlock in jbd2_journal_cancel_revoke()", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/499230/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/2221264/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/2221264/checks/", "tags": {}, "headers": { "Return-Path": "\n <SRS0=L9in=CI=vger.kernel.org=linux-ext4+bounces-15690-patchwork-incoming=ozlabs.org@ozlabs.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "linux-ext4@vger.kernel.org" ], "Delivered-To": [ "patchwork-incoming@legolas.ozlabs.org", "patchwork-incoming@ozlabs.org" ], "Authentication-Results": [ "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=ozlabs.org\n (client-ip=150.107.74.76; helo=mail.ozlabs.org;\n envelope-from=srs0=l9in=ci=vger.kernel.org=linux-ext4+bounces-15690-patchwork-incoming=ozlabs.org@ozlabs.org;\n receiver=patchwork.ozlabs.org)", "gandalf.ozlabs.org;\n arc=pass smtp.remote-ip=\"2600:3c09:e001:a7::12fc:5321\"\n arc.chain=subspace.kernel.org", "gandalf.ozlabs.org;\n dmarc=none (p=none dis=none) header.from=huaweicloud.com", "gandalf.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org\n (client-ip=2600:3c09:e001:a7::12fc:5321; helo=sto.lore.kernel.org;\n envelope-from=linux-ext4+bounces-15690-patchwork-incoming=ozlabs.org@vger.kernel.org;\n receiver=ozlabs.org)", "smtp.subspace.kernel.org;\n arc=none smtp.client-ip=45.249.212.56", "smtp.subspace.kernel.org;\n dmarc=none (p=none dis=none) header.from=huaweicloud.com", "smtp.subspace.kernel.org;\n spf=pass smtp.mailfrom=huaweicloud.com" ], "Received": [ "from mail.ozlabs.org (gandalf.ozlabs.org [150.107.74.76])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4frhl20FYhz1yCv\n\tfor <incoming@patchwork.ozlabs.org>; Thu, 09 Apr 2026 11:13:17 +1000 (AEST)", "from mail.ozlabs.org (mail.ozlabs.org [IPv6:2404:9400:2221:ea00::3])\n\tby gandalf.ozlabs.org (Postfix) with ESMTP id 4frhl11jHlz4wL4\n\tfor <incoming@patchwork.ozlabs.org>; Thu, 09 Apr 2026 11:13:17 +1000 (AEST)", "by gandalf.ozlabs.org (Postfix)\n\tid 4frhl11HR2z4wT4; Thu, 09 Apr 2026 11:13:17 +1000 (AEST)", "from sto.lore.kernel.org (sto.lore.kernel.org\n [IPv6:2600:3c09:e001:a7::12fc:5321])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519)\n\t(No client certificate requested)\n\tby gandalf.ozlabs.org (Postfix) with ESMTPS id 4frhkx0hFRz4wL4\n\tfor <patchwork-incoming@ozlabs.org>; Thu, 09 Apr 2026 11:13:13 +1000 (AEST)", "from smtp.subspace.kernel.org (conduit.subspace.kernel.org\n [100.90.174.1])\n\tby sto.lore.kernel.org (Postfix) with ESMTP id 7ECCC300E2AE\n\tfor <patchwork-incoming@ozlabs.org>; Thu, 9 Apr 2026 01:13:10 +0000 (UTC)", "from localhost.localdomain (localhost.localdomain [127.0.0.1])\n\tby smtp.subspace.kernel.org (Postfix) with ESMTP id B1E6E273D9F;\n\tThu, 9 Apr 2026 01:13:08 +0000 (UTC)", "from dggsgout12.his.huawei.com (dggsgout12.his.huawei.com\n [45.249.212.56])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby smtp.subspace.kernel.org (Postfix) with ESMTPS id A11EF23643F;\n\tThu, 9 Apr 2026 01:13:05 +0000 (UTC)", "from mail.maildlp.com (unknown [172.19.163.170])\n\tby dggsgout12.his.huawei.com (SkyGuard) with ESMTPS id 4frhkl3K9CzKHMLD;\n\tThu, 9 Apr 2026 09:13:03 +0800 (CST)", "from mail02.huawei.com (unknown [10.116.40.112])\n\tby mail.maildlp.com (Postfix) with ESMTP id E91A34056B;\n\tThu, 9 Apr 2026 09:13:02 +0800 (CST)", "from huaweicloud.com (unknown [10.50.85.155])\n\tby APP1 (Coremail) with SMTP id cCh0CgC3utoW_dZp37OQDw--.20149S4;\n\tThu, 09 Apr 2026 09:13:02 +0800 (CST)" ], "ARC-Seal": [ "i=2; a=rsa-sha256; d=ozlabs.org; s=201707; t=1775697197; cv=pass;\n\tb=Vyip85KHCtBt6nQlJwlYYIGb0170+LJ5itPOP1d90ecS+fX498/WW4Cd9NwmjnCqUq9/Kiy2FMT+YG2pht/7du/uhYjZIUknfl9P6o6wbbIopXOl4D0WNZ2kdUoLfc5NnCYR02g/0p5YOU8jw7nn+mCi8ASrWbWu+g8ZrSUDbxlyO1LJS44pDxPwe5Rv6bzpMTZ6sCIAhh/j0WFEpHKQ+AeLBPsJSN9w6ak9fMb+X81VkU/Cd5JECV3sjhyWbZxPUz9j4r9HE7kXW3ru9GZ3r3/0XX2M6Jl2OqmOPUSb8Ip3nBT4M1cAn3rO8dOC88cu1QdOVv7Vdbma6Xr0TXxqDQ==", "i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;\n\tt=1775697188; cv=none;\n b=ZiCmBc8k9AFzHoIChJnmeKS95v7an4Gs9q46evLa03NQFaOKB7bDllcEhW1kO2FHWNOX7XStaS2dnK8UY4ufmD+qLhY9Fn4y324b0UWB/11f4kfSINNEdG30mbxc4sm+KF/miAiXkl6GARo12ArnrSc+/pB5ZJoF00X9y89Y8DU=" ], "ARC-Message-Signature": [ "i=2; a=rsa-sha256; d=ozlabs.org; s=201707;\n\tt=1775697197; c=relaxed/relaxed;\n\tbh=UQxjvZUfN4oQ2n4CnvvP7GlnGSE4ppAUvdRgfWqEYss=;\n\th=From:To:Cc:Subject:Date:Message-ID:MIME-Version;\n b=Kz6pZuJzhgGd5M83JS/RbIKIUoM/L7fMEJ9eZkMR8VdZtCASlYfdosTauPeSOikNq1i9cF2YoczDQ7rB4IlduqFJhOMDlhLvaKR3diUeqttAhvrJrUQ51MF7ZoqlkHo6PnYzVgY+A/KC4Eet9zkJxGbYhhB6xUQFfRRQa8DlF3WL/XqwPjkxMmg4pL/9L5AQEvQq9t8zlr1g3tggrfThPEDVks5yL+RZi9FFA3zv4Slo/lbLIPvBufeDvQgfPo9qwNU9oTgbISRwY2Fi1EbQ9kyE0GUvdfQMIPmh3fYNUT2wqfD8ye5BFOl2uMUK+xRq7FabwRSi6oFtQDPdhHdNAA==", "i=1; a=rsa-sha256; d=subspace.kernel.org;\n\ts=arc-20240116; t=1775697188; c=relaxed/simple;\n\tbh=WCi0MrIHl1kiwvtpnXz7txYMtrH0iG7NTmnJecE2j4s=;\n\th=From:To:Cc:Subject:Date:Message-ID:MIME-Version;\n b=Gipyn0rZQEgdW9cymmNN2ulY43LQjlI62e67QxikdpVBA12mx2fR2ccb4MBaPzXb+/ynAWYr6lHeLkZ6dtfGwjskBehlTsHjsfzilFwbPyqAdcgrSAe92AHiQL1TKS6pRdDSTCQrFwI9ewZThi1UB5fo6fx5f6qedWPP1OQf6T8=" ], "ARC-Authentication-Results": [ "i=2; gandalf.ozlabs.org;\n dmarc=none (p=none dis=none) header.from=huaweicloud.com;\n spf=pass (client-ip=2600:3c09:e001:a7::12fc:5321; helo=sto.lore.kernel.org;\n envelope-from=linux-ext4+bounces-15690-patchwork-incoming=ozlabs.org@vger.kernel.org;\n receiver=ozlabs.org) smtp.mailfrom=vger.kernel.org", "i=1; smtp.subspace.kernel.org;\n dmarc=none (p=none dis=none) header.from=huaweicloud.com;\n spf=pass smtp.mailfrom=huaweicloud.com; arc=none smtp.client-ip=45.249.212.56" ], "From": "Zhang Yi <yi.zhang@huaweicloud.com>", "To": "linux-ext4@vger.kernel.org", "Cc": "linux-fsdevel@vger.kernel.org,\n\tlinux-kernel@vger.kernel.org,\n\tdave@stgolabs.net,\n\ttytso@mit.edu,\n\tadilger.kernel@dilger.ca,\n\tjack@suse.cz,\n\tojaswin@linux.ibm.com,\n\tritesh.list@gmail.com,\n\tlibaokun@linux.alibaba.com,\n\tyi.zhang@huawei.com,\n\tyi.zhang@huaweicloud.com,\n\tyizhang089@gmail.com,\n\tyangerkun@huawei.com,\n\tyukuai@fnnas.com", "Subject": "[PATCH] jbd2: fix deadlock in jbd2_journal_cancel_revoke()", "Date": "Thu, 9 Apr 2026 09:07:30 +0800", "Message-ID": "<20260409010730.5508-1-yi.zhang@huaweicloud.com>", "X-Mailer": "git-send-email 2.52.0", "Precedence": "bulk", "X-Mailing-List": "linux-ext4@vger.kernel.org", "List-Id": "<linux-ext4.vger.kernel.org>", "List-Subscribe": "<mailto:linux-ext4+subscribe@vger.kernel.org>", "List-Unsubscribe": "<mailto:linux-ext4+unsubscribe@vger.kernel.org>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-CM-TRANSID": "cCh0CgC3utoW_dZp37OQDw--.20149S4", "X-Coremail-Antispam": "1UD129KBjvJXoW7Kw15XF4rJr15JF43XFWrKrg_yoW8Zw13pr\n\t90kFyYkrykuF9Ik3ZrXa4UX3ZxCw1kWryUWFZa9wnFkF45XFnFgF42g3WYqFWjvrs7XwsY\n\tqFWjya4rua109rDanT9S1TB71UUUUU7qnTZGkaVYY2UrUUUUjbIjqfuFe4nvWSU5nxnvy2\n\t9KBjDU0xBIdaVrnRJUUU9Y14x267AKxVW5JVWrJwAFc2x0x2IEx4CE42xK8VAvwI8IcIk0\n\trVWrJVCq3wAFIxvE14AKwVWUJVWUGwA2ocxC64kIII0Yj41l84x0c7CEw4AK67xGY2AK02\n\t1l84ACjcxK6xIIjxv20xvE14v26w1j6s0DM28EF7xvwVC0I7IYx2IY6xkF7I0E14v26r4U\n\tJVWxJr1l84ACjcxK6I8E87Iv67AKxVW0oVCq3wA2z4x0Y4vEx4A2jsIEc7CjxVAFwI0_Gc\n\tCE3s1le2I262IYc4CY6c8Ij28IcVAaY2xG8wAqx4xG64xvF2IEw4CE5I8CrVC2j2WlYx0E\n\t2Ix0cI8IcVAFwI0_Jr0_Jr4lYx0Ex4A2jsIE14v26r1j6r4UMcvjeVCFs4IE7xkEbVWUJV\n\tW8JwACjcxG0xvY0x0EwIxGrwACjI8F5VA0II8E6IAqYI8I648v4I1lFIxGxcIEc7CjxVA2\n\tY2ka0xkIwI1lc7CjxVAaw2AFwI0_Jw0_GFyl42xK82IYc2Ij64vIr41l4I8I3I0E4IkC6x\n\t0Yz7v_Jr0_Gr1lx2IqxVAqx4xG67AKxVWUJVWUGwC20s026x8GjcxK67AKxVWUGVWUWwC2\n\tzVAF1VAY17CE14v26r1q6r43MIIYrxkI7VAKI48JMIIF0xvE2Ix0cI8IcVAFwI0_Jr0_JF\n\t4lIxAIcVC0I7IYx2IY6xkF7I0E14v26r4j6F4UMIIF0xvE42xK8VAvwI8IcIk0rVWUJVWU\n\tCwCI42IY6I8E87Iv67AKxVWUJVW8JwCI42IY6I8E87Iv6xkF7I0E14v26r4j6r4UJbIYCT\n\tnIWIevJa73UjIFyTuYvjfUOv38UUUUU", "X-CM-SenderInfo": "d1lo6xhdqjqx5xdzvxpfor3voofrz/", "X-Spam-Status": "No, score=-1.1 required=5.0 tests=ARC_SIGNED,ARC_VALID,\n\tDMARC_MISSING,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,\n\tSPF_HELO_NONE,SPF_PASS autolearn=disabled version=4.0.1", "X-Spam-Checker-Version": "SpamAssassin 4.0.1 (2024-03-25) on gandalf.ozlabs.org" }, "content": "From: Zhang Yi <yi.zhang@huawei.com>\n\nCommit f76d4c28a46a (\"fs/jbd2: use sleeping version of\n__find_get_block()\") changed jbd2_journal_cancel_revoke() to use\n__find_get_block_nonatomic() which holds the folio lock instead of\ni_private_lock. This breaks the lock ordering (folio -> buffer) and\ncauses an ABBA deadlock when the filesystem blocksize < pagesize:\n\n T1 T2\next4_mkdir()\n ext4_init_new_dir()\n ext4_append()\n ext4_getblk()\n lock_buffer() <- A\n sync_blockdev()\n blkdev_writepages()\n writeback_iter()\n writeback_get_folio()\n folio_lock() <- B\n ext4_journal_get_create_access()\n jbd2_journal_cancel_revoke()\n __find_get_block_nonatomic()\n folio_lock() <- B\n block_write_full_folio()\n lock_buffer() <- A\n\nThis can occasionally cause generic/013 to hang.\n\nFix by only calling __find_get_block_nonatomic() when the passed\nbuffer_head doesn't belong to the bdev (i.e., !bh->b_bdev), which is the\nonly case that we need to look up its bdev alias. Otherwise, the lookup\nis redundant since the found buffer_head is equal to the one we passed\nin.\n\nFixes: f76d4c28a46a (\"fs/jbd2: use sleeping version of __find_get_block()\")\nSigned-off-by: Zhang Yi <yi.zhang@huawei.com>\n---\n fs/jbd2/revoke.c | 7 ++++---\n 1 file changed, 4 insertions(+), 3 deletions(-)", "diff": "diff --git a/fs/jbd2/revoke.c b/fs/jbd2/revoke.c\nindex 9016ddb82447..8b52d40c27c9 100644\n--- a/fs/jbd2/revoke.c\n+++ b/fs/jbd2/revoke.c\n@@ -464,13 +464,14 @@ void jbd2_journal_cancel_revoke(handle_t *handle, struct journal_head *jh)\n \t * buffer_head? If so, we'd better make sure we clear the\n \t * revoked status on any hashed alias too, otherwise the revoke\n \t * state machine will get very upset later on. */\n-\tif (need_cancel) {\n+\tif (need_cancel && !bh->b_bdev) {\n \t\tstruct buffer_head *bh2;\n+\n \t\tbh2 = __find_get_block_nonatomic(bh->b_bdev, bh->b_blocknr,\n \t\t\t\t\t\t bh->b_size);\n \t\tif (bh2) {\n-\t\t\tif (bh2 != bh)\n-\t\t\t\tclear_buffer_revoked(bh2);\n+\t\t\tWARN_ON_ONCE(bh2 == bh);\n+\t\t\tclear_buffer_revoked(bh2);\n \t\t\t__brelse(bh2);\n \t\t}\n \t}\n", "prefixes": [] }