Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/1.1/patches/2221179/?format=api
{ "id": 2221179, "url": "http://patchwork.ozlabs.org/api/1.1/patches/2221179/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20260407222208.271838-14-pierrick.bouvier@linaro.org/", "project": { "id": 14, "url": "http://patchwork.ozlabs.org/api/1.1/projects/14/?format=api", "name": "QEMU Development", "link_name": "qemu-devel", "list_id": "qemu-devel.nongnu.org", "list_email": "qemu-devel@nongnu.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20260407222208.271838-14-pierrick.bouvier@linaro.org>", "date": "2026-04-07T22:22:00", "name": "[v11,13/21] target/arm/tcg/translate.c: extract aarch64_translate_code()", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "76c917bb08a35a2c1252d4ae6da796afbba7c2fc", "submitter": { "id": 85798, "url": "http://patchwork.ozlabs.org/api/1.1/people/85798/?format=api", "name": "Pierrick Bouvier", "email": "pierrick.bouvier@linaro.org" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20260407222208.271838-14-pierrick.bouvier@linaro.org/mbox/", "series": [ { "id": 499177, "url": "http://patchwork.ozlabs.org/api/1.1/series/499177/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/list/?series=499177", "date": "2026-04-07T22:21:55", "name": "target/arm: single-binary", "version": 11, "mbox": "http://patchwork.ozlabs.org/series/499177/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/2221179/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/2221179/checks/", "tags": {}, "headers": { "Return-Path": "<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@legolas.ozlabs.org", "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256\n header.s=google header.b=IVSIyItd;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)" ], "Received": [ "from lists.gnu.org (lists1p.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4frYHV5MStz1yD3\n\tfor <incoming@patchwork.ozlabs.org>; Thu, 09 Apr 2026 05:37:24 +1000 (AEST)", "from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from <qemu-devel-bounces@nongnu.org>)\n\tid 1wAYcC-0005LU-Ag; Wed, 08 Apr 2026 15:31:04 -0400", "from eggs.gnu.org ([2001:470:142:3::10])\n by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <pierrick.bouvier@linaro.org>)\n id 1wAYA4-0000lD-4A\n for qemu-devel@nongnu.org; Wed, 08 Apr 2026 15:02:00 -0400", "from mail-pl1-x629.google.com ([2607:f8b0:4864:20::629])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)\n (Exim 4.90_1) (envelope-from <pierrick.bouvier@linaro.org>)\n id 1wAEoZ-0000py-A6\n for qemu-devel@nongnu.org; Tue, 07 Apr 2026 18:22:32 -0400", "by mail-pl1-x629.google.com with SMTP id\n d9443c01a7336-2b258576d8cso35167445ad.0\n for <qemu-devel@nongnu.org>; Tue, 07 Apr 2026 15:22:30 -0700 (PDT)", "from pc.taild8403c.ts.net (216-71-219-44.dyn.novuscom.net.\n [216.71.219.44]) by smtp.gmail.com with ESMTPSA id\n d9443c01a7336-2b274979d5csm180412065ad.38.2026.04.07.15.22.27\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Tue, 07 Apr 2026 15:22:28 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=linaro.org; s=google; t=1775600549; x=1776205349; darn=nongnu.org;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:from:to:cc:subject:date\n :message-id:reply-to;\n bh=QMozfKLpPr+o2x65kY+FaUHoEdApriGrkE0DK1FGUcI=;\n b=IVSIyItd3BO0Ba+TQORYM+wUeukx7eYzPo6VTSiSbc/xF3vVA5pLQlKgg4TDiJgxdF\n wrm2JWy3uUErpPXegEdBBjCL/PlBc8xCLn7cys9ShusVb1kffUP9ssq4rbrIozlQii7N\n BbgrGI6Rj/UB0lFF/c3bqnrJSGYDd4/gtGHDgc/V5N/vxjnhWNxsM6btNQJc2N8GVGK6\n Es2Lj0l6cUekdGi0kB/qc+xvhMbJ7ijmAo1ox2EFDxdLH1sQ4tMCmPjI8mqXbxqtezyg\n vP1W9Uoc580pqHaP3o8DFca8a9DHudfHnJjbVM8xWZpLTyDSQGICs4v95xzA6EB/Tc+m\n My9A==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1775600549; x=1776205349;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from\n :to:cc:subject:date:message-id:reply-to;\n bh=QMozfKLpPr+o2x65kY+FaUHoEdApriGrkE0DK1FGUcI=;\n b=P883wAudQmV83t3J9p/5R01SEN4Kb3BPh5xDjGoqfs6ClOCY6pqVC9aYLsRxZNiPGX\n Mn87FJQ6SGf8se+Ie7Bpef81X3n85PyI8TWkSQnGk4SAswxQl7Fo5NVH14equZhZR/v2\n 2EdTgjw/6DPFZY0xEGkrm3DujhTI23BXn6YfY8YmqBgfzhm9ckCw5/CA8EjhMyZpokLM\n G2e32GKcgFSUXlnXKHJ3pANVZXQjeH8iRdmgQeiStrIVAmgGQF+m1jp5xkpgxOqSH6xq\n 6S0REQN+6GJw6Xd5YdYeGEdqp8iuVGdnNSGcXqJPoVb7GDfT+p3u/ad7299DKm45fbDa\n UOOg==", "X-Gm-Message-State": "AOJu0Yw4ibJrhsXujJRKVQaecg+A5G3WEiEyW32LSAO2UwWx4w385uhM\n 2abl4VAnpcR2Z4OJwahGHqNoJyAO+/kvQKCybcHE2cI52Mtfyg7Ea/yLYHvJtahj3k1WU7wttuZ\n mv5R8rFc=", "X-Gm-Gg": "AeBDietmYSvLXhniKllEis+RXy43aw5T6EvATLzr7fiEcjR8cn5qWPcEeu6dHnX+D2o\n QFvX8YgPRSjfnT71OlW4aE7h4QZclPB/YXJPME+1oc/ETscZ3HTZv6ILsscnVANqW/Hz/VFlfJT\n 9Zgn6A4g+D0C69BEw1qpIhTFtjKIVwFyHqNLO+He7v0KGxIqhbR3DF2rdzzH+5uS6f8m+L0zWDL\n gQMySOBcn0I+5AN7UgJzR/8/d8UB5EbdsFbIxRH8ZfLP2DHpbhal522zLLN+h6kZpq8m3da8utN\n ksSwXKvevqt5BnJHidzLTyS1lWW6g1upqjW7lFonOAWfUM9bMQL0dsPIX8xAdOdiMjDHOl0K17B\n gvAuvMkV/W8tH5eJ5d06Y8C1msLuMpQp3rlXmfzpwd947Gq3sJ/s/Cb1k/kMUGmMnQq+VQvlX1S\n Ve7GLW3ffLL6YEuGpJK30Ax3GijC0nXU2iY0yamzP5BsXk7v9dF8YD9issBngNfuH2izeikOP5b\n yGW", "X-Received": "by 2002:a17:903:3b8f:b0:2b0:445a:8c7b with SMTP id\n d9443c01a7336-2b28181f77amr196965195ad.15.1775600549042;\n Tue, 07 Apr 2026 15:22:29 -0700 (PDT)", "From": "Pierrick Bouvier <pierrick.bouvier@linaro.org>", "To": "qemu-devel@nongnu.org", "Cc": "philmd@linaro.org, jim.macarthur@linaro.org,\n Paolo Bonzini <pbonzini@redhat.com>,\n Richard Henderson <richard.henderson@linaro.org>, qemu-arm@nongnu.org,\n Pierrick Bouvier <pierrick.bouvier@linaro.org>,\n Peter Maydell <peter.maydell@linaro.org>", "Subject": "[PATCH v11 13/21] target/arm/tcg/translate.c: extract\n aarch64_translate_code()", "Date": "Tue, 7 Apr 2026 15:22:00 -0700", "Message-ID": "<20260407222208.271838-14-pierrick.bouvier@linaro.org>", "X-Mailer": "git-send-email 2.47.3", "In-Reply-To": "<20260407222208.271838-1-pierrick.bouvier@linaro.org>", "References": "<20260407222208.271838-1-pierrick.bouvier@linaro.org>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=UTF-8", "Content-Transfer-Encoding": "8bit", "Received-SPF": "pass client-ip=2607:f8b0:4864:20::629;\n envelope-from=pierrick.bouvier@linaro.org; helo=mail-pl1-x629.google.com", "X-Spam_score_int": "-20", "X-Spam_score": "-2.1", "X-Spam_bar": "--", "X-Spam_report": "(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001,\n SPF_PASS=-0.001 autolearn=ham autolearn_force=no", "X-Spam_action": "no action", "X-BeenThere": "qemu-devel@nongnu.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "qemu development <qemu-devel.nongnu.org>", "List-Unsubscribe": "<https://lists.nongnu.org/mailman/options/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>", "List-Archive": "<https://lists.nongnu.org/archive/html/qemu-devel>", "List-Post": "<mailto:qemu-devel@nongnu.org>", "List-Help": "<mailto:qemu-devel-request@nongnu.org?subject=help>", "List-Subscribe": "<https://lists.nongnu.org/mailman/listinfo/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=subscribe>", "Errors-To": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org", "Sender": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org" }, "content": "This allows to get rid of TARGET_AARCH64, and helps with next patch\nwhich will define at runtime tcg address type, by adding a second entry\npoint in a different source file.\n\nSuggested-by: Richard Henderson <richard.henderson@linaro.org>\nReviewed-by: Richard Henderson <richard.henderson@linaro.org>\nReviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>\nSigned-off-by: Pierrick Bouvier <pierrick.bouvier@linaro.org>\n---\n target/arm/internals.h | 2 ++\n target/arm/tcg/stubs32.c | 7 +++++++\n target/arm/tcg/translate-a64.c | 9 +++++++++\n target/arm/tcg/translate.c | 19 +++++++++----------\n 4 files changed, 27 insertions(+), 10 deletions(-)", "diff": "diff --git a/target/arm/internals.h b/target/arm/internals.h\nindex 8ec27508473..2850edcb198 100644\n--- a/target/arm/internals.h\n+++ b/target/arm/internals.h\n@@ -381,6 +381,8 @@ void arm_init_cpreg_list(ARMCPU *cpu);\n \n void arm_cpu_register_gdb_regs_for_features(ARMCPU *cpu);\n void arm_translate_init(void);\n+void aarch64_translate_code(CPUState *cs, TranslationBlock *tb,\n+ int *max_insns, vaddr pc, void *host_pc);\n void arm_translate_code(CPUState *cs, TranslationBlock *tb,\n int *max_insns, vaddr pc, void *host_pc);\n \ndiff --git a/target/arm/tcg/stubs32.c b/target/arm/tcg/stubs32.c\nindex c5a0bc61f47..3945dc49e5e 100644\n--- a/target/arm/tcg/stubs32.c\n+++ b/target/arm/tcg/stubs32.c\n@@ -3,6 +3,7 @@\n */\n \n #include \"qemu/osdep.h\"\n+#include \"target/arm/internals.h\"\n #include \"target/arm/tcg/translate.h\"\n \n \n@@ -15,3 +16,9 @@ void a64_translate_init(void)\n {\n /* Don't initialize for 32 bits. Call site will be fixed later. */\n }\n+\n+void aarch64_translate_code(CPUState *cs, TranslationBlock *tb,\n+ int *max_insns, vaddr pc, void *host_pc)\n+{\n+ g_assert_not_reached();\n+}\ndiff --git a/target/arm/tcg/translate-a64.c b/target/arm/tcg/translate-a64.c\nindex 35ad7530c4b..7533a4d01b6 100644\n--- a/target/arm/tcg/translate-a64.c\n+++ b/target/arm/tcg/translate-a64.c\n@@ -18,6 +18,7 @@\n */\n #include \"qemu/osdep.h\"\n #include \"exec/target_page.h\"\n+#include \"exec/translator.h\"\n #include \"helper-a64.h\"\n #include \"helper-sme.h\"\n #include \"helper-sve.h\"\n@@ -10949,3 +10950,11 @@ const TranslatorOps aarch64_translator_ops = {\n .translate_insn = aarch64_tr_translate_insn,\n .tb_stop = aarch64_tr_tb_stop,\n };\n+\n+void aarch64_translate_code(CPUState *cpu, TranslationBlock *tb,\n+ int *max_insns, vaddr pc, void *host_pc)\n+{\n+ DisasContext dc = {};\n+ translator_loop(cpu, tb, max_insns, pc, host_pc,\n+ &aarch64_translator_ops, &dc.base);\n+}\ndiff --git a/target/arm/tcg/translate.c b/target/arm/tcg/translate.c\nindex 204f9657993..9ab926b118e 100644\n--- a/target/arm/tcg/translate.c\n+++ b/target/arm/tcg/translate.c\n@@ -28,6 +28,7 @@\n #include \"semihosting/semihost.h\"\n #include \"cpregs.h\"\n #include \"exec/target_page.h\"\n+#include \"exec/translator.h\"\n #include \"helper.h\"\n #include \"helper-mve.h\"\n \n@@ -6878,18 +6879,16 @@ static const TranslatorOps thumb_translator_ops = {\n void arm_translate_code(CPUState *cpu, TranslationBlock *tb,\n int *max_insns, vaddr pc, void *host_pc)\n {\n- DisasContext dc = { };\n- const TranslatorOps *ops = &arm_translator_ops;\n CPUARMTBFlags tb_flags = arm_tbflags_from_tb(tb);\n \n- if (EX_TBFLAG_AM32(tb_flags, THUMB)) {\n- ops = &thumb_translator_ops;\n- }\n-#ifdef TARGET_AARCH64\n if (EX_TBFLAG_ANY(tb_flags, AARCH64_STATE)) {\n- ops = &aarch64_translator_ops;\n+ aarch64_translate_code(cpu, tb, max_insns, pc, host_pc);\n+ } else {\n+ DisasContext dc = { };\n+ translator_loop(cpu, tb, max_insns, pc, host_pc,\n+ (EX_TBFLAG_AM32(tb_flags, THUMB)\n+ ? &thumb_translator_ops\n+ : &arm_translator_ops),\n+ &dc.base);\n }\n-#endif\n-\n- translator_loop(cpu, tb, max_insns, pc, host_pc, ops, &dc.base);\n }\n", "prefixes": [ "v11", "13/21" ] }