Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/1.1/patches/2221105/?format=api
{ "id": 2221105, "url": "http://patchwork.ozlabs.org/api/1.1/patches/2221105/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20260408010026.4611-2-matt@matthewpenney.net/", "project": { "id": 14, "url": "http://patchwork.ozlabs.org/api/1.1/projects/14/?format=api", "name": "QEMU Development", "link_name": "qemu-devel", "list_id": "qemu-devel.nongnu.org", "list_email": "qemu-devel@nongnu.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20260408010026.4611-2-matt@matthewpenney.net>", "date": "2026-04-08T01:01:58", "name": "[1/8] hw/char: use g_clear_handle_id() for GSource cleanup", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "883414f89d66ed881d86c9b4d9d6fee1cbb0af89", "submitter": { "id": 92789, "url": "http://patchwork.ozlabs.org/api/1.1/people/92789/?format=api", "name": "Matthew Penney", "email": "matt@matthewpenney.net" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20260408010026.4611-2-matt@matthewpenney.net/mbox/", "series": [ { "id": 499175, "url": "http://patchwork.ozlabs.org/api/1.1/series/499175/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/list/?series=499175", "date": "2026-04-08T01:02:28", "name": "[1/8] hw/char: use g_clear_handle_id() for GSource cleanup", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/499175/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/2221105/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/2221105/checks/", "tags": {}, "headers": { "Return-Path": "<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@legolas.ozlabs.org", "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=matthewpenney.net header.i=@matthewpenney.net\n header.a=rsa-sha256 header.s=protonmail header.b=G/Omia9p;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)" ], "Received": [ "from lists.gnu.org (lists1p.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4frXjy4JVjz1yD3\n\tfor <incoming@patchwork.ozlabs.org>; Thu, 09 Apr 2026 05:11:50 +1000 (AEST)", "from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from <qemu-devel-bounces@nongnu.org>)\n\tid 1wAYJM-0007xC-ID; Wed, 08 Apr 2026 15:11:36 -0400", "from eggs.gnu.org ([2001:470:142:3::10])\n by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <matt@matthewpenney.net>)\n id 1wAYGt-0004ui-LU; Wed, 08 Apr 2026 15:09:06 -0400", "from mail-05.mail-europe.com ([85.9.206.169])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <matt@matthewpenney.net>)\n id 1wAHL5-0001LR-V7; Tue, 07 Apr 2026 21:04:17 -0400" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=matthewpenney.net;\n s=protonmail; t=1775610124; x=1775869324;\n bh=axp9OvX2u/1jELssvVNz/X82F+EVXOIbQ2Ns624NQ98=;\n h=Date:To:From:Cc:Subject:Message-ID:Feedback-ID:From:To:Cc:Date:\n Subject:Reply-To:Feedback-ID:Message-ID:BIMI-Selector;\n b=G/Omia9pDQrucoGX9D2WymyPX7/ggOqz+4YU+1keUf+ISw9boiB1hGKNF6LWrhvGD\n QrBt1lOycaHd2MegDn75fG1EtLks2K0QAK6xZBCm+x2n/OAMtGK6jLM+SZx7Ql/LAE\n sQR+rFGqn1Vj897B4hMsJuIYimsQE1F3Pt0k4kWlOE2q7y8PIGvBoeCxt9cuRDRY1e\n E9xnCJWjBYHhMa+bym9cxFI2y2bzIIN8axXL3sOybs+HTke0LtqLuvKfrtKhH9NiVR\n irfe/blqNBGfEkg97TaDwOsAyPHNoH2iyec0yGjjF1inxcoRGGtcxZjGmg0nXTLbgn\n QhXMmLIWDizxg==", "Date": "Wed, 08 Apr 2026 01:01:58 +0000", "To": "qemu-devel@nongnu.org", "From": "Matthew Penney <matt@matthewpenney.net>", "Cc": "Matthew Penney <matt@matthewpenney.net>, peter.maydell@linaro.org,\n marcandre.lureau@redhat.com, Paolo Bonzini <pbonzini@redhat.com>,\n joel@jms.id.au, \"Michael S. Tsirkin\" <mst@redhat.com>, sam@rfc1149.net,\n pasic@linux.ibm.com, borntraeger@linux.ibm.com,\n \"Collin L. Walling\" <walling@linux.ibm.com>, cohuck@redhat.com,\n farman@linux.ibm.com, mjrosato@linux.ibm.com, lvivier@redhat.com,\n amit@kernel.org, qemu-arm@nongnu.org, qemu-s390x@nongnu.org", "Subject": "[PATCH 1/8] hw/char: use g_clear_handle_id() for GSource cleanup", "Message-ID": "<20260408010026.4611-2-matt@matthewpenney.net>", "Feedback-ID": "185185778:user:proton", "X-Pm-Message-ID": "d72ce9499a15f39196aa172ce73e39dc25ed90eb", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=utf-8", "Content-Transfer-Encoding": "quoted-printable", "Received-SPF": "pass client-ip=85.9.206.169;\n envelope-from=matt@matthewpenney.net;\n helo=mail-05.mail-europe.com", "X-Spam_score_int": "-27", "X-Spam_score": "-2.8", "X-Spam_bar": "--", "X-Spam_report": "(-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001,\n RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001, SPF_HELO_NONE=0.001,\n SPF_PASS=-0.001 autolearn=ham autolearn_force=no", "X-Spam_action": "no action", "X-BeenThere": "qemu-devel@nongnu.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "qemu development <qemu-devel.nongnu.org>", "List-Unsubscribe": "<https://lists.nongnu.org/mailman/options/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>", "List-Archive": "<https://lists.nongnu.org/archive/html/qemu-devel>", "List-Post": "<mailto:qemu-devel@nongnu.org>", "List-Help": "<mailto:qemu-devel-request@nongnu.org?subject=help>", "List-Subscribe": "<https://lists.nongnu.org/mailman/listinfo/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=subscribe>", "Errors-To": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org", "Sender": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org" }, "content": "Use g_clear_handle_id() instead of g_source_remove() with manual ID\nchecking and zeroing.\n\nThis simplifies the code and ensures consistent handling of GSource IDs,\nsince g_clear_handle_id() checks for a non-zero ID before calling the\ncleanup function and zeros it afterwards.\n\nNo functional change intended.\n\nSigned-off-by: Matthew Penney <matt@matthewpenney.net>\n---\n hw/char/cmsdk-apb-uart.c | 5 +----\n hw/char/nrf51_uart.c | 5 +----\n hw/char/serial.c | 7 ++-----\n hw/char/stm32l4x5_usart.c | 5 +----\n hw/char/terminal3270.c | 5 +----\n hw/char/virtio-console.c | 11 +++--------\n 6 files changed, 9 insertions(+), 29 deletions(-)", "diff": "diff --git a/hw/char/cmsdk-apb-uart.c b/hw/char/cmsdk-apb-uart.c\nindex edb80f6181..0631821a57 100644\n--- a/hw/char/cmsdk-apb-uart.c\n+++ b/hw/char/cmsdk-apb-uart.c\n@@ -236,10 +236,7 @@ buffer_drained:\n \n static void uart_cancel_transmit(CMSDKAPBUART *s)\n {\n- if (s->watch_tag) {\n- g_source_remove(s->watch_tag);\n- s->watch_tag = 0;\n- }\n+ g_clear_handle_id(&s->watch_tag, g_source_remove);\n }\n \n static void uart_write(void *opaque, hwaddr offset, uint64_t value,\ndiff --git a/hw/char/nrf51_uart.c b/hw/char/nrf51_uart.c\nindex 7306923244..96f0d085fd 100644\n--- a/hw/char/nrf51_uart.c\n+++ b/hw/char/nrf51_uart.c\n@@ -104,10 +104,7 @@ buffer_drained:\n \n static void uart_cancel_transmit(NRF51UARTState *s)\n {\n- if (s->watch_tag) {\n- g_source_remove(s->watch_tag);\n- s->watch_tag = 0;\n- }\n+ g_clear_handle_id(&s->watch_tag, g_source_remove);\n }\n \n static void uart_write(void *opaque, hwaddr addr,\ndiff --git a/hw/char/serial.c b/hw/char/serial.c\nindex 0f3469a1e8..cfb5efed50 100644\n--- a/hw/char/serial.c\n+++ b/hw/char/serial.c\n@@ -857,10 +857,7 @@ static void serial_reset(void *opaque)\n {\n SerialState *s = opaque;\n \n- if (s->watch_tag > 0) {\n- g_source_remove(s->watch_tag);\n- s->watch_tag = 0;\n- }\n+ g_clear_handle_id(&s->watch_tag, g_source_remove);\n \n s->rbr = 0;\n s->ier = 0;\n@@ -913,7 +910,7 @@ static int serial_be_change(void *opaque)\n }\n \n if (s->watch_tag > 0) {\n- g_source_remove(s->watch_tag);\n+ g_clear_handle_id(&s->watch_tag, g_source_remove);\n s->watch_tag = qemu_chr_fe_add_watch(&s->chr, G_IO_OUT | G_IO_HUP,\n serial_watch_cb, s);\n }\ndiff --git a/hw/char/stm32l4x5_usart.c b/hw/char/stm32l4x5_usart.c\nindex 736f1e764e..dd1b099195 100644\n--- a/hw/char/stm32l4x5_usart.c\n+++ b/hw/char/stm32l4x5_usart.c\n@@ -280,10 +280,7 @@ buffer_drained:\n \n static void usart_cancel_transmit(Stm32l4x5UsartBaseState *s)\n {\n- if (s->watch_tag) {\n- g_source_remove(s->watch_tag);\n- s->watch_tag = 0;\n- }\n+ g_clear_handle_id(&s->watch_tag, g_source_remove);\n }\n \n static void stm32l4x5_update_params(Stm32l4x5UsartBaseState *s)\ndiff --git a/hw/char/terminal3270.c b/hw/char/terminal3270.c\nindex 1d857bad9b..989b6f6ee1 100644\n--- a/hw/char/terminal3270.c\n+++ b/hw/char/terminal3270.c\n@@ -52,10 +52,7 @@ static int terminal_can_read(void *opaque)\n \n static void terminal_timer_cancel(Terminal3270 *t)\n {\n- if (t->timer_tag) {\n- g_source_remove(t->timer_tag);\n- t->timer_tag = 0;\n- }\n+ g_clear_handle_id(&t->timer_tag, g_source_remove);\n }\n \n /*\ndiff --git a/hw/char/virtio-console.c b/hw/char/virtio-console.c\nindex efe7cd6772..4de8577c13 100644\n--- a/hw/char/virtio-console.c\n+++ b/hw/char/virtio-console.c\n@@ -159,10 +159,7 @@ static void chr_event(void *opaque, QEMUChrEvent event)\n virtio_serial_open(port);\n break;\n case CHR_EVENT_CLOSED:\n- if (vcon->watch) {\n- g_source_remove(vcon->watch);\n- vcon->watch = 0;\n- }\n+ g_clear_handle_id(&vcon->watch, g_source_remove);\n virtio_serial_close(port);\n break;\n case CHR_EVENT_BREAK:\n@@ -188,7 +185,7 @@ static int chr_be_change(void *opaque)\n }\n \n if (vcon->watch) {\n- g_source_remove(vcon->watch);\n+ g_clear_handle_id(&vcon->watch, g_source_remove);\n vcon->watch = qemu_chr_fe_add_watch(&vcon->chr,\n G_IO_OUT | G_IO_HUP,\n chr_write_unblocked, vcon);\n@@ -256,9 +253,7 @@ static void virtconsole_unrealize(DeviceState *dev)\n {\n VirtConsole *vcon = VIRTIO_CONSOLE(dev);\n \n- if (vcon->watch) {\n- g_clear_handle_id(&vcon->watch, g_source_remove);\n- }\n+ g_clear_handle_id(&vcon->watch, g_source_remove);\n }\n \n static void virtconsole_class_init(ObjectClass *klass, const void *data)\n", "prefixes": [ "1/8" ] }