Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/1.1/patches/2221018/?format=api
{ "id": 2221018, "url": "http://patchwork.ozlabs.org/api/1.1/patches/2221018/?format=api", "web_url": "http://patchwork.ozlabs.org/project/linuxppc-dev/patch/20260408-ibmvfc-fpin-support-v1-2-52b06c464e03@linux.ibm.com/", "project": { "id": 2, "url": "http://patchwork.ozlabs.org/api/1.1/projects/2/?format=api", "name": "Linux PPC development", "link_name": "linuxppc-dev", "list_id": "linuxppc-dev.lists.ozlabs.org", "list_email": "linuxppc-dev@lists.ozlabs.org", "web_url": "https://github.com/linuxppc/wiki/wiki", "scm_url": "https://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux.git", "webscm_url": "https://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux.git/" }, "msgid": "<20260408-ibmvfc-fpin-support-v1-2-52b06c464e03@linux.ibm.com>", "date": "2026-04-08T17:07:43", "name": "[2/5] ibmvfc: Add NOOP command support", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "04d73f4c9112e30935717bc03538ae106f04af33", "submitter": { "id": 93089, "url": "http://patchwork.ozlabs.org/api/1.1/people/93089/?format=api", "name": "Dave Marquardt via B4 Relay", "email": "devnull+davemarq.linux.ibm.com@kernel.org" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/linuxppc-dev/patch/20260408-ibmvfc-fpin-support-v1-2-52b06c464e03@linux.ibm.com/mbox/", "series": [ { "id": 499164, "url": "http://patchwork.ozlabs.org/api/1.1/series/499164/?format=api", "web_url": "http://patchwork.ozlabs.org/project/linuxppc-dev/list/?series=499164", "date": "2026-04-08T17:07:44", "name": "ibmvfc: make ibmvfc support FPIN messages", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/499164/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/2221018/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/2221018/checks/", "tags": {}, "headers": { "Return-Path": "\n <linuxppc-dev+bounces-19518-incoming=patchwork.ozlabs.org@lists.ozlabs.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "linuxppc-dev@lists.ozlabs.org" ], "Delivered-To": "patchwork-incoming@legolas.ozlabs.org", "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256\n header.s=k20201202 header.b=Am6AMy4m;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=lists.ozlabs.org\n (client-ip=2404:9400:21b9:f100::1; helo=lists.ozlabs.org;\n envelope-from=linuxppc-dev+bounces-19518-incoming=patchwork.ozlabs.org@lists.ozlabs.org;\n receiver=patchwork.ozlabs.org)", "lists.ozlabs.org;\n arc=none smtp.remote-ip=\"2600:3c0a:e001:78e:0:1991:8:25\"", "lists.ozlabs.org;\n dmarc=pass (p=quarantine dis=none) header.from=kernel.org", "lists.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256\n header.s=k20201202 header.b=Am6AMy4m;\n\tdkim-atps=neutral", "lists.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=kernel.org\n (client-ip=2600:3c0a:e001:78e:0:1991:8:25; helo=sea.source.kernel.org;\n envelope-from=devnull+davemarq.linux.ibm.com@kernel.org;\n receiver=lists.ozlabs.org)" ], "Received": [ "from lists.ozlabs.org (lists.ozlabs.org\n [IPv6:2404:9400:21b9:f100::1])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4frTzC1L4Gz1xv0\n\tfor <incoming@patchwork.ozlabs.org>; Thu, 09 Apr 2026 03:08:07 +1000 (AEST)", "from boromir.ozlabs.org (localhost [127.0.0.1])\n\tby lists.ozlabs.org (Postfix) with ESMTP id 4frTz06MrHz2ypw;\n\tThu, 09 Apr 2026 03:07:56 +1000 (AEST)", "from sea.source.kernel.org (sea.source.kernel.org\n [IPv6:2600:3c0a:e001:78e:0:1991:8:25])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature RSA-PSS (2048 bits) server-digest\n SHA256)\n\t(No client certificate requested)\n\tby lists.ozlabs.org (Postfix) with ESMTPS id 4frTyw3wPtz2yVP\n\tfor <linuxppc-dev@lists.ozlabs.org>; Thu, 09 Apr 2026 03:07:52 +1000 (AEST)", "from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58])\n\tby sea.source.kernel.org (Postfix) with ESMTP id 89F124431A;\n\tWed, 8 Apr 2026 17:07:49 +0000 (UTC)", "by smtp.kernel.org (Postfix) with ESMTPS id 66046C2BC9E;\n\tWed, 8 Apr 2026 17:07:49 +0000 (UTC)", "from aws-us-west-2-korg-lkml-1.web.codeaurora.org\n (localhost.localdomain [127.0.0.1])\n\tby smtp.lore.kernel.org (Postfix) with ESMTP id 5B83B10F9961;\n\tWed, 8 Apr 2026 17:07:49 +0000 (UTC)" ], "ARC-Seal": "i=1; a=rsa-sha256; d=lists.ozlabs.org; s=201707; t=1775668076;\n\tcv=none;\n b=Ri9JVi+efvyjOZzhTNUO8isYUHA9+iyPBevROoirr/3u5cTonIBLGlDFeR5dnYuB/2BhNu5r2CSGy2FASl2dBTDgUUUG4vaxf9famX4F5cNMlqnrQm8RmKVWIMa551z4IhCqVff3ZeGwHcBmTOu2p5GCAjFhUfG4ZHvb6IT6xWZ40RwdKmvh/jIsqA/akoph5Lz13J6sLSt9AFd5oUI9DyVcTr8Yva4Pi9XQs2MOLPXNFnPrXMLsgRgbYpqd9dsYyEdoQVHhPkmnWH0HisHuD0A6F0mdQCQF8UMd0Z3iBHUuPCU4yf72aWm8d5HgANXwJRt7KpU42+IiyIB+czOFrQ==", "ARC-Message-Signature": "i=1; a=rsa-sha256; d=lists.ozlabs.org; s=201707;\n\tt=1775668076; c=relaxed/relaxed;\n\tbh=wfyfBTtzXsRTsQfAr++s/Fpd+8/l99zGMEPoeZRv9b8=;\n\th=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References:\n\t In-Reply-To:To:Cc;\n b=RJEXeKPnb6CmGWeXbIydF8fl97RJu9MOJ6MWVv+dkmWBAo3jWtpC/B6esWQn/hBYSCJVQSOqpPNtda+RItml2o/J/LIc6aXHuS3TLXjwmRGT3yZHTdQ3kVKcdbEMDpC+8JLVXuN9wKDc1Yj3rH44Ennc6kT9OuKm+Pz9+SmUNzc6QckeBZOl9WLvfBbb6gWQ4bKjnv+OlQZLwqUq7cmK3EdPTpNnfKVkyb13kcGuQZ1SCZNEqY5N3D4WzdT0w0AuG+x+sRLbur7ElKUe9mtkW34ZK2id1kXoRMRyHGy7yX3UvTxRN985cromHW91TKA09A84p6WdI1Us+Tg9e1JKKQ==", "ARC-Authentication-Results": "i=1; lists.ozlabs.org;\n dmarc=pass (p=quarantine dis=none) header.from=kernel.org;\n dkim=pass (2048-bit key;\n unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256\n header.s=k20201202 header.b=Am6AMy4m; dkim-atps=neutral;\n spf=pass (client-ip=2600:3c0a:e001:78e:0:1991:8:25;\n helo=sea.source.kernel.org;\n envelope-from=devnull+davemarq.linux.ibm.com@kernel.org;\n receiver=lists.ozlabs.org) smtp.mailfrom=kernel.org", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;\n\ts=k20201202; t=1775668069;\n\tbh=nPzT0/RuJBqZZlg+GeHIBkfDAhpQe+soZk67pjb3qbI=;\n\th=From:Date:Subject:References:In-Reply-To:To:Cc:Reply-To:From;\n\tb=Am6AMy4m7CLqnC+ba9Q+kwdPrqZiitEBYz9NBESR/LlaGk6VTgTaNIjjf0cnxt2P8\n\t RgOPR3zM0pP/annF8maTEItxaoO5/VzGxJhgXWqL+dnyNgJ4TK2/s0rC0WpY94roRh\n\t VQbqHQfxQFFJ10Eztc7tFYcmh/JejkROJaIxgiwKvJPPQatcKd1E14xEV7+PIH1sCK\n\t +eyTrnJMjfqCOdmAwUa/O2ZodkiBbLoxGUKbOBPkiV3ck0u2Bii1kqlxMGI4DOGRU+\n\t 81zW2NBeKiFySgA+klciQ+n+o8m8r21+RWEG3Iff4+iHyjTAYRtT96Um7Mrge1mce/\n\t SVY92ac1kN3vg==", "From": "Dave Marquardt via B4 Relay <devnull+davemarq.linux.ibm.com@kernel.org>", "Date": "Wed, 08 Apr 2026 12:07:43 -0500", "Subject": "[PATCH 2/5] ibmvfc: Add NOOP command support", "X-Mailing-List": "linuxppc-dev@lists.ozlabs.org", "List-Id": "<linuxppc-dev.lists.ozlabs.org>", "List-Help": "<mailto:linuxppc-dev+help@lists.ozlabs.org>", "List-Owner": "<mailto:linuxppc-dev+owner@lists.ozlabs.org>", "List-Post": "<mailto:linuxppc-dev@lists.ozlabs.org>", "List-Archive": "<https://lore.kernel.org/linuxppc-dev/>,\n <https://lists.ozlabs.org/pipermail/linuxppc-dev/>", "List-Subscribe": "<mailto:linuxppc-dev+subscribe@lists.ozlabs.org>,\n <mailto:linuxppc-dev+subscribe-digest@lists.ozlabs.org>,\n <mailto:linuxppc-dev+subscribe-nomail@lists.ozlabs.org>", "List-Unsubscribe": "<mailto:linuxppc-dev+unsubscribe@lists.ozlabs.org>", "Precedence": "list", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"utf-8\"", "Content-Transfer-Encoding": "7bit", "Message-Id": "<20260408-ibmvfc-fpin-support-v1-2-52b06c464e03@linux.ibm.com>", "References": "<20260408-ibmvfc-fpin-support-v1-0-52b06c464e03@linux.ibm.com>", "In-Reply-To": "<20260408-ibmvfc-fpin-support-v1-0-52b06c464e03@linux.ibm.com>", "To": "\"James E.J. Bottomley\" <James.Bottomley@HansenPartnership.com>,\n \"Martin K. Petersen\" <martin.petersen@oracle.com>,\n Madhavan Srinivasan <maddy@linux.ibm.com>,\n Michael Ellerman <mpe@ellerman.id.au>, Nicholas Piggin <npiggin@gmail.com>,\n \"Christophe Leroy (CS GROUP)\" <chleroy@kernel.org>,\n Tyrel Datwyler <tyreld@linux.ibm.com>", "Cc": "linux-kernel@vger.kernel.org, linux-scsi@vger.kernel.org,\n linuxppc-dev@lists.ozlabs.org, Brian King <brking@linux.ibm.com>,\n Greg Joyce <gjoyce@linux.ibm.com>, Kyle Mahlkuch <kmahlkuc@linux.ibm.com>,\n Dave Marquardt <davemarq@linux.ibm.com>", "X-Mailer": "b4 0.15.1", "X-Developer-Signature": "v=1; a=ed25519-sha256; t=1775668068; l=5787;\n i=davemarq@linux.ibm.com; s=20260216; h=from:subject:message-id;\n bh=n0x38jb1bZNcxVTLqGeLg3JWwZ917lZAZQZ9f38BwC8=;\n b=YehqTVT50E6sV4zwteh8rEfJStiBCFGPtpJuVhLwWGKrLeEXW1qmoUz/Ko2nviIBgH+RBRc6j\n iUYVrgIs6EJCIJ1KwFUV3kcAGmz9HxumAJ4JQABAQofmjLKFm3uKmme", "X-Developer-Key": "i=davemarq@linux.ibm.com; a=ed25519;\n pk=vy0/nfobrje6EqZxuyw6a3ZstytG8WK2vf5Y3xtGrEg=", "X-Endpoint-Received": "by B4 Relay for davemarq@linux.ibm.com/20260216 with\n auth_id=689", "X-Original-From": "Dave Marquardt <davemarq@linux.ibm.com>", "Reply-To": "davemarq@linux.ibm.com", "X-Spam-Status": "No, score=-0.2 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED,\n\tDKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,SPF_PASS\n\tautolearn=disabled version=4.0.1 OzLabs 8", "X-Spam-Checker-Version": "SpamAssassin 4.0.1 (2024-03-25) on lists.ozlabs.org" }, "content": "From: Dave Marquardt <davemarq@linux.ibm.com>\n\n- Add VFC_NOOP command support\n- Add KUnit tests for VFC_NOOP command\n---\n drivers/scsi/ibmvscsi/ibmvfc.c | 23 +++++++++++++----------\n drivers/scsi/ibmvscsi/ibmvfc.h | 13 +++++++++++++\n drivers/scsi/ibmvscsi/ibmvfc_kunit.c | 27 +++++++++++++++++++++++++++\n 3 files changed, 53 insertions(+), 10 deletions(-)", "diff": "diff --git a/drivers/scsi/ibmvscsi/ibmvfc.c b/drivers/scsi/ibmvscsi/ibmvfc.c\nindex 3ac376ba2c62..808301fa452d 100644\n--- a/drivers/scsi/ibmvscsi/ibmvfc.c\n+++ b/drivers/scsi/ibmvscsi/ibmvfc.c\n@@ -189,13 +189,6 @@ static long h_reg_sub_crq(unsigned long unit_address, unsigned long ioba,\n \treturn rc;\n }\n \n-static int ibmvfc_check_caps(struct ibmvfc_host *vhost, unsigned long cap_flags)\n-{\n-\tu64 host_caps = be64_to_cpu(vhost->login_buf->resp.capabilities);\n-\n-\treturn (host_caps & cap_flags) ? 1 : 0;\n-}\n-\n static struct ibmvfc_fcp_cmd_iu *ibmvfc_get_fcp_iu(struct ibmvfc_host *vhost,\n \t\t\t\t\t\t struct ibmvfc_cmd *vfc_cmd)\n {\n@@ -1512,7 +1505,9 @@ static void ibmvfc_set_login_info(struct ibmvfc_host *vhost)\n \t\tlogin_info->flags |= cpu_to_be16(IBMVFC_CLIENT_MIGRATED);\n \n \tlogin_info->max_cmds = cpu_to_be32(max_cmds);\n-\tlogin_info->capabilities = cpu_to_be64(IBMVFC_CAN_MIGRATE | IBMVFC_CAN_SEND_VF_WWPN);\n+\tlogin_info->capabilities =\n+\t\tcpu_to_be64(IBMVFC_CAN_MIGRATE | IBMVFC_CAN_SEND_VF_WWPN |\n+\t\t\t IBMVFC_CAN_USE_NOOP_CMD);\n \n \tif (vhost->mq_enabled || vhost->using_channels)\n \t\tlogin_info->capabilities |= cpu_to_be64(IBMVFC_CAN_USE_CHANNELS);\n@@ -3461,8 +3456,8 @@ EXPORT_SYMBOL_IF_KUNIT(ibmvfc_handle_async);\n * @evt_doneq:\tEvent done queue\n *\n **/\n-static void ibmvfc_handle_crq(struct ibmvfc_crq *crq, struct ibmvfc_host *vhost,\n-\t\t\t struct list_head *evt_doneq)\n+VISIBLE_IF_KUNIT void ibmvfc_handle_crq(struct ibmvfc_crq *crq, struct ibmvfc_host *vhost,\n+\t\t\t\t\tstruct list_head *evt_doneq)\n {\n \tlong rc;\n \tstruct ibmvfc_event *evt = (struct ibmvfc_event *)be64_to_cpu(crq->ioba);\n@@ -3520,6 +3515,13 @@ static void ibmvfc_handle_crq(struct ibmvfc_crq *crq, struct ibmvfc_host *vhost,\n \tif (crq->format == IBMVFC_ASYNC_EVENT)\n \t\treturn;\n \n+\tif (crq->format == IBMVFC_VFC_NOOP) {\n+\t\tif (!ibmvfc_check_caps(vhost, IBMVFC_SUPPORT_NOOP_CMD))\n+\t\t\tdev_err(vhost->dev,\n+\t\t\t\t\"Received unexpected NOOP command from partner\\n\");\n+\t\treturn;\n+\t}\n+\n \t/* The only kind of payload CRQs we should get are responses to\n \t * things we send. Make sure this response is to something we\n \t * actually sent\n@@ -3540,6 +3542,7 @@ static void ibmvfc_handle_crq(struct ibmvfc_crq *crq, struct ibmvfc_host *vhost,\n \tlist_move_tail(&evt->queue_list, evt_doneq);\n \tspin_unlock(&evt->queue->l_lock);\n }\n+EXPORT_SYMBOL_IF_KUNIT(ibmvfc_handle_crq);\n \n /**\n * ibmvfc_scan_finished - Check if the device scan is done.\ndiff --git a/drivers/scsi/ibmvscsi/ibmvfc.h b/drivers/scsi/ibmvscsi/ibmvfc.h\nindex 29932284a4c9..cd0917f70c6d 100644\n--- a/drivers/scsi/ibmvscsi/ibmvfc.h\n+++ b/drivers/scsi/ibmvscsi/ibmvfc.h\n@@ -180,6 +180,7 @@ struct ibmvfc_npiv_login {\n #define IBMVFC_CAN_HANDLE_FPIN\t\t0x04\n #define IBMVFC_CAN_USE_MAD_VERSION\t0x08\n #define IBMVFC_CAN_SEND_VF_WWPN\t\t0x10\n+#define IBMVFC_CAN_USE_NOOP_CMD\t\t0x200\n \t__be64 node_name;\n \tstruct srp_direct_buf async;\n \tu8 partition_name[IBMVFC_MAX_NAME];\n@@ -226,6 +227,7 @@ struct ibmvfc_npiv_login_resp {\n #define IBMVFC_MAD_VERSION_CAP\t\t0x20\n #define IBMVFC_HANDLE_VF_WWPN\t\t0x40\n #define IBMVFC_CAN_SUPPORT_CHANNELS\t0x80\n+#define IBMVFC_SUPPORT_NOOP_CMD\t\t0x1000\n \t__be32 max_cmds;\n \t__be32 scsi_id_sz;\n \t__be64 max_dma_len;\n@@ -621,6 +623,7 @@ struct ibmvfc_trace_entry {\n enum ibmvfc_crq_formats {\n \tIBMVFC_CMD_FORMAT\t\t= 0x01,\n \tIBMVFC_ASYNC_EVENT\t= 0x02,\n+\tIBMVFC_VFC_NOOP\t\t= 0x03,\n \tIBMVFC_MAD_FORMAT\t\t= 0x04,\n };\n \n@@ -946,6 +949,13 @@ struct ibmvfc_host {\n \t\t\tdev_err((vhost)->dev, ##__VA_ARGS__); \\\n \t} while (0)\n \n+static inline int ibmvfc_check_caps(struct ibmvfc_host *vhost, unsigned long cap_flags)\n+{\n+\tu64 host_caps = be64_to_cpu(vhost->login_buf->resp.capabilities);\n+\n+\treturn (host_caps & cap_flags) ? 1 : 0;\n+}\n+\n #define ENTER DBG_CMD(printk(KERN_INFO IBMVFC_NAME\": Entering %s\\n\", __func__))\n #define LEAVE DBG_CMD(printk(KERN_INFO IBMVFC_NAME\": Leaving %s\\n\", __func__))\n \n@@ -960,6 +970,9 @@ struct ibmvfc_host {\n #ifdef VISIBLE_IF_KUNIT\n VISIBLE_IF_KUNIT void ibmvfc_handle_async(struct ibmvfc_async_crq *crq, struct ibmvfc_host *vhost);\n VISIBLE_IF_KUNIT struct list_head *ibmvfc_get_headp(void);\n+VISIBLE_IF_KUNIT void ibmvfc_handle_crq(struct ibmvfc_crq *crq,\n+\t\t\t\t\tstruct ibmvfc_host *vhost,\n+\t\t\t\t\tstruct list_head *evt_doneq);\n #endif\n \n #endif\ndiff --git a/drivers/scsi/ibmvscsi/ibmvfc_kunit.c b/drivers/scsi/ibmvscsi/ibmvfc_kunit.c\nindex 1c238896049f..3359e4ebebe2 100644\n--- a/drivers/scsi/ibmvscsi/ibmvfc_kunit.c\n+++ b/drivers/scsi/ibmvscsi/ibmvfc_kunit.c\n@@ -79,8 +79,35 @@ static void ibmvfc_handle_fpin_event_test(struct kunit *test)\n \t}\n }\n \n+/**\n+ * ibmvfc_noop_test - unit test for VFC_NOOP command\n+ * @test: pointer to kunit structure\n+ *\n+ * Return: void\n+ */\n+static void ibmvfc_noop_test(struct kunit *test)\n+{\n+\tstruct ibmvfc_host *vhost;\n+\tstruct list_head *queue;\n+\tstruct ibmvfc_crq crq;\n+\tstruct list_head *headp;\n+\tLIST_HEAD(evtq);\n+\n+\theadp = ibmvfc_get_headp();\n+\tqueue = headp->next;\n+\tvhost = container_of(queue, struct ibmvfc_host, queue);\n+\n+\tKUNIT_EXPECT_TRUE(test, ibmvfc_check_caps(vhost, IBMVFC_SUPPORT_NOOP_CMD));\n+\n+\tcrq.valid = 0x80;\n+\tcrq.format = IBMVFC_VFC_NOOP;\n+\tcrq.ioba = cpu_to_be64(NULL);\n+\tibmvfc_handle_crq(&crq, vhost, &evtq);\n+}\n+\n static struct kunit_case ibmvfc_fpin_test_cases[] = {\n \tKUNIT_CASE(ibmvfc_handle_fpin_event_test),\n+\tKUNIT_CASE(ibmvfc_noop_test),\n \t{},\n };\n \n", "prefixes": [ "2/5" ] }