Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/1.1/patches/2220971/?format=api
{ "id": 2220971, "url": "http://patchwork.ozlabs.org/api/1.1/patches/2220971/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20260408141105.2781683-1-aleksandr.loktionov@intel.com/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/1.1/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20260408141105.2781683-1-aleksandr.loktionov@intel.com>", "date": "2026-04-08T14:11:05", "name": "[net,v2] ice: fix ice_init_link() error return preventing probe", "commit_ref": null, "pull_url": null, "state": "under-review", "archived": false, "hash": "15cce682da4da2e4c60adc0f323a04a6686c0497", "submitter": { "id": 75597, "url": "http://patchwork.ozlabs.org/api/1.1/people/75597/?format=api", "name": "Loktionov, Aleksandr", "email": "aleksandr.loktionov@intel.com" }, "delegate": { "id": 109701, "url": "http://patchwork.ozlabs.org/api/1.1/users/109701/?format=api", "username": "anguy11", "first_name": "Anthony", "last_name": "Nguyen", "email": "anthony.l.nguyen@intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20260408141105.2781683-1-aleksandr.loktionov@intel.com/mbox/", "series": [ { "id": 499146, "url": "http://patchwork.ozlabs.org/api/1.1/series/499146/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/list/?series=499146", "date": "2026-04-08T14:11:05", "name": "[net,v2] ice: fix ice_init_link() error return preventing probe", "version": 2, "mbox": "http://patchwork.ozlabs.org/series/499146/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/2220971/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/2220971/checks/", "tags": {}, "headers": { "Return-Path": "<intel-wired-lan-bounces@osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@legolas.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=osuosl.org header.i=@osuosl.org header.a=rsa-sha256\n header.s=default header.b=frV6Us2g;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=osuosl.org\n (client-ip=2605:bc80:3010::138; helo=smtp1.osuosl.org;\n envelope-from=intel-wired-lan-bounces@osuosl.org;\n receiver=patchwork.ozlabs.org)" ], "Received": [ "from smtp1.osuosl.org (smtp1.osuosl.org [IPv6:2605:bc80:3010::138])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4frQ3636G5z1xy1\n\tfor <incoming@patchwork.ozlabs.org>; Thu, 09 Apr 2026 00:11:14 +1000 (AEST)", "from localhost (localhost [127.0.0.1])\n\tby smtp1.osuosl.org (Postfix) with ESMTP id B2FD4822BE;\n\tWed, 8 Apr 2026 14:11:12 +0000 (UTC)", "from smtp1.osuosl.org ([127.0.0.1])\n by localhost (smtp1.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP\n id hGip5eM7jkOQ; Wed, 8 Apr 2026 14:11:11 +0000 (UTC)", "from lists1.osuosl.org (lists1.osuosl.org [140.211.166.142])\n\tby smtp1.osuosl.org (Postfix) with ESMTP id 4F4EF822B7;\n\tWed, 8 Apr 2026 14:11:11 +0000 (UTC)", "from smtp1.osuosl.org (smtp1.osuosl.org [IPv6:2605:bc80:3010::138])\n by lists1.osuosl.org (Postfix) with ESMTP id 01FD12C7\n for <intel-wired-lan@lists.osuosl.org>; Wed, 8 Apr 2026 14:11:10 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n by smtp1.osuosl.org (Postfix) with ESMTP id E76AA822B7\n for <intel-wired-lan@lists.osuosl.org>; Wed, 8 Apr 2026 14:11:09 +0000 (UTC)", "from smtp1.osuosl.org ([127.0.0.1])\n by localhost (smtp1.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP\n id cRRkkgluk9QC for <intel-wired-lan@lists.osuosl.org>;\n Wed, 8 Apr 2026 14:11:09 +0000 (UTC)", "from mgamail.intel.com (mgamail.intel.com [198.175.65.20])\n by smtp1.osuosl.org (Postfix) with ESMTPS id 1C66381E7B\n for <intel-wired-lan@lists.osuosl.org>; Wed, 8 Apr 2026 14:11:08 +0000 (UTC)", "from fmviesa007.fm.intel.com ([10.60.135.147])\n by orvoesa112.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 08 Apr 2026 07:11:08 -0700", "from amlin-019-225.igk.intel.com ([10.102.19.225])\n by fmviesa007.fm.intel.com with ESMTP; 08 Apr 2026 07:11:06 -0700" ], "X-Virus-Scanned": [ "amavis at osuosl.org", "amavis at osuosl.org" ], "X-Comment": "SPF check N/A for local connections - client-ip=140.211.166.142;\n helo=lists1.osuosl.org; envelope-from=intel-wired-lan-bounces@osuosl.org;\n receiver=<UNKNOWN> ", "DKIM-Filter": [ "OpenDKIM Filter v2.11.0 smtp1.osuosl.org 4F4EF822B7", "OpenDKIM Filter v2.11.0 smtp1.osuosl.org 1C66381E7B" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=osuosl.org;\n\ts=default; t=1775657471;\n\tbh=1rdcosm0EFh37UtPjNpFqnswsy0BBWrAYwscU/I6rBk=;\n\th=From:To:Cc:Date:Subject:List-Id:List-Unsubscribe:List-Archive:\n\t List-Post:List-Help:List-Subscribe:From;\n\tb=frV6Us2g4KBMcsfzWpP/Vl8CBYf60E4ZSymbVLPwxH3osRVkReQWNFSAGp5Ovcl9v\n\t uUYjVDpPte0b1+nZRxjRnUwLNu7Vecxm9lynMBrQZm1M/EzzfZ3jPT+TJaFluFGOTg\n\t fO+stXF6DEFFyltE6tYugCdGmtpv0Ox9uOHJRQ3CjrD+3f7sHw+I0kTff56UFhWUWu\n\t lMQKdxOH5m7NPpIEBYdOpl0Na0aPqpspB/Oy7XlWzoVZk1L5yfi4wkpSIS6AYnnlzq\n\t ucv5g58j41jTKRnWNh4nDR4uHruv1Cb2GRVACv0eh6d7Pji/D6rQcpydpzB8Tj66+e\n\t YQOzCOvDD0wdQ==", "Received-SPF": "Pass (mailfrom) identity=mailfrom; client-ip=198.175.65.20;\n helo=mgamail.intel.com; envelope-from=aleksandr.loktionov@intel.com;\n receiver=<UNKNOWN>", "DMARC-Filter": "OpenDMARC Filter v1.4.2 smtp1.osuosl.org 1C66381E7B", "X-CSE-ConnectionGUID": [ "tIYuEmL4RommVQq0YA3iiA==", "l5M3vLNJTda7FdNanzWWgQ==" ], "X-CSE-MsgGUID": [ "o76UWw3LQyGGQ56ccgp7pw==", "xwh4V9ZdTzWBYPFZynAnXA==" ], "X-IronPort-AV": [ "E=McAfee;i=\"6800,10657,11753\"; a=\"76358661\"", "E=Sophos;i=\"6.23,167,1770624000\"; d=\"scan'208\";a=\"76358661\"", "E=Sophos;i=\"6.23,167,1770624000\"; d=\"scan'208\";a=\"225306483\"" ], "X-ExtLoop1": "1", "From": "Aleksandr Loktionov <aleksandr.loktionov@intel.com>", "To": "intel-wired-lan@lists.osuosl.org, anthony.l.nguyen@intel.com,\n aleksandr.loktionov@intel.com", "Cc": "netdev@vger.kernel.org, Paul Greenwalt <paul.greenwalt@intel.com>,\n Simon Horman <horms@kernel.org>", "Date": "Wed, 8 Apr 2026 16:11:05 +0200", "Message-ID": "<20260408141105.2781683-1-aleksandr.loktionov@intel.com>", "X-Mailer": "git-send-email 2.52.0", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-Mailman-Original-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple;\n d=intel.com; i=@intel.com; q=dns/txt; s=Intel;\n t=1775657469; x=1807193469;\n h=from:to:cc:subject:date:message-id:mime-version:\n content-transfer-encoding;\n bh=goncyoFHCJ+qxXrxdTzPIV8gay2dfG8ABKFs2X8eL3E=;\n b=ltLwnFFe8gdETVZBMdnyrUDGveB1yC+6i7YUQzJptR951hP5LvLT0nKc\n 8UITfIk37+xUQ3pzd4+NjC8uLB7uinkRDnngmD4PxyCvnGdJy04T7SRIl\n 5Qj/XieEiM/FLg3qSPb0uqVhnHricvDAuayXv186A2mr9e71u5eZcWDGT\n 8ZU7x+vfX96ZpQQ8getdG8sWLn1gKPP25qG5dtZ9RB4TjriPUwj+J6Ndl\n nc5D3Ff2HmdTPJvLMMYyFZQSsN4TUSFB+lSjGQTocbIqPXbHnmMiQ0dZN\n NNeFQEKZ7K9hhRm68umRq1naTM1CbEvr95cXWiIlSanfg1bHRBIyr7mSD\n w==;", "X-Mailman-Original-Authentication-Results": [ "smtp1.osuosl.org;\n dmarc=pass (p=none dis=none)\n header.from=intel.com", "smtp1.osuosl.org;\n dkim=pass (2048-bit key,\n unprotected) header.d=intel.com header.i=@intel.com header.a=rsa-sha256\n header.s=Intel header.b=ltLwnFFe" ], "Subject": "[Intel-wired-lan] [PATCH net v2] ice: fix ice_init_link() error\n return preventing probe", "X-BeenThere": "intel-wired-lan@osuosl.org", "X-Mailman-Version": "2.1.30", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n <intel-wired-lan.osuosl.org>", "List-Unsubscribe": "<https://lists.osuosl.org/mailman/options/intel-wired-lan>,\n <mailto:intel-wired-lan-request@osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@osuosl.org?subject=help>", "List-Subscribe": "<https://lists.osuosl.org/mailman/listinfo/intel-wired-lan>,\n <mailto:intel-wired-lan-request@osuosl.org?subject=subscribe>", "Errors-To": "intel-wired-lan-bounces@osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@osuosl.org>" }, "content": "From: Paul Greenwalt <paul.greenwalt@intel.com>\n\nice_init_link() can return an error status from ice_update_link_info()\nor ice_init_phy_user_cfg(), causing probe to fail.\n\nAn incorrect NVM update procedure can result in link/PHY errors, and\nthe recommended resolution is to update the NVM using the correct\nprocedure. If the driver fails probe due to link errors, the user\ncannot update the NVM to recover. The link/PHY errors logged are\nnon-fatal: they are already annotated as 'not a fatal error if this\nfails'.\n\nSince none of the errors inside ice_init_link() should prevent probe\nfrom completing, convert it to void and remove the error check in the\ncaller. All failures are already logged; callers have no meaningful\nrecovery path for link init errors.\n\nFixes: 5b246e533d01 (\"ice: split probe into smaller functions\")\nCc: stable@vger.kernel.org\nSigned-off-by: Paul Greenwalt <paul.greenwalt@intel.com>\nSigned-off-by: Aleksandr Loktionov <aleksandr.loktionov@intel.com>\nReviewed-by: Simon Horman <horms@kernel.org>\n---\nv1 -> v2:\n - Rename the now-unused goto label err_init_link to err_deinit_pf_sw\n to better describe the cleanup it performs (Simon Horman).\n\n drivers/net/ethernet/intel/ice/ice_main.c | 16 +++++-----------\n 1 file changed, 5 insertions(+), 11 deletions(-)", "diff": "diff --git a/drivers/net/ethernet/intel/ice/ice_main.c b/drivers/net/ethernet/intel/ice/ice_main.c\nindex cf116bb..a6b0c09 100644\n--- a/drivers/net/ethernet/intel/ice/ice_main.c\n+++ b/drivers/net/ethernet/intel/ice/ice_main.c\n@@ -4856,16 +4856,14 @@ static void ice_init_wakeup(struct ice_pf *pf)\n \tdevice_set_wakeup_enable(ice_pf_to_dev(pf), false);\n }\n \n-static int ice_init_link(struct ice_pf *pf)\n+static void ice_init_link(struct ice_pf *pf)\n {\n \tstruct device *dev = ice_pf_to_dev(pf);\n \tint err;\n \n \terr = ice_init_link_events(pf->hw.port_info);\n-\tif (err) {\n+\tif (err)\n \t\tdev_err(dev, \"ice_init_link_events failed: %d\\n\", err);\n-\t\treturn err;\n-\t}\n \n \t/* not a fatal error if this fails */\n \terr = ice_init_nvm_phy_type(pf->hw.port_info);\n@@ -4899,8 +4897,6 @@ static int ice_init_link(struct ice_pf *pf)\n \t} else {\n \t\tset_bit(ICE_FLAG_NO_MEDIA, pf->flags);\n \t}\n-\n-\treturn err;\n }\n \n static int ice_init_pf_sw(struct ice_pf *pf)\n@@ -5043,11 +5039,9 @@ static int ice_init(struct ice_pf *pf)\n \n \tice_init_wakeup(pf);\n \n-\terr = ice_init_link(pf);\n-\tif (err)\n-\t\tgoto err_init_link;\n+\tice_init_link(pf);\n \n \terr = ice_send_version(pf);\n \tif (err)\n-\t\tgoto err_init_link;\n+\t\tgoto err_deinit_pf_sw;\n \n@@ -5069,7 +5063,7 @@ static int ice_init(struct ice_pf *pf)\n \treturn 0;\n \n-err_init_link:\n+err_deinit_pf_sw:\n \tice_deinit_pf_sw(pf);\n err_init_pf_sw:\n \tice_dealloc_vsis(pf);\n unroll_pf_init:\n", "prefixes": [ "net", "v2" ] }