Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/1.1/patches/2220965/?format=api
{ "id": 2220965, "url": "http://patchwork.ozlabs.org/api/1.1/patches/2220965/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20260408131216.2662245-9-aleksandr.loktionov@intel.com/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/1.1/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20260408131216.2662245-9-aleksandr.loktionov@intel.com>", "date": "2026-04-08T13:12:16", "name": "[iwl-next,v2,8/8] ixgbe: use int instead of u32 for error code variables", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "1098b98d0931c2297ab784fffb3627f86f1ff301", "submitter": { "id": 75597, "url": "http://patchwork.ozlabs.org/api/1.1/people/75597/?format=api", "name": "Loktionov, Aleksandr", "email": "aleksandr.loktionov@intel.com" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20260408131216.2662245-9-aleksandr.loktionov@intel.com/mbox/", "series": [ { "id": 499140, "url": "http://patchwork.ozlabs.org/api/1.1/series/499140/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/list/?series=499140", "date": "2026-04-08T13:12:08", "name": "ixgbe: nits and improvements", "version": 2, "mbox": "http://patchwork.ozlabs.org/series/499140/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/2220965/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/2220965/checks/", "tags": {}, "headers": { "Return-Path": "<intel-wired-lan-bounces@osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@legolas.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=osuosl.org header.i=@osuosl.org header.a=rsa-sha256\n header.s=default header.b=qIHqdslW;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=osuosl.org\n (client-ip=2605:bc80:3010::137; helo=smtp4.osuosl.org;\n envelope-from=intel-wired-lan-bounces@osuosl.org;\n receiver=patchwork.ozlabs.org)" ], "Received": [ "from smtp4.osuosl.org (smtp4.osuosl.org [IPv6:2605:bc80:3010::137])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4frNlV2dywz1xy1\n\tfor <incoming@patchwork.ozlabs.org>; Wed, 08 Apr 2026 23:12:38 +1000 (AEST)", "from localhost (localhost [127.0.0.1])\n\tby smtp4.osuosl.org (Postfix) with ESMTP id 2EBFD40F27;\n\tWed, 8 Apr 2026 13:12:34 +0000 (UTC)", "from smtp4.osuosl.org ([127.0.0.1])\n by localhost (smtp4.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP\n id fSt_X7tDo6kz; Wed, 8 Apr 2026 13:12:33 +0000 (UTC)", "from lists1.osuosl.org (lists1.osuosl.org [140.211.166.142])\n\tby smtp4.osuosl.org (Postfix) with ESMTP id 82D8C40ECA;\n\tWed, 8 Apr 2026 13:12:33 +0000 (UTC)", "from smtp4.osuosl.org (smtp4.osuosl.org [140.211.166.137])\n by lists1.osuosl.org (Postfix) with ESMTP id 30E422C7\n for <intel-wired-lan@lists.osuosl.org>; Wed, 8 Apr 2026 13:12:32 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n by smtp4.osuosl.org (Postfix) with ESMTP id 166E340EE7\n for <intel-wired-lan@lists.osuosl.org>; Wed, 8 Apr 2026 13:12:32 +0000 (UTC)", "from smtp4.osuosl.org ([127.0.0.1])\n by localhost (smtp4.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP\n id b3mRfIFOQvZM for <intel-wired-lan@lists.osuosl.org>;\n Wed, 8 Apr 2026 13:12:31 +0000 (UTC)", "from mgamail.intel.com (mgamail.intel.com [192.198.163.7])\n by smtp4.osuosl.org (Postfix) with ESMTPS id 249A640EC4\n for <intel-wired-lan@lists.osuosl.org>; Wed, 8 Apr 2026 13:12:31 +0000 (UTC)", "from orviesa007.jf.intel.com ([10.64.159.147])\n by fmvoesa101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 08 Apr 2026 06:12:31 -0700", "from amlin-019-225.igk.intel.com ([10.102.19.225])\n by orviesa007.jf.intel.com with ESMTP; 08 Apr 2026 06:12:30 -0700" ], "X-Virus-Scanned": [ "amavis at osuosl.org", "amavis at osuosl.org" ], "X-Comment": "SPF check N/A for local connections - client-ip=140.211.166.142;\n helo=lists1.osuosl.org; envelope-from=intel-wired-lan-bounces@osuosl.org;\n receiver=<UNKNOWN> ", "DKIM-Filter": [ "OpenDKIM Filter v2.11.0 smtp4.osuosl.org 82D8C40ECA", "OpenDKIM Filter v2.11.0 smtp4.osuosl.org 249A640EC4" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=osuosl.org;\n\ts=default; t=1775653953;\n\tbh=wsVt+BWRYoW7FtWOKVeV4987lyqjvhvhSPZG/e0+UX0=;\n\th=From:To:Cc:Date:In-Reply-To:References:Subject:List-Id:\n\t List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe:\n\t From;\n\tb=qIHqdslW0JwliZ9gJJiAQ4DY4Zm7+c52AdqcV2W/TqR8QV8MIgON6B4OxmnTisw/o\n\t 2yMJJSJIUeGvraB2bQxyrDa+xQ2sZQwNss7PP3cHNN9hVBKdnoFrn/AiYel3CyEbGh\n\t LwNLS6eo1JoR9PfWjkGcT2mEibL8ldjcOuu5+iU3Hz109L7lNHw8QXLXHg2ztknbjn\n\t fk9N2dKbTzcr2qEZo2MnLZiG93zSmS7WXtN4d8a4ZY5QnL6BagVfXtsVXuh48W82eK\n\t IVWNkrxks7Dke0wppSJGQtzJyRsJTkjGGwmxc/ogGwlq/h4HcRBO1ak956PiujXJIz\n\t VCTWpN8MuTmVg==", "Received-SPF": "Pass (mailfrom) identity=mailfrom; client-ip=192.198.163.7;\n helo=mgamail.intel.com; envelope-from=aleksandr.loktionov@intel.com;\n receiver=<UNKNOWN>", "DMARC-Filter": "OpenDMARC Filter v1.4.2 smtp4.osuosl.org 249A640EC4", "X-CSE-ConnectionGUID": [ "UArAXaSfQnez4BPkddPPLw==", "KnQNf1VbReiLKVuzPvE/tg==" ], "X-CSE-MsgGUID": [ "SKN/gmEpQZidqS10nJEW/g==", "PnM6zYYXS8K5ZkkPwLKTsQ==" ], "X-IronPort-AV": [ "E=McAfee;i=\"6800,10657,11752\"; a=\"102087299\"", "E=Sophos;i=\"6.23,167,1770624000\"; d=\"scan'208\";a=\"102087299\"", "E=Sophos;i=\"6.23,167,1770624000\"; d=\"scan'208\";a=\"228715125\"" ], "X-ExtLoop1": "1", "From": "Aleksandr Loktionov <aleksandr.loktionov@intel.com>", "To": "intel-wired-lan@lists.osuosl.org, anthony.l.nguyen@intel.com,\n aleksandr.loktionov@intel.com", "Cc": "netdev@vger.kernel.org,\n\tSimon Horman <horms@kernel.org>", "Date": "Wed, 8 Apr 2026 15:12:16 +0200", "Message-ID": "<20260408131216.2662245-9-aleksandr.loktionov@intel.com>", "X-Mailer": "git-send-email 2.52.0", "In-Reply-To": "<20260408131216.2662245-1-aleksandr.loktionov@intel.com>", "References": "<20260408131216.2662245-1-aleksandr.loktionov@intel.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-Mailman-Original-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple;\n d=intel.com; i=@intel.com; q=dns/txt; s=Intel;\n t=1775653951; x=1807189951;\n h=from:to:cc:subject:date:message-id:in-reply-to:\n references:mime-version:content-transfer-encoding;\n bh=qSs/6cxPK78CVLwR3TsPdb+AwFgYd6qJdHXW2+qXedc=;\n b=BGgdxmu5tNzI148KpFgBAUIph2JCVcMj5r8orjgU1sOXcfdYGjGaoEjz\n cSakOlGnogRpjABF4abpV8rmkoqoNxiagIgtO0xoC64eJmh2+/82FGq5z\n b0KQMiZOsO7goL2BtwyD3fbJYTJyfJlC3pBNcGrQYXsZbVVUdiumAyiZN\n 9rA8395f70f2idr6dNjqF4AGZ4xBQy0KdHtPexzqyOtVUtpXVCqBTshX3\n cVsvA8T4d7aEObBzng5pAhoCXL+afh4ETgwM4fy4tUt/OzoWrzbjzgRi0\n Wfc9xQlfZjCm/mNOc7UH+jj8bI4/wRkXwe0t/FPHY/LF9W/gnAWzTUMnW\n A==;", "X-Mailman-Original-Authentication-Results": [ "smtp4.osuosl.org;\n dmarc=pass (p=none dis=none)\n header.from=intel.com", "smtp4.osuosl.org;\n dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com\n header.a=rsa-sha256 header.s=Intel header.b=BGgdxmu5" ], "Subject": "[Intel-wired-lan] [PATCH iwl-next v2 8/8] ixgbe: use int instead of\n u32 for error code variables", "X-BeenThere": "intel-wired-lan@osuosl.org", "X-Mailman-Version": "2.1.30", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n <intel-wired-lan.osuosl.org>", "List-Unsubscribe": "<https://lists.osuosl.org/mailman/options/intel-wired-lan>,\n <mailto:intel-wired-lan-request@osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@osuosl.org?subject=help>", "List-Subscribe": "<https://lists.osuosl.org/mailman/listinfo/intel-wired-lan>,\n <mailto:intel-wired-lan-request@osuosl.org?subject=subscribe>", "Errors-To": "intel-wired-lan-bounces@osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@osuosl.org>" }, "content": "The variables used to store return values of kernel and driver functions\nthroughout the ixgbe driver are declared as u32 in several places. Such\nfunctions return negative errno values on error (e.g. -EIO, -EFAULT),\nwhich are sign-extended negative integers. Storing them in an unsigned\nu32 silently wraps the value: -EIO (0xFFFFFFF7) stored in u32 becomes a\nlarge positive number, so any \"if (status)\" truthiness check still works\nby accident, but comparisons against specific negative error codes or\npropagation up the call stack produce wrong results.\n\nIn the Linux kernel, u32 is reserved for fixed-width quantities used in\nhardware interfaces or protocol structures. Using it for generic error\ncodes misleads reviewers into thinking the value is hardware-constrained.\n\nChange all such local variables from u32 to int driver-wide: one in\nixgbe_main.c (ixgbe_resume), three in ixgbe_phy.c\n(ixgbe_identify_phy_generic, ixgbe_tn_check_overtemp,\nixgbe_set_copper_phy_power), and six in ixgbe_x550.c\n(ixgbe_check_link_t_X550em, ixgbe_get_lasi_ext_t_x550em,\nixgbe_enable_lasi_ext_t_x550em, ixgbe_handle_lasi_ext_t_x550em,\nixgbe_ext_phy_t_x550em_get_link, ixgbe_setup_internal_phy_t_x550em).\n\nNo functional change.\n\nReviewed-by: Simon Horman <horms@kernel.org>\nSigned-off-by: Aleksandr Loktionov <aleksandr.loktionov@intel.com>\n---\nv1 -> v2:\n - Carry Reviewed-by: Simon Horman from the IWL posting; add [N/M]\n numbering; no code change.\n\n drivers/net/ethernet/intel/ixgbe/ixgbe_main.c | 2 +-\n drivers/net/ethernet/intel/ixgbe/ixgbe_phy.c | 6 +++---\n drivers/net/ethernet/intel/ixgbe/ixgbe_x550.c | 12 ++++++------\n 3 files changed, 10 insertions(+), 10 deletions(-)", "diff": "diff --git a/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c b/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c\nindex ed5b75b..99cfccd 100644\n--- a/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c\n+++ b/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c\n@@ -7531,7 +7531,7 @@ static int ixgbe_resume(struct device *dev_d)\n \tstruct pci_dev *pdev = to_pci_dev(dev_d);\n \tstruct ixgbe_adapter *adapter = pci_get_drvdata(pdev);\n \tstruct net_device *netdev = adapter->netdev;\n-\tu32 err;\n+\tint err;\n \n \tadapter->hw.hw_addr = adapter->io_addr;\n \ndiff --git a/drivers/net/ethernet/intel/ixgbe/ixgbe_phy.c b/drivers/net/ethernet/intel/ixgbe/ixgbe_phy.c\nindex ab733e7..de8f6c6 100644\n--- a/drivers/net/ethernet/intel/ixgbe/ixgbe_phy.c\n+++ b/drivers/net/ethernet/intel/ixgbe/ixgbe_phy.c\n@@ -262,7 +262,7 @@ static bool ixgbe_probe_phy(struct ixgbe_hw *hw, u16 phy_addr)\n **/\n int ixgbe_identify_phy_generic(struct ixgbe_hw *hw)\n {\n-\tu32 status = -EFAULT;\n+\tint status = -EFAULT;\n \tu32 phy_addr;\n \n \tif (!hw->phy.phy_semaphore_mask) {\n@@ -2811,7 +2811,7 @@ static void ixgbe_i2c_bus_clear(struct ixgbe_hw *hw)\n bool ixgbe_tn_check_overtemp(struct ixgbe_hw *hw)\n {\n \tu16 phy_data = 0;\n-\tu32 status;\n+\tint status;\n \n \tif (hw->device_id != IXGBE_DEV_ID_82599_T3_LOM)\n \t\treturn false;\n@@ -2831,7 +2831,7 @@ bool ixgbe_tn_check_overtemp(struct ixgbe_hw *hw)\n **/\n int ixgbe_set_copper_phy_power(struct ixgbe_hw *hw, bool on)\n {\n-\tu32 status;\n+\tint status;\n \tu16 reg;\n \n \t/* Bail if we don't have copper phy */\ndiff --git a/drivers/net/ethernet/intel/ixgbe/ixgbe_x550.c b/drivers/net/ethernet/intel/ixgbe/ixgbe_x550.c\nindex 76d2fa3..9b14f3b 100644\n--- a/drivers/net/ethernet/intel/ixgbe/ixgbe_x550.c\n+++ b/drivers/net/ethernet/intel/ixgbe/ixgbe_x550.c\n@@ -1911,7 +1911,7 @@ static int ixgbe_check_link_t_X550em(struct ixgbe_hw *hw,\n \t\t\t\t bool *link_up,\n \t\t\t\t bool link_up_wait_to_complete)\n {\n-\tu32 status;\n+\tint status;\n \tu16 i, autoneg_status;\n \n \tif (hw->mac.ops.get_media_type(hw) != ixgbe_media_type_copper)\n@@ -2330,7 +2330,7 @@ static int ixgbe_get_link_capabilities_X550em(struct ixgbe_hw *hw,\n static int ixgbe_get_lasi_ext_t_x550em(struct ixgbe_hw *hw, bool *lsc,\n \t\t\t\t bool *is_overtemp)\n {\n-\tu32 status;\n+\tint status;\n \tu16 reg;\n \n \t*is_overtemp = false;\n@@ -2418,7 +2418,7 @@ static int ixgbe_get_lasi_ext_t_x550em(struct ixgbe_hw *hw, bool *lsc,\n static int ixgbe_enable_lasi_ext_t_x550em(struct ixgbe_hw *hw)\n {\n \tbool lsc, overtemp;\n-\tu32 status;\n+\tint status;\n \tu16 reg;\n \n \t/* Clear interrupt flags */\n@@ -2512,7 +2512,7 @@ static int ixgbe_handle_lasi_ext_t_x550em(struct ixgbe_hw *hw,\n {\n \tstruct ixgbe_phy_info *phy = &hw->phy;\n \tbool lsc;\n-\tu32 status;\n+\tint status;\n \n \tstatus = ixgbe_get_lasi_ext_t_x550em(hw, &lsc, is_overtemp);\n \tif (status)\n@@ -2606,7 +2606,7 @@ static int ixgbe_setup_kr_x550em(struct ixgbe_hw *hw)\n **/\n static int ixgbe_ext_phy_t_x550em_get_link(struct ixgbe_hw *hw, bool *link_up)\n {\n-\tu32 ret;\n+\tint ret;\n \tu16 autoneg_status;\n \n \t*link_up = false;\n@@ -2642,7 +2642,7 @@ static int ixgbe_setup_internal_phy_t_x550em(struct ixgbe_hw *hw)\n {\n \tixgbe_link_speed force_speed;\n \tbool link_up;\n-\tu32 status;\n+\tint status;\n \tu16 speed;\n \n \tif (hw->mac.ops.get_media_type(hw) != ixgbe_media_type_copper)\n", "prefixes": [ "iwl-next", "v2", "8/8" ] }