Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/1.1/patches/2220787/?format=api
{ "id": 2220787, "url": "http://patchwork.ozlabs.org/api/1.1/patches/2220787/?format=api", "web_url": "http://patchwork.ozlabs.org/project/kvm-riscv/patch/20260407-riscv_insn_table-v1-7-54b4736a1e77@gmail.com/", "project": { "id": 70, "url": "http://patchwork.ozlabs.org/api/1.1/projects/70/?format=api", "name": "Linux KVM RISC-V", "link_name": "kvm-riscv", "list_id": "kvm-riscv.lists.infradead.org", "list_email": "kvm-riscv@lists.infradead.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20260407-riscv_insn_table-v1-7-54b4736a1e77@gmail.com>", "date": "2026-04-08T04:45:55", "name": "[07/16] riscv: kvm: Use generated instruction headers for csr code", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "cd0b18cf6ec2455db8c0a62c3cec8255b2faf4e9", "submitter": { "id": 92521, "url": "http://patchwork.ozlabs.org/api/1.1/people/92521/?format=api", "name": "Charlie Jenkins via B4 Relay", "email": "devnull+thecharlesjenkins.gmail.com@kernel.org" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/kvm-riscv/patch/20260407-riscv_insn_table-v1-7-54b4736a1e77@gmail.com/mbox/", "series": [ { "id": 499063, "url": "http://patchwork.ozlabs.org/api/1.1/series/499063/?format=api", "web_url": "http://patchwork.ozlabs.org/project/kvm-riscv/list/?series=499063", "date": "2026-04-08T04:45:48", "name": "riscv: Generate riscv instruction functions", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/499063/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/2220787/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/2220787/checks/", "tags": {}, "headers": { "Return-Path": "\n <kvm-riscv-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@legolas.ozlabs.org", "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n secure) header.d=lists.infradead.org header.i=@lists.infradead.org\n header.a=rsa-sha256 header.s=bombadil.20210309 header.b=Vrvlljav;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256\n header.s=k20201202 header.b=ATfScWCf;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=none (no SPF record) smtp.mailfrom=lists.infradead.org\n (client-ip=2607:7c80:54:3::133; helo=bombadil.infradead.org;\n envelope-from=kvm-riscv-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org;\n receiver=patchwork.ozlabs.org)" ], "Received": [ "from bombadil.infradead.org (bombadil.infradead.org\n [IPv6:2607:7c80:54:3::133])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fr9Wq56Dsz1yD6\n\tfor <incoming@patchwork.ozlabs.org>; Wed, 08 Apr 2026 14:46:45 +1000 (AEST)", "from localhost ([::1] helo=bombadil.infradead.org)\n\tby bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux))\n\tid 1wAKoN-00000008EiK-3Ka3;\n\tWed, 08 Apr 2026 04:46:43 +0000", "from sea.source.kernel.org ([2600:3c0a:e001:78e:0:1991:8:25])\n\tby bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux))\n\tid 1wAKoJ-00000008EbP-1Z7z;\n\tWed, 08 Apr 2026 04:46:40 +0000", "from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58])\n\tby sea.source.kernel.org (Postfix) with ESMTP id 126D24456D;\n\tWed, 8 Apr 2026 04:46:37 +0000 (UTC)", "by smtp.kernel.org (Postfix) with ESMTPS id E1DD7C19425;\n\tWed, 8 Apr 2026 04:46:36 +0000 (UTC)", "from aws-us-west-2-korg-lkml-1.web.codeaurora.org\n (localhost.localdomain [127.0.0.1])\n\tby smtp.lore.kernel.org (Postfix) with ESMTP id DA34FFD5F76;\n\tWed, 8 Apr 2026 04:46:36 +0000 (UTC)" ], "DKIM-Signature": [ "v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;\n\td=lists.infradead.org; s=bombadil.20210309; h=Sender:\n\tContent-Transfer-Encoding:Content-Type:Reply-To:List-Subscribe:List-Help:\n\tList-Post:List-Archive:List-Unsubscribe:List-Id:Cc:To:In-Reply-To:References:\n\tMessage-Id:MIME-Version:Subject:Date:From:Content-ID:Content-Description:\n\tResent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:\n\tList-Owner; bh=Q+2Em6ugpozwzzBnOynMXNtzmQnpMfCzRLTso2SDTOs=; b=VrvlljavXK07D/\n\tD2MkSggiUk2jc10+FLeYPZdUN7fVfldA0g+iu0O5rgNRZtv5UD1gjoZoZW3V6cblSaE93wSsgUrIs\n\toyyYY2vQHyp4xiKZQSs+GFfFYiepoULjLAw0CNL/GshW4YZ/Hp+B5I7NwThCqoJx5Q2iFdCkJFIDU\n\tP3QXklc8PHYVS5smvDiotIPTNYOIxlqqV8pRsnMsiR6zSUUsThKkPdTqEmOtlwIS7eQSgUKjVLXPG\n\tpb2zlRrPYL7R2mTPNjK5eCowcvNQATKepToZcnxCNT/UxPLVsMSGebbhzubto1c+aiqKdnSq4ypAk\n\t2AGtaruW0fHRqByEWbNA==;", "v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;\n\ts=k20201202; t=1775623597;\n\tbh=oUL9asvy+zE2dNrRAwplrqDe/MHJwCo7NgVB5/FNQwQ=;\n\th=From:Date:Subject:References:In-Reply-To:To:Cc:Reply-To:From;\n\tb=ATfScWCfZefHXUaxmesU7O0ved1t35WQwwofWUoyc0MizRGKps5XpEf+GPv9ZpmgE\n\t FrRJYtkiALxTnZB29AjMrsseEcXnpIBBuD+3agEsL5KZfzkBpy1WhAPLUIPWslaa/V\n\t h6mVcsuaCTpwaQmRnS5dde8xMtC0z9PgIjpfT86sziXq+EhzWons1zb/B50MNPGSOT\n\t ZHaJoerqzzeyOHlACK+vi5/CULTx0Eui/Ldv85C9snoiBwRnHm/KnLNkP6qCKZI1QI\n\t bZCLCxI/aEr5nCmOyLwlS31/stpmafiwTEMaThYG0MNsXBmkIaGEt/VT2LqYxTI310\n\t acY3cIpTD3zSA==" ], "From": "Charlie Jenkins via B4 Relay\n <devnull+thecharlesjenkins.gmail.com@kernel.org>", "Date": "Tue, 07 Apr 2026 21:45:55 -0700", "Subject": "[PATCH 07/16] riscv: kvm: Use generated instruction headers for\n csr code", "MIME-Version": "1.0", "Message-Id": "<20260407-riscv_insn_table-v1-7-54b4736a1e77@gmail.com>", "References": "<20260407-riscv_insn_table-v1-0-54b4736a1e77@gmail.com>", "In-Reply-To": "<20260407-riscv_insn_table-v1-0-54b4736a1e77@gmail.com>", "To": "Paul Walmsley <pjw@kernel.org>, Palmer Dabbelt <palmer@dabbelt.com>,\n Alexandre Ghiti <alex@ghiti.fr>, Anup Patel <anup@brainfault.org>,\n Atish Patra <atish.patra@linux.dev>, Conor Dooley <conor@kernel.org>,\n Paolo Bonzini <pbonzini@redhat.com>,\n Andrew Morton <akpm@linux-foundation.org>, Shuah Khan <shuah@kernel.org>", "Cc": "linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org,\n kvm@vger.kernel.org, kvm-riscv@lists.infradead.org,\n linux-kselftest@vger.kernel.org,\n Charlie Jenkins <thecharlesjenkins@gmail.com>", "X-Mailer": "b4 0.14.3", "X-Developer-Signature": "v=1; a=ed25519-sha256; t=1775623594; l=2903;\n i=thecharlesjenkins@gmail.com; s=2026030; h=from:subject:message-id;\n bh=zjTRDc41ANyFedf3cbSbk5JAhE4813R8ZlVWeNgHH4k=;\n b=cFumLVLBW7/FLTqc8/qslS5/l43/knn4JqcHGnwby/U3awqE5WHPDYMVQa4US319I3Fc8+sSE\n zm0gqE8af27AxhLcN+beDIDk2Pe48rb+bCg8mJDVSRseygG8Qjv0eCI", "X-Developer-Key": "i=thecharlesjenkins@gmail.com; a=ed25519;\n pk=vpF2USrG+aB6CTbSt34rzJKsAVe/l+GAXo1IomCMETk=", "X-Endpoint-Received": "by B4 Relay for thecharlesjenkins@gmail.com/2026030\n with auth_id=663", "X-Original-From": "Charlie Jenkins <thecharlesjenkins@gmail.com>", "X-CRM114-Version": "20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 ", "X-CRM114-CacheID": "sfid-20260407_214639_492975_87F46478 ", "X-CRM114-Status": "GOOD ( 11.90 )", "X-Spam-Score": "-0.0 (/)", "X-Spam-Report": "Spam detection software,\n running on the system \"bombadil.infradead.org\",\n has NOT identified this incoming email as spam. The original\n message has been attached to this so you can view it or label\n similar future email. If you have any questions, see\n the administrator of that system for details.\n Content preview: From: Charlie Jenkins Migrate the csr parsing code to use\n the generated instruction headers instead of the hand-written instruction\n composition functions. Signed-off-by: Charlie Jenkins\n Content analysis details: (-0.0 points, 5.0 required)\n pts rule name description\n ---- ----------------------\n --------------------------------------------------\n -0.0 SPF_PASS SPF: sender matches SPF record\n 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record\n -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from\n envelope-from domain\n 0.1 DKIM_SIGNED Message has a DKIM or DK signature,\n not necessarily valid\n -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from\n author's\n domain\n -0.1 DKIM_VALID Message has at least one valid DKIM or DK\n signature\n -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1%\n [score: 0.0000]\n 2.1 FREEMAIL_FORGED_REPLYTO Freemail in Reply-To, but not From", "X-BeenThere": "kvm-riscv@lists.infradead.org", "X-Mailman-Version": "2.1.34", "Precedence": "list", "List-Id": "<kvm-riscv.lists.infradead.org>", "List-Unsubscribe": "<http://lists.infradead.org/mailman/options/kvm-riscv>,\n <mailto:kvm-riscv-request@lists.infradead.org?subject=unsubscribe>", "List-Archive": "<http://lists.infradead.org/pipermail/kvm-riscv/>", "List-Post": "<mailto:kvm-riscv@lists.infradead.org>", "List-Help": "<mailto:kvm-riscv-request@lists.infradead.org?subject=help>", "List-Subscribe": "<http://lists.infradead.org/mailman/listinfo/kvm-riscv>,\n <mailto:kvm-riscv-request@lists.infradead.org?subject=subscribe>", "Reply-To": "thecharlesjenkins@gmail.com", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Sender": "\"kvm-riscv\" <kvm-riscv-bounces@lists.infradead.org>", "Errors-To": "kvm-riscv-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org" }, "content": "From: Charlie Jenkins <thecharlesjenkins@gmail.com>\n\nMigrate the csr parsing code to use the generated instruction headers\ninstead of the hand-written instruction composition functions.\n\nSigned-off-by: Charlie Jenkins <thecharlesjenkins@gmail.com>\n\n---\n\nThis is a simple transformation that I have again validated through\nbrute force.\n---\n arch/riscv/kvm/vcpu_insn.c | 47 +++++++++++++++++++++++-----------------------\n 1 file changed, 24 insertions(+), 23 deletions(-)", "diff": "diff --git a/arch/riscv/kvm/vcpu_insn.c b/arch/riscv/kvm/vcpu_insn.c\nindex 4d89b94128ae..62c4510a40af 100644\n--- a/arch/riscv/kvm/vcpu_insn.c\n+++ b/arch/riscv/kvm/vcpu_insn.c\n@@ -146,43 +146,44 @@ int kvm_riscv_vcpu_csr_return(struct kvm_vcpu *vcpu, struct kvm_run *run)\n \n static int csr_insn(struct kvm_vcpu *vcpu, struct kvm_run *run, ulong insn)\n {\n+\t#define GET_REG(_rd) (*((unsigned long *)(&vcpu->arch.guest_context) + _rd))\n+\n \tint i, rc = KVM_INSN_ILLEGAL_TRAP;\n-\tunsigned int csr_num = insn >> SH_RS2;\n-\tunsigned int rs1_num = (insn >> SH_RS1) & MASK_RX;\n-\tulong rs1_val = GET_RS1(insn, &vcpu->arch.guest_context);\n+\tunsigned int csr_num;\n \tconst struct csr_func *tcfn, *cfn = NULL;\n \tulong val = 0, wr_mask = 0, new_val = 0;\n \n \t/* Decode the CSR instruction */\n-\tswitch (GET_FUNCT3(insn)) {\n-\tcase GET_FUNCT3(INSN_MATCH_CSRRW):\n+\tif (riscv_insn_is_csrrw(insn)) {\n \t\twr_mask = -1UL;\n-\t\tnew_val = rs1_val;\n-\t\tbreak;\n-\tcase GET_FUNCT3(INSN_MATCH_CSRRS):\n-\t\twr_mask = rs1_val;\n+\t\tnew_val = GET_REG(riscv_insn_csrrw_extract_xs1(insn));\n+\t\tcsr_num = riscv_insn_csrrw_extract_csr(insn);\n+\t} else if (riscv_insn_is_csrrs(insn)) {\n+\t\twr_mask = GET_REG(riscv_insn_csrrs_extract_xs1(insn));\n \t\tnew_val = -1UL;\n-\t\tbreak;\n-\tcase GET_FUNCT3(INSN_MATCH_CSRRC):\n-\t\twr_mask = rs1_val;\n+\t\tcsr_num = riscv_insn_csrrs_extract_csr(insn);\n+\t} else if (riscv_insn_is_csrrc(insn)) {\n+\t\twr_mask = GET_REG(riscv_insn_csrrs_extract_xs1(insn));\n \t\tnew_val = 0;\n-\t\tbreak;\n-\tcase GET_FUNCT3(INSN_MATCH_CSRRWI):\n+\t\tcsr_num = riscv_insn_csrrc_extract_csr(insn);\n+\t} else if (riscv_insn_is_csrrwi(insn)) {\n \t\twr_mask = -1UL;\n-\t\tnew_val = rs1_num;\n-\t\tbreak;\n-\tcase GET_FUNCT3(INSN_MATCH_CSRRSI):\n-\t\twr_mask = rs1_num;\n+\t\tnew_val = riscv_insn_csrrwi_extract_imm(insn);\n+\t\tcsr_num = riscv_insn_csrrwi_extract_csr(insn);\n+\t} else if (riscv_insn_is_csrrsi(insn)) {\n+\t\twr_mask = riscv_insn_csrrwi_extract_imm(insn);\n \t\tnew_val = -1UL;\n-\t\tbreak;\n-\tcase GET_FUNCT3(INSN_MATCH_CSRRCI):\n-\t\twr_mask = rs1_num;\n+\t\tcsr_num = riscv_insn_csrrsi_extract_csr(insn);\n+\t} else if (riscv_insn_is_csrrci(insn)) {\n+\t\twr_mask = GET_REG(riscv_insn_csrrwi_extract_imm(insn));\n \t\tnew_val = 0;\n-\t\tbreak;\n-\tdefault:\n+\t\tcsr_num = riscv_insn_csrrwi_extract_csr(insn);\n+\t} else {\n \t\treturn rc;\n \t}\n \n+\t#undef GET_REG\n+\n \t/* Save instruction decode info */\n \tvcpu->arch.csr_decode.insn = insn;\n \tvcpu->arch.csr_decode.return_handled = 0;\n", "prefixes": [ "07/16" ] }