Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/1.1/patches/2220646/?format=api
{ "id": 2220646, "url": "http://patchwork.ozlabs.org/api/1.1/patches/2220646/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20260407050818.2249570-5-lulu@redhat.com/", "project": { "id": 14, "url": "http://patchwork.ozlabs.org/api/1.1/projects/14/?format=api", "name": "QEMU Development", "link_name": "qemu-devel", "list_id": "qemu-devel.nongnu.org", "list_email": "qemu-devel@nongnu.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20260407050818.2249570-5-lulu@redhat.com>", "date": "2026-04-07T05:05:51", "name": "[RFC,v4,4/5] chardev/socket: add AF_PACKET inject path", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "33448a1291916682106cee068a1f318b7b26f6e5", "submitter": { "id": 78960, "url": "http://patchwork.ozlabs.org/api/1.1/people/78960/?format=api", "name": "Cindy Lu", "email": "lulu@redhat.com" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20260407050818.2249570-5-lulu@redhat.com/mbox/", "series": [ { "id": 499026, "url": "http://patchwork.ozlabs.org/api/1.1/series/499026/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/list/?series=499026", "date": "2026-04-07T05:05:51", "name": "net/filter: Add AF_PACKET support for vhost-net", "version": 4, "mbox": "http://patchwork.ozlabs.org/series/499026/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/2220646/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/2220646/checks/", "tags": {}, "headers": { "Return-Path": "<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@legolas.ozlabs.org", "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256\n header.s=mimecast20190719 header.b=i2lgC7Ur;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)" ], "Received": [ "from lists.gnu.org (lists.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fqwr964Qzz1yGp\n\tfor <incoming@patchwork.ozlabs.org>; Wed, 08 Apr 2026 05:15:05 +1000 (AEST)", "from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from <qemu-devel-bounces@nongnu.org>)\n\tid 1wABXY-0000Gh-Vo; Tue, 07 Apr 2026 14:52:45 -0400", "from eggs.gnu.org ([2001:470:142:3::10])\n by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <lulu@redhat.com>) id 1wABUI-0003Gt-3J\n for qemu-devel@nongnu.org; Tue, 07 Apr 2026 14:49:22 -0400", "from us-smtp-delivery-124.mimecast.com ([170.10.133.124])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <lulu@redhat.com>) id 1w9ygX-0003OZ-UQ\n for qemu-devel@nongnu.org; Tue, 07 Apr 2026 01:09:11 -0400", "from mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com\n (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by\n relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3,\n cipher=TLS_AES_256_GCM_SHA384) id us-mta-128-flpCFxObOweQEstrpIocrA-1; Tue,\n 07 Apr 2026 01:09:04 -0400", "from mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com\n (mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.12])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest\n SHA256)\n (No client certificate requested)\n by mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS\n id C374F1956046; Tue, 7 Apr 2026 05:09:03 +0000 (UTC)", "from S2.redhat.com (unknown [10.72.112.55])\n by mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP\n id 595E519560A6; Tue, 7 Apr 2026 05:09:00 +0000 (UTC)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n s=mimecast20190719; t=1775538548;\n h=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n to:to:cc:mime-version:mime-version:\n content-transfer-encoding:content-transfer-encoding:\n in-reply-to:in-reply-to:references:references;\n bh=Gg4529iHncAEaCTY/PX+ysrl8jbN0pCBm9+RUtBBRwc=;\n b=i2lgC7UrQgtThApwCXXp6wzUDGPYGkhPc6nkMmPduzhc0/20JvEyEOxzLhn9Wu4yXGIElG\n PPflyC4WyeXx9M89rDo06ao7bDKZ37nWR0X0w/H0/uCcYqh81ZSv0UPezihkc3Mi9PxDwi\n mqT6wZneLkfPHsu2X2URRaM7X9T5hH4=", "X-MC-Unique": "flpCFxObOweQEstrpIocrA-1", "X-Mimecast-MFC-AGG-ID": "flpCFxObOweQEstrpIocrA_1775538543", "From": "Cindy Lu <lulu@redhat.com>", "To": "lulu@redhat.com, mst@redhat.com, jasowang@redhat.com, zhangckid@gmail.com,\n lizhijian@fujitsu.com, jmarcin@redhat.com, qemu-devel@nongnu.org", "Subject": "[RFC v4 4/5] chardev/socket: add AF_PACKET inject path", "Date": "Tue, 7 Apr 2026 13:05:51 +0800", "Message-ID": "<20260407050818.2249570-5-lulu@redhat.com>", "In-Reply-To": "<20260407050818.2249570-1-lulu@redhat.com>", "References": "<20260407050818.2249570-1-lulu@redhat.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-Scanned-By": "MIMEDefang 3.0 on 10.30.177.12", "Received-SPF": "pass client-ip=170.10.133.124; envelope-from=lulu@redhat.com;\n helo=us-smtp-delivery-124.mimecast.com", "X-Spam_score_int": "-25", "X-Spam_score": "-2.6", "X-Spam_bar": "--", "X-Spam_report": "(-2.6 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.54,\n DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=0.001,\n RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001,\n SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no", "X-Spam_action": "no action", "X-BeenThere": "qemu-devel@nongnu.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "qemu development <qemu-devel.nongnu.org>", "List-Unsubscribe": "<https://lists.nongnu.org/mailman/options/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>", "List-Archive": "<https://lists.nongnu.org/archive/html/qemu-devel>", "List-Post": "<mailto:qemu-devel@nongnu.org>", "List-Help": "<mailto:qemu-devel-request@nongnu.org?subject=help>", "List-Subscribe": "<https://lists.nongnu.org/mailman/listinfo/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=subscribe>", "Errors-To": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org", "Sender": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org" }, "content": "Add the AF_PACKET inject write path for socket chardevs. When a socket\nbackend is opened with af-packet-mode=inject, tcp_chr_write() no longer\nsends the redirector stream framing through QIOChannel. Instead it\nparses the existing 4-byte length header, accumulates one complete\npacket, and frame on the AF_PACKET fd.\n\nSigned-off-by: Cindy Lu <lulu@redhat.com>\n---\n chardev/char-socket.c | 148 ++++++++++++++++++++++++++++++++++++++++++\n 1 file changed, 148 insertions(+)", "diff": "diff --git a/chardev/char-socket.c b/chardev/char-socket.c\nindex c710fdb497..45d06fda8f 100644\n--- a/chardev/char-socket.c\n+++ b/chardev/char-socket.c\n@@ -108,11 +108,159 @@ static void tcp_chr_accept(QIONetListener *listener,\n static int tcp_chr_read_poll(void *opaque);\n static void tcp_chr_disconnect_locked(Chardev *chr);\n \n+#define TCP_CHARDEV_AF_PACKET_MAX_FRAME_SIZE 65536\n+\n+static bool tcp_chr_uses_af_packet_inject(SocketChardev *s)\n+{\n+ return s->is_af_packet &&\n+ s->af_packet_mode_set &&\n+ s->af_packet_mode == CHARDEV_SOCKET_AF_PACKET_MODE_INJECT;\n+}\n+\n+static ssize_t tcp_chr_send_af_packet(SocketChardev *s,\n+ const uint8_t *buf,\n+ size_t len)\n+{\n+#ifdef CONFIG_LINUX\n+ struct iovec iov = {\n+ .iov_base = (void *)buf,\n+ .iov_len = len,\n+ };\n+ struct msghdr msg = {\n+ .msg_iov = &iov,\n+ .msg_iovlen = 1,\n+ };\n+ ssize_t ret;\n+\n+ if (!s->sioc || s->sioc->localAddr.ss_family != AF_PACKET) {\n+ errno = ENOTSOCK;\n+ return -1;\n+ }\n+\n+ do {\n+ ret = sendmsg(s->sioc->fd, &msg, 0);\n+ } while (ret < 0 && errno == EINTR);\n+\n+ return ret;\n+#else\n+ errno = EPROTONOSUPPORT;\n+ return -1;\n+#endif\n+}\n+\n+static bool tcp_chr_af_packet_prepare_send(SocketChardev *s, uint32_t frame_len)\n+{\n+ if (frame_len > TCP_CHARDEV_AF_PACKET_MAX_FRAME_SIZE) {\n+ errno = EMSGSIZE;\n+ return false;\n+ }\n+\n+ if (frame_len == 0) {\n+ s->af_packet_send_len = 0;\n+ s->af_packet_send_offset = 0;\n+ s->af_packet_send_len_bytes = 0;\n+ return true;\n+ }\n+\n+ if (s->af_packet_send_buf_size < frame_len) {\n+ s->af_packet_send_buf = g_realloc(s->af_packet_send_buf, frame_len);\n+ s->af_packet_send_buf_size = frame_len;\n+ }\n+\n+ s->af_packet_send_len = frame_len;\n+ s->af_packet_send_offset = 0;\n+ s->af_packet_send_len_bytes = sizeof(s->af_packet_send_len_buf);\n+ return true;\n+}\n+\n+static int tcp_chr_inject_af_packet(Chardev *chr,\n+ SocketChardev *s,\n+ const uint8_t *buf,\n+ int len)\n+{\n+ size_t offset = 0;\n+ uint32_t frame_len_be;\n+\n+ while (offset < len) {\n+ size_t copy;\n+\n+ if (s->af_packet_send_len_bytes < sizeof(s->af_packet_send_len_buf)) {\n+ copy = MIN(sizeof(s->af_packet_send_len_buf) -\n+ s->af_packet_send_len_bytes,\n+ (size_t)len - offset);\n+ memcpy(s->af_packet_send_len_buf + s->af_packet_send_len_bytes,\n+ buf + offset, copy);\n+ s->af_packet_send_len_bytes += copy;\n+ offset += copy;\n+\n+ if (s->af_packet_send_len_bytes <\n+ sizeof(s->af_packet_send_len_buf)) {\n+ continue;\n+ }\n+\n+ memcpy(&frame_len_be, s->af_packet_send_len_buf,\n+ sizeof(frame_len_be));\n+ if (!tcp_chr_af_packet_prepare_send(s, ntohl(frame_len_be))) {\n+ return -1;\n+ }\n+ if (s->af_packet_send_len == 0) {\n+ continue;\n+ }\n+ }\n+\n+ copy = MIN(s->af_packet_send_len - s->af_packet_send_offset,\n+ (size_t)len - offset);\n+ memcpy(s->af_packet_send_buf + s->af_packet_send_offset,\n+ buf + offset, copy);\n+ s->af_packet_send_offset += copy;\n+ offset += copy;\n+\n+ if (s->af_packet_send_offset == s->af_packet_send_len) {\n+ ssize_t ret;\n+\n+ ret = tcp_chr_send_af_packet(s, s->af_packet_send_buf,\n+ s->af_packet_send_len);\n+\n+ if (ret < 0) {\n+ if (errno == EAGAIN || errno == EWOULDBLOCK) {\n+ return -1;\n+ }\n+ if (tcp_chr_read_poll(chr) <= 0) {\n+ trace_chr_socket_poll_err(chr, chr->label);\n+ tcp_chr_disconnect_locked(chr);\n+ }\n+ return -1;\n+ }\n+\n+ if (ret != (ssize_t)s->af_packet_send_len) {\n+ if (ret >= 0) {\n+ errno = EIO;\n+ }\n+ if (tcp_chr_read_poll(chr) <= 0) {\n+ trace_chr_socket_poll_err(chr, chr->label);\n+ tcp_chr_disconnect_locked(chr);\n+ }\n+ return -1;\n+ }\n+\n+ s->af_packet_send_len = 0;\n+ s->af_packet_send_offset = 0;\n+ s->af_packet_send_len_bytes = 0;\n+ }\n+ }\n+\n+ return len;\n+}\n+\n /* Called with chr_write_lock held. */\n static int tcp_chr_write(Chardev *chr, const uint8_t *buf, int len)\n {\n SocketChardev *s = SOCKET_CHARDEV(chr);\n \n+ if (tcp_chr_uses_af_packet_inject(s)) {\n+ return tcp_chr_inject_af_packet(chr, s, buf, len);\n+ }\n+\n if (s->state == TCP_CHARDEV_STATE_CONNECTED) {\n int ret = io_channel_send_full(s->ioc, buf, len,\n s->write_msgfds,\n", "prefixes": [ "RFC", "v4", "4/5" ] }