Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/1.1/patches/2220358/?format=api
{ "id": 2220358, "url": "http://patchwork.ozlabs.org/api/1.1/patches/2220358/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20260407022748.57629-18-pierrick.bouvier@linaro.org/", "project": { "id": 14, "url": "http://patchwork.ozlabs.org/api/1.1/projects/14/?format=api", "name": "QEMU Development", "link_name": "qemu-devel", "list_id": "qemu-devel.nongnu.org", "list_email": "qemu-devel@nongnu.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20260407022748.57629-18-pierrick.bouvier@linaro.org>", "date": "2026-04-07T02:27:45", "name": "[v9,17/20] target/arm/tcg/arm_ldst.h: merge in translate.c", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "ceb2eff36f37f43055007869291288cd5cf69169", "submitter": { "id": 85798, "url": "http://patchwork.ozlabs.org/api/1.1/people/85798/?format=api", "name": "Pierrick Bouvier", "email": "pierrick.bouvier@linaro.org" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20260407022748.57629-18-pierrick.bouvier@linaro.org/mbox/", "series": [ { "id": 498907, "url": "http://patchwork.ozlabs.org/api/1.1/series/498907/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/list/?series=498907", "date": "2026-04-07T02:27:28", "name": "target/arm: single-binary", "version": 9, "mbox": "http://patchwork.ozlabs.org/series/498907/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/2220358/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/2220358/checks/", "tags": {}, "headers": { "Return-Path": "<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@legolas.ozlabs.org", "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256\n header.s=google header.b=QKnYFBu8;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)" ], "Received": [ "from lists.gnu.org (lists.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fqVZY4LC2z1xtJ\n\tfor <incoming@patchwork.ozlabs.org>; Tue, 07 Apr 2026 12:31:49 +1000 (AEST)", "from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from <qemu-devel-bounces@nongnu.org>)\n\tid 1w9wBP-00080Y-2l; Mon, 06 Apr 2026 22:28:51 -0400", "from eggs.gnu.org ([2001:470:142:3::10])\n by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <pierrick.bouvier@linaro.org>)\n id 1w9wAr-0007eR-9l\n for qemu-devel@nongnu.org; Mon, 06 Apr 2026 22:28:17 -0400", "from mail-pl1-x62e.google.com ([2607:f8b0:4864:20::62e])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)\n (Exim 4.90_1) (envelope-from <pierrick.bouvier@linaro.org>)\n id 1w9wAn-000713-4x\n for qemu-devel@nongnu.org; Mon, 06 Apr 2026 22:28:16 -0400", "by mail-pl1-x62e.google.com with SMTP id\n d9443c01a7336-2aae4816912so28515145ad.2\n for <qemu-devel@nongnu.org>; Mon, 06 Apr 2026 19:28:11 -0700 (PDT)", "from pc.taild8403c.ts.net (216-71-219-44.dyn.novuscom.net.\n [216.71.219.44]) by smtp.gmail.com with ESMTPSA id\n d9443c01a7336-2b2749794e8sm161423685ad.53.2026.04.06.19.28.10\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Mon, 06 Apr 2026 19:28:10 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=linaro.org; s=google; t=1775528891; x=1776133691; darn=nongnu.org;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:from:to:cc:subject:date\n :message-id:reply-to;\n bh=huvcXnMs/4HjTKO88sCRvIdI93uZJ7KONvYohCQFmDE=;\n b=QKnYFBu8Dg5apEXbZHuB7UrYq2aU3r5V+IrY+nZXnmg1qDaiwm8hE+s32HNrePPu3y\n BaC1y2kX3QhRPBXkaUalo8saSdvrF31zd33sFITci7UCw0ghrxqmulMiyhQ5P4BkMc80\n j7R5mfwoIeDqzlPpz028ulpSJDVWAWnJD16Sj+BlSgkvJsEm1+bdTedKZ8P4xgDH26wT\n hrj6okjJKAyYIttRX9s+10IYfnJ/xUboqx8vPoqW/0ae2u+Kq3mNyK/temlxpluidHHO\n QVqXz6ivBI9bkbvnsdkDaaIEswhOP7sDFfWSeFJ3CRi6N5EoRc4jSl5kBSy9a1/ZVf/r\n 7aqw==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1775528891; x=1776133691;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from\n :to:cc:subject:date:message-id:reply-to;\n bh=huvcXnMs/4HjTKO88sCRvIdI93uZJ7KONvYohCQFmDE=;\n b=Pi67Bd0Rj2iiJLDbICN5KghVp2r8kAuYgquim+ChaygYXDtTBkSHf8wbUSm0NBhIwL\n H3Zfe5IK8grlY3niJIa0QiEcapG5U4HQ+BsjD4RivHL3dUXnbWv8ctEKjsQzp8A6IzLK\n 2tswjpk0eqABbYNY9JKHlLhigIrD78kKbreasxm37XSEyXCsqnFKt84y4HitPfn7axjZ\n BVQEQVYY4+/wmSHrMelPk6Ep5E9jYD61htcoWnIesMmQH7tSxZi7R8RoRJTQFBeues9B\n +2fSCKjlbWSOLTsl28SVN1xjAuUHrevTdRPQIX6H7HS63Cp5mwSAU1/DHfsntuEiDrhv\n 1RvQ==", "X-Gm-Message-State": "AOJu0YxM2qV6c0oVWxYZ7WK8QYWoA1bvsia+nS6PnhKFe+gTdhQ6r9ve\n XkN+2Lt9po0sxLuo0k8QSB+9Nv8AlTnLBnObKNdZ+oRCw66RIzzG9RcdAnq2RWsWmFyWfyiXmk9\n nkLEp6Zh0/Q==", "X-Gm-Gg": "AeBDiesPSf317P8m6DsPXCvjAtZxi1IQHPiiDeG2uY5EQlQ69qhUwbHdUb8EnBy/iRg\n 1jWh4QnoBRyo1DrSn6pq04cid7ffxDrCD6DTD585kowXpjCs4iso6gFsjeHn4pojUI5Wz1wZTgn\n mSfMzXz9G4RK8yZzVMECMm0nFu5rJa6DeH7rwb5js6ohpkMhgrwayTKytk/JsUnJ8eFcIsdMSV3\n 64IZPE/HgOaSdEbWZ/UYrIIgrvbq4YHLst18wt+hM+o5YNHiP51R3vj8puHTTUVn+pbm7HXbBZ8\n opM1sFnerMBmrvUMQF1lZGvjs8TQTKzBRiX7LLbc4kYZryy4jTkNLb74A+d3AT8zvyN4gcS3Hfs\n XAHAT9qO8te1DlALtajzqfK0UV/JuEY/0ZXHTi09EQ0P+wythszatXQsfKkyj21wwiRNy88jEMP\n 8XdRDjls+j+mHtpNDgFHvynn/vAorS71xcxII0NB/K7pPf1wpEoZoGhzw6/hF1+hL8/Rxv+kYZF\n hfb", "X-Received": "by 2002:a17:903:3c47:b0:2b2:4ded:954e with SMTP id\n d9443c01a7336-2b281801b5amr175135735ad.24.1775528890538;\n Mon, 06 Apr 2026 19:28:10 -0700 (PDT)", "From": "Pierrick Bouvier <pierrick.bouvier@linaro.org>", "To": "qemu-devel@nongnu.org", "Cc": "philmd@linaro.org, Paolo Bonzini <pbonzini@redhat.com>,\n Peter Maydell <peter.maydell@linaro.org>,\n Richard Henderson <richard.henderson@linaro.org>,\n Pierrick Bouvier <pierrick.bouvier@linaro.org>, jim.macarthur@linaro.org,\n qemu-arm@nongnu.org", "Subject": "[PATCH v9 17/20] target/arm/tcg/arm_ldst.h: merge in translate.c", "Date": "Mon, 6 Apr 2026 19:27:45 -0700", "Message-ID": "<20260407022748.57629-18-pierrick.bouvier@linaro.org>", "X-Mailer": "git-send-email 2.47.3", "In-Reply-To": "<20260407022748.57629-1-pierrick.bouvier@linaro.org>", "References": "<20260407022748.57629-1-pierrick.bouvier@linaro.org>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Received-SPF": "pass client-ip=2607:f8b0:4864:20::62e;\n envelope-from=pierrick.bouvier@linaro.org; helo=mail-pl1-x62e.google.com", "X-Spam_score_int": "-20", "X-Spam_score": "-2.1", "X-Spam_bar": "--", "X-Spam_report": "(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001,\n SPF_PASS=-0.001 autolearn=ham autolearn_force=no", "X-Spam_action": "no action", "X-BeenThere": "qemu-devel@nongnu.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "qemu development <qemu-devel.nongnu.org>", "List-Unsubscribe": "<https://lists.nongnu.org/mailman/options/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>", "List-Archive": "<https://lists.nongnu.org/archive/html/qemu-devel>", "List-Post": "<mailto:qemu-devel@nongnu.org>", "List-Help": "<mailto:qemu-devel-request@nongnu.org?subject=help>", "List-Subscribe": "<https://lists.nongnu.org/mailman/listinfo/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=subscribe>", "Errors-To": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org", "Sender": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org" }, "content": "Only translate.c uses those functions, thus move them back to this file.\n\nReviewed-by: Richard Henderson <richard.henderson@linaro.org>\nSigned-off-by: Pierrick Bouvier <pierrick.bouvier@linaro.org>\n---\n target/arm/tcg/arm_ldst.h | 47 --------------------------------------\n target/arm/tcg/translate.c | 22 +++++++++++++++++-\n 2 files changed, 21 insertions(+), 48 deletions(-)", "diff": "diff --git a/target/arm/tcg/arm_ldst.h b/target/arm/tcg/arm_ldst.h\nindex cee0548a1c7..e69de29bb2d 100644\n--- a/target/arm/tcg/arm_ldst.h\n+++ b/target/arm/tcg/arm_ldst.h\n@@ -1,47 +0,0 @@\n-/*\n- * ARM load/store instructions for code (armeb-user support)\n- *\n- * Copyright (c) 2012 CodeSourcery, LLC\n- *\n- * This library is free software; you can redistribute it and/or\n- * modify it under the terms of the GNU Lesser General Public\n- * License as published by the Free Software Foundation; either\n- * version 2.1 of the License, or (at your option) any later version.\n- *\n- * This library is distributed in the hope that it will be useful,\n- * but WITHOUT ANY WARRANTY; without even the implied warranty of\n- * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU\n- * Lesser General Public License for more details.\n- *\n- * You should have received a copy of the GNU Lesser General Public\n- * License along with this library; if not, see <http://www.gnu.org/licenses/>.\n- */\n-\n-#ifndef ARM_LDST_H\n-#define ARM_LDST_H\n-\n-#include \"exec/translator.h\"\n-#include \"qemu/bswap.h\"\n-\n-/* Load an instruction and return it in the standard little-endian order */\n-static inline uint32_t arm_ldl_code(CPUARMState *env, DisasContextBase *s,\n- target_ulong addr, bool sctlr_b)\n-{\n- return translator_ldl_swap(env, s, addr, bswap_code(sctlr_b));\n-}\n-\n-/* Ditto, for a halfword (Thumb) instruction */\n-static inline uint16_t arm_lduw_code(CPUARMState *env, DisasContextBase* s,\n- target_ulong addr, bool sctlr_b)\n-{\n-#ifndef CONFIG_USER_ONLY\n- /* In big-endian (BE32) mode, adjacent Thumb instructions have been swapped\n- within each word. Undo that now. */\n- if (sctlr_b) {\n- addr ^= 2;\n- }\n-#endif\n- return translator_lduw_swap(env, s, addr, bswap_code(sctlr_b));\n-}\n-\n-#endif\ndiff --git a/target/arm/tcg/translate.c b/target/arm/tcg/translate.c\nindex b3c95fb66cb..1fbe41ec643 100644\n--- a/target/arm/tcg/translate.c\n+++ b/target/arm/tcg/translate.c\n@@ -25,7 +25,6 @@\n #define TCG_ADDRESS_BITS 32\n #include \"tcg/tcg-op-mem.h\"\n #include \"qemu/log.h\"\n-#include \"arm_ldst.h\"\n #include \"semihosting/semihost.h\"\n #include \"cpregs.h\"\n #include \"exec/target_page.h\"\n@@ -6280,6 +6279,20 @@ static void disas_thumb_insn(DisasContext *s, uint32_t insn)\n }\n }\n \n+/* Ditto, for a halfword (Thumb) instruction */\n+static uint16_t arm_lduw_code(CPUARMState *env, DisasContextBase* s,\n+ target_ulong addr, bool sctlr_b)\n+{\n+#ifndef CONFIG_USER_ONLY\n+ /* In big-endian (BE32) mode, adjacent Thumb instructions have been swapped\n+ within each word. Undo that now. */\n+ if (sctlr_b) {\n+ addr ^= 2;\n+ }\n+#endif\n+ return translator_lduw_swap(env, s, addr, bswap_code(sctlr_b));\n+}\n+\n static bool insn_crosses_page(CPUARMState *env, DisasContext *s)\n {\n /* Return true if the insn at dc->base.pc_next might cross a page boundary.\n@@ -6514,6 +6527,13 @@ static void arm_post_translate_insn(DisasContext *dc)\n }\n }\n \n+/* Load an instruction and return it in the standard little-endian order */\n+static uint32_t arm_ldl_code(CPUARMState *env, DisasContextBase *s,\n+ target_ulong addr, bool sctlr_b)\n+{\n+ return translator_ldl_swap(env, s, addr, bswap_code(sctlr_b));\n+}\n+\n static void arm_tr_translate_insn(DisasContextBase *dcbase, CPUState *cpu)\n {\n DisasContext *dc = container_of(dcbase, DisasContext, base);\n", "prefixes": [ "v9", "17/20" ] }