Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/1.1/patches/2220331/?format=api
{ "id": 2220331, "url": "http://patchwork.ozlabs.org/api/1.1/patches/2220331/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20260406233236.3585504-2-joshua.a.hay@intel.com/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/1.1/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20260406233236.3585504-2-joshua.a.hay@intel.com>", "date": "2026-04-06T23:32:35", "name": "[iwl-net,1/2] idpf: do not enable XDP if queue based scheduling is not supported", "commit_ref": null, "pull_url": null, "state": "under-review", "archived": false, "hash": "e8f60cb9c585f0c3ee2f8509e6c1d93a27567a89", "submitter": { "id": 19461, "url": "http://patchwork.ozlabs.org/api/1.1/people/19461/?format=api", "name": "Joshua Hay", "email": "joshua.a.hay@intel.com" }, "delegate": { "id": 109701, "url": "http://patchwork.ozlabs.org/api/1.1/users/109701/?format=api", "username": "anguy11", "first_name": "Anthony", "last_name": "Nguyen", "email": "anthony.l.nguyen@intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20260406233236.3585504-2-joshua.a.hay@intel.com/mbox/", "series": [ { "id": 498901, "url": "http://patchwork.ozlabs.org/api/1.1/series/498901/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/list/?series=498901", "date": "2026-04-06T23:32:34", "name": "idpf: queue based scheduling fixes", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/498901/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/2220331/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/2220331/checks/", "tags": {}, "headers": { "Return-Path": "<intel-wired-lan-bounces@osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@legolas.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=osuosl.org header.i=@osuosl.org header.a=rsa-sha256\n header.s=default header.b=F71jPZgI;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=osuosl.org\n (client-ip=140.211.166.137; helo=smtp4.osuosl.org;\n envelope-from=intel-wired-lan-bounces@osuosl.org;\n receiver=patchwork.ozlabs.org)" ], "Received": [ "from smtp4.osuosl.org (smtp4.osuosl.org [140.211.166.137])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fqQMR6J1Sz1y2d\n\tfor <incoming@patchwork.ozlabs.org>; Tue, 07 Apr 2026 09:21:55 +1000 (AEST)", "from localhost (localhost [127.0.0.1])\n\tby smtp4.osuosl.org (Postfix) with ESMTP id D237E407FB;\n\tMon, 6 Apr 2026 23:21:49 +0000 (UTC)", "from smtp4.osuosl.org ([127.0.0.1])\n by localhost (smtp4.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP\n id C1erGAzwKxOc; Mon, 6 Apr 2026 23:21:49 +0000 (UTC)", "from lists1.osuosl.org (lists1.osuosl.org [140.211.166.142])\n\tby smtp4.osuosl.org (Postfix) with ESMTP id EB31D407E7;\n\tMon, 6 Apr 2026 23:21:48 +0000 (UTC)", "from smtp1.osuosl.org (smtp1.osuosl.org [140.211.166.138])\n by lists1.osuosl.org (Postfix) with ESMTP id B81941EB\n for <intel-wired-lan@lists.osuosl.org>; Mon, 6 Apr 2026 23:21:47 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n by smtp1.osuosl.org (Postfix) with ESMTP id 9D20C80CAF\n for <intel-wired-lan@lists.osuosl.org>; Mon, 6 Apr 2026 23:21:46 +0000 (UTC)", "from smtp1.osuosl.org ([127.0.0.1])\n by localhost (smtp1.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP\n id IieMTD-4g-DT for <intel-wired-lan@lists.osuosl.org>;\n Mon, 6 Apr 2026 23:21:46 +0000 (UTC)", "from mgamail.intel.com (mgamail.intel.com [198.175.65.19])\n by smtp1.osuosl.org (Postfix) with ESMTPS id E439880D29\n for <intel-wired-lan@lists.osuosl.org>; Mon, 6 Apr 2026 23:21:45 +0000 (UTC)", "from orviesa003.jf.intel.com ([10.64.159.143])\n by orvoesa111.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 06 Apr 2026 16:21:45 -0700", "from dcskidmo-m40.jf.intel.com ([10.166.241.14])\n by orviesa003.jf.intel.com with ESMTP; 06 Apr 2026 16:21:45 -0700" ], "X-Virus-Scanned": [ "amavis at osuosl.org", "amavis at osuosl.org" ], "X-Comment": "SPF check N/A for local connections - client-ip=140.211.166.142;\n helo=lists1.osuosl.org; envelope-from=intel-wired-lan-bounces@osuosl.org;\n receiver=<UNKNOWN> ", "DKIM-Filter": [ "OpenDKIM Filter v2.11.0 smtp4.osuosl.org EB31D407E7", "OpenDKIM Filter v2.11.0 smtp1.osuosl.org E439880D29" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=osuosl.org;\n\ts=default; t=1775517709;\n\tbh=x/h072mNH8O3frvdI61cCmI6mKDeI7Vt7BpXvSiOBIU=;\n\th=From:To:Cc:Date:In-Reply-To:References:Subject:List-Id:\n\t List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe:\n\t From;\n\tb=F71jPZgI6MWpE3b0kxVyLod9klmxcPnrjxRyNznHM2M4Gcw8pSQWkjXEhOjP7Xz7w\n\t 0CKdpJPlRR8bSwZ+7oWTeEAOfP3bvJjB1568KH2sJLY/P7RAgU/q7ZxTi6ojhVUcgT\n\t PerXiKWr02Cddbzsr7j1pUMF0C8+VDIDhS94eBoDHgMcBWCQb1Dq9K/S7smBrvEtWg\n\t PskraTVO+qsZBe2uoKpnpshkA7WLQrNyYSz9ckmv+r35Ym3ebmeqTO7lCdtOLOn0la\n\t Z2uaU26zEXeqQxOWnJeGblX7foJWrFPwT2zgf2EgZWY2UNy/uBPiHH43jVFNIOf5ZA\n\t MXZuEmyhkEuhw==", "Received-SPF": "Pass (mailfrom) identity=mailfrom; client-ip=198.175.65.19;\n helo=mgamail.intel.com; envelope-from=joshua.a.hay@intel.com;\n receiver=<UNKNOWN>", "DMARC-Filter": "OpenDMARC Filter v1.4.2 smtp1.osuosl.org E439880D29", "X-CSE-ConnectionGUID": [ "kl13WZyDSwaPaDqYocJUcg==", "njMNRV/uQE+PsVEet3GWgQ==" ], "X-CSE-MsgGUID": [ "IKQvVeI1SYiQzYwMaSPzCg==", "kUxQpqsAQu2cm77uTCXO1w==" ], "X-IronPort-AV": [ "E=McAfee;i=\"6800,10657,11751\"; a=\"76368984\"", "E=Sophos;i=\"6.23,164,1770624000\"; d=\"scan'208\";a=\"76368984\"", "E=Sophos;i=\"6.23,164,1770624000\"; d=\"scan'208\";a=\"232050499\"" ], "X-ExtLoop1": "1", "From": "Joshua Hay <joshua.a.hay@intel.com>", "To": "intel-wired-lan@lists.osuosl.org", "Cc": "netdev@vger.kernel.org", "Date": "Mon, 6 Apr 2026 16:32:35 -0700", "Message-Id": "<20260406233236.3585504-2-joshua.a.hay@intel.com>", "X-Mailer": "git-send-email 2.39.2", "In-Reply-To": "<20260406233236.3585504-1-joshua.a.hay@intel.com>", "References": "<20260406233236.3585504-1-joshua.a.hay@intel.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-Mailman-Original-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple;\n d=intel.com; i=@intel.com; q=dns/txt; s=Intel;\n t=1775517706; x=1807053706;\n h=from:to:cc:subject:date:message-id:in-reply-to:\n references:mime-version:content-transfer-encoding;\n bh=zYACHUeAYIX/BOrJWhNTzqspS+ACuYxHxxVneDb5d+Y=;\n b=beK4Pyd6W13T66hZjFpmtCbEcRQEzBO8ILqvLShwRA34pualk35oWOek\n 3ymnfz3SAN0EhdVtOFZDZZnAAzAPOkvG4OeYBga1qRwXvU6LSmJMa+VUY\n mczw9idfwdCwr3hsrITUSJxQd3GFa2cCG5y0WLybo1gQyk5ady27Q4lzg\n iMKgTyzLsfEut43p49fik/y+42ZzcTVfJteeyqRfL7VWcp0qTEegOT/ES\n 6UNVoyOvRRnB/2ZkMNMCm6gKWoaXZxvSpxghxSWjx7Yz+DgzuTEykSJy9\n RdqgcL2xyXaeW4ArG7tA9ZuUOnJDIfPEr27Ptonh7DudDYRDwCFs6U+eG\n w==;", "X-Mailman-Original-Authentication-Results": [ "smtp1.osuosl.org;\n dmarc=pass (p=none dis=none)\n header.from=intel.com", "smtp1.osuosl.org;\n dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com\n header.a=rsa-sha256 header.s=Intel header.b=beK4Pyd6" ], "Subject": "[Intel-wired-lan] [PATCH iwl-net 1/2] idpf: do not enable XDP if\n queue based scheduling is not supported", "X-BeenThere": "intel-wired-lan@osuosl.org", "X-Mailman-Version": "2.1.30", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n <intel-wired-lan.osuosl.org>", "List-Unsubscribe": "<https://lists.osuosl.org/mailman/options/intel-wired-lan>,\n <mailto:intel-wired-lan-request@osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@osuosl.org?subject=help>", "List-Subscribe": "<https://lists.osuosl.org/mailman/listinfo/intel-wired-lan>,\n <mailto:intel-wired-lan-request@osuosl.org?subject=subscribe>", "Errors-To": "intel-wired-lan-bounces@osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@osuosl.org>" }, "content": "The current XDP implementation uses queue based scheduling for its TxQs.\nIf the FW does not advertise support for queue based scheduling, do not\nenable XDP. Add the missing capability check at the start of the XDP\nconfiguration. This will temporarily break XDP while a flow based\nimplementation is worked on, as well as while FWs with queue based by\ndefault are rolled out.\n\nFixes: 705457e7211f (\"idpf: implement XDP_SETUP_PROG in ndo_bpf for splitq\")\nSigned-off-by: Joshua Hay <joshua.a.hay@intel.com>\nReviewed-by: Aleksandr Loktionov <aleksandr.loktionov@intel.com>\nReviewed-by: Madhu Chittim <madhu.chittim@intel.com>\n---\n drivers/net/ethernet/intel/idpf/xdp.c | 7 +++++++\n 1 file changed, 7 insertions(+)", "diff": "diff --git a/drivers/net/ethernet/intel/idpf/xdp.c b/drivers/net/ethernet/intel/idpf/xdp.c\nindex 18a6e7062863..9c3bdb193684 100644\n--- a/drivers/net/ethernet/intel/idpf/xdp.c\n+++ b/drivers/net/ethernet/intel/idpf/xdp.c\n@@ -511,6 +511,13 @@ int idpf_xdp(struct net_device *dev, struct netdev_bpf *xdp)\n \tif (!idpf_is_queue_model_split(vport->dflt_qv_rsrc.txq_model))\n \t\tgoto notsupp;\n \n+\tif (!idpf_is_cap_ena(vport->adapter, IDPF_OTHER_CAPS,\n+\t\t\t VIRTCHNL2_CAP_SPLITQ_QSCHED)) {\n+\t\tNL_SET_ERR_MSG_MOD(xdp->extack,\n+\t\t\t\t \"Device does not support requested XDP Tx scheduling mode\");\n+\t\tgoto notsupp;\n+\t}\n+\n \tswitch (xdp->command) {\n \tcase XDP_SETUP_PROG:\n \t\tret = idpf_xdp_setup_prog(vport, xdp);\n", "prefixes": [ "iwl-net", "1/2" ] }