Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/1.1/patches/2220142/?format=api
{ "id": 2220142, "url": "http://patchwork.ozlabs.org/api/1.1/patches/2220142/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20260406141735.25844-5-armenon@redhat.com/", "project": { "id": 14, "url": "http://patchwork.ozlabs.org/api/1.1/projects/14/?format=api", "name": "QEMU Development", "link_name": "qemu-devel", "list_id": "qemu-devel.nongnu.org", "list_email": "qemu-devel@nongnu.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20260406141735.25844-5-armenon@redhat.com>", "date": "2026-04-06T14:17:29", "name": "[v3,04/10] hw/tpm: Implement TPM CRB chunking logic", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "f3a38398818e0d9141cc996794c0a1cbed1fb65a", "submitter": { "id": 91136, "url": "http://patchwork.ozlabs.org/api/1.1/people/91136/?format=api", "name": "Arun Menon", "email": "armenon@redhat.com" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20260406141735.25844-5-armenon@redhat.com/mbox/", "series": [ { "id": 498860, "url": "http://patchwork.ozlabs.org/api/1.1/series/498860/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/list/?series=498860", "date": "2026-04-06T14:17:28", "name": "hw/tpm: CRB chunking capability to handle PQC", "version": 3, "mbox": "http://patchwork.ozlabs.org/series/498860/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/2220142/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/2220142/checks/", "tags": {}, "headers": { "Return-Path": "<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@legolas.ozlabs.org", "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256\n header.s=mimecast20190719 header.b=ivwgUre7;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256\n header.s=google header.b=RT5m3C+C;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)" ], "Received": [ "from lists.gnu.org (lists.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fqBJy46mdz1yJm\n\tfor <incoming@patchwork.ozlabs.org>; Tue, 07 Apr 2026 00:18:57 +1000 (AEST)", "from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from <qemu-devel-bounces@nongnu.org>)\n\tid 1w9kmZ-0003vC-AQ; Mon, 06 Apr 2026 10:18:27 -0400", "from eggs.gnu.org ([2001:470:142:3::10])\n by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <armenon@redhat.com>)\n id 1w9kmV-0003uu-Ip\n for qemu-devel@nongnu.org; Mon, 06 Apr 2026 10:18:23 -0400", "from us-smtp-delivery-124.mimecast.com ([170.10.129.124])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <armenon@redhat.com>)\n id 1w9kmT-00053w-Ir\n for qemu-devel@nongnu.org; Mon, 06 Apr 2026 10:18:23 -0400", "from mail-pl1-f200.google.com (mail-pl1-f200.google.com\n [209.85.214.200]) by relay.mimecast.com with ESMTP with STARTTLS\n (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id\n us-mta-517-R_FFpvZkNnuqieUV90t87g-1; Mon, 06 Apr 2026 10:18:19 -0400", "by mail-pl1-f200.google.com with SMTP id\n d9443c01a7336-2b0c92ff4ebso53623725ad.2\n for <qemu-devel@nongnu.org>; Mon, 06 Apr 2026 07:18:19 -0700 (PDT)", "from fedora.armenon-thinkpadp16vgen1.bengluru.csb ([152.59.100.84])\n by smtp.gmail.com with ESMTPSA id\n d9443c01a7336-2b27478cb4fsm156732905ad.29.2026.04.06.07.18.09\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Mon, 06 Apr 2026 07:18:16 -0700 (PDT)" ], "DKIM-Signature": [ "v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n s=mimecast20190719; t=1775485100;\n h=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n to:to:cc:cc:mime-version:mime-version:\n content-transfer-encoding:content-transfer-encoding:\n in-reply-to:in-reply-to:references:references;\n bh=7WOfrYNr8qdjwqalVNIDCmZ6n0sTZxk/tvJFpxXi1l8=;\n b=ivwgUre7J8JYBL3ODY4WFP0PaVssa4cuVrubfvbIxBqXMzt88/IKqzGCC1ViuVjfOaVehB\n xZrCZh46J1Zcxhb9rRU8ktBzaD7qZClh2VvUqZjePPx2Q/UDMk9oXSwx08o8tsde8ORnbt\n zULBeTUnEOpMhjrpOZBC/WXP1afr5GI=", "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=redhat.com; s=google; t=1775485098; x=1776089898; darn=nongnu.org;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:from:to:cc:subject:date\n :message-id:reply-to;\n bh=7WOfrYNr8qdjwqalVNIDCmZ6n0sTZxk/tvJFpxXi1l8=;\n b=RT5m3C+CpkqBSJpwee64nXND3KSai5BRQT4jDq8d7QLfbnua5Gf1Uq+ykud7wFdlv5\n 1HkT1+VtDczth9H3tnRLf0Ta1+biAIjjtXvpTbD2Od84Ok/zkuNErz/S5kuWrLX7ynbt\n xgDJEyK/K4cIOzIa3fllgBBxNgDgkc605DMsaAYGoxNJf6HxsUihLzVSXuLS03TRfV2K\n OnBFRhcyChXbfmd9bhktg2/5nZxZEwtY9UGmKn2PjbORoN++vsE2gN4vBAQTN7Pj1UP6\n gvEnUA9ubGGWKmXHKtMW1qtpHtXcuvYm39LC/LinBWndItwSc33eWLD2bi/59yD9LOon\n 2RYg==" ], "X-MC-Unique": "R_FFpvZkNnuqieUV90t87g-1", "X-Mimecast-MFC-AGG-ID": "R_FFpvZkNnuqieUV90t87g_1775485098", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1775485098; x=1776089898;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from\n :to:cc:subject:date:message-id:reply-to;\n bh=7WOfrYNr8qdjwqalVNIDCmZ6n0sTZxk/tvJFpxXi1l8=;\n b=MLI+VSwRJAjvsTuLArxPjv5I6SQb9yjyJO3nvAWTF1rmavWvvD9xkrfxQ5q/HW3jt1\n SIfRvHZE70EsjMqCgF4SFgvBc072rQ927Qx0lXlArnumgJNB7TlQf6Y1DO9hZUSDx4Cx\n 2rCh58UWE0iRtPZ0aDrEZvPF2UAoKyUHW0SQl762yUpmle9REA07uKP1flTTbHkC6zxc\n 402igkbACtU7KDoEE+d+/aG6dXIukRp5zAr1SpXZ1yLxfReVQg4Dm6v4KQ/CGCMxOhv0\n 9mkget+oXAaPLSZy5gvG1k8As/3oAFtCMehbkkt7YvMtcygoW6gL7HteAMuQZZ56N+Yh\n SNfA==", "X-Gm-Message-State": "AOJu0YwPcuSx9xzIMNY4Yw6LSlr12ykZiN8tVNaeP3LBMh6i5Un57TNC\n jvkCAqIJOmnYRuvI0u6QSutIRcs6LsRoXnSv3oqRxq5WH1Ex3Qr3tyoLX0BGZIKTFZScxYkkBam\n DBKdtdfuqZUJLCc57+SoYCVlgGqVNXBWm/PHr5QeZWyPeqTdj3NPsaB/L/AdBUfL1pxS1pkImTi\n eMdVs4xCEaipUrLFs76gajUNOENtSwoD+dl9dpRWk=", "X-Gm-Gg": "AeBDievkExAqrJmF5cNwW5r6ME5uJzsUvFYdK7LG9qQhhIlOns8ZsTgSVNusqzEDNKj\n 0MEUTUPuVcgQugtXTOCOBzcMRGI729Ppzqd65YGt7QCifrXdOHLoLrgozKSNml/bJKHtCrIGTj0\n z3P88LnC60sEbg//RfJTxzkUCLeOJogS7qRIj8FoCMgkRptts9HN/yTvJUUl6U/SmYtFZQvZ3PV\n 6HXtHf2sZE/Ktk/K1yINfNgQIMVjgqerGZawtS35ihxzuW6/9mUG9z4AHAst1llnd07w2eB16yW\n P6u8W+ECW/AoCFLBTNuJQ2Tw5k7bFnwPEJmV1pE435+gffnmmooe8yBpAVtsYv6BZpsP+yYaDac\n DFgwsn/V/6IyjWV/2IofbB63aCWLGeXqGVmsyB6qwP3Xvie2an7yBW8PV2SpYQkA6EAU=", "X-Received": [ "by 2002:a17:903:9ce:b0:2b0:65b8:b5b4 with SMTP id\n d9443c01a7336-2b2818fd5d3mr137028075ad.39.1775485098004;\n Mon, 06 Apr 2026 07:18:18 -0700 (PDT)", "by 2002:a17:903:9ce:b0:2b0:65b8:b5b4 with SMTP id\n d9443c01a7336-2b2818fd5d3mr137027535ad.39.1775485097329;\n Mon, 06 Apr 2026 07:18:17 -0700 (PDT)" ], "From": "Arun Menon <armenon@redhat.com>", "To": "qemu-devel@nongnu.org", "Cc": "Ani Sinha <anisinha@redhat.com>, Laurent Vivier <lvivier@redhat.com>,\n Zhao Liu <zhao1.liu@intel.com>, Stefan Berger <stefanb@linux.vnet.ibm.com>,\n Marcel Apfelbaum <marcel.apfelbaum@gmail.com>,\n Paolo Bonzini <pbonzini@redhat.com>, Fabiano Rosas <farosas@suse.de>,\n marcandre.lureau@redhat.com, \"Michael S. Tsirkin\" <mst@redhat.com>,\n Yanan Wang <wangyanan55@huawei.com>, Igor Mammedov <imammedo@redhat.com>,\n\t=?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= <philmd@linaro.org>,\n Arun Menon <armenon@redhat.com>, Stefan Berger <stefanb@linux.ibm.com>", "Subject": "[PATCH v3 04/10] hw/tpm: Implement TPM CRB chunking logic", "Date": "Mon, 6 Apr 2026 19:47:29 +0530", "Message-ID": "<20260406141735.25844-5-armenon@redhat.com>", "X-Mailer": "git-send-email 2.53.0", "In-Reply-To": "<20260406141735.25844-1-armenon@redhat.com>", "References": "<20260406141735.25844-1-armenon@redhat.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Received-SPF": "pass client-ip=170.10.129.124; envelope-from=armenon@redhat.com;\n helo=us-smtp-delivery-124.mimecast.com", "X-Spam_score_int": "-25", "X-Spam_score": "-2.6", "X-Spam_bar": "--", "X-Spam_report": "(-2.6 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.54,\n DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001,\n RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001,\n SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no", "X-Spam_action": "no action", "X-BeenThere": "qemu-devel@nongnu.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "qemu development <qemu-devel.nongnu.org>", "List-Unsubscribe": "<https://lists.nongnu.org/mailman/options/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>", "List-Archive": "<https://lists.nongnu.org/archive/html/qemu-devel>", "List-Post": "<mailto:qemu-devel@nongnu.org>", "List-Help": "<mailto:qemu-devel-request@nongnu.org?subject=help>", "List-Subscribe": "<https://lists.nongnu.org/mailman/listinfo/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=subscribe>", "Errors-To": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org", "Sender": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org" }, "content": "From: Arun Menon <armenon@redhat.com>\n\n- Add logic to populate internal TPM command request and response\n buffers and to toggle the control registers after each operation.\n- The chunk size is limited to CRB_CTRL_CMD_SIZE which is\n (TPM_CRB_ADDR_SIZE - A_CRB_DATA_BUFFER). This comes out as 3968 bytes\n (4096 - 128 or 0x1000 - 0x80), because 128 bytes are reserved for\n control and status registers. In other words, only 3968 bytes are\n available for the TPM data.\n- With this feature, guests can send commands larger than 3968 bytes.\n- Refer section 6.5.3.9 of [1] for implementation details.\n\n[1] https://trustedcomputinggroup.org/wp-content/uploads/PC-Client-Specific-Platform-TPM-Profile-for-TPM-2p0-v1p07_rc1_121225.pdf\n\nSigned-off-by: Arun Menon <armenon@redhat.com>\nReviewed-by: Stefan Berger <stefanb@linux.ibm.com>\n---\n hw/tpm/tpm_crb.c | 148 +++++++++++++++++++++++++++++++++++++++++------\n 1 file changed, 131 insertions(+), 17 deletions(-)", "diff": "diff --git a/hw/tpm/tpm_crb.c b/hw/tpm/tpm_crb.c\nindex d65b3e2cc1..b9f295db7a 100644\n--- a/hw/tpm/tpm_crb.c\n+++ b/hw/tpm/tpm_crb.c\n@@ -17,6 +17,7 @@\n #include \"qemu/osdep.h\"\n \n #include \"qemu/module.h\"\n+#include \"qemu/error-report.h\"\n #include \"qapi/error.h\"\n #include \"system/address-spaces.h\"\n #include \"hw/core/qdev-properties.h\"\n@@ -65,6 +66,7 @@ DECLARE_INSTANCE_CHECKER(CRBState, CRB,\n #define CRB_INTF_CAP_CRB_CHUNK 0b1\n \n #define CRB_CTRL_CMD_SIZE (TPM_CRB_ADDR_SIZE - A_CRB_DATA_BUFFER)\n+#define TPM_HEADER_SIZE 10\n \n enum crb_loc_ctrl {\n CRB_LOC_CTRL_REQUEST_ACCESS = BIT(0),\n@@ -80,6 +82,8 @@ enum crb_ctrl_req {\n \n enum crb_start {\n CRB_START_INVOKE = BIT(0),\n+ CRB_START_RSP_RETRY = BIT(1),\n+ CRB_START_NEXT_CHUNK = BIT(2),\n };\n \n enum crb_cancel {\n@@ -122,6 +126,69 @@ static uint8_t tpm_crb_get_active_locty(CRBState *s)\n return ARRAY_FIELD_EX32(s->regs, CRB_LOC_STATE, activeLocality);\n }\n \n+static bool tpm_crb_append_command_request(CRBState *s)\n+{\n+ /*\n+ * The linux guest writes the TPM command to the MMIO region in chunks.\n+ * This function appends a chunk from the MMIO region to internal\n+ * command_buffer.\n+ */\n+ void *mem = memory_region_get_ram_ptr(&s->cmdmem);\n+ uint32_t to_copy = 0;\n+ uint32_t total_request_size = 0;\n+\n+ /*\n+ * The initial call extracts the total TPM command size\n+ * from its header. For the subsequent calls, the data already\n+ * appended in the command_buffer is used to calculate the total\n+ * size, as its header stays the same.\n+ */\n+ if (s->command_buffer->len == 0) {\n+ total_request_size = tpm_cmd_get_size(mem);\n+ if (total_request_size < TPM_HEADER_SIZE) {\n+ ARRAY_FIELD_DP32(s->regs, CRB_CTRL_STS, tpmSts, 1);\n+ ARRAY_FIELD_DP32(s->regs, CRB_CTRL_START, invoke, 0);\n+ ARRAY_FIELD_DP32(s->regs, CRB_CTRL_START, nextChunk, 0);\n+ tpm_crb_clear_internal_buffers(s);\n+ error_report(\"Command size %\" PRIu32 \" less than \"\n+ \"TPM header size %\" PRIu32,\n+ total_request_size, (uint32_t)TPM_HEADER_SIZE);\n+ return false;\n+ }\n+ } else {\n+ total_request_size = tpm_cmd_get_size(s->command_buffer->data);\n+ }\n+ total_request_size = MIN(total_request_size, s->be_buffer_size);\n+\n+ if (total_request_size > s->command_buffer->len) {\n+ uint32_t remaining = total_request_size - s->command_buffer->len;\n+ to_copy = MIN(remaining, CRB_CTRL_CMD_SIZE);\n+ g_byte_array_append(s->command_buffer, (guint8 *)mem, to_copy);\n+ }\n+ return true;\n+}\n+\n+static void tpm_crb_fill_command_response(CRBState *s)\n+{\n+ /*\n+ * Response from the tpm backend will be stored in the internal\n+ * response_buffer. This function will serve that accumulated response\n+ * to the linux guest in chunks by writing it back to MMIO region.\n+ */\n+ void *mem = memory_region_get_ram_ptr(&s->cmdmem);\n+ uint32_t remaining = s->response_buffer->len - s->response_offset;\n+ uint32_t to_copy = MIN(CRB_CTRL_CMD_SIZE, remaining);\n+\n+ memcpy(mem, s->response_buffer->data + s->response_offset, to_copy);\n+\n+ if (to_copy < CRB_CTRL_CMD_SIZE) {\n+ memset((guint8 *)mem + to_copy, 0, CRB_CTRL_CMD_SIZE - to_copy);\n+ }\n+\n+ s->response_offset += to_copy;\n+ memory_region_set_dirty(&s->cmdmem, 0, CRB_CTRL_CMD_SIZE);\n+}\n+\n static void tpm_crb_mmio_write(void *opaque, hwaddr addr,\n uint64_t val, unsigned size)\n {\n@@ -152,20 +219,55 @@ static void tpm_crb_mmio_write(void *opaque, hwaddr addr,\n }\n break;\n case A_CRB_CTRL_START:\n- if (val == CRB_START_INVOKE &&\n- !(s->regs[R_CRB_CTRL_START] & CRB_START_INVOKE) &&\n- tpm_crb_get_active_locty(s) == locty) {\n- void *mem = memory_region_get_ram_ptr(&s->cmdmem);\n-\n- ARRAY_FIELD_DP32(s->regs, CRB_CTRL_START, invoke, 1);\n- s->cmd = (TPMBackendCmd) {\n- .in = mem,\n- .in_len = MIN(tpm_cmd_get_size(mem), s->be_buffer_size),\n- .out = mem,\n- .out_len = s->be_buffer_size,\n- };\n-\n- tpm_backend_deliver_request(s->tpmbe, &s->cmd);\n+ if (tpm_crb_get_active_locty(s) != locty) {\n+ break;\n+ }\n+ if (s->regs[R_CRB_CTRL_START] & CRB_START_INVOKE) {\n+ /*\n+ * Backend TPM is busy processing a request.\n+ */\n+ break;\n+ }\n+ if (val & CRB_START_INVOKE) {\n+ if (!(s->regs[R_CRB_CTRL_START] & CRB_START_INVOKE)) {\n+ if (!tpm_crb_append_command_request(s)) {\n+ break;\n+ }\n+ ARRAY_FIELD_DP32(s->regs, CRB_CTRL_START, invoke, 1);\n+ g_byte_array_set_size(s->response_buffer, s->be_buffer_size);\n+ s->cmd = (TPMBackendCmd) {\n+ .in = s->command_buffer->data,\n+ .in_len = s->command_buffer->len,\n+ .out = s->response_buffer->data,\n+ .out_len = s->response_buffer->len,\n+ };\n+ tpm_backend_deliver_request(s->tpmbe, &s->cmd);\n+ }\n+ } else if (val & CRB_START_NEXT_CHUNK) {\n+ /*\n+ * nextChunk is used both while sending and receiving data.\n+ * To distinguish between the two, response_buffer is checked.\n+ * If it does not have data, then that means we have not yet\n+ * sent the command to the tpm backend, and therefore call\n+ * tpm_crb_append_command_request().\n+ */\n+ if (s->response_buffer->len > 0 &&\n+ s->response_offset < s->response_buffer->len) {\n+ tpm_crb_fill_command_response(s);\n+ } else {\n+ if (!tpm_crb_append_command_request(s)) {\n+ break;\n+ }\n+ }\n+ ARRAY_FIELD_DP32(s->regs, CRB_CTRL_START, nextChunk, 0);\n+ } else if (val & CRB_START_RSP_RETRY) {\n+ if (s->response_buffer->len > 0) {\n+ trace_tpm_crb_mmio_write(addr, size, val);\n+ s->response_offset = 0;\n+ tpm_crb_fill_command_response(s);\n+ }\n+ ARRAY_FIELD_DP32(s->regs, CRB_CTRL_START, crbRspRetry, 0);\n+ ARRAY_FIELD_DP32(s->regs, CRB_CTRL_START, nextChunk, 0);\n }\n break;\n case A_CRB_LOC_CTRL:\n@@ -210,8 +312,21 @@ static void tpm_crb_request_completed(TPMIf *ti, int ret)\n if (ret != 0) {\n ARRAY_FIELD_DP32(s->regs, CRB_CTRL_STS,\n tpmSts, 1); /* fatal error */\n+ tpm_crb_clear_internal_buffers(s);\n+ } else {\n+ uint32_t actual_resp_size = tpm_cmd_get_size(s->response_buffer->data);\n+ uint32_t total_resp_size = MIN(actual_resp_size, s->be_buffer_size);\n+ g_byte_array_set_size(s->response_buffer, total_resp_size);\n+ s->response_offset = 0;\n }\n- memory_region_set_dirty(&s->cmdmem, 0, CRB_CTRL_CMD_SIZE);\n+ /*\n+ * Send the first chunk. Subsequent chunks will be sent\n+ * on receiving nextChunk from the guest\n+ */\n+ tpm_crb_fill_command_response(s);\n+ ARRAY_FIELD_DP32(s->regs, CRB_CTRL_START, nextChunk, 0);\n+ ARRAY_FIELD_DP32(s->regs, CRB_CTRL_START, crbRspRetry, 0);\n+ g_byte_array_set_size(s->command_buffer, 0);\n }\n \n static enum TPMVersion tpm_crb_get_version(TPMIf *ti)\n@@ -288,8 +403,7 @@ static void tpm_crb_reset(void *dev)\n s->regs[R_CRB_CTRL_RSP_SIZE] = CRB_CTRL_CMD_SIZE;\n s->regs[R_CRB_CTRL_RSP_ADDR] = TPM_CRB_ADDR_BASE + A_CRB_DATA_BUFFER;\n \n- s->be_buffer_size = MIN(tpm_backend_get_buffer_size(s->tpmbe),\n- CRB_CTRL_CMD_SIZE);\n+ s->be_buffer_size = tpm_backend_get_buffer_size(s->tpmbe);\n \n if (tpm_backend_startup_tpm(s->tpmbe, s->be_buffer_size) < 0) {\n exit(1);\n", "prefixes": [ "v3", "04/10" ] }