Cover Letter Detail
Show a cover letter.
GET /api/1.1/covers/2232327/?format=api
{ "id": 2232327, "url": "http://patchwork.ozlabs.org/api/1.1/covers/2232327/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/cover/20260504-qom-tests-v2-0-ef7e3dc94f7a@redhat.com/", "project": { "id": 14, "url": "http://patchwork.ozlabs.org/api/1.1/projects/14/?format=api", "name": "QEMU Development", "link_name": "qemu-devel", "list_id": "qemu-devel.nongnu.org", "list_email": "qemu-devel@nongnu.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20260504-qom-tests-v2-0-ef7e3dc94f7a@redhat.com>", "date": "2026-05-04T11:34:48", "name": "[v2,00/46] Fix various QOM object life-cycle issues", "submitter": { "id": 66774, "url": "http://patchwork.ozlabs.org/api/1.1/people/66774/?format=api", "name": "Marc-André Lureau", "email": "marcandre.lureau@redhat.com" }, "mbox": "http://patchwork.ozlabs.org/project/qemu-devel/cover/20260504-qom-tests-v2-0-ef7e3dc94f7a@redhat.com/mbox/", "series": [ { "id": 502649, "url": "http://patchwork.ozlabs.org/api/1.1/series/502649/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/list/?series=502649", "date": "2026-05-04T11:34:48", "name": "Fix various QOM object life-cycle issues", "version": 2, "mbox": "http://patchwork.ozlabs.org/series/502649/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/covers/2232327/comments/", "headers": { "Return-Path": "<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@legolas.ozlabs.org", "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256\n header.s=mimecast20190719 header.b=HOJdkem0;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists1p.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)" ], "Received": [ "from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g8KN3490lz1yKW\n\tfor <incoming@patchwork.ozlabs.org>; Mon, 04 May 2026 21:36:01 +1000 (AEST)", "from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists1p.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from <qemu-devel-bounces@nongnu.org>)\n\tid 1wJraD-0007Ut-Dw; Mon, 04 May 2026 07:35:29 -0400", "from eggs.gnu.org ([2001:470:142:3::10])\n by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <marcandre.lureau@redhat.com>)\n id 1wJraA-0007UM-O3\n for qemu-devel@nongnu.org; Mon, 04 May 2026 07:35:26 -0400", "from us-smtp-delivery-124.mimecast.com ([170.10.129.124])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <marcandre.lureau@redhat.com>)\n id 1wJra8-0000lt-0U\n for qemu-devel@nongnu.org; Mon, 04 May 2026 07:35:26 -0400", "from mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com\n (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by\n relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3,\n cipher=TLS_AES_256_GCM_SHA384) id us-mta-687-Bgi5IbSoPjCRQFhAhiWGmA-1; Mon,\n 04 May 2026 07:35:18 -0400", "from mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com\n (mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.111])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest\n SHA256)\n (No client certificate requested)\n by mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS\n id 4FD5C195609E; Mon, 4 May 2026 11:35:16 +0000 (UTC)", "from localhost (unknown [10.44.24.4])\n by mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP\n id 385BE1800347; Mon, 4 May 2026 11:35:13 +0000 (UTC)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n s=mimecast20190719; t=1777894521;\n h=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n to:to:cc:cc:mime-version:mime-version:content-type:content-type:\n content-transfer-encoding:content-transfer-encoding;\n bh=S/z45fmEm0PjMVQmPl8UN4OhYtYkCO5fR7/JcJElm3U=;\n b=HOJdkem0B/JldvwrdxcyzRxHAbeg/sYo6JTR5oRehRS3MbUIiCQ8+dXo0pcgmWMfEWTxl5\n UehkhdHSDo+F+goyIMRXp1hAOPUdeIjCHM+Bw39KpIc8HFCVDLwPWtR2Kc8qvsg29ASSoH\n rKFTXbR91ubiIOBVcRa8JPAgOi5S2eI=", "X-MC-Unique": "Bgi5IbSoPjCRQFhAhiWGmA-1", "X-Mimecast-MFC-AGG-ID": "Bgi5IbSoPjCRQFhAhiWGmA_1777894516", "From": "=?utf-8?q?Marc-Andr=C3=A9_Lureau?= <marcandre.lureau@redhat.com>", "Subject": "[PATCH v2 00/46] Fix various QOM object life-cycle issues", "Date": "Mon, 04 May 2026 15:34:48 +0400", "Message-Id": "<20260504-qom-tests-v2-0-ef7e3dc94f7a@redhat.com>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"utf-8\"", "Content-Transfer-Encoding": "8bit", "X-B4-Tracking": "v=1; b=H4sIAAAAAAAC/22NQQ6CMBAAv0L2bE23RQye/IfhAO0iNYFitxIN6\n d8tePU4yWRmBabgiOFSrBBocez8lEEdCjBDO91JOJsZlFSVLNVZPP0oInFkUVvT666u6hIRsj8\n H6t17b92aH/Ore5CJW2AzBsfRh88+W3Dz/nUXFFKYEnWvK3nSiNdAdmjj0fgRmpTSF6Hf0Fa1A\n AAA", "X-Change-ID": "20260427-qom-tests-9dcf3b969411", "To": "qemu-devel@nongnu.org", "Cc": "armbru@redhat.com,\n =?utf-8?q?Marc-Andr=C3=A9_Lureau?= <marcandre.lureau@redhat.com>,\n Jagannathan Raman <jag.raman@oracle.com>, peterx@redhat.com, =?utf-8?q?Dan?=\n\t=?utf-8?q?iel_P=2E_Berrang=C3=A9?= <berrange@redhat.com>,\n Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>, =?utf-8?q?Philippe_Mathi?=\n\t=?utf-8?q?eu-Daud=C3=A9?= <philmd@linaro.org>,\n Peter Maydell <peter.maydell@linaro.org>, Pavel Pisa <pisa@fel.cvut.cz>,\n Gerd Hoffmann <kraxel@redhat.com>,\n =?utf-8?q?C=C3=A9dric_Le_Goater?= <clg@redhat.com>,\n Glenn Miles <milesg@linux.ibm.com>,\n Alistair Francis <alistair.francis@wdc.com>", "X-Developer-Signature": "v=1; a=openpgp-sha256; l=6846;\n i=marcandre.lureau@redhat.com; h=from:subject:message-id;\n bh=9xyeXP+FHzQsUEcHJT68T/vfgF/olbeEFtj1T6k2HCQ=;\n b=owEBbQKS/ZANAwAKAdro4Ql1lpzlAcsmYgBp+IRrFj+CSRvGwCiJtSVJoP+RjbeTb0KmvioRn\n ZmPXg5ZS2uJAjMEAAEKAB0WIQSHqb2TP4fGBtJ29i3a6OEJdZac5QUCafiEawAKCRDa6OEJdZac\n 5fFzD/9fMIyr9EsP+J3MVz2Cgs8xfvUq089SUy8eMWKC1mGVdkl+m5ASTEJZsR2X4QDiWCZb+tt\n ZnfVRzAWVhLc/3svzRFHfZ0RYyhcW7Tj7a8MR3RmxGSZSbT8JTBTkTWUqsdxKgoXtoO0mBVqcYc\n tq188z4FdCxRmz4f54YMdwUB+N4IEq/sPxChrkSaznxuLspKlyV+mrAMEHRiG+bD4dRcXYCUNrE\n 1k9O3L7VxcpO6Fp57jyH2g3BN+vvIY60CuTkEA41Vs3xKR1aEuVFxww0igIunx2Jx1DVF8Kmi3w\n JF3Kog9LjGSCzTLWVPlhXQ3V7TmjON5UaRICBntdZZ/IXdPC2e/5hdr7rSla4ZD5ArnJbVPC4Uq\n 8OWH/ddyAlLOASpi+p/q61WxLEvNC3BAxVHZo7jlVGeomMQRNDLDm7nN65lNtZlziUpHLiGeGkO\n mGosQd+0a6dhH8RGFAYHt76xXdwBF6dxeGEkYO1Va7QCoPDXCw/wsJ1HQCV6Cfm4UsTkso74WZX\n RywF8W91PYlo7tOP1hxLu+nPUohDPg6uExjF+ZVQwhHDtsgYYa4rlpVMS8EsDZhEQSJlGsncQYL\n UUtldok75BGntxOiGGBWvEeVOv4dxYhan97m8UoCQ7m/95r5OKu3IN9hatrYKdpqhRMQtyuD0T+\n dPwELSYcdIQpLDA==", "X-Developer-Key": "i=marcandre.lureau@redhat.com; a=openpgp;\n fpr=87A9BD933F87C606D276F62DDAE8E10975969CE5", "X-Scanned-By": "MIMEDefang 3.4.1 on 10.30.177.111", "Received-SPF": "pass client-ip=170.10.129.124;\n envelope-from=marcandre.lureau@redhat.com;\n helo=us-smtp-delivery-124.mimecast.com", "X-Spam_score_int": "8", "X-Spam_score": "0.8", "X-Spam_bar": "/", "X-Spam_report": "(0.8 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.444,\n DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001,\n RCVD_IN_SBL_CSS=3.335, SPF_HELO_PASS=-0.001,\n SPF_PASS=-0.001 autolearn=no autolearn_force=no", "X-Spam_action": "no action", "X-BeenThere": "qemu-devel@nongnu.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "qemu development <qemu-devel.nongnu.org>", "List-Unsubscribe": "<https://lists.nongnu.org/mailman/options/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>", "List-Archive": "<https://lists.nongnu.org/archive/html/qemu-devel>", "List-Post": "<mailto:qemu-devel@nongnu.org>", "List-Help": "<mailto:qemu-devel-request@nongnu.org?subject=help>", "List-Subscribe": "<https://lists.nongnu.org/mailman/listinfo/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=subscribe>", "Errors-To": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org", "Sender": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org" }, "content": "Hi,\n\nAfter Markus's \"Several QOM objects crash on introspection\" report, I\nstarted writing some unit test.\n\nThis series adds a new \"qom-tests\" qtest command that exercises basic QOM\nobject life-cycle: it instantiates all non-abstract object types, gets/sets\ntheir properties, and unrefs them. This quickly surfaces leaks and crashes\nthat could otherwise be triggered at runtime via QMP qom commands.\n\nThe bulk of the series fixes the issues found by this test and ASan\nhelp. Some of the patches are redundant with patches sent earlier on the\nML and marked as RFC, they should naturally be dropped during rebases,\nbut are added for completeness and to make sure CI pass after this\nseries in the meantime.\n\nSigned-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>\n---\nChanges in v2:\n- tweak error messages\n- drop \"qom: skip link property check callback\", instead\n added two patches to avoid crash on NULL link check, and doc update\n- drop \"RFC system/ioport\" in favour of Peter Xu fix\n- added \"hw/fsi: move OPBus qbus_init() to instance_init\" to address TODO comment\n- added \"target/riscv: use hash table as set for user_options\"\n- gather a-b/r-b trailers\n- Link to v1: https://lore.kernel.org/qemu-devel/20260427-qom-tests-v1-0-c413f3605311@redhat.com\n\n---\nMarc-André Lureau (45):\n hw/pci: handle missing bus in prop_pci_busnr_get\n chardev/char-socket: handle NULL addr in char_socket_get_addr\n hw/pci-bridge: handle missing parent in prop_pxb_uid_get\n hw/pci-host/i440fx: handle NULL bus in pci-hole64 getters\n hw/pci-host/q35: handle NULL bus in pci-hole64 getters\n hw/remote: check visit return in vfu_object_set_socket\n hw/ipmi: reject NULL 'bmc' property rather than crash\n hw/xlnx_dp: reject NULL 'dpdma' property rather than crash\n qom/object: update doc about NULL values in link properties\n hw/intc/apic: move checks to realize()\n hw/remote: guard listener unregister in finalize\n backends/cryptodev-lkcf: skip cleanup when not initialized\n io/net-listener: move mutex init to instance_init\n net/colo-compare: guard finalize against uninitialized state\n system/ioport: minor code simplification\n ui/console: remove console from global list on finalization\n hw/i386/x86: free oem_id and oem_table_id on finalization\n hw/core/machine: free shim_filename on finalization\n hw/core/resetcontainer: free children array on finalization\n net/filter: free old values in property setters\n ui/console-vc: destroy fifo on text console finalization\n target/i386/sev: add finalize functions and fix leaking setters\n target/i386/kvm/tdx: free strings in tdx_guest_finalize\n hw/i386/nitro_enclave: add instance finalize\n net/can: free ifname on socketcan finalization\n backends/igvm-cfg: free filename on finalization\n scsi/pr-manager-helper: free path on finalization\n accel/kvm: free device path on finalization\n system/qtest: add missing qtest_finalize()\n hw/i386/pc: free pcspk on finalization\n hw/tpm: free PPI buffer on finalization\n hw/fsi: move OPBus address space init to realize\n hw/fsi: move OPBus qbus_init() to instance_init\n hw/gpio/pca9552: fix state_str leak in pca955x_set_led\n hw/arm/aspeed: free fmc_model and spi_model on finalization\n hw/arm/sbsa-ref: free unrealized flash devices on finalization\n hw/arm/virt: free flash devices and OEM strings on finalization\n hw/loongarch/virt: free flash devices and OEM strings on finalization\n hw/ppc/spapr: free host_model and host_serial on finalization\n hw/ppc/pnv: drop extra ref on PHB after adding as child\n target/riscv: fix general_user_opts hash table leak\n target/riscv: use hash table as set for user_options\n hw/riscv/virt: free flash devices and OEM strings on finalization\n hw/i2c/pmbus: fix undefined behavior in pmbus_direct_mode2data\n qtest: add \"qom-tests\" command\n\nPeter Xu (1):\n system/ioport: Fix qom-list-properties crash on portio list obj\n\n include/qom/object.h | 8 +++---\n target/riscv/cpu.h | 3 +-\n tests/qtest/libqtest.h | 8 ++++++\n accel/kvm/kvm-all.c | 8 ++++++\n backends/cryptodev-lkcf.c | 4 +++\n backends/igvm-cfg.c | 1 +\n chardev/char-socket.c | 4 +++\n hw/arm/aspeed.c | 9 ++++++\n hw/arm/sbsa-ref.c | 12 ++++++++\n hw/arm/virt.c | 14 ++++++++++\n hw/core/machine.c | 1 +\n hw/core/resetcontainer.c | 3 ++\n hw/display/xlnx_dp.c | 6 ++++\n hw/fsi/aspeed_apb2opb.c | 37 +++++++++++++++---------\n hw/gpio/pca9552.c | 2 +-\n hw/i2c/pmbus_device.c | 4 +--\n hw/i386/nitro_enclave.c | 11 ++++++++\n hw/i386/pc.c | 10 +++++++\n hw/i386/x86.c | 9 ++++++\n hw/intc/apic_common.c | 23 ++++++++-------\n hw/ipmi/ipmi.c | 9 +++++-\n hw/loongarch/virt.c | 14 ++++++++++\n hw/pci-bridge/pci_expander_bridge.c | 8 +++++-\n hw/pci-host/i440fx.c | 15 ++++++++--\n hw/pci-host/q35.c | 15 ++++++++--\n hw/pci/pci.c | 11 ++++++--\n hw/ppc/pnv.c | 1 +\n hw/ppc/spapr.c | 2 ++\n hw/remote/remote-obj.c | 4 ++-\n hw/remote/vfio-user-obj.c | 4 ++-\n hw/riscv/virt.c | 14 ++++++++++\n hw/tpm/tpm_tis_sysbus.c | 9 ++++++\n io/net-listener.c | 9 +++++-\n net/can/can_socketcan.c | 8 ++++++\n net/colo-compare.c | 31 ++++++++++----------\n net/filter.c | 2 ++\n scsi/pr-manager-helper.c | 1 +\n system/ioport.c | 14 +++++++---\n system/qtest.c | 56 +++++++++++++++++++++++++++++++++++++\n target/i386/cpu-apic.c | 6 +---\n target/i386/kvm/tdx.c | 5 ++++\n target/i386/sev.c | 37 ++++++++++++++++++++++++\n target/riscv/cpu.c | 51 ++++++++++++++++++---------------\n target/riscv/kvm/kvm-cpu.c | 6 ++--\n tests/qtest/libqtest.c | 6 ++++\n tests/qtest/qom-test.c | 12 ++++++++\n ui/console-vc.c | 1 +\n ui/console.c | 5 +++-\n 48 files changed, 440 insertions(+), 93 deletions(-)\n---\nbase-commit: ac0cc20ad2fe0b8df2e5d9458e90a095ac711ab1\nchange-id: 20260427-qom-tests-9dcf3b969411\n\nBest regards,\n-- \nMarc-André Lureau <marcandre.lureau@redhat.com>" }