Cover Letter Detail
Show a cover letter.
GET /api/1.1/covers/2231749/?format=api
{ "id": 2231749, "url": "http://patchwork.ozlabs.org/api/1.1/covers/2231749/?format=api", "web_url": "http://patchwork.ozlabs.org/project/glibc/cover/20260501112421.3373616-1-avinal.xlvii@gmail.com/", "project": { "id": 41, "url": "http://patchwork.ozlabs.org/api/1.1/projects/41/?format=api", "name": "GNU C Library", "link_name": "glibc", "list_id": "libc-alpha.sourceware.org", "list_email": "libc-alpha@sourceware.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20260501112421.3373616-1-avinal.xlvii@gmail.com>", "date": "2026-05-01T11:24:03", "name": "[v2,0/2] intl: Import plural expression hardening from GNU gettext", "submitter": { "id": 88549, "url": "http://patchwork.ozlabs.org/api/1.1/people/88549/?format=api", "name": "Avinal Kumar", "email": "avinal.xlvii@gmail.com" }, "mbox": "http://patchwork.ozlabs.org/project/glibc/cover/20260501112421.3373616-1-avinal.xlvii@gmail.com/mbox/", "series": [ { "id": 502445, "url": "http://patchwork.ozlabs.org/api/1.1/series/502445/?format=api", "web_url": "http://patchwork.ozlabs.org/project/glibc/list/?series=502445", "date": "2026-05-01T11:24:03", "name": "intl: Import plural expression hardening from GNU gettext", "version": 2, "mbox": "http://patchwork.ozlabs.org/series/502445/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/covers/2231749/comments/", "headers": { "Return-Path": "<libc-alpha-bounces~incoming=patchwork.ozlabs.org@sourceware.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "libc-alpha@sourceware.org" ], "Delivered-To": [ "patchwork-incoming@legolas.ozlabs.org", "libc-alpha@sourceware.org" ], "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256\n header.s=20251104 header.b=PLp4GgHp;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=sourceware.org\n (client-ip=38.145.34.32; helo=vm01.sourceware.org;\n envelope-from=libc-alpha-bounces~incoming=patchwork.ozlabs.org@sourceware.org;\n receiver=patchwork.ozlabs.org)", "sourceware.org;\n\tdkim=pass (2048-bit key,\n unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256\n header.s=20251104 header.b=PLp4GgHp", "sourceware.org;\n dmarc=pass (p=none dis=none) header.from=gmail.com", "sourceware.org; spf=pass smtp.mailfrom=gmail.com", "server2.sourceware.org;\n arc=none smtp.remote-ip=2607:f8b0:4864:20::102e" ], "Received": [ "from vm01.sourceware.org (vm01.sourceware.org [38.145.34.32])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g6TGm2px4z1yHZ\n\tfor <incoming@patchwork.ozlabs.org>; Fri, 01 May 2026 21:25:03 +1000 (AEST)", "from vm01.sourceware.org (localhost [127.0.0.1])\n\tby sourceware.org (Postfix) with ESMTP id 374B84371D75\n\tfor <incoming@patchwork.ozlabs.org>; Fri, 1 May 2026 11:25:01 +0000 (GMT)", "from mail-pj1-x102e.google.com (mail-pj1-x102e.google.com\n [IPv6:2607:f8b0:4864:20::102e])\n by sourceware.org (Postfix) with ESMTPS id A03854A9A893\n for <libc-alpha@sourceware.org>; Fri, 1 May 2026 11:24:40 +0000 (GMT)", "by mail-pj1-x102e.google.com with SMTP id\n 98e67ed59e1d1-35fb7c1a455so653475a91.3\n for <libc-alpha@sourceware.org>; Fri, 01 May 2026 04:24:40 -0700 (PDT)", "from fedoraemon.neon-universe.ts.net\n ([2406:7400:11d:a9dc:9a14:72eb:1a60:868a])\n by smtp.gmail.com with ESMTPSA id\n 98e67ed59e1d1-364be028cd6sm5198006a91.14.2026.05.01.04.24.35\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Fri, 01 May 2026 04:24:37 -0700 (PDT)" ], "DKIM-Filter": [ "OpenDKIM Filter v2.11.0 sourceware.org 374B84371D75", "OpenDKIM Filter v2.11.0 sourceware.org A03854A9A893" ], "DMARC-Filter": "OpenDMARC Filter v1.4.2 sourceware.org A03854A9A893", "ARC-Filter": "OpenARC Filter v1.0.0 sourceware.org A03854A9A893", "ARC-Seal": "i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1777634680; cv=none;\n b=EyDm6A9ssPCQbr7tyFchmLKeZWA5fY5bxVLeO/lFTEkxwi1Bqj9lasMhwjETqPprtSQqmLwTR+6sXQdm1OnNHyrXDWfhY+dZgqzr4PKQEytCJBarWxPwrBXdlI3YCYqMZAXPrpOAWg0Gya4mjEQdrqj6uC4eduaEhvlNcto+1YQ=", "ARC-Message-Signature": "i=1; a=rsa-sha256; d=sourceware.org; s=key;\n t=1777634680; c=relaxed/simple;\n bh=bK7TDy8vtJbmRPsqkFmuDsJdK99YubdLcobKtEZPeBI=;\n h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version;\n b=DOMoT0P/jSDhi437JbFu8Gb30QrDDDWstW1TEDuBuXnI0nU0OZBpgTxNICK15arTmE8hI3qJO+cWGKjXsHxwWnDmb6j5DdA0k2GCyKJlYCTbk71HDtbpvXdQ7VYHtAevo6FO/zSk0rDBRZdQgwaBWZTMl4uX0WO3llzNGVUwrGY=", "ARC-Authentication-Results": "i=1; server2.sourceware.org", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=gmail.com; s=20251104; t=1777634679; x=1778239479; darn=sourceware.org;\n h=content-transfer-encoding:mime-version:message-id:date:subject:cc\n :to:from:from:to:cc:subject:date:message-id:reply-to;\n bh=vqLuYaaH2/uehH3c8wgzv6Vv/DjfTdhBoNNM7TRx9z4=;\n b=PLp4GgHpau3y9tPP5Iaw1ApfXPlgaQxezqxOqgEWp5vaksnkGzTQUX4Ju0oj50pkWv\n hUUD0T2iialAPKz4NHlaLk0j0aqSIzJ3hY10ERDOvdrDAARU5SNbRqvyj4ejWfeqefJp\n vSk03ef+IiwiYPNZ7ZIp4diZydV27zZoaT577Uva/jj7VshJyGA/0obbDd/4gk4vcoD7\n 6eChuAG4MdVUl1ayBYqE6OSS2RFpvIPcugN2rdubPuA6CZoiznUmdtbRtEH4H2O/RpaD\n pvExJ2dhn9jjEbVYIL4hquNC+hoQKBoZed+I3ahsTt8Lwc2pnCWZtCI2qpSI8vhkdn2e\n dxLg==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1777634679; x=1778239479;\n h=content-transfer-encoding:mime-version:message-id:date:subject:cc\n :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date\n :message-id:reply-to;\n bh=vqLuYaaH2/uehH3c8wgzv6Vv/DjfTdhBoNNM7TRx9z4=;\n b=O5+MhjQ9Vt5AQDF87frOAq8znM7ozxrhQzfE2YU9Zbm3porKS4peSiexN+pH6K5e08\n gQ77c/58xzhG9eOll0akKlbieJu0sVEffz4lxUYKQ/6oxBr8npn5k7Q7mkoiyANgo/rA\n 37fJX4VMs4ePEl1HSvr2ToNw5pCF9FezbxOFS7USkbgvl+GJ6BTss58w+FyxgppjDsIw\n CLN5FcctFe2+Ofx/v3CK93+SCa528iuRASE/p+nS3mb2Y77rgtPEsYgKaXfwIZgHFdx3\n aB2wboNPVUYiGpY/kdXIN7lfNTOceC3eIhLytgmAPNBeFHBpebIqSUv4Wg0l96rAKlUg\n LAaw==", "X-Gm-Message-State": "AOJu0Yy8xbv7c2XxSjNhiWvLUGWv/b8AswVXWCOwXGpVWqrsqye5dnex\n ecAMUe4jYAolwp2Eve+JMVuYN3VMp+Yc28lZ4VZnm0en05r2a7Es1syq9rr/RQ==", "X-Gm-Gg": "AeBDieuk1X1EEMhecKz/p1ZAurS/z6yxDqKJLdrrB/RLdI6TOwwgs9DMpJFvJxoU64h\n /nMPVSFiqAVGy/A/fUZKZrEpylZn4d0MabwqvBS8CZtFXgdnu0DjcKUyDM42l9xwf94RCIFEMbV\n 3GxTrAYI3VW1G9a+bLpf5vZZ52PCwmz6N8dVaxI0uO1QKbeOujYPh+fwJMAgEA+wKMz65HtlTSC\n jCvfetXvisJ29TkGgUIEU98HLmnjKmis9pHGATixHWCtIX8IM/3RKItNmyUglBZUweXdVEYRfYI\n VqgTTo3MeX/loSGLmvbTgTyXlWxAYKjIZzKx4bkG/+hb4cpyD/Xv+z+56gDnwrdeev5mLVJGEjg\n sp9uZRBxicxasQ598hSPqgf/Jz39POjXb5nLMBjOz6ByF38Vc66BfYWHjmM2R4qInKYrnFXIYy1\n vtasStCACJhsFKPREGu68Hkw590+oqq4Orm1aDIV8kqv3EUeRNTQUQDPo437hxeeoO6w==", "X-Received": "by 2002:a17:90b:3c10:b0:35f:bfdd:f5a1 with SMTP id\n 98e67ed59e1d1-364c30efa39mr7205755a91.13.1777634678973;\n Fri, 01 May 2026 04:24:38 -0700 (PDT)", "From": "Avinal Kumar <avinal.xlvii@gmail.com>", "To": "libc-alpha@sourceware.org", "Cc": "adhemerval.zanella@linaro.org", "Subject": "[PATCH v2 0/2] intl: Import plural expression hardening from GNU\n gettext", "Date": "Fri, 1 May 2026 16:54:03 +0530", "Message-ID": "<20260501112421.3373616-1-avinal.xlvii@gmail.com>", "X-Mailer": "git-send-email 2.54.0", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=UTF-8", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "libc-alpha@sourceware.org", "X-Mailman-Version": "2.1.30", "Precedence": "list", "List-Id": "Libc-alpha mailing list <libc-alpha.sourceware.org>", "List-Unsubscribe": "<https://sourceware.org/mailman/options/libc-alpha>,\n <mailto:libc-alpha-request@sourceware.org?subject=unsubscribe>", "List-Archive": "<https://sourceware.org/pipermail/libc-alpha/>", "List-Post": "<mailto:libc-alpha@sourceware.org>", "List-Help": "<mailto:libc-alpha-request@sourceware.org?subject=help>", "List-Subscribe": "<https://sourceware.org/mailman/listinfo/libc-alpha>,\n <mailto:libc-alpha-request@sourceware.org?subject=subscribe>", "Errors-To": "libc-alpha-bounces~incoming=patchwork.ozlabs.org@sourceware.org" }, "content": "Changes from v1:\n\n- Added adapted tests for plural expression hardening from gettext.\n\nI ran the tests against a non-patched glibc and they crash as expected:\n\n Didn't expect signal from child: got `Floating point exception'\n ...\n FAIL: intl/tst-plural-eval\n === Summary of results ===\n 1 FAIL\n 19 PASS\n\nAdaptation choices:\n\n- gettext embeds the ~20KB nested expression as a literal string.\n I wrote an AWK script (plural-depth.awk) to generate it instead,\n following glibc's convention of using AWK for test data\n generation (cf. po2test.awk). Much easier on the eyes.\n\n- The tests are split into a C program (tst-plural-eval.c) and a shell\n script (tst-plural-eval.sh) that creates the .mo test data. gettext\n uses shell-only tests with its $NGETTEXT binary.\n\n- The division-by-zero trigger value needs to be > 1000 since msgfmt -c\n only validates plural expressions for 0 <= n <= 1000. gettext uses\n 1666; I took the creative liberty of using 1729 — the Hardy-Ramanujan\n number, because if a number is going to crash your program, it might\n as well be an interesting one :)\n\nUsed AI for debugging, learning glibc testing styles, prettyfying commits and comments. \n\nAvinal Kumar (2):\n intl: Import plural expression hardening from GNU gettext\n intl: Add tests for plural expression hardening\n\n intl/Makefile | 11 +++-\n intl/dcigettext.c | 27 +++-----\n intl/eval-plural.h | 139 ++++++++++++++++++++++++++++++----------\n intl/plural-depth.awk | 54 ++++++++++++++++\n intl/plural-exp.h | 21 +++++-\n intl/tst-plural-eval.c | 75 ++++++++++++++++++++++\n intl/tst-plural-eval.sh | 67 +++++++++++++++++++\n 7 files changed, 339 insertions(+), 55 deletions(-)\n create mode 100644 intl/plural-depth.awk\n create mode 100644 intl/tst-plural-eval.c\n create mode 100644 intl/tst-plural-eval.sh" }