Cover Letter Detail
Show a cover letter.
GET /api/1.1/covers/2229366/?format=api
{ "id": 2229366, "url": "http://patchwork.ozlabs.org/api/1.1/covers/2229366/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/cover/20260428070647.777141-1-michal.swiatkowski@linux.intel.com/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/1.1/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20260428070647.777141-1-michal.swiatkowski@linux.intel.com>", "date": "2026-04-28T07:06:45", "name": "[iwl-net,v1,0/2] Rework ice Tx checksum", "submitter": { "id": 81972, "url": "http://patchwork.ozlabs.org/api/1.1/people/81972/?format=api", "name": "Michal Swiatkowski", "email": "michal.swiatkowski@linux.intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/cover/20260428070647.777141-1-michal.swiatkowski@linux.intel.com/mbox/", "series": [ { "id": 501778, "url": "http://patchwork.ozlabs.org/api/1.1/series/501778/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/list/?series=501778", "date": "2026-04-28T07:06:47", "name": "Rework ice Tx checksum", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/501778/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/covers/2229366/comments/", "headers": { "Return-Path": "<intel-wired-lan-bounces@osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@legolas.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=osuosl.org header.i=@osuosl.org header.a=rsa-sha256\n header.s=default header.b=SZGbPj3m;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=osuosl.org\n (client-ip=2605:bc80:3010::137; helo=smtp4.osuosl.org;\n envelope-from=intel-wired-lan-bounces@osuosl.org;\n receiver=patchwork.ozlabs.org)" ], "Received": [ "from smtp4.osuosl.org (smtp4.osuosl.org [IPv6:2605:bc80:3010::137])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g4Xcc1hNPz1yJQ\n\tfor <incoming@patchwork.ozlabs.org>; Tue, 28 Apr 2026 17:48:48 +1000 (AEST)", "from localhost (localhost [127.0.0.1])\n\tby smtp4.osuosl.org (Postfix) with ESMTP id A747841121;\n\tTue, 28 Apr 2026 07:48:46 +0000 (UTC)", "from smtp4.osuosl.org ([127.0.0.1])\n by localhost (smtp4.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP\n id GHL8ar7UWixp; Tue, 28 Apr 2026 07:48:45 +0000 (UTC)", "from lists1.osuosl.org (lists1.osuosl.org [140.211.166.142])\n\tby smtp4.osuosl.org (Postfix) with ESMTP id 440564111E;\n\tTue, 28 Apr 2026 07:48:45 +0000 (UTC)", "from smtp1.osuosl.org (smtp1.osuosl.org [140.211.166.138])\n by lists1.osuosl.org (Postfix) with ESMTP id 890E5231\n for <intel-wired-lan@lists.osuosl.org>; Tue, 28 Apr 2026 07:48:43 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n by smtp1.osuosl.org (Postfix) with ESMTP id 6F14683595\n for <intel-wired-lan@lists.osuosl.org>; Tue, 28 Apr 2026 07:48:43 +0000 (UTC)", "from smtp1.osuosl.org ([127.0.0.1])\n by localhost (smtp1.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP\n id uH3cvvdZ_lTQ for <intel-wired-lan@lists.osuosl.org>;\n Tue, 28 Apr 2026 07:48:42 +0000 (UTC)", "from mgamail.intel.com (mgamail.intel.com [192.198.163.12])\n by smtp1.osuosl.org (Postfix) with ESMTPS id 4C31181DF6\n for <intel-wired-lan@lists.osuosl.org>; Tue, 28 Apr 2026 07:48:42 +0000 (UTC)", "from fmviesa003.fm.intel.com ([10.60.135.143])\n by fmvoesa106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 28 Apr 2026 00:48:41 -0700", "from os-delivery.igk.intel.com ([10.102.21.165])\n by fmviesa003.fm.intel.com with ESMTP; 28 Apr 2026 00:48:37 -0700" ], "X-Virus-Scanned": [ "amavis at osuosl.org", "amavis at osuosl.org" ], "X-Comment": "SPF check N/A for local connections - client-ip=140.211.166.142;\n helo=lists1.osuosl.org; envelope-from=intel-wired-lan-bounces@osuosl.org;\n receiver=<UNKNOWN> ", "DKIM-Filter": [ "OpenDKIM Filter v2.11.0 smtp4.osuosl.org 440564111E", "OpenDKIM Filter v2.11.0 smtp1.osuosl.org 4C31181DF6" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=osuosl.org;\n\ts=default; t=1777362525;\n\tbh=72kvUDy67XvkuOCjTdd6EaMNEGi97jXi33FAtt2eb9o=;\n\th=From:To:Cc:Date:Subject:List-Id:List-Unsubscribe:List-Archive:\n\t List-Post:List-Help:List-Subscribe:From;\n\tb=SZGbPj3mSIlsGuVPOcc9sCplaW5bkf9Tt9mx2sJvQyAcxKT+/zb3FhFyy4sZBSrQh\n\t KG7zYP3baSSuKNSWZxs1Lo2kGooV21soAZSmhmwUE1KlbU36DxZ656jgZw6Im06Uyj\n\t /qtmtoz4MFIxXBb60Ppus8HZu5OQnpVwk2AhcHP0zcWsqqHnYbyXFDBuE+xxtYnZH9\n\t p3mUnCuQkgaHllBA5qsBVRnIMguDLLqRLPRGA8KkrVlQm+KLYYjUADSZYZ4S614vAC\n\t RnTItSMoEQkyqzBS/Vv4ND3BcqGtbjCl5lztsvjtHofALTlDV8SWoBSdxyQMdOUS4V\n\t WKFPzF1PUAXNQ==", "Received-SPF": "Pass (mailfrom) identity=mailfrom; client-ip=192.198.163.12;\n helo=mgamail.intel.com; envelope-from=michal.swiatkowski@linux.intel.com;\n receiver=<UNKNOWN>", "DMARC-Filter": "OpenDMARC Filter v1.4.2 smtp1.osuosl.org 4C31181DF6", "X-CSE-ConnectionGUID": [ "o4T6po1jT1eqRfLqYvEj6g==", "6zDqpDuoQdS5dOu/lJqulA==" ], "X-CSE-MsgGUID": [ "WGJCjy5URF25aBW4mn7k/w==", "81SKb8KxQ/S+MTVdb8qPmQ==" ], "X-IronPort-AV": [ "E=McAfee;i=\"6800,10657,11769\"; a=\"82114974\"", "E=Sophos;i=\"6.23,203,1770624000\"; d=\"scan'208\";a=\"82114974\"" ], "X-ExtLoop1": "1", "From": "Michal Swiatkowski <michal.swiatkowski@linux.intel.com>", "To": "intel-wired-lan@lists.osuosl.org", "Cc": "netdev@vger.kernel.org, jramaseu@redhat.com, anthony.l.nguyen@intel.com,\n przemyslaw.kitszel@intel.com, aleksandr.loktionov@intel.com,\n Michal Swiatkowski <michal.swiatkowski@linux.intel.com>", "Date": "Tue, 28 Apr 2026 09:06:45 +0200", "Message-ID": "<20260428070647.777141-1-michal.swiatkowski@linux.intel.com>", "X-Mailer": "git-send-email 2.49.0", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-Mailman-Original-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple;\n d=intel.com; i=@intel.com; q=dns/txt; s=Intel;\n t=1777362522; x=1808898522;\n h=from:to:cc:subject:date:message-id:mime-version:\n content-transfer-encoding;\n bh=1J1mF9VLA4ad+WVCKHtPLi8k9wXENH/phrj6cZ2eDTM=;\n b=Cvq62SrIWnlYY39cdJyaNEVpNBj7wLq6QnjDENCNkcpjgK4hjJzPKHiC\n PPx9gBG83we9Py2dDyAyCT9S1zz+SXbFkn+naWuxcsHco7/vdXaVVHsDt\n RI2SdHERh5w1RBOqrcpIpcRlj92Vgpp/9NiAClBw0aupTruMbuBScQL+m\n YtWZ3nN1p2P9FgWd+oRb9cVa7s7MjMaebndGHyWfe8NwNpU5FvxXlqDyl\n 3AX8wzgOuv6rwFD5lP0yiNmrssK2xp2hwwLrIIrFZRQVtyCXR10xRJZht\n 64W2aB5drJOPYNVtjwImArVsUsTMSS0wCKsTd20oN29tZ8JHhq8bo4apb\n A==;", "X-Mailman-Original-Authentication-Results": [ "smtp1.osuosl.org;\n dmarc=none (p=none dis=none)\n header.from=linux.intel.com", "smtp1.osuosl.org;\n dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com\n header.a=rsa-sha256 header.s=Intel header.b=Cvq62SrI" ], "Subject": "[Intel-wired-lan] [PATCH iwl-net v1 0/2] Rework ice Tx checksum", "X-BeenThere": "intel-wired-lan@osuosl.org", "X-Mailman-Version": "2.1.30", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n <intel-wired-lan.osuosl.org>", "List-Unsubscribe": "<https://lists.osuosl.org/mailman/options/intel-wired-lan>,\n <mailto:intel-wired-lan-request@osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@osuosl.org?subject=help>", "List-Subscribe": "<https://lists.osuosl.org/mailman/listinfo/intel-wired-lan>,\n <mailto:intel-wired-lan-request@osuosl.org?subject=subscribe>", "Errors-To": "intel-wired-lan-bounces@osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@osuosl.org>" }, "content": "Hi,\n\nJakub find the problem with how ice handles Tx checksum offload [1].\n\nThe issue is that IP_CSUM/IPV6_CSUM should support only basic packet\ntypes. Kernel assumes that if there are extensions headers and there is\nno HW_CSUM software fallback should be applied. Here is a patch that\nintroduced that [2].\n\nHowever, software fallback can't be applied when TSO offload happens.\nThat is the situation that this patchset is fixing.\n\nWhen TSO is enabled and IP_CSUM/IPV6_CSUM is on, kernel is assuming\nhardware will be able to calculate the checksum, but later on the\nextension headers are checked and if there is no HW_CSUM the\nskb_bad_offload() is called.\n\nFollowing the documentation ice driver is capable of HW_CSUM support, so\nswitch from IP_CSUM/IPV6_CSUM to HW_CSUM. Other Intel drivers (even\nprevious like i40e, ixgbe) also supports HW_CSUM.\n\nThe HW_CSUM was used to indicate that GCS (Intel name for checksumming\noffload using additional descriptor) is support, which is variation of\nHW_CSUM. Even without GCS th HW_CSUM is supported. First patch is\nswitching to use custom Tx ring flags to allow HW_CSUM usage.\n\n[1] https://lore.kernel.org/netdev/20260310150557.1138437-1-jramaseu@redhat.com/\n[2] https://lore.kernel.org/all/5fbeecfc311ea182aa1d1c771725ab8b4cac515e.1729778144.git.benoit.monin@gmx.fr/\n\nMichal Swiatkowski (2):\n ice: always do GCS if hardware supports it\n ice: use NETIF_F_HW_CSUM instead of IP/IPV6\n\n drivers/net/ethernet/intel/ice/ice_lib.c | 4 ++++\n drivers/net/ethernet/intel/ice/ice_main.c | 21 +--------------------\n drivers/net/ethernet/intel/ice/ice_txrx.c | 2 +-\n drivers/net/ethernet/intel/ice/ice_txrx.h | 1 +\n 4 files changed, 7 insertions(+), 21 deletions(-)" }