Cover Letter Detail
Show a cover letter.
GET /api/1.1/covers/2228659/?format=api
{ "id": 2228659, "url": "http://patchwork.ozlabs.org/api/1.1/covers/2228659/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/cover/20260427080738.77138-1-philmd@linaro.org/", "project": { "id": 14, "url": "http://patchwork.ozlabs.org/api/1.1/projects/14/?format=api", "name": "QEMU Development", "link_name": "qemu-devel", "list_id": "qemu-devel.nongnu.org", "list_email": "qemu-devel@nongnu.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20260427080738.77138-1-philmd@linaro.org>", "date": "2026-04-27T08:07:06", "name": "[v4,00/32] monitor: Remove need of per-target handlers", "submitter": { "id": 85046, "url": "http://patchwork.ozlabs.org/api/1.1/people/85046/?format=api", "name": "Philippe Mathieu-Daudé", "email": "philmd@linaro.org" }, "mbox": "http://patchwork.ozlabs.org/project/qemu-devel/cover/20260427080738.77138-1-philmd@linaro.org/mbox/", "series": [ { "id": 501599, "url": "http://patchwork.ozlabs.org/api/1.1/series/501599/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/list/?series=501599", "date": "2026-04-27T08:07:06", "name": "monitor: Remove need of per-target handlers", "version": 4, "mbox": "http://patchwork.ozlabs.org/series/501599/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/covers/2228659/comments/", "headers": { "Return-Path": "<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@legolas.ozlabs.org", "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256\n header.s=google header.b=Gac8VkXC;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists1p.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)" ], "Received": [ "from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g3x5k29Hvz1yHv\n\tfor <incoming@patchwork.ozlabs.org>; Mon, 27 Apr 2026 18:08:26 +1000 (AEST)", "from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists1p.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from <qemu-devel-bounces@nongnu.org>)\n\tid 1wHH0Q-0000Tx-2S; Mon, 27 Apr 2026 04:07:50 -0400", "from eggs.gnu.org ([2001:470:142:3::10])\n by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <philmd@linaro.org>) id 1wHH0M-0000TO-JJ\n for qemu-devel@nongnu.org; Mon, 27 Apr 2026 04:07:46 -0400", "from mail-wm1-x329.google.com ([2a00:1450:4864:20::329])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)\n (Exim 4.90_1) (envelope-from <philmd@linaro.org>) id 1wHH0K-00016v-C4\n for qemu-devel@nongnu.org; Mon, 27 Apr 2026 04:07:46 -0400", "by mail-wm1-x329.google.com with SMTP id\n 5b1f17b1804b1-488a14c31eeso80713535e9.0\n for <qemu-devel@nongnu.org>; Mon, 27 Apr 2026 01:07:43 -0700 (PDT)", "from localhost.localdomain (88-187-86-199.subs.proxad.net.\n [88.187.86.199]) by smtp.gmail.com with ESMTPSA id\n 5b1f17b1804b1-4891f98728dsm169172445e9.23.2026.04.27.01.07.40\n (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256);\n Mon, 27 Apr 2026 01:07:41 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=linaro.org; s=google; t=1777277262; x=1777882062; darn=nongnu.org;\n h=content-transfer-encoding:mime-version:message-id:date:subject:to\n :from:from:to:cc:subject:date:message-id:reply-to;\n bh=cRdKTwaViuti0IsXh3G6zVaoRtewZVdl6XkNeSs1K14=;\n b=Gac8VkXCWlctV+/bBLAE+RJeS57CNxVJrmXicov//0Zad4FIYVa+bihzqOjyruTFSc\n /APz5LfjcHsFdsexmJjgIMMUWkxgxaRjXN7tXKaTs8V1a2NfB8DK/oMvSV2ss6fu2IQr\n evrvvFn+E/bTmeGUYmubejFNS9/uChfDRVT7NQpToQJ2aIsy2cc28Z5/l4fgXkR0yc4G\n zgP8rvbDnTJR0tJeCQfIeth4jCQfpbGf8N3ipoVfG1gxR0RYpZ2rkdUi57Hu7V6z6cie\n cLDHyTGPEmdOASoObQgomq9zNMbosNMocm7hA38kAcP7gsmqeeJvsmSOWEnyMTAZxUtL\n AHNA==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1777277262; x=1777882062;\n h=content-transfer-encoding:mime-version:message-id:date:subject:to\n :from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id\n :reply-to;\n bh=cRdKTwaViuti0IsXh3G6zVaoRtewZVdl6XkNeSs1K14=;\n b=F7Qjd1RvT/C1UamRMJxllJPwnUdRk/s+mONsmRuzEhtJu++l4FH8NDk29VDhbBy26f\n 1h5IbkQHLLWfJznBVACptCuKNaJb0kb+Lspo4Szqwr/c1LnhcWnsof+Ya6gMf8uz1A5A\n Y5JjpsPZWu655boWBVCU65gsDXvtgVL7jLDE1+qNWL+zYJaEv5TR3/V+TmMM3Fb9Bl0H\n 5BhAhTMQdTTG6i0ldYL5qltYU78cC8+MCdn3Uog2ayxinVaWI+FLGjDLDP9J3wObDWVz\n KPylWvAUT3EEEktWBvHciuContWjqFYOkvwowuZJf8HrTW5p6zcQo6Su+dXJHwktI/5b\n EpQA==", "X-Forwarded-Encrypted": "i=1;\n AFNElJ+H4ftQDqJnWSvpHT3ufXBg5pB6O57Q5bxq6v8RvgWi7DwSRRkQUGguUAuWkxmKhG69oB7p+eIYFyHn@nongnu.org", "X-Gm-Message-State": "AOJu0Ywa2jBivXe3FSlROMhb0+Kxbo5ykeqr49arO/v//j/tw+RpG17D\n K/oRkdZhxnsR2lmoJcxm2Tdt1Vx7pTsd53Eeql1qRfRMbZkjGUVL4iUZ69T+HyPNtzSMvDb6AXb\n vtaGmems=", "X-Gm-Gg": "AeBDieuQBEmHYAwwE8YoMW1Z0p01aEISLJ7gVDihPfy35Un+ZbXSnwf7aCrII7ZCgDl\n BY1ppOj2fVIco2KO5Mhkjg8PzVMRYNDtMsOpIHV3ImHTrZG/VFb+v1/QtfwiVzKPPpCI5xlJoLC\n n4+EwUS8EN8sB3DP6gmctZcc3B9seuKU7eNfWP6gsn+a0ZvHtpNh0FfGlJRhyv5yIxfiF/q857T\n Erz7PzDEH/bULQjR0/4wkE9TqbqWhnNwmNpPcP0MaGgURAeaiBcJMAE7XoW+3o34WhGxy5uIRGL\n Ef1U32EorBrEA14vzr1kk4TDn0uEqjsdtjllyrksd2Kzk8ej+ywDpeno5EUkaBH1bwx2b7sGwDV\n YkLr4c8d8S2HCtrSezgS3a7QGGncUmvJ2qULDkYoYfYPiwWoEI/jyZ55j8jUKwVLiMOHE83Rpaz\n oaS6ONv0K/4jvWvg1XAjDhSwh8HitUPFUuq7uXaJznYT+t4uBRyj0N7x7LStfOhJPhgHynOWebm\n d4UO4tMCKioZrJyFAtwfA==", "X-Received": "by 2002:a05:600c:1d22:b0:48a:6798:52e9 with SMTP id\n 5b1f17b1804b1-48a6798548fmr170265015e9.0.1777277261992;\n Mon, 27 Apr 2026 01:07:41 -0700 (PDT)", "From": "=?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= <philmd@linaro.org>", "To": "Markus Armbruster <armbru@redhat.com>,\n\tqemu-devel@nongnu.org", "Subject": "[PATCH v4 00/32] monitor: Remove need of per-target handlers", "Date": "Mon, 27 Apr 2026 10:07:06 +0200", "Message-ID": "<20260427080738.77138-1-philmd@linaro.org>", "X-Mailer": "git-send-email 2.53.0", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"utf-8\"", "Content-Transfer-Encoding": "8bit", "Received-SPF": "pass client-ip=2a00:1450:4864:20::329;\n envelope-from=philmd@linaro.org; helo=mail-wm1-x329.google.com", "X-Spam_score_int": "-20", "X-Spam_score": "-2.1", "X-Spam_bar": "--", "X-Spam_report": "(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001,\n SPF_PASS=-0.001 autolearn=ham autolearn_force=no", "X-Spam_action": "no action", "X-BeenThere": "qemu-devel@nongnu.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "qemu development <qemu-devel.nongnu.org>", "List-Unsubscribe": "<https://lists.nongnu.org/mailman/options/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>", "List-Archive": "<https://lists.nongnu.org/archive/html/qemu-devel>", "List-Post": "<mailto:qemu-devel@nongnu.org>", "List-Help": "<mailto:qemu-devel-request@nongnu.org?subject=help>", "List-Subscribe": "<https://lists.nongnu.org/mailman/listinfo/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=subscribe>", "Errors-To": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org", "Sender": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org" }, "content": "Missing review: 32\n\nSince v3:\n- Rebased\n\nSince v2:\n- Addressed rth review comments\n\nChanges needed for the single binary (and heterogeneous emulation).\n\nConvert target_monitor_defs() and target_monitor_defs()\nto SysemuCPUOps fields, adapting the 4 targets using these\n'legacy' code.\n\nInstead of filtering the commands per target / device at\nbuild time, add a new field to HMPCommand to filter them\nat runtime, allowing to compile the command array once.\n\nPhilippe Mathieu-Daudé (32):\n monitor/hmp: : Include missing 'exec/target_long.h' header\n target/sparc/monitor: Dump all registers as 32-bit\n monitor: Remove MonitorDef::type field and MD_TLONG / MD_I32\n monitor: Extract completion declarations to 'monitor/hmp-completion.h'\n stubs: Rename monitor* -> qmp* files\n monitor/meson: Use SPICE with migration HMP commands\n monitor: Restrict monitor_set_cpu() method scope\n monitor: Make 'info via' a generic command\n monitor: Make Xen emulation commands generic ones\n system: Expose 'arch_init.h' as 'qemu/base-arch-defs.h'\n monitor: Introduce HMPCommand::arch_bitmask field\n hw/s390x: Reduce 'monitor/monitor.h' inclusions\n monitor: Do not check TARGET_S390X to build s390x commands\n monitor: Do not check TARGET_I386 to build target/i386/ commands\n monitor: Do not check TARGET_I386 to build 'info sgx' command\n monitor: Do not check TARGET_I386 to build 'info sev' command\n monitor: Do not check TARGET_I386/RISCV to build 'info mem' command\n monitor: Do not check multiple TARGET_* to build 'info tlb' command\n cpus: Introduce SysemuCPUOps::monitor_get_register() hook\n target/riscv: Register target_get_monitor_def in SysemuCPUOps\n monitor: Remove target_get_monitor_def()\n monitor: Have MonitorDef::get_value() always return int64_t type\n monitor: Reduce target-specific methods further\n monitor: Remove 'monitor/hmp-target.h' header\n monitor: Forward-declare the MonitorDef type\n cpus: Introduce SysemuCPUOps::monitor_defs hook\n target/i386: Replace target_monitor_defs -> SysemuCPUOps::monitor_defs\n target/m68k: Replace target_monitor_defs -> SysemuCPUOps::monitor_defs\n target/sparc: Replace target_monitor_defs ->\n SysemuCPUOps::monitor_defs\n monitor: Remove target_monitor_defs()\n monitor: Merge hmp-target.c code within hmp-cmds.c\n monitor: Remove hmp_info_pic() left-over declaration\n\n MAINTAINERS | 16 ++-\n include/hw/core/sysemu-cpu-ops.h | 14 ++\n include/hw/s390x/storage-attributes.h | 4 -\n include/hw/s390x/storage-keys.h | 3 -\n include/monitor/hmp-completion.h | 40 ++++++\n include/monitor/hmp-target.h | 50 -------\n include/monitor/hmp.h | 43 +++---\n include/monitor/monitor.h | 1 -\n .../qemu/base-arch-defs.h | 10 +-\n include/qemu/typedefs.h | 1 +\n monitor/monitor-internal.h | 13 +-\n target/riscv/internals.h | 3 +\n chardev/char-hmp-cmds.c | 1 +\n hw/i386/kvm/xen-stubs.c | 12 ++\n hw/i386/sgx-hmp-stub.c | 16 +++\n hw/i386/sgx-stub.c | 6 -\n hw/i386/sgx.c | 1 -\n hw/misc/mos6522-stub.c | 16 +++\n hw/pci/pci.c | 2 +-\n hw/s390x/s390-skeys.c | 2 +\n hw/s390x/s390-stattrib.c | 2 +\n migration/migration-hmp-cmds.c | 1 +\n monitor/hmp-cmds.c | 41 +++++-\n monitor/hmp-target.c | 124 ------------------\n monitor/hmp.c | 45 ++++++-\n net/net-hmp-cmds.c | 1 +\n qom/qom-hmp-cmds.c | 1 +\n stubs/hmp-cmd-info_mem.c | 12 ++\n stubs/hmp-cmd-info_sev.c | 16 +++\n stubs/hmp-cmd-info_tlb.c | 12 ++\n stubs/hmp-cmds-hw-s390x.c | 15 +++\n stubs/hmp-cmds-target-i386.c | 13 ++\n stubs/{monitor-arm-gic.c => qmp-arm-gic.c} | 0\n ...or-cpu-s390x-kvm.c => qmp-cpu-s390x-kvm.c} | 0\n .../{monitor-cpu-s390x.c => qmp-cpu-s390x.c} | 0\n stubs/{monitor-cpu.c => qmp-cpu.c} | 0\n stubs/{monitor-i386-rtc.c => qmp-i386-rtc.c} | 0\n stubs/{monitor-i386-sev.c => qmp-i386-sev.c} | 0\n stubs/{monitor-i386-sgx.c => qmp-i386-sgx.c} | 0\n stubs/{monitor-i386-xen.c => qmp-i386-xen.c} | 0\n stubs/target-get-monitor-def.c | 29 ----\n stubs/target-monitor-defs.c | 7 -\n system/arch_init.c | 2 +-\n system/qdev-monitor.c | 3 +-\n system/runstate-hmp-cmds.c | 1 +\n system/vl.c | 2 +-\n target/i386/cpu-apic.c | 1 -\n target/i386/cpu.c | 29 ++++\n target/i386/monitor.c | 26 ----\n target/i386/sev-system-stub.c | 6 -\n target/i386/sev.c | 1 -\n target/m68k/cpu.c | 18 +++\n target/m68k/monitor.c | 22 ----\n target/ppc/monitor.c | 2 -\n target/riscv/cpu.c | 1 +\n target/riscv/monitor.c | 12 +-\n target/sh4/monitor.c | 1 -\n target/sparc/cpu.c | 19 +++\n target/sparc/monitor.c | 19 ---\n target/xtensa/monitor.c | 1 -\n trace/trace-hmp-cmds.c | 1 +\n ui/ui-hmp-cmds.c | 1 +\n hmp-commands-info.hx | 26 ++--\n hmp-commands.hx | 13 +-\n hw/i386/meson.build | 1 +\n hw/misc/meson.build | 1 +\n migration/meson.build | 2 +-\n monitor/meson.build | 5 +-\n stubs/meson.build | 23 ++--\n 69 files changed, 425 insertions(+), 387 deletions(-)\n create mode 100644 include/monitor/hmp-completion.h\n delete mode 100644 include/monitor/hmp-target.h\n rename system/arch_init.h => include/qemu/base-arch-defs.h (92%)\n create mode 100644 hw/i386/sgx-hmp-stub.c\n create mode 100644 hw/misc/mos6522-stub.c\n delete mode 100644 monitor/hmp-target.c\n create mode 100644 stubs/hmp-cmd-info_mem.c\n create mode 100644 stubs/hmp-cmd-info_sev.c\n create mode 100644 stubs/hmp-cmd-info_tlb.c\n create mode 100644 stubs/hmp-cmds-hw-s390x.c\n create mode 100644 stubs/hmp-cmds-target-i386.c\n rename stubs/{monitor-arm-gic.c => qmp-arm-gic.c} (100%)\n rename stubs/{monitor-cpu-s390x-kvm.c => qmp-cpu-s390x-kvm.c} (100%)\n rename stubs/{monitor-cpu-s390x.c => qmp-cpu-s390x.c} (100%)\n rename stubs/{monitor-cpu.c => qmp-cpu.c} (100%)\n rename stubs/{monitor-i386-rtc.c => qmp-i386-rtc.c} (100%)\n rename stubs/{monitor-i386-sev.c => qmp-i386-sev.c} (100%)\n rename stubs/{monitor-i386-sgx.c => qmp-i386-sgx.c} (100%)\n rename stubs/{monitor-i386-xen.c => qmp-i386-xen.c} (100%)\n delete mode 100644 stubs/target-get-monitor-def.c\n delete mode 100644 stubs/target-monitor-defs.c" }