Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/1.0/patches/2221382/?format=api
{ "id": 2221382, "url": "http://patchwork.ozlabs.org/api/1.0/patches/2221382/?format=api", "project": { "id": 14, "url": "http://patchwork.ozlabs.org/api/1.0/projects/14/?format=api", "name": "QEMU Development", "link_name": "qemu-devel", "list_id": "qemu-devel.nongnu.org", "list_email": "qemu-devel@nongnu.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20260409104756.465294-4-john.levon@nutanix.com>", "date": "2026-04-09T10:47:56", "name": "[3/3] vfio-user: fix DMA write reply", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "e1bde85269edd32d2abc70a61bdf9aa9942e5059", "submitter": { "id": 80631, "url": "http://patchwork.ozlabs.org/api/1.0/people/80631/?format=api", "name": "John Levon", "email": "john.levon@nutanix.com" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20260409104756.465294-4-john.levon@nutanix.com/mbox/", "series": [ { "id": 499273, "url": "http://patchwork.ozlabs.org/api/1.0/series/499273/?format=api", "date": "2026-04-09T10:47:53", "name": "vfio-user fixes", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/499273/mbox/" } ], "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/2221382/checks/", "tags": {}, "headers": { "Return-Path": "<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@legolas.ozlabs.org", "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=nutanix.com header.i=@nutanix.com header.a=rsa-sha256\n header.s=proofpoint20171006 header.b=ZrYdaWVZ;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=nutanix.com header.i=@nutanix.com header.a=rsa-sha256\n header.s=selector1 header.b=L/RwbPFE;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)" ], "Received": [ "from lists.gnu.org (lists1p.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4frxWD0VKqz1xy1\n\tfor <incoming@patchwork.ozlabs.org>; Thu, 09 Apr 2026 20:48:55 +1000 (AEST)", "from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from <qemu-devel-bounces@nongnu.org>)\n\tid 1wAmvu-0006IJ-7N; Thu, 09 Apr 2026 06:48:23 -0400", "from eggs.gnu.org ([2001:470:142:3::10])\n by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <john.levon@nutanix.com>)\n id 1wAmvl-00065g-Au\n for qemu-devel@nongnu.org; Thu, 09 Apr 2026 06:48:14 -0400", "from mx0a-002c1b01.pphosted.com ([148.163.151.68])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <john.levon@nutanix.com>)\n id 1wAmvi-0006SI-LZ\n for qemu-devel@nongnu.org; Thu, 09 Apr 2026 06:48:12 -0400", "from pps.filterd (m0127840.ppops.net [127.0.0.1])\n by mx0a-002c1b01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id\n 6397tK4u2041684; Thu, 9 Apr 2026 03:48:07 -0700", "from ph0pr06cu001.outbound.protection.outlook.com\n (mail-westus3azon11021099.outbound.protection.outlook.com [40.107.208.99])\n by mx0a-002c1b01.pphosted.com (PPS) with ESMTPS id 4dcms675rj-1\n (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT);\n Thu, 09 Apr 2026 03:48:07 -0700 (PDT)", "from CH2PR02MB6760.namprd02.prod.outlook.com (2603:10b6:610:7f::9)\n by SJ0PR02MB7597.namprd02.prod.outlook.com (2603:10b6:a03:319::8) with\n Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9769.17; Thu, 9 Apr\n 2026 10:48:05 +0000", "from CH2PR02MB6760.namprd02.prod.outlook.com\n ([fe80::dbc1:9766:c58d:4887]) by CH2PR02MB6760.namprd02.prod.outlook.com\n ([fe80::dbc1:9766:c58d:4887%6]) with mapi id 15.20.9769.035; Thu, 9 Apr 2026\n 10:48:05 +0000" ], "DKIM-Signature": [ "v=1; a=rsa-sha256; c=relaxed/relaxed; d=nutanix.com; h=\n cc:content-transfer-encoding:content-type:date:from:in-reply-to\n :message-id:mime-version:references:subject:to; s=\n proofpoint20171006; bh=DJgBrU89x0Xj39oqDstylv5nGc845iu1BsAVm6rOE\n 9s=; b=ZrYdaWVZxzLSt5PTLZ2MPm1bnHG0tPXtE3I535Q1YyH84wojOoj4bkRHP\n DMb4SxETYJKysIdrElTg+de/PG2T5hczDliw6r+fOXDzkZfozYy/e182Qk3L7oNH\n 2WZM6VUiIFyiwLsMSFR7PjOUCVxtv4EbDCjnL9QD+/rjTxBMMRFmxH3XXHzYPT02\n 8sVDYsz7TUvTo6mH9uaNng0Lu8t8ORHXpiySbm/ZvJzawWg6zhdAQV1cNLTXXmJg\n 0talwpn1qghOhUtCIryxuNRcd7ocIAW41T0CETqkmHFK7SHjn46UBDsha+q5ZiHQ\n swkBT04LnelxpduAaH6F4xuQOvn4Q==", "v=1; a=rsa-sha256; c=relaxed/relaxed; d=nutanix.com;\n s=selector1;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;\n bh=DJgBrU89x0Xj39oqDstylv5nGc845iu1BsAVm6rOE9s=;\n b=L/RwbPFEZCj/3zQj+K2Q98hXk2rDdFBhOpOu70+PLtkkfbqMizcvPwi65iKf76U78Hz64w8LfTz4nxKHlfKKcYcpSV9zxXC3l2ESUpgJibKZNb5U4wJqFhBVCGrNCvOHEUXVmVwOFmJrxjV3ifiahb0zGVjptkxEEQHNtptlmNSPEfMhWXbfIZnKxNFXiawe3VnR80sj0qawKHk6ffEUB6+Vr4FVKjPlXWrWMcbJc1HFfQv9xUrPwxYgS3HGxQmznySWSu+SHXc5l9Gm6NJ5901zZvnB/fULijzRHW778G5IQUqKaX9nuIM8xA/wMMYOBBQpr2nejswX+1k2FGXm7A==" ], "ARC-Seal": "i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none;\n b=OW6SvcXqVWWVtgsvUL9NGmVWh+0tO0b2bqPdKR4JhDZsvz4Gj6ZB4mZDTIpkIo3Hht4wuLX7bo7oH6pxIl8phbsHUfaMr1JIhjLnuFYz4SjbcOc1Q0/uPBVLtCWb01GD4eraibZFged/d2nUMmvALVFQ1JG/KrNc2jD4cojEhSStdDnlYNF9ucXQAvQ5IHycadI8oPZghvLMmjIXR/ycpyJgj5ESoba+zUzYAknU3uuvc3t4UmBHhRb40k8GDqGbpHbshqywsVfzOboG8xWHU2MZQoW6l11sSigSeebQb55pOHC0ox5uDNGFwJ7D1zpUBjU+cVssIfUMfBrnNNZvZw==", "ARC-Message-Signature": "i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;\n s=arcselector10001;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;\n bh=DJgBrU89x0Xj39oqDstylv5nGc845iu1BsAVm6rOE9s=;\n b=GqL+sPlFoOzS0zgUzPAVQD8QCxECrhAm+FpXup6nRp+z3RvrSuyWOh/BQIl2NCUwYltiIOf8S0HVWXRftlCN1yNRLxh8ZgF+/yozPbAj99BvT2+SP1gBeKx7yGVfVLHvsNNw/RnIO8E7J9907TkxKnFsWwi5jKhe6tagu+hLBkMf5dG7M9ZHTjAU6/9TPuxTt4RLmCFkp4v6viU68i4+RoW/o/FoWGf/vhlkS95OXCdOu3isp12dD2V/zfbBcnGWMorCAn+LcLavH01xmdilIYd4/B0BHrCnf7LYUYz8tOOjFh74VlVGXqp+lu9jBA1YQD5xOwUwlM9cXqEkbPkouw==", "ARC-Authentication-Results": "i=1; mx.microsoft.com 1; spf=pass\n smtp.mailfrom=nutanix.com; dmarc=pass action=none header.from=nutanix.com;\n dkim=pass header.d=nutanix.com; arc=none", "From": "John Levon <john.levon@nutanix.com>", "To": "qemu-devel@nongnu.org", "Cc": "Thanos Makatos <thanos.makatos@nutanix.com>,\n Pierrick Bouvier <pierrick.bouvier@linaro.org>, =?utf-8?q?C=C3=A9dric_Le_Go?=\n\t=?utf-8?q?ater?= <clg@redhat.com>, John Levon <john.levon@nutanix.com>,\n Patrick Mooney <patrick@matx.com>", "Subject": "[PATCH 3/3] vfio-user: fix DMA write reply", "Date": "Thu, 9 Apr 2026 11:47:56 +0100", "Message-ID": "<20260409104756.465294-4-john.levon@nutanix.com>", "X-Mailer": "git-send-email 2.43.0", "In-Reply-To": "<20260409104756.465294-1-john.levon@nutanix.com>", "References": "<20260409104756.465294-1-john.levon@nutanix.com>", "Content-Transfer-Encoding": "8bit", "Content-Type": "text/plain", "X-ClientProxiedBy": "LO2P123CA0057.GBRP123.PROD.OUTLOOK.COM\n (2603:10a6:600:1::21) To CH2PR02MB6760.namprd02.prod.outlook.com\n (2603:10b6:610:7f::9)", "MIME-Version": "1.0", "X-MS-PublicTrafficType": "Email", "X-MS-TrafficTypeDiagnostic": "CH2PR02MB6760:EE_|SJ0PR02MB7597:EE_", "X-MS-Office365-Filtering-Correlation-Id": "c976a49b-6142-4f1e-ed15-08de96257ad0", "x-proofpoint-crosstenant": "true", "X-MS-Exchange-SenderADCheck": "1", "X-MS-Exchange-AntiSpam-Relay": "0", "X-Microsoft-Antispam": "BCL:0;\n ARA:13230040|366016|376014|1800799024|22082099003|18002099003|56012099003;", "X-Microsoft-Antispam-Message-Info": "\n kwTDer9PMMfboeXlc1Y1Z2ezYHuiGGL67QuB8gwLmuk3uUjQjcMV5G4XVhjYubKPd7FB6XHeHN7sYeCiOSgty8A8lEkBNfLHbmhgA33l2wxSg1ufuQzy19XUpfJ6uW9q+q5hkeviz93MB/FajTZZrvejMtfcPbZMEoXVTm2Xo4RdLqQs+jzyvv9MhDQBEGuPYU9n7PbHdJlUpOmMtzLn3i0zgy4Ioo0gjyT3AIXq+6pj7/aY2BVRUtgDCngxM25iSf95sUnrEzZ31HD1PTAkMh0NitKMEnmtdOLjdEgs6g2i6xUTg1zjLCfe7e4LnuuXQFgAxIm9es25fS5c4QyvKX7FP6KdrPoHzRFglB1UdQOVxn2ET3EEnh30dP4taukhOGJUDh1S/6s+xIrPas6OKb9XmGzWPemIdbcLDWsO4YdQmY/vTZakWR9CcIlORdqmss2JyaR/IIYihqKjSRdGi2PiXFAarprWdRcI8IW/CmLnrsfiUZg15qKYfmrqOHUA+aUozJLkPw/ngAhAz04oPtCevcxFs7FTVgSX5PMqdPSAzOy7XdwJGpsoMh4pwccoqCb3G/A5S3mCSx7/4FvybsLGKsgxsivfCUhuYX/Wh7JdF1qtXaykKmJ0olbsY2HSdpR4xXhh87dedpQuo4mudlS9naJ5FumPEpj9hQqFCA1w63PdNIiHEaDzfSMY31n1q1KWui6llP1Igc5aRxAU6txnDm3SttHu55Nc8scPj2U=", "X-Forefront-Antispam-Report": "CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:;\n IPV:NLI; SFV:NSPM; H:CH2PR02MB6760.namprd02.prod.outlook.com; PTR:; CAT:NONE;\n SFS:(13230040)(366016)(376014)(1800799024)(22082099003)(18002099003)(56012099003);\n DIR:OUT; SFP:1102;", "X-MS-Exchange-AntiSpam-MessageData-ChunkCount": "1", "X-MS-Exchange-AntiSpam-MessageData-0": "\n eDiwt4qZfaum/h2WlEYlrVklLd0/1wVc3+HocxmRdViQQpapkhDcJsWVCMgHLU+1Bdz4jWRTVGNPLZIVRQnvDNnA9pID+snbU/c2CoPxzfwpQlEgSYh7/ejiJcoDE07ELUovBQc3EQrkIoFmoegZTdbuVkplqg7tATgfc8NcIizfweqLxcHFb+pJz3HZGpPwSnFj3mKjzeZJa4FeA1z0B9/rw1i5cz2x9cxQgv939u5/PCcSv4lf5BTmGCP9TKLLYQkbTG4aL0Abp0EuG7W/ebpXu9uyQOAuOvnl/j9nTOliejakktA9WoVpL0H6TujMcLo9LvKycs3SjFc5OV2NsN4OlQZVb9j+JsUOurZVGs/xSxeSrosb9z3cJjvcxF+VIxgpeTNdC3nUlsllCrEiGmVCPsYDyLUXTF9lwzzAQYsUsYnC1E6alkDEUBRHT3WSKS+qus5AFWdswCPv8gFce5M1kAD+Abkv+vzFwF1AM02vcLveCPQyxmIHDI4Vtx8u5oJFs26+TTOwYj5Wyk/sujRVx6IcD4bxIdHaYc8mWEesoEgrv/kkgqkVWqsLb8Kh8FO8vJ5J88oFomt5eCikPZRGncLkJU8OP53HhMsTy8OpRn80vRoaYqEt265IA/5jYI/LvzYpMh1wvVvWBs53hKzKT3GvEHpPHoBrKxj8Zo0sWrLzN7C/ujxfN8y2rtHFeXH11m3CfdhGdgRL20CWntqZY1Mpqo8Kpi8jnq4edYF2LoDISH8H9+i3ui6svGf+3iFSQ78cR8Ev/LcwhzqvN6LsBI4P7Y7MKgxgeIIEoYCoCGPqluiY3sUMHhgaIWz3XleBKXW1M45r49LRRLI7oojbzbPSW+kk8qBGfyPb9bnZoN2JLl4g1hRWLV8ehNrmy9LKq01zYBgCM8P28ZG+FE40pXZpEim+ptgRtuz8EQmpDELa9qjwIqrtc2g9bLvhdkjnFD8fA0zIMBnpJT50m62XT4bc1Ds9vEcUHnaKrFb8/bg2inCJOrGK8JCKcDa4G17/hIUZtXffzmR7/tNoO5pRHlRQX1xpva2cMxoESXt/DE28zaPTWGOZtuCUeZPA/sSsCHp8JBWo25P92R4uOzlhbIJQG2Wll5N9ZCRLDTWUYZGsJQlfiAFXBNfGDOt9rLWxi5wjdyhARqJUxQNB6ZLSmvgzq6zkvtR2DmEy+d05xIDkyg23J86kSIqpVA/r2+4KSIbW0m7dj+yf9Ituvlui4noZvykKqLlRYyOqL0HRK4V/QMMHcT0AbHI1YOELSaSmyVEI7JrlJf83GIqzyllJrQ9YCCdAyLUyXW9eMhGuBsm3IHXqknQclDj1WJJily8XR56uBycTQoSxbcAAN265dHJWnevKyGJOe8FA2ZKW4DIVuKEAhF1MqFDtxiqOZFy6Ymg/Vmop17yPHox2u533Fvh0TZwOnGZtjkPGH/emUGKUopkDZBIhDBuVkXVbsnMaa7xAvCGZt2Ib4dOxayxWbuGTi4d+bR89yhR7scZmauSaJ0EaDRVNWJAgNEjja9FeRJ0SCsM4O+jT3hWg7C3YVqmN26V5qpXeAiL/fIb55aORzfXRCz1C35iOp+5M/tLIJPPXtpYHPcBFLri/Ati3zHK/4yR/tXHlaNKgL3yjtTCdfm14fbUa5vG7sJKlh8Oc6QKVxvmATO2QfHZX2SoN3yqyYYr1BYsi/Yyqi6XhN+mTMluFhHCeTigYQFQYnssPeRYOrzzioYGxrgdu7Q==", "X-Exchange-RoutingPolicyChecked": "\n A8OdHcBTYpsWxtuwouCJCxsYqKpUryxxrqqWAza6zjl6pkXxg0ujoMk65ZM0OW3JcSiEWwVUaI2ocd7yF3x6g7TqogVdcmZqOB7HgzJmAV57X6eymYpn0t+bJdBxhXamYD3ZV+fxIc5uc1o14CTPa+S6zgEseKFKZ9wGYNhJSMpnCW1GK1C1qzUW4tU1anZEDrh0/3Ejdu8Q7ECaxwoYlCyWgFKJ1bkguYvDbsgvRJZH+y8URy6ckKjrPgB+uVYPh43OqBj8YPFPYaDoasaucx6llzJBySteT3UWpQeFv8jHj8lSWkJ0Y4YPu6Bm1UnaFKh5CNtlAEOtbVFo2Le1nQ==", "X-OriginatorOrg": "nutanix.com", "X-MS-Exchange-CrossTenant-Network-Message-Id": "\n c976a49b-6142-4f1e-ed15-08de96257ad0", "X-MS-Exchange-CrossTenant-AuthSource": "CH2PR02MB6760.namprd02.prod.outlook.com", "X-MS-Exchange-CrossTenant-AuthAs": "Internal", "X-MS-Exchange-CrossTenant-OriginalArrivalTime": "09 Apr 2026 10:48:05.6254 (UTC)", "X-MS-Exchange-CrossTenant-FromEntityHeader": "Hosted", "X-MS-Exchange-CrossTenant-Id": "bb047546-786f-4de1-bd75-24e5b6f79043", "X-MS-Exchange-CrossTenant-MailboxType": "HOSTED", "X-MS-Exchange-CrossTenant-UserPrincipalName": "\n TgKsnEn31gVT0MQCblJFsicvkCHtj9ept28uNXKsbPg21RDc91pKkbBrzHeACwoI9zQFhu3DKXjIxHXc3RLOPA==", "X-MS-Exchange-Transport-CrossTenantHeadersStamped": "SJ0PR02MB7597", "X-Authority-Analysis": "v=2.4 cv=Su2gLvO0 c=1 sm=1 tr=0 ts=69d783e7 cx=c_pps\n a=gvdBbcfKwwW3/oSCzHqKfA==:117 a=6eWqkTHjU83fiwn7nKZWdM+Sl24=:19\n a=z/mQ4Ysz8XfWz/Q5cLBRGdckG28=:19 a=lCpzRmAYbLLaTzLvsPZ7Mbvzbb8=:19\n a=xqWC_Br6kY4A:10 a=A5OVakUREuEA:10 a=0kUYKlekyDsA:10\n a=VkNPw1HP01LnGYTKEx00:22 a=VofLwUrZ8Iiv6rRUPXIb:22 a=_-M8LpHI31CeLmyZm6wg:22\n a=puMWUmrUAAAA:8 a=64Cc0HZtAAAA:8 a=w6TJzBNOSodSHIE7IQgA:9\n a=oJ1xzHRvupUJs7EIRaQM:22", "X-Proofpoint-Spam-Details-Enc": "AW1haW4tMjYwNDA5MDA5NyBTYWx0ZWRfXwUeemlL69OMo\n JYvZNikD85iHjMFSHYHMMjniQs0mOWFD7CB2K3bdxlkYPaCPa+3M+D9Ny4xPgt/AAHONfUsWaHc\n YZZIF93HXF7okFJLpeMeTbImPef20szEW6muGS7SU1I4fP0M6WnrUxGh5tsBia6dHTJliG8wVTQ\n S/GJH6BLdcEbBM+RCnh5lhvGz727BqEgO//vd7m8mZUWg0sbTnoA+3vwaQRvEaIhd/kWSbpmGqT\n U9YxvXRn5I4GBySYe69pUeojGDZ+Pq8v43PZ+QCgWCpM72GNllzxZO/gfFlIDjCBHIcBoxb3gBq\n RT7L306GdQ1xSlygfDW1jAOmNsnuWycUHcLxxjbKUSbH6lo+6gJsmX9bGTWNeI47/a7RIgApS/4\n P/TJ0UzMzBxrrWXs7NCrCcI3gckl6G48th5/CxOt6Mf4gxSwYkt8OVMC/dC/jWeFyL89q8zRIi7\n WGN4/HGg9SlDvvssHjQ==", "X-Proofpoint-GUID": "dKNGsafrwZil5F6HPxgZnWjWX6Fp8rld", "X-Proofpoint-ORIG-GUID": "dKNGsafrwZil5F6HPxgZnWjWX6Fp8rld", "X-Proofpoint-Virus-Version": "vendor=baseguard\n engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49\n definitions=2026-04-09_03,2026-04-09_01,2025-10-01_01", "X-Proofpoint-Spam-Reason": "safe", "Received-SPF": "pass client-ip=148.163.151.68;\n envelope-from=john.levon@nutanix.com; helo=mx0a-002c1b01.pphosted.com", "X-Spam_score_int": "-32", "X-Spam_score": "-3.3", "X-Spam_bar": "---", "X-Spam_report": "(-3.3 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.54,\n DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001,\n RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001, SPF_HELO_NONE=0.001,\n SPF_PASS=-0.001 autolearn=ham autolearn_force=no", "X-Spam_action": "no action", "X-BeenThere": "qemu-devel@nongnu.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "qemu development <qemu-devel.nongnu.org>", "List-Unsubscribe": "<https://lists.nongnu.org/mailman/options/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>", "List-Archive": "<https://lists.nongnu.org/archive/html/qemu-devel>", "List-Post": "<mailto:qemu-devel@nongnu.org>", "List-Help": "<mailto:qemu-devel-request@nongnu.org?subject=help>", "List-Subscribe": "<https://lists.nongnu.org/mailman/listinfo/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=subscribe>", "Errors-To": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org", "Sender": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org" }, "content": "The protocol specifies that DMA write replies should include\naddress+count, but the client code was only doing so for read. Fix that\nup.\n\nIn addition, add a protocol clarification over how short writes may be\nreported in that reply. QEMU never reports a short write via the\ncount field.\n\nReported-by: Patrick Mooney <patrick@matx.com>\nSigned-off-by: John Levon <john.levon@nutanix.com>\n---\n docs/interop/vfio-user.rst | 6 ++++++\n hw/vfio-user/pci.c | 30 ++++++++++++++++++++++--------\n 2 files changed, 28 insertions(+), 8 deletions(-)", "diff": "diff --git a/docs/interop/vfio-user.rst b/docs/interop/vfio-user.rst\nindex d4766487ea..12deb25102 100644\n--- a/docs/interop/vfio-user.rst\n+++ b/docs/interop/vfio-user.rst\n@@ -1429,6 +1429,9 @@ Reply\n * *count* is the size of the data transferred.\n * *data* is the data read.\n \n+Note that whether short reads return an error or just set count appropriately is\n+a client-side choice; servers should be prepared to handle both cases.\n+\n ``VFIO_USER_DMA_WRITE``\n -----------------------\n \n@@ -1469,6 +1472,9 @@ Reply\n * *address* is the client DMA memory address being accessed.\n * *count* is the size of the data transferred.\n \n+Note that whether short writes return an error or just set count appropriately\n+is a client-side choice; servers should be prepared to handle both cases.\n+\n ``VFIO_USER_DEVICE_RESET``\n --------------------------\n \ndiff --git a/hw/vfio-user/pci.c b/hw/vfio-user/pci.c\nindex 64b8b3cb8c..facc79727a 100644\n--- a/hw/vfio-user/pci.c\n+++ b/hw/vfio-user/pci.c\n@@ -109,6 +109,10 @@ static void vfio_user_dma_read(VFIOPCIDevice *vdev, VFIOUserDMARW *msg)\n \n r = pci_dma_read(pdev, res->offset, &res->data, res->count);\n \n+ /*\n+ * pci_dma_read() doesn't support reporting short reads via the reply's\n+ * count parameter; in this case, we'll reply with an error instead.\n+ */\n switch (r) {\n case MEMTX_OK:\n if (res->hdr.flags & VFIO_USER_NO_REPLY) {\n@@ -136,6 +140,7 @@ static void vfio_user_dma_write(VFIOPCIDevice *vdev, VFIOUserDMARW *msg)\n {\n PCIDevice *pdev = PCI_DEVICE(vdev);\n VFIOUserProxy *proxy = vdev->vbasedev.proxy;\n+ VFIOUserDMARW *res;\n MemTxResult r;\n \n if (msg->hdr.size < sizeof(*msg)) {\n@@ -150,26 +155,35 @@ static void vfio_user_dma_write(VFIOPCIDevice *vdev, VFIOUserDMARW *msg)\n \n r = pci_dma_write(pdev, msg->offset, &msg->data, msg->count);\n \n+ res = g_malloc0(sizeof(*res));\n+ memcpy(res, msg, sizeof(*res));\n+ g_free(msg);\n+\n+ /*\n+ * pci_dma_write() doesn't support reporting short writes via the reply's\n+ * count parameter; in this case, we'll reply with an error instead.\n+ */\n switch (r) {\n case MEMTX_OK:\n- if ((msg->hdr.flags & VFIO_USER_NO_REPLY) == 0) {\n- vfio_user_send_reply(proxy, &msg->hdr, sizeof(msg->hdr));\n- } else {\n- g_free(msg);\n+ if (res->hdr.flags & VFIO_USER_NO_REPLY) {\n+ g_free(res);\n+ return;\n }\n+\n+ vfio_user_send_reply(proxy, &res->hdr, sizeof(*res));\n break;\n case MEMTX_ERROR:\n- vfio_user_send_error(proxy, &msg->hdr, EFAULT);\n+ vfio_user_send_error(proxy, &res->hdr, EFAULT);\n break;\n case MEMTX_DECODE_ERROR:\n- vfio_user_send_error(proxy, &msg->hdr, ENODEV);\n+ vfio_user_send_error(proxy, &res->hdr, ENODEV);\n break;\n case MEMTX_ACCESS_ERROR:\n- vfio_user_send_error(proxy, &msg->hdr, EPERM);\n+ vfio_user_send_error(proxy, &res->hdr, EPERM);\n break;\n default:\n error_printf(\"vfio_user_dma_write unknown error %d\\n\", r);\n- vfio_user_send_error(vdev->vbasedev.proxy, &msg->hdr, EINVAL);\n+ vfio_user_send_error(vdev->vbasedev.proxy, &res->hdr, EINVAL);\n }\n }\n \n", "prefixes": [ "3/3" ] }