Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/1.0/patches/2221201/?format=api
{ "id": 2221201, "url": "http://patchwork.ozlabs.org/api/1.0/patches/2221201/?format=api", "project": { "id": 14, "url": "http://patchwork.ozlabs.org/api/1.0/projects/14/?format=api", "name": "QEMU Development", "link_name": "qemu-devel", "list_id": "qemu-devel.nongnu.org", "list_email": "qemu-devel@nongnu.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20260408041953.1899532-4-brian.cain@oss.qualcomm.com>", "date": "2026-04-08T04:19:28", "name": "[v4,03/28] target/hexagon: Implement start/stop helpers, soft reset", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "f08a6df02c26dbf4e266b139b47e1b0347e8c153", "submitter": { "id": 89839, "url": "http://patchwork.ozlabs.org/api/1.0/people/89839/?format=api", "name": "Brian Cain", "email": "brian.cain@oss.qualcomm.com" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20260408041953.1899532-4-brian.cain@oss.qualcomm.com/mbox/", "series": [ { "id": 499179, "url": "http://patchwork.ozlabs.org/api/1.0/series/499179/?format=api", "date": "2026-04-08T04:19:31", "name": "Hexagon system emulation - Part 2/3", "version": 4, "mbox": "http://patchwork.ozlabs.org/series/499179/mbox/" } ], "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/2221201/checks/", "tags": {}, "headers": { "Return-Path": "<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@legolas.ozlabs.org", "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=qualcomm.com header.i=@qualcomm.com header.a=rsa-sha256\n header.s=qcppdkim1 header.b=BY4dMjkh;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com\n header.a=rsa-sha256 header.s=google header.b=EXAlKV5O;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)" ], "Received": [ "from lists.gnu.org (lists1p.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4frYQK52qlz1xy1\n\tfor <incoming@patchwork.ozlabs.org>; Thu, 09 Apr 2026 05:43:21 +1000 (AEST)", "from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from <qemu-devel-bounces@nongnu.org>)\n\tid 1wAYTB-0007Fu-9b; Wed, 08 Apr 2026 15:21:47 -0400", "from eggs.gnu.org ([2001:470:142:3::10])\n by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <brian.cain@oss.qualcomm.com>)\n id 1wAY4U-0006PA-1K\n for qemu-devel@nongnu.org; Wed, 08 Apr 2026 14:56:14 -0400", "from mx0b-0031df01.pphosted.com ([205.220.180.131])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <brian.cain@oss.qualcomm.com>)\n id 1wAKOl-0005Yv-NK\n for qemu-devel@nongnu.org; Wed, 08 Apr 2026 00:20:18 -0400", "from pps.filterd (m0279870.ppops.net [127.0.0.1])\n by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id\n 637M6KM32450557\n for <qemu-devel@nongnu.org>; Wed, 8 Apr 2026 04:20:13 GMT", "from mail-dl1-f71.google.com (mail-dl1-f71.google.com\n [74.125.82.71])\n by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4ddae68wkn-1\n (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT)\n for <qemu-devel@nongnu.org>; Wed, 08 Apr 2026 04:20:13 +0000 (GMT)", "by mail-dl1-f71.google.com with SMTP id\n a92af1059eb24-1276e71652fso3470577c88.0\n for <qemu-devel@nongnu.org>; Tue, 07 Apr 2026 21:20:13 -0700 (PDT)", "from hu-bcain-lv.qualcomm.com (Global_NAT1.qualcomm.com.\n [129.46.96.20]) by smtp.gmail.com with ESMTPSA id\n a92af1059eb24-12c14a371b1sm6480362c88.13.2026.04.07.21.20.10\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Tue, 07 Apr 2026 21:20:10 -0700 (PDT)" ], "DKIM-Signature": [ "v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h=\n cc:content-transfer-encoding:content-type:date:from:in-reply-to\n :message-id:mime-version:references:subject:to; s=qcppdkim1; bh=\n 43eht5i5NYtJP0f/h9KiBbJpH+OYgI6m0lyV0s2tzuM=; b=BY4dMjkhlA6mn2yF\n uoqX1B0UzPUPseKt5kvNX2oEqYt/4TnRWutqG8ABjNssmpwTUraEg2sZPsdkmz6W\n Mt2uVl7p7ccSfLQbZY0AohDc/rO3PX/xL+v3aBEmQTbvMuNtdM0cxKzawXqo2etF\n 5C3RCtX7KyFmVjkKP9H9jAgtZK7WqZquq810jyqBOr62Rb3hqVyrAVsWMaWb+QLg\n gSlkJq95TdkyZpZks2fB1/cppxi2y/HftQbTNC1UAi3uNLDKlKzUCbaB/E9Ti6+x\n 4iOAzX5o46hCCY4K3Nk1H1qxnabG8EcIB868EuXf8zzrE/wCQVS+VZBtRgQB9UHy\n fO1NLQ==", "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=oss.qualcomm.com; s=google; t=1775622012; x=1776226812; darn=nongnu.org;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:from:to:cc:subject:date\n :message-id:reply-to;\n bh=43eht5i5NYtJP0f/h9KiBbJpH+OYgI6m0lyV0s2tzuM=;\n b=EXAlKV5OqbXLIn/W81LSL83HWgTHFS43ClzQ+86CO+jtjc4DrCu3usnhH1FkYS3qwP\n dpn8vt/Ko17QVLBbSb5yttKKo2Nq2rocltcN6vM4WJPm6XgIeVMeBoJiH1J0BQ+PEP2C\n 3+N8FRwzwtIzPJhsoqAAXShqMJrDDyD6Yi4vf0P6BXKYarftYKchoZ9BKrdYs2j3/aL0\n OtxmHaiQw3uifwoGm1rY/vTguhZ9/IW1lwFS/m07H3irjImUdVKe5DJeQQmCcvc1KbwV\n zGBrfJUvgfGz6dybi9JINW/M217iDNpfB5lhQJK5K0oWRC0xrV9v15CKv8F7czo4VloV\n hAmg==" ], "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1775622012; x=1776226812;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from\n :to:cc:subject:date:message-id:reply-to;\n bh=43eht5i5NYtJP0f/h9KiBbJpH+OYgI6m0lyV0s2tzuM=;\n b=NAPSPr0J7hgF+LYs08zEdfzosvWosF/RI2Th8yiYhVBZ7M6r5Jfg+xk0wH9ryo4acb\n vevblTI+TyV6KgvGBTo/WIOfe9OiMlOE+Xuk12b+o07bqqGzzmRpqndctzyzAFcvchF0\n FAVnpT7mADQcDwUYUkB/N1X/nVJlsuMMTamMPhqJdd72G2+bngA7th6dgh3TK63pDY6+\n tMwcq9FyAyqF9YBzT8KDUQ+ri3U4dO214hwB0T4+6iW7MO2DE+IK8oEyiMN8HsDYaP5T\n 421MM3TPAJ6T7Y6TddDywICgJdQoCMW2NZxxIuhEbB/YVgzPKJJaycs/7SkV3hKsB234\n ypgg==", "X-Gm-Message-State": "AOJu0YzbyLC09P8SDff9vGnt8hYUy5mhuRN7RQyi4CvNgj0hHG5s6N5J\n j400mUByJZpBxng9ra6doDtBfLwjiYwE8bTmhW5Hne2EX/Rezl5iDn+OLUi455lsHcfSv+yM8Pt\n zpX8bKLEeNnWRcUwjHMzGGUDtHSSFgqq/nRieEhIiOsnoe33I+mlu3nZO9r6c8p5mRA==", "X-Gm-Gg": "AeBDieugqxaiIEEiOb2EVQUnXqwkX2RwMjEcHwf74K1dbIb1dj6yyZgNdgm2o2kUZIq\n AD++FbRLvhPn6o618n3Uw6qo5KMVMRP6grMw3zlG4oIDhnynj6HJyls9u460BkML5441Qo5S4WP\n yYGg6DN5/KIrNY6pF5WJnI4Tb220+OcrDcuAB3eQ62f6/amZnKujFPDV9LTPtP/RoxxlXJEHePh\n rnnd6JxVhqJTHmoQ27ykVvMQm71fr/v8jnc3qetiksygb4Z4sm7VyFlMQV+hRBppdGW9GeHA9qc\n wFy7EfcNn9+tqZ0beTw0/uD7luh8LO2yN3/G8DsOpff3xybL1mu2tjPz3RC6ftVq+5jNyi/H79T\n Xm7wF6j+WPIUMP6N5ujT1My5eqLNl+UFdSDX2kWI7MrnHr7c28AlU+LGUzEWG40cWUQmCAw==", "X-Received": [ "by 2002:a05:7022:61f:b0:12a:6fb7:8801 with SMTP id\n a92af1059eb24-12bfb7074cfmr9452746c88.14.1775622012096;\n Tue, 07 Apr 2026 21:20:12 -0700 (PDT)", "by 2002:a05:7022:61f:b0:12a:6fb7:8801 with SMTP id\n a92af1059eb24-12bfb7074cfmr9452729c88.14.1775622011517;\n Tue, 07 Apr 2026 21:20:11 -0700 (PDT)" ], "From": "Brian Cain <brian.cain@oss.qualcomm.com>", "To": "qemu-devel@nongnu.org", "Cc": "brian.cain@oss.qualcomm.com, philmd@linaro.org, ltaylorsimpson@gmail.com,\n matheus.bernardino@oss.qualcomm.com, marco.liebel@oss.qualcomm.com,\n quic_mburton@quicinc.com, sid.manning@oss.qualcomm.com, ale@rev.ng,\n anjo@rev.ng, Brian Cain <bcain@quicinc.com>", "Subject": "[PATCH v4 03/28] target/hexagon: Implement start/stop helpers,\n soft reset", "Date": "Tue, 7 Apr 2026 21:19:28 -0700", "Message-Id": "<20260408041953.1899532-4-brian.cain@oss.qualcomm.com>", "X-Mailer": "git-send-email 2.34.1", "In-Reply-To": "<20260408041953.1899532-1-brian.cain@oss.qualcomm.com>", "References": "<20260408041953.1899532-1-brian.cain@oss.qualcomm.com>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"utf-8\"", "Content-Transfer-Encoding": "base64", "X-Proofpoint-Spam-Details-Enc": "AW1haW4tMjYwNDA4MDAzNiBTYWx0ZWRfX+MW9ZDOTMaqP\n q14Qg8tl5oeVdHUaUbtpk1yS8wYbvnbyMsOjYz+YY6ftLHyp554CjMsSKrsB+4/rlUYegFv9XtQ\n GTEwAumJiYxilj2e4uZW9y1WgNb1F6kp86PlbM55JQv+RPGPC384a92JD9i9gxRqf8RGt3RIZuT\n y+MZ8q0jmOPBzftREw72pYKrRl6er231i/i+8YS6Uw9Me/ELBJCPvMzZIqKJCZDee2rf9vR1gta\n W02OLt8GlQISQJPypzH+q6e5TtB1z6++YfCINolQdvlFQBCC5XBC+iheGGl/JN/nJwWebTBm0PE\n htm/AzuJI+dT0mZSwHJNYqsR5bZtUGmruKkVG/hqV2QZsu/L7RF8XkZ/BYAw3AZipANizYaPM21\n 9urA2ZVncSIkBLFJeeEvzQJxbGoZi1L59nPE1iEXaqC8LajOvQ5qW9mC+HPcllRzN9B7asdly4S\n 1oHYZxNhGL5tJhkp8Cg==", "X-Proofpoint-GUID": "loFzOvGnRvLDpDwqVjG5Qd9NcO_C37Dk", "X-Proofpoint-ORIG-GUID": "loFzOvGnRvLDpDwqVjG5Qd9NcO_C37Dk", "X-Authority-Analysis": "v=2.4 cv=K4AS2SWI c=1 sm=1 tr=0 ts=69d5d77d cx=c_pps\n a=JYo30EpNSr/tUYqK9jHPoA==:117 a=ouPCqIW2jiPt+lZRy3xVPw==:17\n a=IkcTkHD0fZMA:10 a=A5OVakUREuEA:10 a=s4-Qcg_JpJYA:10\n a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=gowsoOTTUOVcmtlkKump:22\n a=COk6AnOGAAAA:8 a=EUspDBNiAAAA:8 a=Yg3Zx8E-q63MwIDgcCkA:9\n a=5DSkQkq5sdZ_jMUF:21 a=QEXdDO2ut3YA:10 a=Fk4IpSoW4aLDllm1B1p-:22\n a=TjNXssC_j7lpFel5tvFf:22", "X-Proofpoint-Virus-Version": "vendor=baseguard\n engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49\n definitions=2026-04-08_02,2026-04-07_05,2025-10-01_01", "X-Proofpoint-Spam-Details": "rule=outbound_notspam policy=outbound score=0\n priorityscore=1501 impostorscore=0 lowpriorityscore=0 clxscore=1015\n phishscore=0 malwarescore=0 spamscore=0 bulkscore=0 adultscore=0\n suspectscore=0 classifier=typeunknown authscore=0 authtc= authcc=\n route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2604010000\n definitions=main-2604080036", "Received-SPF": "pass client-ip=205.220.180.131;\n envelope-from=brian.cain@oss.qualcomm.com; helo=mx0b-0031df01.pphosted.com", "X-Spam_score_int": "-27", "X-Spam_score": "-2.8", "X-Spam_bar": "--", "X-Spam_report": "(-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001,\n RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001, SPF_HELO_NONE=0.001,\n SPF_PASS=-0.001 autolearn=ham autolearn_force=no", "X-Spam_action": "no action", "X-BeenThere": "qemu-devel@nongnu.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "qemu development <qemu-devel.nongnu.org>", "List-Unsubscribe": "<https://lists.nongnu.org/mailman/options/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>", "List-Archive": "<https://lists.nongnu.org/archive/html/qemu-devel>", "List-Post": "<mailto:qemu-devel@nongnu.org>", "List-Help": "<mailto:qemu-devel-request@nongnu.org?subject=help>", "List-Subscribe": "<https://lists.nongnu.org/mailman/listinfo/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=subscribe>", "Errors-To": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org", "Sender": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org" }, "content": "From: Brian Cain <bcain@quicinc.com>\n\nSigned-off-by: Brian Cain <brian.cain@oss.qualcomm.com>\n---\n target/hexagon/cpu.h | 9 +++++++++\n target/hexagon/cpu.c | 28 ++++++++++++++++++++++++++--\n target/hexagon/op_helper.c | 4 ++--\n 3 files changed, 37 insertions(+), 4 deletions(-)", "diff": "diff --git a/target/hexagon/cpu.h b/target/hexagon/cpu.h\nindex 3049b5a411a..2938291ff1d 100644\n--- a/target/hexagon/cpu.h\n+++ b/target/hexagon/cpu.h\n@@ -212,6 +212,15 @@ G_NORETURN void hexagon_raise_exception_err(CPUHexagonState *env,\n uint32_t exception,\n uintptr_t pc);\n \n+#ifndef CONFIG_USER_ONLY\n+/*\n+ * @return true if the @a thread_env hardware thread is\n+ * not stopped.\n+ */\n+bool hexagon_thread_is_enabled(CPUHexagonState *thread_env);\n+void hexagon_cpu_soft_reset(CPUHexagonState *env);\n+#endif\n+\n typedef HexagonCPU ArchCPU;\n \n void hexagon_translate_init(void);\ndiff --git a/target/hexagon/cpu.c b/target/hexagon/cpu.c\nindex 9ae8e104043..fe7bb198d72 100644\n--- a/target/hexagon/cpu.c\n+++ b/target/hexagon/cpu.c\n@@ -33,6 +33,7 @@\n #ifndef CONFIG_USER_ONLY\n #include \"sys_macros.h\"\n #include \"accel/tcg/cpu-ldst.h\"\n+#include \"qemu/main-loop.h\"\n #endif\n \n static void hexagon_v66_cpu_init(Object *obj) { }\n@@ -315,6 +316,28 @@ static void hexagon_restore_state_to_opc(CPUState *cs,\n }\n \n \n+#ifndef CONFIG_USER_ONLY\n+void hexagon_cpu_soft_reset(CPUHexagonState *env)\n+{\n+ HexagonCPU *cpu;\n+\n+ BQL_LOCK_GUARD();\n+ env->t_sreg[HEX_SREG_SSR] = 0;\n+ hexagon_ssr_set_cause(env, HEX_CAUSE_RESET);\n+\n+ cpu = env_archcpu(env);\n+ if (cpu->globalregs) {\n+ uint32_t evb =\n+ hexagon_globalreg_read(cpu->globalregs, HEX_SREG_EVB,\n+ env->threadId);\n+ env->gpr[HEX_REG_PC] = evb;\n+ } else {\n+ env->gpr[HEX_REG_PC] = cpu->boot_addr;\n+ }\n+}\n+#endif\n+\n+\n static void hexagon_cpu_reset_hold(Object *obj, ResetType type)\n {\n CPUState *cs = CPU(obj);\n@@ -344,9 +367,10 @@ static void hexagon_cpu_reset_hold(Object *obj, ResetType type)\n \n env->t_sreg[HEX_SREG_HTID] = cpu->htid;\n env->threadId = cpu->htid;\n- env->gpr[HEX_REG_PC] = cpu->boot_addr;\n-#endif\n+ hexagon_cpu_soft_reset(env);\n env->cause_code = HEX_EVENT_NONE;\n+ env->gpr[HEX_REG_PC] = cpu->boot_addr;\n+#endif\n }\n \n static void hexagon_cpu_disas_set_info(const CPUState *cs,\ndiff --git a/target/hexagon/op_helper.c b/target/hexagon/op_helper.c\nindex 7e6e04e512a..a28ed061412 100644\n--- a/target/hexagon/op_helper.c\n+++ b/target/hexagon/op_helper.c\n@@ -1478,12 +1478,12 @@ uint32_t HELPER(iassignr)(CPUHexagonState *env, uint32_t src)\n \n void HELPER(start)(CPUHexagonState *env, uint32_t imask)\n {\n- g_assert_not_reached();\n+ hexagon_start_threads(env, imask);\n }\n \n void HELPER(stop)(CPUHexagonState *env)\n {\n- g_assert_not_reached();\n+ hexagon_stop_thread(env);\n }\n \n void HELPER(wait)(CPUHexagonState *env, target_ulong PC)\n", "prefixes": [ "v4", "03/28" ] }